@ai-matrx/records-ui 0.70.0 → 0.71.0

package/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog — @ai-matrx/records-ui
 
+## 0.71.0
+
+**A public form no longer takes the page down when it asks for a choice, a linked record or a
+person.** (lane FIX-10A, from VERIFIER-10 finding F1.)
+
+An agent built and published a job-request form for a plumbing company in forty seconds and
+handed over its link. Opened by a signed-out stranger — the only person that link is for — it
+answered **HTTP 500**, on production, with `useRecordsClient was called outside
+<RecordsProvider>` in the console.
+
+The public arm of `FormRunner` is deliberately the arm that mounts **no store client**: the
+server resolved the Fields through `custom.form_public`, and the browser on that page holds no
+key, knows no organization and may not read a row. `useOptionalRecordsClient` exists in
+`@ai-matrx/records` for exactly that screen. But three of the editors `FieldControl` can draw
+asked for the client with `useRecordsClient`, which throws by design — so **any** public form
+carrying a drop-down, a relation or a person question died, whatever it was about.
+
+* **`OptionControl`, `RelationPicker` and `PersonPicker` now take the optional client** and,
+  with none mounted, are **absent and honest** instead of fatal. A choice question takes the
+  answer as text and says why the list cannot be read on a page answered without an account; a
+  relation question says it cannot be answered here and to leave it blank; a person question
+  already had that sentence and now reaches it instead of throwing above it.
+* **The guard** — `src/a-public-form-needs-no-store-client.test.tsx` — walks `FIELD_KINDS`, the
+  store's own closed list of the nineteen kinds a Field can be, and renders the public arm with
+  a question of every one of them and no provider of any sort above it. Red on the bytes before
+  this release (4 of 19), green on these. A twentieth kind whose editor reaches for the store
+  turns it red the day it is added, not the day a stranger opens a link.
+
 ## 0.70.0
 
 **The bar that said four now opens four.** (lane DRILL.)

package/dist/index.cjs

@@ -919,8 +919,9 @@ var import_react5 = require("react");
 var import_react6 = require("@ai-matrx/records/react");
 var import_design_system2 = require("@ai-matrx/design-system");
 var import_jsx_runtime3 = require("react/jsx-runtime");
+var NO_STORE_ON_THIS_SCREEN_REASON = "cannot be answered on this page: it points at a record in somebody's own data, and a page answered without an account is never allowed to search that. Leave it blank and whoever receives this will fill it in.";
 function RelationPicker({ field, value, onChange, disabled, id, className, allowCreate = true }) {
-  const client = (0, import_react6.useRecordsClient)();
+  const client = (0, import_react6.useOptionalRecordsClient)();
   const [rows, setRows] = (0, import_react5.useState)(null);
   const [words, setWords] = (0, import_react5.useState)({});
   const [refusal, setRefusal] = (0, import_react5.useState)(null);
@@ -938,7 +939,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
   );
   (0, import_react5.useEffect)(() => {
     const target2 = field.relation_target;
-    if (!target2) return;
+    if (!target2 || !client) return;
     let cancelled = false;
     void client.list({ table_id: target2, limit: 200 }).then((result) => {
       if (cancelled) return;
@@ -950,7 +951,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
     };
   }, [client, field.relation_target]);
   (0, import_react5.useEffect)(() => {
-    if (!rows) return;
+    if (!rows || !client) return;
     const wanted = [.../* @__PURE__ */ new Set([...rows.map((row) => row.id), ...picked])].filter(
       (id2) => words[id2] === void 0
     );
@@ -970,7 +971,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
     };
   }, [client, field.id, rows, picked, words]);
   (0, import_react5.useEffect)(() => {
-    if (!open || !allowCreate || target || targetRefusal) return;
+    if (!open || !allowCreate || target || targetRefusal || !client) return;
     const id2 = field.relation_target;
     if (!id2) return;
     let cancelled = false;
@@ -991,6 +992,13 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
       cancelled = true;
     };
   }, [client, open, allowCreate, target, targetRefusal, field.relation_target]);
+  if (!client) {
+    return /* @__PURE__ */ (0, import_jsx_runtime3.jsxs)("p", { id, className: (0, import_design_system2.cn)("text-xs text-muted-foreground", className), children: [
+      fieldName(field),
+      " ",
+      NO_STORE_ON_THIS_SCREEN_REASON
+    ] });
+  }
   if (!field.relation_target) {
     return /* @__PURE__ */ (0, import_jsx_runtime3.jsxs)("p", { className: "text-xs text-muted-foreground", children: [
       fieldName(field),
@@ -1321,10 +1329,11 @@ function JsonControl({ field, value, onChange, disabled, id }) {
   ] });
 }
 function OptionControl({ field, value, onChange, disabled, id }) {
-  const client = (0, import_react8.useRecordsClient)();
+  const client = (0, import_react8.useOptionalRecordsClient)();
   const [options, setOptions] = (0, import_react7.useState)(null);
   const [refusal, setRefusal] = (0, import_react7.useState)(null);
   (0, import_react7.useEffect)(() => {
+    if (!client) return;
     let cancelled = false;
     void client.fieldOptions({ field_id: field.id }).then((result) => {
       if (cancelled) return;
@@ -1335,6 +1344,23 @@ function OptionControl({ field, value, onChange, disabled, id }) {
       cancelled = true;
     };
   }, [client, field.id]);
+  if (!client) {
+    return /* @__PURE__ */ (0, import_jsx_runtime4.jsxs)("div", { className: "flex flex-col gap-1", children: [
+      /* @__PURE__ */ (0, import_jsx_runtime4.jsx)(
+        import_design_system3.BasicInput,
+        {
+          id,
+          value: value === null || value === void 0 ? "" : String(value),
+          disabled,
+          onChange: (e) => onChange(e.target.value === "" ? null : e.target.value)
+        }
+      ),
+      /* @__PURE__ */ (0, import_jsx_runtime4.jsxs)("p", { className: "text-xs text-muted-foreground", children: [
+        fieldName(field),
+        " is normally picked from a list. This page is answered without an account, so the list cannot be read here \u2014 type your answer and whoever receives it will match it up."
+      ] })
+    ] });
+  }
   if (refusal) return /* @__PURE__ */ (0, import_jsx_runtime4.jsx)("p", { id, className: "text-xs text-destructive", children: refusal });
   if (!options) return /* @__PURE__ */ (0, import_jsx_runtime4.jsx)("p", { id, className: "text-xs text-muted-foreground", children: "Reading this field's choices\u2026" });
   if (options.length === 0) {
@@ -1419,7 +1445,7 @@ async function personRecordForMember(client, personTableId, people, member) {
   return written;
 }
 function PersonPicker({ field, value, onChange, disabled, id, className }) {
-  const client = (0, import_react10.useRecordsClient)();
+  const client = (0, import_react10.useOptionalRecordsClient)();
   const host = useRecordsUi();
   const [members, setMembers] = (0, import_react9.useState)(null);
   const [people, setPeople] = (0, import_react9.useState)([]);
@@ -1434,7 +1460,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
     [value]
   );
   const load = (0, import_react9.useCallback)(async () => {
-    if (!membersPort) return;
+    if (!membersPort || !client) return;
     const [roster, records] = await Promise.all([
       membersPort(),
       personTable ? client.list({ table_id: personTable, limit: 500 }) : Promise.resolve(null)
@@ -1451,7 +1477,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
     void load();
   }, [open, load]);
   (0, import_react9.useEffect)(() => {
-    if (picked.length === 0 || !personTable || people.length > 0) return;
+    if (picked.length === 0 || !personTable || people.length > 0 || !client) return;
     let cancelled = false;
     void client.list({ table_id: personTable, limit: 500 }).then((result) => {
       if (cancelled || !result.ok) return;
@@ -1461,7 +1487,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
       cancelled = true;
     };
   }, [client, personTable, picked.length, people.length]);
-  if (!membersPort) {
+  if (!membersPort || !client) {
     return /* @__PURE__ */ (0, import_jsx_runtime5.jsx)("p", { className: (0, import_design_system4.cn)("text-xs text-muted-foreground", className), children: NO_MEMBERS_REASON });
   }
   if (!personTable) {