@ai-matrx/records-ui 0.69.0 → 0.71.0

package/CHANGELOG.md

@@ -1,5 +1,60 @@
 # Changelog — @ai-matrx/records-ui
 
+## 0.71.0
+
+**A public form no longer takes the page down when it asks for a choice, a linked record or a
+person.** (lane FIX-10A, from VERIFIER-10 finding F1.)
+
+An agent built and published a job-request form for a plumbing company in forty seconds and
+handed over its link. Opened by a signed-out stranger — the only person that link is for — it
+answered **HTTP 500**, on production, with `useRecordsClient was called outside
+<RecordsProvider>` in the console.
+
+The public arm of `FormRunner` is deliberately the arm that mounts **no store client**: the
+server resolved the Fields through `custom.form_public`, and the browser on that page holds no
+key, knows no organization and may not read a row. `useOptionalRecordsClient` exists in
+`@ai-matrx/records` for exactly that screen. But three of the editors `FieldControl` can draw
+asked for the client with `useRecordsClient`, which throws by design — so **any** public form
+carrying a drop-down, a relation or a person question died, whatever it was about.
+
+* **`OptionControl`, `RelationPicker` and `PersonPicker` now take the optional client** and,
+  with none mounted, are **absent and honest** instead of fatal. A choice question takes the
+  answer as text and says why the list cannot be read on a page answered without an account; a
+  relation question says it cannot be answered here and to leave it blank; a person question
+  already had that sentence and now reaches it instead of throwing above it.
+* **The guard** — `src/a-public-form-needs-no-store-client.test.tsx` — walks `FIELD_KINDS`, the
+  store's own closed list of the nineteen kinds a Field can be, and renders the public arm with
+  a question of every one of them and no provider of any sort above it. Red on the bytes before
+  this release (4 of 19), green on these. A twentieth kind whose editor reaches for the store
+  turns it red the day it is added, not the day a stranger opens a link.
+
+## 0.70.0
+
+**The bar that said four now opens four.** (lane DRILL.)
+
+* **`TablePage` takes a `filter`** — the store's one `RecordFilter` — and hands it to the grid
+  AND the board, so switching layout after a drill-through does not quietly widen back to the
+  whole table. It is a question for this visit, like `activeView` and `activeGroupField`, and
+  is never written onto the saved view. `Grid` and `ViewSwitcher` (and `useViewRecords`) take
+  it too; the narrowing happens in the STORE, never in the browser, because this screen holds
+  one page and a browser-side filter would drop every match on page two.
+* **`cameFromLine` says the narrow thing, and means it.** TAILS-6 shipped *"This is every
+  record grouped into the same columns the chart used — not only the ones that number
+  counted"*, which was TRUE and useless: no door took a filter. It now reads *"These are only
+  the records that number counted: Status is Cancelled. Everything else in this table is being
+  held back"*, and it still refuses to claim narrowing when no question came with the click.
+* **`filterInWords`** turns the question into the words of the person whose business it is —
+  the Field's own name through the same `fieldName` the column headers use, never a column
+  key. `null` becomes "Status is not filled in"; a window becomes "from … up to …", because
+  the store's windows are half-open and "to 2026-02-01" would read as including February 1st.
+* **`DigestScheduler.filters` is a `RecordFilter`**, and `DashboardCanvas`'s
+  `as Record<string, unknown>` is gone — that cast was the seam where the dashboard's filter,
+  the saved view it schedules over and the drill-through it opens could have drifted apart.
+* **Guard `a-number-opens-only-its-own-rows.test.tsx`** asserts the DOOR the page opened and
+  the argument it carried, and refuses by name the moment anything opens the unfiltered
+  `read_records` while holding a filter. Shown RED on the pre-fix bytes (four clauses,
+  including the old sentence) and green on these.
+
 ## 0.69.0
 
 **She can make the one that is missing, from where she is looking for it.** (lane TAILS-7.)

package/dist/index.cjs

@@ -919,8 +919,9 @@ var import_react5 = require("react");
 var import_react6 = require("@ai-matrx/records/react");
 var import_design_system2 = require("@ai-matrx/design-system");
 var import_jsx_runtime3 = require("react/jsx-runtime");
+var NO_STORE_ON_THIS_SCREEN_REASON = "cannot be answered on this page: it points at a record in somebody's own data, and a page answered without an account is never allowed to search that. Leave it blank and whoever receives this will fill it in.";
 function RelationPicker({ field, value, onChange, disabled, id, className, allowCreate = true }) {
-  const client = (0, import_react6.useRecordsClient)();
+  const client = (0, import_react6.useOptionalRecordsClient)();
   const [rows, setRows] = (0, import_react5.useState)(null);
   const [words, setWords] = (0, import_react5.useState)({});
   const [refusal, setRefusal] = (0, import_react5.useState)(null);
@@ -938,7 +939,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
   );
   (0, import_react5.useEffect)(() => {
     const target2 = field.relation_target;
-    if (!target2) return;
+    if (!target2 || !client) return;
     let cancelled = false;
     void client.list({ table_id: target2, limit: 200 }).then((result) => {
       if (cancelled) return;
@@ -950,7 +951,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
     };
   }, [client, field.relation_target]);
   (0, import_react5.useEffect)(() => {
-    if (!rows) return;
+    if (!rows || !client) return;
     const wanted = [.../* @__PURE__ */ new Set([...rows.map((row) => row.id), ...picked])].filter(
       (id2) => words[id2] === void 0
     );
@@ -970,7 +971,7 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
     };
   }, [client, field.id, rows, picked, words]);
   (0, import_react5.useEffect)(() => {
-    if (!open || !allowCreate || target || targetRefusal) return;
+    if (!open || !allowCreate || target || targetRefusal || !client) return;
     const id2 = field.relation_target;
     if (!id2) return;
     let cancelled = false;
@@ -991,6 +992,13 @@ function RelationPicker({ field, value, onChange, disabled, id, className, allow
       cancelled = true;
     };
   }, [client, open, allowCreate, target, targetRefusal, field.relation_target]);
+  if (!client) {
+    return /* @__PURE__ */ (0, import_jsx_runtime3.jsxs)("p", { id, className: (0, import_design_system2.cn)("text-xs text-muted-foreground", className), children: [
+      fieldName(field),
+      " ",
+      NO_STORE_ON_THIS_SCREEN_REASON
+    ] });
+  }
   if (!field.relation_target) {
     return /* @__PURE__ */ (0, import_jsx_runtime3.jsxs)("p", { className: "text-xs text-muted-foreground", children: [
       fieldName(field),
@@ -1321,10 +1329,11 @@ function JsonControl({ field, value, onChange, disabled, id }) {
   ] });
 }
 function OptionControl({ field, value, onChange, disabled, id }) {
-  const client = (0, import_react8.useRecordsClient)();
+  const client = (0, import_react8.useOptionalRecordsClient)();
   const [options, setOptions] = (0, import_react7.useState)(null);
   const [refusal, setRefusal] = (0, import_react7.useState)(null);
   (0, import_react7.useEffect)(() => {
+    if (!client) return;
     let cancelled = false;
     void client.fieldOptions({ field_id: field.id }).then((result) => {
       if (cancelled) return;
@@ -1335,6 +1344,23 @@ function OptionControl({ field, value, onChange, disabled, id }) {
       cancelled = true;
     };
   }, [client, field.id]);
+  if (!client) {
+    return /* @__PURE__ */ (0, import_jsx_runtime4.jsxs)("div", { className: "flex flex-col gap-1", children: [
+      /* @__PURE__ */ (0, import_jsx_runtime4.jsx)(
+        import_design_system3.BasicInput,
+        {
+          id,
+          value: value === null || value === void 0 ? "" : String(value),
+          disabled,
+          onChange: (e) => onChange(e.target.value === "" ? null : e.target.value)
+        }
+      ),
+      /* @__PURE__ */ (0, import_jsx_runtime4.jsxs)("p", { className: "text-xs text-muted-foreground", children: [
+        fieldName(field),
+        " is normally picked from a list. This page is answered without an account, so the list cannot be read here \u2014 type your answer and whoever receives it will match it up."
+      ] })
+    ] });
+  }
   if (refusal) return /* @__PURE__ */ (0, import_jsx_runtime4.jsx)("p", { id, className: "text-xs text-destructive", children: refusal });
   if (!options) return /* @__PURE__ */ (0, import_jsx_runtime4.jsx)("p", { id, className: "text-xs text-muted-foreground", children: "Reading this field's choices\u2026" });
   if (options.length === 0) {
@@ -1419,7 +1445,7 @@ async function personRecordForMember(client, personTableId, people, member) {
   return written;
 }
 function PersonPicker({ field, value, onChange, disabled, id, className }) {
-  const client = (0, import_react10.useRecordsClient)();
+  const client = (0, import_react10.useOptionalRecordsClient)();
   const host = useRecordsUi();
   const [members, setMembers] = (0, import_react9.useState)(null);
   const [people, setPeople] = (0, import_react9.useState)([]);
@@ -1434,7 +1460,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
     [value]
   );
   const load = (0, import_react9.useCallback)(async () => {
-    if (!membersPort) return;
+    if (!membersPort || !client) return;
     const [roster, records] = await Promise.all([
       membersPort(),
       personTable ? client.list({ table_id: personTable, limit: 500 }) : Promise.resolve(null)
@@ -1451,7 +1477,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
     void load();
   }, [open, load]);
   (0, import_react9.useEffect)(() => {
-    if (picked.length === 0 || !personTable || people.length > 0) return;
+    if (picked.length === 0 || !personTable || people.length > 0 || !client) return;
     let cancelled = false;
     void client.list({ table_id: personTable, limit: 500 }).then((result) => {
       if (cancelled || !result.ok) return;
@@ -1461,7 +1487,7 @@ function PersonPicker({ field, value, onChange, disabled, id, className }) {
       cancelled = true;
     };
   }, [client, personTable, picked.length, people.length]);
-  if (!membersPort) {
+  if (!membersPort || !client) {
     return /* @__PURE__ */ (0, import_jsx_runtime5.jsx)("p", { className: (0, import_design_system4.cn)("text-xs text-muted-foreground", className), children: NO_MEMBERS_REASON });
   }
   if (!personTable) {
@@ -3557,6 +3583,7 @@ var NO_COLUMNS_WHY = "A column is what a record holds \u2014 a name, a date, an
 function Grid({
   tableId,
   pageSize = 50,
+  filter,
   onOpenRecord,
   onAddField,
   onNewRecordForm,
@@ -3572,7 +3599,7 @@ function Grid({
   const table = (0, import_react21.useTable)(tableId);
   const fields = (0, import_react21.useFields)(tableId);
   const [page, setPage] = (0, import_react20.useState)(0);
-  const records = (0, import_react21.useRecords)(tableId, { pageSize, page });
+  const records = (0, import_react21.useRecords)(tableId, { pageSize, page, ...filter ? { filter } : {} });
   const rights = useTableRights(table.data);
   const rows = (0, import_react20.useMemo)(() => records.data?.rows ?? [], [records.data]);
   const rowIds = (0, import_react20.useMemo)(() => rows.map((row) => row.id), [rows]);
@@ -7321,9 +7348,12 @@ function unplacedName(record, field, labels) {
 // src/ViewSwitcher.tsx
 var import_jsx_runtime26 = require("react/jsx-runtime");
 var NO_FIELDS = [];
-function useViewRecords(view, pageSize = 200) {
+function useViewRecords(view, pageSize = 200, filter) {
   const client = (0, import_react49.useRecordsClient)();
-  const table = (0, import_react49.useRecords)(view.ruleId ? null : view.subject, { pageSize });
+  const table = (0, import_react49.useRecords)(view.ruleId ? null : view.subject, {
+    pageSize,
+    ...filter ? { filter } : {}
+  });
   const [ruled, setRuled] = (0, import_react48.useState)({
     rows: [],
     loading: Boolean(view.ruleId),
@@ -7378,6 +7408,7 @@ function ViewSwitcher({
   onNewRecordForm,
   onAskWhoChanged,
   pageSize = 200,
+  filter,
   className
 }) {
   const [layout, setLayout] = (0, import_react48.useState)(view.layout);
@@ -7415,6 +7446,7 @@ function ViewSwitcher({
       {
         tableId: view.subject,
         pageSize,
+        ...filter ? { filter } : {},
         ...local.presentation ?? view.presentation ? { presentation: local.presentation ?? view.presentation } : {},
         ...onViewChange ? { onPresentationChange: (next) => change({ presentation: next }) } : {},
         ...onOpenRecord ? { onOpenRecord } : {},
@@ -7426,6 +7458,7 @@ function ViewSwitcher({
       {
         view: { ...view, ...local, layout },
         pageSize,
+        ...filter ? { filter } : {},
         onChange: change,
         remembered: Boolean(onViewChange),
         ...onOpenRecord ? { onOpenRecord } : {},
@@ -7473,13 +7506,14 @@ function boardColumnChoice(fields, chosenKey, stage) {
 function Board({
   view,
   pageSize,
+  filter,
   onChange,
   remembered,
   onOpenRecord,
   onMoved
 }) {
   const fields = (0, import_react49.useFields)(view.subject);
-  const records = useViewRecords(view, pageSize);
+  const records = useViewRecords(view, pageSize, filter);
   const stage = useStageField(view.subject);
   if (fields.error) return /* @__PURE__ */ (0, import_jsx_runtime26.jsx)(RefusalNotice, { error: fields.error });
   if (records.error) return /* @__PURE__ */ (0, import_jsx_runtime26.jsx)(RefusalNotice, { error: records.error });
@@ -13000,14 +13034,20 @@ function DashboardCanvas({ tableId, activeDashboardId, filter, className }) {
         rights.admin ? /* @__PURE__ */ (0, import_jsx_runtime47.jsx)(import_design_system44.Button, { size: "sm", variant: "ghost", onClick: () => void remove(board), children: "Delete" }) : null
       ] }) : null
     ] }),
-    board && scheduling ? /* @__PURE__ */ (0, import_jsx_runtime47.jsx)(
-      DigestScheduler,
-      {
-        tableId,
-        subjectName: board.name,
-        ...filter ? { filters: filter } : {},
-        onClose: () => setScheduling(false)
-      }
+    board && scheduling ? (
+      // ONE SHAPE, SO NO CAST. The dashboard's own filter, the saved view it
+      // schedules over and the drill-through it opens are all the same
+      // `RecordFilter`; the `as Record<string, unknown>` that used to be here
+      // was the seam where they could have drifted.
+      /* @__PURE__ */ (0, import_jsx_runtime47.jsx)(
+        DigestScheduler,
+        {
+          tableId,
+          subjectName: board.name,
+          ...filter ? { filters: filter } : {},
+          onClose: () => setScheduling(false)
+        }
+      )
     ) : null,
     board ? /* @__PURE__ */ (0, import_jsx_runtime47.jsxs)("div", { className: "flex flex-col gap-1", children: [
       /* @__PURE__ */ (0, import_jsx_runtime47.jsxs)("div", { className: "flex items-center gap-1", children: [
@@ -15007,9 +15047,35 @@ var import_react111 = require("react");
 var import_react112 = require("@ai-matrx/records/react");
 var import_design_system54 = require("@ai-matrx/design-system");
 var import_jsx_runtime58 = require("react/jsx-runtime");
-function cameFromLine(label, groupField) {
-  const grouped = groupField ? `grouped into the same columns the chart used` : `for this table`;
-  return `You came here from \u201C${label}\u201D. This is every record ${grouped} \u2014 not only the ones that number counted \u2014 so the column you clicked is here with the rest beside it.`;
+function filterInWords(filter, fields) {
+  const nameOf = (key) => {
+    const field = fields.find((f) => f.key === key);
+    return field ? fieldName(field) : humanize(key);
+  };
+  const parts = Object.keys(filter).map((key) => {
+    const value = filter[key];
+    if (value === null || value === void 0) return `${nameOf(key)} is not filled in`;
+    if (typeof value === "object") {
+      const from = (value.from ?? "").toString().trim();
+      const to = (value.to ?? "").toString().trim();
+      if (from !== "" && to !== "") return `${nameOf(key)} from ${from} up to ${to}`;
+      if (from !== "") return `${nameOf(key)} from ${from} onwards`;
+      if (to !== "") return `${nameOf(key)} up to ${to}`;
+      return `${nameOf(key)} in a period nobody named`;
+    }
+    return `${nameOf(key)} is ${String(value)}`;
+  });
+  if (parts.length === 0) return "";
+  if (parts.length === 1) return parts[0];
+  return `${parts.slice(0, -1).join(", ")} and ${parts[parts.length - 1]}`;
+}
+function cameFromLine(label, groupField, question) {
+  const asked = (question ?? "").trim();
+  if (asked === "") {
+    const grouped = groupField ? " grouped into the same columns the chart used" : "";
+    return `You came here from \u201C${label}\u201D. This is every record in this table${grouped} \u2014 that number was counted over all of them.`;
+  }
+  return `You came here from \u201C${label}\u201D. These are only the records that number counted: ${asked}. Everything else in this table is being held back \u2014 clear the filter to see all of it.`;
 }
 var TABLE_NOT_REACHABLE = "This table is not in the organization you are working in, so there is nothing here to show. Switch to the organization that owns it and open it again \u2014 or it may have been deleted.";
 var DEFAULT_VIEW_NAME = "All records";
@@ -15056,11 +15122,14 @@ function TablePage({
   onViewChanged,
   activeGroupField,
   cameFrom,
+  filter,
   className
 }) {
   const client = (0, import_react112.useRecordsClient)();
   const table = (0, import_react112.useTable)(tableId);
   const rights = useTableRights(table.data);
+  const pageFields = (0, import_react112.useFields)(filter ? tableId : null);
+  const askedInWords = filter ? filterInWords(filter, pageFields.data ?? []) : null;
   const organizationId = (0, import_react112.useRecordsClient)().config.organizationId;
   const [view, setView] = (0, import_react111.useState)(null);
   const opening = openingRail(activeRecordId);
@@ -15254,7 +15323,7 @@ function TablePage({
           {
             "data-testid": "came-from-a-number",
             className: "rounded-md border px-3 py-2 text-xs leading-relaxed text-muted-foreground",
-            children: cameFromLine(cameFrom, activeGroupField ?? null)
+            children: cameFromLine(cameFrom, activeGroupField ?? null, askedInWords)
           }
         ) : null,
         /* @__PURE__ */ (0, import_jsx_runtime58.jsx)(
@@ -15268,6 +15337,7 @@ function TablePage({
               ...activeGroupField ? { groupField: activeGroupField } : {}
             },
             pageSize,
+            ...filter ? { filter } : {},
             onLayoutChange: (layout) => {
               setLayoutFromLink(layout);
               onViewChanged?.(layout);