@ai-matrx/associations 0.11.4 → 0.13.0

package/CHANGELOG.md

@@ -1,5 +1,65 @@
 # Changelog — @ai-matrx/associations
 
+## 0.13.0
+
+A search that could not look no longer says "no results".
+
+* **Breaking:** `searchCandidatesAcrossTokens` returns `{ results, failures }` instead of a bare
+  array. `failures: TokenSearchFailure[]` (`{ token, error }`, registry order) lists every token
+  whose read failed — those tokens used to be screamed and silently dropped, so a search where
+  some or all tokens failed looked like "nothing matched". Result order and the per-token cap are
+  unchanged. New types `SearchAcrossTokensResult`, `TokenSearchFailure` (from `/core`).
+* `useUniversalEntitySearch` also returns `failures: UniversalSearchFailure[]` (`token: null` =
+  the recents read failed), `error` (non-null only when nothing could be read — every token
+  failed, or the recents read failed and the fallback browse failed too) and
+  `status: "loading" | "error" | "ready"`. A failed recents read still falls back to browsing,
+  but is recorded in `failures` — never silently turned into a browse.
+* New `SearchFailureNotice` + `describeSearchFailures` (`/react`): the one way a face shows the
+  hook's failures — the ErrorBox failure block when `error` is set, and a one-line
+  "Couldn't search Notes, Tasks" note above partial results. `UniversalAssociationPicker` and the
+  `AssociationPicker` recents strip render it.
+* **Breaking:** `ownerId` removed from `ListCandidatesArgs`, `SearchAcrossTokensArgs`,
+  `UseUniversalEntitySearchArgs` and `UniversalAssociationPickerProps`. It was never applied —
+  `public.reference_search_candidates(p_token, p_search, p_limit, p_ids)` has no owner
+  parameter; visibility is the RPC's alone. An ignored filter is a lie.
+
+**Consumer action:** read `.results` (and handle `.failures`) from
+`searchCandidatesAcrossTokens`; stop passing `ownerId` to the candidate reads, the hook and
+`UniversalAssociationPicker`; render `SearchFailureNotice` (or your own use of `error` /
+`failures`) wherever you render `useUniversalEntitySearch` results.
+
+## 0.12.1
+
+Re-cut of 0.12.0 — same package source. The 0.12.0 tag was cut from a commit whose workspace
+lockfile did not match `shared/messaging/package.json` (ERR_PNPM_OUTDATED_LOCKFILE), so its
+publish could never install; an immutable tag cannot move, so the bytes ship as 0.12.1.
+No consumer action beyond 0.12.0's.
+
+## 0.12.0
+
+* `UniversalAssociationPicker`: an empty search box with no recents (favorites / last-viewed) now
+  **browses candidates across the offered tokens** instead of saying "No recent items" — it was a
+  screen that lied for an account with hundreds of records it had never opened. Results carry a
+  "Recent" or "Browse" label.
+* `UniversalAssociationPicker` takes `emptyQueryMode?: "recents" | "candidates"` (default
+  `"recents"`, which falls back as above).
+* `useUniversalEntitySearch` returns `source: "search" | "recents" | "candidates"` (new
+  `UniversalSearchSource` type); `isRecents` is unchanged in meaning.
+* A chip whose token has a `pickerOverrides` component (Files → the host's window) no longer
+  leaves the picker body blank: it says the window is open (or closed), offers "Bring window to
+  front" / "Reopen window", and "Back to search". Closing the override window keeps the chip
+  selected instead of silently dropping back to search.
+
+**Consumer action:** none required. Hosts whose override window renders attached state should
+read `AssociationPickerProps.attachedIds` (it has always been passed; matrx-frontend's file
+override did not read it until this release's adoption).
+
+## 0.11.5
+
+Automatic changed-only republish, cut by the release train while the 0.12.0 source below was
+already on `main` (a checkout sweep committed it before its own version bump) — so 0.11.5 DOES
+carry the 0.12.0 picker changes despite its auto text. Adopt 0.12.0.
+
 ## 0.11.4
 
 Automatic changed-only republish (docs/metadata drift since the last tag — see

package/dist/{CommentThread-DDeqHgTk.d.cts → CommentThread-DP4sEzb2.d.cts}

@@ -1008,8 +1008,6 @@ interface CandidateRecord {
 }
 interface ListCandidatesArgs {
     token: EntityTypeToken;
-    /** Scope to this owner's rows when the entity declares an owner column. */
-    ownerId?: string | null;
     /** Case-insensitive title filter. */
     search?: string;
     limit?: number;
@@ -1028,12 +1026,25 @@ interface SearchAcrossTokensArgs {
     /** Tokens to search. Defaults to every curated token in the registry. */
     tokens?: EntityTypeToken[];
     search: string;
-    ownerId?: string | null;
     /** Cap per token — a universal search shows a few of everything. */
     perTokenLimit?: number;
     /** Max in-flight token queries. */
     concurrency?: number;
 }
+/** One token whose candidate read failed during a cross-token search. */
+interface TokenSearchFailure {
+    token: EntityTypeToken;
+    error: string;
+}
+/**
+ * A cross-token search's honest answer: what could be read, AND what could
+ * not. An empty `results` with non-empty `failures` is "we couldn't look",
+ * never "there is nothing".
+ */
+interface SearchAcrossTokensResult {
+    results: UniversalCandidate[];
+    failures: TokenSearchFailure[];
+}
 interface ReferenceSearchCandidatesFn {
     (args: {
         p_token: string;
@@ -1063,10 +1074,12 @@ interface CandidatesServiceApi {
     /**
      * ONE search over EVERY listable entity type — the "attach anything from
      * anywhere" primitive. Registry-driven client fan-out, capped and
-     * concurrency-limited. Per-token failures are screamed and skipped — one
-     * broken table never blanks the search.
+     * concurrency-limited. One broken table never blanks the search: a failed
+     * token is screamed (errorSink) AND reported in `failures` (registry
+     * order), so a face can say what it could not search instead of showing
+     * "no results".
      */
-    searchCandidatesAcrossTokens(args: SearchAcrossTokensArgs): Promise<UniversalCandidate[]>;
+    searchCandidatesAcrossTokens(args: SearchAcrossTokensArgs): Promise<SearchAcrossTokensResult>;
 }
 
 interface TitlesServiceApi {
@@ -1630,10 +1643,14 @@ interface UniversalAssociationPickerProps {
         ok: boolean;
         error?: string;
     }>;
-    /** Owner filter for candidate reads (defaults to RLS-only). */
-    ownerId?: string | null;
     /** Org stamped onto rows created via the per-token "+ New" footer. */
     orgId?: string | null;
+    /**
+     * What an empty search box shows. `"recents"` (default) shows favorites and
+     * last-viewed records and falls back to browsing candidates when there are
+     * none; `"candidates"` always browses the available records.
+     */
+    emptyQueryMode?: "recents" | "candidates";
     className?: string;
 }
 declare function attachedKey(token: string, id: string): string;

package/dist/{CommentThread-DDeqHgTk.d.ts → CommentThread-DP4sEzb2.d.ts}

@@ -1008,8 +1008,6 @@ interface CandidateRecord {
 }
 interface ListCandidatesArgs {
     token: EntityTypeToken;
-    /** Scope to this owner's rows when the entity declares an owner column. */
-    ownerId?: string | null;
     /** Case-insensitive title filter. */
     search?: string;
     limit?: number;
@@ -1028,12 +1026,25 @@ interface SearchAcrossTokensArgs {
     /** Tokens to search. Defaults to every curated token in the registry. */
     tokens?: EntityTypeToken[];
     search: string;
-    ownerId?: string | null;
     /** Cap per token — a universal search shows a few of everything. */
     perTokenLimit?: number;
     /** Max in-flight token queries. */
     concurrency?: number;
 }
+/** One token whose candidate read failed during a cross-token search. */
+interface TokenSearchFailure {
+    token: EntityTypeToken;
+    error: string;
+}
+/**
+ * A cross-token search's honest answer: what could be read, AND what could
+ * not. An empty `results` with non-empty `failures` is "we couldn't look",
+ * never "there is nothing".
+ */
+interface SearchAcrossTokensResult {
+    results: UniversalCandidate[];
+    failures: TokenSearchFailure[];
+}
 interface ReferenceSearchCandidatesFn {
     (args: {
         p_token: string;
@@ -1063,10 +1074,12 @@ interface CandidatesServiceApi {
     /**
      * ONE search over EVERY listable entity type — the "attach anything from
      * anywhere" primitive. Registry-driven client fan-out, capped and
-     * concurrency-limited. Per-token failures are screamed and skipped — one
-     * broken table never blanks the search.
+     * concurrency-limited. One broken table never blanks the search: a failed
+     * token is screamed (errorSink) AND reported in `failures` (registry
+     * order), so a face can say what it could not search instead of showing
+     * "no results".
      */
-    searchCandidatesAcrossTokens(args: SearchAcrossTokensArgs): Promise<UniversalCandidate[]>;
+    searchCandidatesAcrossTokens(args: SearchAcrossTokensArgs): Promise<SearchAcrossTokensResult>;
 }
 
 interface TitlesServiceApi {
@@ -1630,10 +1643,14 @@ interface UniversalAssociationPickerProps {
         ok: boolean;
         error?: string;
     }>;
-    /** Owner filter for candidate reads (defaults to RLS-only). */
-    ownerId?: string | null;
     /** Org stamped onto rows created via the per-token "+ New" footer. */
     orgId?: string | null;
+    /**
+     * What an empty search box shows. `"recents"` (default) shows favorites and
+     * last-viewed records and falls back to browsing candidates when there are
+     * none; `"candidates"` always browses the available records.
+     */
+    emptyQueryMode?: "recents" | "candidates";
     className?: string;
 }
 declare function attachedKey(token: string, id: string): string;

package/dist/core/index.cjs

@@ -3112,10 +3112,11 @@ function createCandidatesService(deps) {
     };
   }
   async function searchCandidatesAcrossTokens(args) {
-    const { tokens, search, ownerId, perTokenLimit = 5, concurrency = 6 } = args;
+    const { tokens, search, perTokenLimit = 5, concurrency = 6 } = args;
     const list = tokens ?? registry.listableTokens();
-    if (list.length === 0) return [];
+    if (list.length === 0) return { results: [], failures: [] };
     const out = [];
+    const failures = [];
     let cursor = 0;
     async function worker() {
       while (cursor < list.length) {
@@ -3124,12 +3125,13 @@ function createCandidatesService(deps) {
         if (!token) continue;
         const res = await listAssociationCandidates({
           token,
-          ownerId: ownerId ?? null,
           search,
           limit: perTokenLimit
         });
         if (res.ok) {
           for (const c of res.data) out.push({ ...c, token });
+        } else {
+          failures.push({ token, error: res.error });
         }
       }
     }
@@ -3143,7 +3145,10 @@ function createCandidatesService(deps) {
       if (ta !== tb) return ta - tb;
       return a.title.localeCompare(b.title);
     });
-    return out;
+    failures.sort(
+      (a, b) => (tokenOrder.get(a.token) ?? 0) - (tokenOrder.get(b.token) ?? 0)
+    );
+    return { results: out, failures };
   }
   return {
     callReferenceSearchCandidates,