@ai-matrx/agents 0.9.0 → 0.9.1

package/dist/catalog/react/index.d.cts

@@ -567,6 +567,11 @@ declare function useAgentConsumer(consumerId: string, options?: {
  * The four ownership counts a tab strip prints. Declared HERE, beside the code
  * that computes them, so both the web tab strip and the native one name the
  * same shape (0.9.0 — it used to live in the web-only `AgentListTabs`).
+ *
+ * 🚨 These are the numbers on the BADGES, and since 0.9.1 they count exactly
+ * the rows the tab renders under the consumer's own archive filter. A badge
+ * that counted rows the list hid was the screen telling the user something
+ * untrue about her own agents.
  */
 interface AgentListTabCounts {
     mine: number;

package/dist/catalog/react/index.d.ts

@@ -567,6 +567,11 @@ declare function useAgentConsumer(consumerId: string, options?: {
  * The four ownership counts a tab strip prints. Declared HERE, beside the code
  * that computes them, so both the web tab strip and the native one name the
  * same shape (0.9.0 — it used to live in the web-only `AgentListTabs`).
+ *
+ * 🚨 These are the numbers on the BADGES, and since 0.9.1 they count exactly
+ * the rows the tab renders under the consumer's own archive filter. A badge
+ * that counted rows the list hid was the screen telling the user something
+ * untrue about her own agents.
  */
 interface AgentListTabCounts {
     mine: number;

package/dist/catalog/react/index.js

@@ -422,7 +422,19 @@ function memoize2(fn) {
     return last;
   };
 }
+function compareAgentIds(a, b) {
+  const idA = a.id ?? "";
+  const idB = b.id ?? "";
+  if (idA < idB) return -1;
+  if (idA > idB) return 1;
+  return 0;
+}
 function applyAgentSortComparator(a, b, sortBy) {
+  const primary = compareAgentSortKey(a, b, sortBy);
+  if (!Number.isFinite(primary) || primary === 0) return compareAgentIds(a, b);
+  return primary;
+}
+function compareAgentSortKey(a, b, sortBy) {
   switch (sortBy) {
     case "name-asc":
       return (a.name ?? "").localeCompare(b.name ?? "");
@@ -598,22 +610,46 @@ var makeSelectFilteredAgents = (includeSystemInAll = false) => memoize2(
     return filterUserTypeAgents(userAgents, consumer);
   }
 );
+function agentMatchesArchiveFilter(agent, archFilter) {
+  if (archFilter === "active") return !agent.isArchived;
+  if (archFilter === "archived") return Boolean(agent.isArchived);
+  return true;
+}
+function countUserRows(agents, archFilter, predicate) {
+  let n = 0;
+  for (const a of agents) {
+    if (a.agentType !== "user") continue;
+    if (!agentMatchesArchiveFilter(a, archFilter)) continue;
+    if (predicate(a)) n += 1;
+  }
+  return n;
+}
+var isOwned = (a) => a.isOwner === true;
+var isShared = (a) => a.isOwner === false && a.accessLevel != null;
+var isAny = () => true;
+var isFavorite = (a) => Boolean(a.isFavorite);
+var selectAgentTabCounts = memoize2(
+  (agents, archFilter) => ({
+    mine: countUserRows(agents, archFilter, isOwned),
+    shared: countUserRows(agents, archFilter, isShared),
+    all: countUserRows(agents, archFilter, isAny),
+    system: selectBuiltinTypeAgents(agents).length
+  })
+);
 var selectTotalUserAgentsCount = memoize1(
-  (agents) => selectUserTypeAgents(agents).length
+  (agents) => countUserRows(agents, "active", isAny)
 );
 var selectTotalOwnedAgentsCount = memoize1(
-  (agents) => selectUserTypeAgents(agents).filter((a) => a.isOwner === true).length
+  (agents) => countUserRows(agents, "active", isOwned)
 );
 var selectTotalSharedAgentsCount = memoize1(
-  (agents) => selectUserTypeAgents(agents).filter(
-    (a) => a.isOwner === false && a.accessLevel != null
-  ).length
+  (agents) => countUserRows(agents, "active", isShared)
 );
 var selectTotalBuiltinAgentsCount = memoize1(
   (agents) => selectBuiltinTypeAgents(agents).length
 );
 var selectTotalFavoriteAgentsCount = memoize1(
-  (agents) => selectUserTypeAgents(agents).filter((a) => a.isFavorite).length
+  (agents) => countUserRows(agents, "active", isFavorite)
 );
 
 // catalog/shared/useAgentListCore.ts
@@ -644,7 +680,8 @@ function useAgentListCore({
   const consumer = useAgentConsumer(consumerId, { unregisterOnUnmount: true });
   const rows = useAgentCatalogRows();
   const userId = catalog.getUserIdOrNull();
-  const ownedCount = selectTotalOwnedAgentsCount(rows);
+  const tabCountsForFilter = selectAgentTabCounts(rows, consumer.state.archFilter);
+  const ownedCount = tabCountsForFilter.mine;
   const selectFiltered = useMemo3(
     () => makeSelectFilteredAgents(includeSystemInAll),
     [includeSystemInAll]
@@ -661,12 +698,7 @@ function useAgentListCore({
   const onSystemTab = consumer.tab === "system";
   const allCategories = onSystemTab ? selectAllSystemAgentCategories(rows) : selectAllAgentCategories(rows);
   const allTags = onSystemTab ? selectAllSystemAgentTags(rows) : selectAllAgentTags(rows);
-  const tabCounts = {
-    mine: ownedCount,
-    shared: selectTotalSharedAgentsCount(rows),
-    all: selectTotalUserAgentsCount(rows),
-    system: selectTotalBuiltinAgentsCount(rows)
-  };
+  const tabCounts = tabCountsForFilter;
   const isLoading = status === "loading";
   const agentsLoaded = status === "succeeded" || status === "failed";
   const ensureLoaded = useCallback3(() => {
@@ -1196,15 +1228,15 @@ function FavoriteAgentButton({
     [id]
   );
   const record = useAgentCatalogState(select);
-  const isFavorite = record?.isFavorite ?? false;
+  const isFavorite2 = record?.isFavorite ?? false;
   const isOwner = record?.isOwner ?? true;
   const handleClick = (e) => {
     e.stopPropagation();
     if (disabled || !isOwner) return;
-    void catalog.setFavorite(id, !isFavorite).catch(() => {
+    void catalog.setFavorite(id, !isFavorite2).catch(() => {
     });
   };
-  const title = isOwner ? isFavorite ? "Remove from favorites" : "Add to favorites" : "Shared \u2014 cannot favorite";
+  const title = isOwner ? isFavorite2 ? "Remove from favorites" : "Add to favorites" : "Shared \u2014 cannot favorite";
   if (variant === "list") {
     return /* @__PURE__ */ jsx6(
       "button",
@@ -1218,14 +1250,14 @@ function FavoriteAgentButton({
         onClick: handleClick,
         disabled: disabled || !isOwner,
         title,
-        "aria-label": isFavorite ? "Remove from favorites" : "Add to favorites",
+        "aria-label": isFavorite2 ? "Remove from favorites" : "Add to favorites",
         children: /* @__PURE__ */ jsx6(
           StarIcon,
           {
-            filled: isFavorite,
+            filled: isFavorite2,
             className: cn2(
               "h-3.5 w-3.5 transition-all duration-150",
-              isFavorite ? "matrx-agent-star-on" : "text-muted-foreground/40 hover:matrx-agent-star-on"
+              isFavorite2 ? "matrx-agent-star-on" : "text-muted-foreground/40 hover:matrx-agent-star-on"
             )
           }
         )
@@ -1240,13 +1272,13 @@ function FavoriteAgentButton({
         "absolute top-2.5 right-2.5 z-10 p-0.5 rounded transition-all duration-150",
         "focus:outline-none focus-visible:ring-2 focus-visible:ring-primary",
         disabled || !isOwner ? "cursor-not-allowed" : "hover:scale-110 cursor-pointer",
-        isFavorite ? "matrx-agent-star-on" : "text-muted-foreground/40 hover:matrx-agent-star-on"
+        isFavorite2 ? "matrx-agent-star-on" : "text-muted-foreground/40 hover:matrx-agent-star-on"
       ),
       onClick: handleClick,
       disabled: disabled || !isOwner,
       title,
-      "aria-label": isFavorite ? "Remove from favorites" : "Add to favorites",
-      children: /* @__PURE__ */ jsx6(StarIcon, { filled: isFavorite, className: "w-4 h-4 transition-all duration-150" })
+      "aria-label": isFavorite2 ? "Remove from favorites" : "Add to favorites",
+      children: /* @__PURE__ */ jsx6(StarIcon, { filled: isFavorite2, className: "w-4 h-4 transition-all duration-150" })
     }
   );
 }
@@ -1582,6 +1614,7 @@ function AgentRow({
   return /* @__PURE__ */ jsxs7(
     "div",
     {
+      "data-testid": `agent-row-${agent.id}`,
       className: cn5(
         "flex items-center w-full text-left transition-colors group",
         "hover:bg-muted/50 active:bg-muted/70",