@ai-ecoverse/slicc-spectrum 1.62.0 → 1.62.2

package/README.md

@@ -150,7 +150,7 @@ Text is Adobe Clean Spectrum VF, falling back to Adobe Clean, and code is Spectr
 | `<slicc-settings>` | Theme, the model and thinking level for new cones, composer and diff preferences, and accounts to connect, reconnect or disconnect. An account whose status is `signing-in` (or a non-API-key account while its `connect` is pending) reads “Signing in…”; when the port has `cancel(id)`, its row offers Cancel (`data-action="cancel-sign-in"`), and the rejected `connect` that follows shows no error. Accounts with `group: 'mcp'` (MCP servers) get their own **MCP servers** heading (`.accounts[data-group=mcp]`). An `api-key` account asks for its `secret`: “{provider} API key” by default, “{provider} token” for `secret: 'token'`; when it is `expired` it reads **API key rejected** or **Token rejected**. An MCP server with `auth: 'oauth'` signs in in a pop-up: its button reads **Sign in**, and it reads **Needs sign-in** when `disconnected` and **Sign-in expired** when `expired`. With a `vault` port, **Secrets** (`<slicc-secrets>`) follows.
 | `<slicc-secrets>` | Settings › Secrets from the model's `vault`: never a value, a placeholder or a value field. A head with **Locked** or **Unlocked**, the lock mode and a vault button (**Unlock** or **Open the vault**); waiting requests under **Waiting for you** (`[data-request]`, the agent's `prompt` shown as plain text under "From the agent, not checked by SLICC:", capped at 200 characters, with **Answer in the vault**); unacknowledged `PolicyNotice`s as alerts (`[data-notice]`, each widening in a sentence, **Acknowledge**, `data-action="acknowledge"`); the secrets (`li[data-secret][data-state]`, with `[data-rules]`, `[data-exits]`, `[data-exec]` and how often programs were given it today ("at least" while older activity on the same day isn't loaded), `[data-source]`, `[data-used]`, `[data-expires]`, and **Replace value**, **Sign in again** or **Manage**) or `[data-empty]`; where the rules live (`[data-policy]`); **Import…** and **Export…**; and **Activity** (`ol.audit li[data-seq][data-type]`, **Only reveals to programs**, `data-action="reveals"`, and **Show older**, `data-action="older"`, paging with `audit(before)`). The section's `data-vault` is `locked`, `unlocked` or `loading`. A popup the browser blocked shows how to allow it (`[data-popup=blocked]`), a done one which secret was saved (`[data-popup=done]`). |
 | `<slicc-vault-button>` | Places `vault.button()`'s element (the vault's own button frame), posts its `config` (`ButtonConfig` plus `theme`) once the button is `ready`, takes the reported `size` (with the focus-ring `inset` as negative margin) and `label` (as its title), moves focus to the control before or after it when the frame reports `focus` (`previous` or `next`), and fires `vault-popup` (bubbles, composed) with each `popup` event's `{ intent, state, result? }`. |
-| `<slicc-updates>` | Install / Update: component states, version changes, last checks, download and link counts, action buttons, failures with Retry, and collapsible install logs. Opens at boot until the agent is ready without failures. Background updates stay in the header's update status; new failures reopen the panel, and after a reload into a boot that isn't ready yet such a panel closes once the agent is ready. Every automatic close is saved to the layout. When the port offers packages, an Optional packages section lists them below as compact rows, each with its state, version, download size, requirements, commands, progress, errors and Install log; packages never count in the header or keep the panel open at boot. Packages the user added or pinned with pnpm show up in their own Your packages section below it, with a Pinned or Added light, their version against seven's, and Unpin or Remove. Also available through View and the rails. |
+| `<slicc-updates>` | Install / Update: component states, version changes, last checks, download and link counts, action buttons, failures with Retry, and collapsible install logs. Opens at boot until the agent is ready without failures. Background updates stay in the header's update status; new failures reopen the panel, and after a reload into a boot that isn't ready yet such a panel closes once the agent is ready. Every automatic close is saved to the layout. When the port offers packages, an Optional packages section lists them below as compact rows, each with its state, version, download size, requirements, commands, progress, errors and Install log; packages never count in the header or keep the panel open at boot. Packages the user added or pinned with pnpm show up in their own Your packages section below it, with a neutral Pinned light (a hold, not a success) or a positive Added light, their version against seven's, and Unpin or Remove. Also available through View and the rails. |
 | `<slicc-memory>` | What agents remember, per scope (everyone, a cone or a role), grouped by section: search, filter by tag, expand, edit, add and forget. Free text outside an entry shows “From MEMORY.md”. |
 | `<slicc-monitor>` | The live monitor: vitals with sparklines (active agents, spend, budget, fullest context), alerts, and the topology (cones and scoops, terminals, tabs, pending changes, sprinkles, tray followers). Each section (`li.section[data-id]`) shows its count and an attention badge, and opens its surface with **Open** where one exists (`agents`, `terminals` and `processes` → terminal, `tabs`, `changes`). A section with rows expands into them with its toggle (`.toggle`, `aria-expanded`; `data-open` on the section): collapsed by default, expanded while a row is `warn` or `error`, until the user toggles it. Each row (`li.row[data-status]`, `data-id` from the row's `id`) shows a status light (blue active, gray idle, orange warn, red error, with the status spoken), the name, the meta line and its badges, indented by `depth` (`data-depth`, up to 6). |
 | `<slicc-freezer>` | Every conversation in the session, from `frozen()`: cones, scoops and agent runs, each with a kind badge, live ones first with a Live light, then the newest first. A live row offers **Open**, which selects that agent; a stopped one offers **Thaw** and **Remove**, which deletes its working folders after a confirmation. A thawed scoop or agent run keeps its row, which says what it was thawed as. **Delete cone**, in the agents list (or <kbd>Delete</kbd> on a cone's row) and the header's cone picker, stops a cone after a confirmation; `/freeze` does it at once. Either way its conversation stays here, and a row without a `kind` counts as a cone. |

package/dist/slicc-ui.js

@@ -14081,6 +14081,20 @@ function deepActive(root2) {
 }
 var scrollback = 1 << 18;
 var laid = ({ width, height }) => width > 0 && height > 0;
+function settled(element2) {
+  return new Promise((resolve2) => {
+    let last = "";
+    const frame = () => {
+      if (!element2.isConnected) return;
+      const { width, height } = element2.getBoundingClientRect();
+      const size4 = `${width}x${height}`;
+      if (laid({ width, height }) && size4 === last) return resolve2();
+      last = size4;
+      requestAnimationFrame(frame);
+    };
+    requestAnimationFrame(frame);
+  });
+}
 var ended = { write() {
 }, resize() {
 }, close() {
@@ -14286,7 +14300,7 @@ var SliccTerminalPanel = class extends ThemedElement {
     const backend = keep(model.terminals, info.id);
     terminal.backend = {
       open: async (sink) => {
-        await this.#placed(info.id);
+        await this.#placed(info.id, terminal);
         terminal.fit();
         return backend.open(sink, { cols: terminal.cols, rows: terminal.rows });
       }
@@ -14306,17 +14320,18 @@ var SliccTerminalPanel = class extends ThemedElement {
     );
     return terminal;
   }
-  #placed(id) {
+  #placed(id, screen) {
     const host4 = this.getRootNode().host;
     const panel = host4?.localName === "slicc-dock" ? host4.api.getPanel(terminalPanel(id)) : void 0;
-    if (!panel || laid(panel.api)) return Promise.resolve();
-    return new Promise((resolve2) => {
+    if (!panel) return Promise.resolve();
+    const sized = laid(panel.api) ? Promise.resolve() : new Promise((resolve2) => {
       const watch = panel.api.onDidDimensionsChange((size4) => {
         if (!laid(size4)) return;
         watch.dispose();
         resolve2();
       });
     });
+    return sized.then(() => settled(screen));
   }
   #request() {
     this.dispatchEvent(new CustomEvent("new-terminal", { bubbles: true, composed: true }));
@@ -21509,7 +21524,7 @@ var packageActions = {
 };
 function packageLight(item2) {
   if (item2.pin && item2.state === "installed")
-    return ["positive", item2.pin.base === null ? "Added" : "Pinned"];
+    return item2.pin.base === null ? ["positive", "Added"] : ["neutral", "Pinned"];
   if (item2.pin?.base && item2.state === "removing") return ["info", "Unpinning"];
   return packageStates[item2.state];
 }
@@ -21534,7 +21549,7 @@ function requiresText(item2, all2) {
   return parts2.length ? parts2.join("; ") : null;
 }
 var snapshot = (items) => new Map(items.map(({ id, state: state3, error }) => [id, { state: state3, error }]));
-function settled(failures, before, after) {
+function settled2(failures, before, after) {
   return new Map(
     [...failures].filter(([id]) => {
       const was = before.get(id);
@@ -21843,7 +21858,7 @@ var SliccUpdates = class extends ModelElement {
     const subscriptions = [
       port.on("items", (items) => {
         const next = snapshot(items);
-        this.failures = settled(this.failures, previous, next);
+        this.failures = settled2(this.failures, previous, next);
         previous = next;
         this.requestUpdate();
       })
@@ -21854,7 +21869,7 @@ var SliccUpdates = class extends ModelElement {
       ...subscriptions,
       port.on("packages", (items) => {
         const next = snapshot(items);
-        this.problems = settled(this.problems, packages, next);
+        this.problems = settled2(this.problems, packages, next);
         packages = next;
         this.requestUpdate();
       })
@@ -55121,16 +55136,24 @@ var OverflowObserver = class extends CompositeDisposable {
   }
 };
 function watchElementResize(element2, cb) {
+  const pendingFrames = /* @__PURE__ */ new Set();
   const observer = new ResizeObserver((entires) => {
-    requestAnimationFrame(() => {
+    let ran = false;
+    let frame;
+    frame = requestAnimationFrame(() => {
+      ran = true;
+      if (frame !== void 0) pendingFrames.delete(frame);
       const firstEntry = entires[0];
       cb(firstEntry);
     });
+    if (!ran) pendingFrames.add(frame);
   });
   observer.observe(element2);
   return { dispose: () => {
     observer.unobserve(element2);
     observer.disconnect();
+    for (const frame of pendingFrames) cancelAnimationFrame(frame);
+    pendingFrames.clear();
   } };
 }
 var removeClasses = (element2, ...classes) => {
@@ -63603,16 +63626,21 @@ var TabsContainer = class extends CompositeDisposable {
         y: event2.clientY,
         zIndex: (relativeParent === null || relativeParent === void 0 ? void 0 : relativeParent.style.zIndex) ? `calc(${relativeParent.style.zIndex} * 2)` : void 0
       };
-      const context = this.createOverflowRenderContext(root2, anchor);
+      const { context, rowRenderers } = this.createOverflowRenderContext(root2, anchor);
       const advancedOverflow = this.accessor.advancedOverflowService;
-      if (advancedOverflow) advancedOverflow.renderOverflow({
-        group: this.group,
-        overflowTabs: [...this._overflowTabs],
-        overflowTabGroups: [...this._overflowTabGroups],
-        pinnedOverflowTabs: [...this._overflowPinnedTabs],
-        context
-      });
-      else context.open(this.renderFreeOverflowList(context));
+      try {
+        if (advancedOverflow) advancedOverflow.renderOverflow({
+          group: this.group,
+          overflowTabs: [...this._overflowTabs],
+          overflowTabGroups: [...this._overflowTabGroups],
+          pinnedOverflowTabs: [...this._overflowPinnedTabs],
+          context
+        });
+        else context.open(this.renderFreeOverflowList(context));
+      } catch (err) {
+        rowRenderers.dispose();
+        throw err;
+      }
     }));
   }
   /**
@@ -63633,6 +63661,7 @@ var TabsContainer = class extends CompositeDisposable {
       if (overflowGroupSet.has(tg.id)) for (const pid of tg.panelIds) panelToGroup.set(pid, tg);
     }
     const popup2 = () => this.accessor.getPopupServiceForGroup(this.group);
+    const rowRenderers = new CompositeDisposable();
     const buildGroupHeader = (tg) => {
       const groupHeader = document.createElement("div");
       groupHeader.className = "dv-tabs-overflow-group-header";
@@ -63662,69 +63691,87 @@ var TabsContainer = class extends CompositeDisposable {
       return groupHeader;
     };
     return {
-      overflowGroupIdForPanel: (panelId) => {
-        var _panelToGroup$get;
-        return (_panelToGroup$get = panelToGroup.get(panelId)) === null || _panelToGroup$get === void 0 ? void 0 : _panelToGroup$get.id;
-      },
-      buildGroupHeader: (tabGroupId) => {
-        const tg = groupById.get(tabGroupId);
-        if (!tg || !overflowGroupSet.has(tg.id)) return;
-        return buildGroupHeader(tg);
-      },
-      buildPinnedHeader: () => {
-        const header = document.createElement("div");
-        header.className = "dv-tabs-overflow-group-header dv-tabs-overflow-pinned-header";
-        const glyph = createPinButton();
-        glyph.classList.add("dv-tabs-overflow-pinned-icon");
-        header.appendChild(glyph);
-        const labelSpan = document.createElement("span");
-        labelSpan.className = "dv-tabs-overflow-group-label";
-        labelSpan.textContent = "Pinned";
-        header.appendChild(labelSpan);
-        return header;
-      },
-      buildRow: (panelId) => {
-        const panel = this.group.panels.find((p17) => p17.id === panelId);
-        if (!panel) return;
-        const tab = this.tabs.tabs.find((t88) => t88.panel.id === panelId);
-        const tg = panelToGroup.get(panelId);
-        const child = panel.view.createTabRenderer("headerOverflow").element;
-        const wrapper = document.createElement("div");
-        toggleClass(wrapper, "dv-tab", true);
-        toggleClass(wrapper, "dv-active-tab", panel.api.isActive);
-        toggleClass(wrapper, "dv-inactive-tab", !panel.api.isActive);
-        if (tg) toggleClass(wrapper, "dv-tab--grouped", true);
-        const doActivate = () => {
-          if (tg === null || tg === void 0 ? void 0 : tg.collapsed) tg.expand();
-          tab === null || tab === void 0 || tab.element.scrollIntoView({
-            block: "nearest",
-            inline: "nearest"
+      context: {
+        overflowGroupIdForPanel: (panelId) => {
+          var _panelToGroup$get;
+          return (_panelToGroup$get = panelToGroup.get(panelId)) === null || _panelToGroup$get === void 0 ? void 0 : _panelToGroup$get.id;
+        },
+        buildGroupHeader: (tabGroupId) => {
+          const tg = groupById.get(tabGroupId);
+          if (!tg || !overflowGroupSet.has(tg.id)) return;
+          return buildGroupHeader(tg);
+        },
+        buildPinnedHeader: () => {
+          const header = document.createElement("div");
+          header.className = "dv-tabs-overflow-group-header dv-tabs-overflow-pinned-header";
+          const glyph = createPinButton();
+          glyph.classList.add("dv-tabs-overflow-pinned-icon");
+          header.appendChild(glyph);
+          const labelSpan = document.createElement("span");
+          labelSpan.className = "dv-tabs-overflow-group-label";
+          labelSpan.textContent = "Pinned";
+          header.appendChild(labelSpan);
+          return header;
+        },
+        buildRow: (panelId) => {
+          const panel = this.group.panels.find((p17) => p17.id === panelId);
+          if (!panel) return;
+          const tab = this.tabs.tabs.find((t88) => t88.panel.id === panelId);
+          const tg = panelToGroup.get(panelId);
+          const tabComponent = panel.view.createTabRenderer("headerOverflow");
+          let rowDisposed = false;
+          const disposeRow = Disposable.from(() => {
+            if (!rowDisposed) {
+              var _tabComponent$dispose;
+              rowDisposed = true;
+              (_tabComponent$dispose = tabComponent.dispose) === null || _tabComponent$dispose === void 0 || _tabComponent$dispose.call(tabComponent);
+            }
           });
-          this.accessor.withOrigin("user", () => panel.api.setActive());
-        };
-        wrapper.addEventListener("click", (event2) => {
-          popup2().close();
-          if (event2.defaultPrevented) return;
-          doActivate();
-        });
-        wrapper.appendChild(child);
-        return {
-          element: wrapper,
-          panel,
-          activate: () => {
+          if (rowRenderers.isDisposed) disposeRow.dispose();
+          else rowRenderers.addDisposables(disposeRow);
+          const child = tabComponent.element;
+          const wrapper = document.createElement("div");
+          toggleClass(wrapper, "dv-tab", true);
+          toggleClass(wrapper, "dv-active-tab", panel.api.isActive);
+          toggleClass(wrapper, "dv-inactive-tab", !panel.api.isActive);
+          if (tg) toggleClass(wrapper, "dv-tab--grouped", true);
+          const doActivate = () => {
+            if (tg === null || tg === void 0 ? void 0 : tg.collapsed) tg.expand();
+            tab === null || tab === void 0 || tab.element.scrollIntoView({
+              block: "nearest",
+              inline: "nearest"
+            });
+            this.accessor.withOrigin("user", () => panel.api.setActive());
+          };
+          wrapper.addEventListener("click", (event2) => {
             popup2().close();
+            if (event2.defaultPrevented) return;
             doActivate();
-          }
-        };
-      },
-      open: (body4) => {
-        popup2().openPopover(body4, anchor);
+          });
+          wrapper.appendChild(child);
+          return {
+            element: wrapper,
+            panel,
+            activate: () => {
+              popup2().close();
+              doActivate();
+            },
+            dispose: () => {
+              rowRenderers.removeDisposable(disposeRow);
+              disposeRow.dispose();
+            }
+          };
+        },
+        open: (body4) => {
+          popup2().openPopover(body4, anchor, { onClose: () => rowRenderers.dispose() });
+        },
+        close: () => popup2().close(),
+        focusTrigger: () => {
+          root2.tabIndex = -1;
+          root2.focus();
+        }
       },
-      close: () => popup2().close(),
-      focusTrigger: () => {
-        root2.tabIndex = -1;
-        root2.focus();
-      }
+      rowRenderers
     };
   }
   /**
@@ -64638,6 +64685,7 @@ var DockviewGroupPanelModel = class extends CompositeDisposable {
     this.tabsContainer.setRightActionsElement(element2);
   }
   setActive(isGroupActive, force = false) {
+    if (this.isDisposed) return;
     if (!force && this.isActive === isGroupActive) return;
     this._isGroupActive = isGroupActive;
     toggleClass(this.container, "dv-active-group", isGroupActive);
@@ -67291,13 +67339,14 @@ var ContextMenuController = class {
   * menu passes the `tabGroup`. No-op when no renderer could be created (no
   * factory configured, or the factory declined the component).
   */
-  appendComponentItem(menuEl, item2, identity, group, close) {
+  appendComponentItem(menuEl, item2, identity, group, close, renderers) {
     var _this$accessor$option4, _this$accessor$option5;
     const renderer = (_this$accessor$option4 = (_this$accessor$option5 = this.accessor.options).createContextMenuItemComponent) === null || _this$accessor$option4 === void 0 ? void 0 : _this$accessor$option4.call(_this$accessor$option5, {
       id: nextContextMenuItemId(),
       component: item2.component
     });
     if (!renderer) return;
+    renderers.addDisposables(renderer);
     renderer.init(_objectSpread2(_objectSpread2({}, identity), {}, {
       group,
       api: this.accessor.api,
@@ -67357,9 +67406,9 @@ var ContextMenuController = class {
   * default row; an item carrying none of the three renders nothing. Shared
   * by both menus, which differ only in `identity`.
   */
-  appendConfigItem(menuEl, item2, identity, group, close) {
+  appendConfigItem(menuEl, item2, identity, group, close, renderers) {
     if (item2.element) menuEl.appendChild(item2.element);
-    else if (item2.component) this.appendComponentItem(menuEl, item2, identity, group, close);
+    else if (item2.component) this.appendComponentItem(menuEl, item2, identity, group, close, renderers);
     else if (item2.label) menuEl.appendChild(buildItem(item2.label, close, () => {
       var _item$action;
       return (_item$action = item2.action) === null || _item$action === void 0 ? void 0 : _item$action.call(item2);
@@ -67371,22 +67420,28 @@ var ContextMenuController = class {
     event2.preventDefault();
     const popupService = this.accessor.getPopupServiceForGroup(group);
     const close = () => popupService.close();
+    const renderers = new CompositeDisposable();
     const menuEl = document.createElement("div");
     menuEl.className = "dv-context-menu";
     menuEl.setAttribute("role", "menu");
-    for (const item2 of items) {
-      if (isItemConfig(item2)) {
-        this.appendConfigItem(menuEl, item2, { panel }, group, close);
-        continue;
+    try {
+      for (const item2 of items) {
+        if (isItemConfig(item2)) {
+          this.appendConfigItem(menuEl, item2, { panel }, group, close, renderers);
+          continue;
+        }
+        const el = this.buildBuiltInTabItem(item2, panel, group, close);
+        if (el) menuEl.appendChild(el);
       }
-      const el = this.buildBuiltInTabItem(item2, panel, group, close);
-      if (el) menuEl.appendChild(el);
+    } catch (err) {
+      renderers.dispose();
+      throw err;
     }
     popupService.openPopover(menuEl, {
       x: event2.clientX,
       y: event2.clientY,
       zIndex: popoverZIndexFor(event2.target, group)
-    });
+    }, { onClose: () => renderers.dispose() });
   }
   showForChip(tabGroup, group, event2) {
     if (!this.accessor.options.getTabGroupChipContextMenuItems) return;
@@ -67400,22 +67455,28 @@ var ContextMenuController = class {
     event2.preventDefault();
     const popupService = this.accessor.getPopupServiceForGroup(group);
     const close = () => popupService.close();
+    const renderers = new CompositeDisposable();
     const menuEl = document.createElement("div");
     menuEl.className = "dv-context-menu";
     menuEl.setAttribute("role", "menu");
-    for (const item2 of items) if (item2 === "separator") menuEl.appendChild(buildSeparator());
-    else if (item2 === "rename") menuEl.appendChild(buildRenameInput(tabGroup));
-    else if (item2 === "colorPicker") menuEl.appendChild(buildColorPicker(tabGroup, this.accessor.tabGroupColorPalette));
-    else if (item2 === "collapse") menuEl.appendChild(this.buildCollapseItem(tabGroup, close));
-    else if (item2 === "close") menuEl.appendChild(buildItem("Close All", close, () => {
-      group.panels.filter((p17) => tabGroup.containsPanel(p17.id)).forEach((p17) => p17.api.close());
-    }));
-    else if (isItemConfig(item2)) this.appendConfigItem(menuEl, item2, { tabGroup }, group, close);
+    try {
+      for (const item2 of items) if (item2 === "separator") menuEl.appendChild(buildSeparator());
+      else if (item2 === "rename") menuEl.appendChild(buildRenameInput(tabGroup));
+      else if (item2 === "colorPicker") menuEl.appendChild(buildColorPicker(tabGroup, this.accessor.tabGroupColorPalette));
+      else if (item2 === "collapse") menuEl.appendChild(this.buildCollapseItem(tabGroup, close));
+      else if (item2 === "close") menuEl.appendChild(buildItem("Close All", close, () => {
+        group.panels.filter((p17) => tabGroup.containsPanel(p17.id)).forEach((p17) => p17.api.close());
+      }));
+      else if (isItemConfig(item2)) this.appendConfigItem(menuEl, item2, { tabGroup }, group, close, renderers);
+    } catch (err) {
+      renderers.dispose();
+      throw err;
+    }
     popupService.openPopover(menuEl, {
       x: event2.clientX,
       y: event2.clientY,
       zIndex: popoverZIndexFor(event2.target, group)
-    });
+    }, { onClose: () => renderers.dispose() });
   }
 };
 var ContextMenuModule = defineModule({
@@ -67633,6 +67694,7 @@ var OverlayRenderContainer = class extends CompositeDisposable {
     const observerDisposable = new MutableDisposable();
     const correctLayerPosition = () => {
       if (panel.api.location.type === "floating") queueMicrotask(() => {
+        if (disposable.isDisposed) return;
         const floatingGroup = this.accessor.getFloatingWindowForGroup(panel.api.group);
         if (!floatingGroup) return;
         const element2 = floatingGroup.overlay.element;
@@ -67831,7 +67893,7 @@ var PopupService = class extends CompositeDisposable {
     newRoot.prepend(this._element);
     this._root = newRoot;
   }
-  openPopover(element2, position) {
+  openPopover(element2, position, options) {
     var _position$zIndex;
     this.close();
     const wrapper = this._window.document.createElement("div");
@@ -67846,14 +67908,14 @@ var PopupService = class extends CompositeDisposable {
     this._element.appendChild(wrapper);
     this._active = wrapper;
     const POINTERDOWN_GRACE_MS = 200;
-    this._activeDisposable.value = createDismissableLayer({
+    this._activeDisposable.value = new CompositeDisposable(createDismissableLayer({
       window: this._window,
       onDismiss: () => this.close(),
       elements: () => this._active ? [this._active] : [],
       keys: ["Enter"],
       pointerDownGraceMs: POINTERDOWN_GRACE_MS,
       resize: true
-    });
+    }), (options === null || options === void 0 ? void 0 : options.onClose) ? Disposable.from(options.onClose) : Disposable.NONE);
     this._window.requestAnimationFrame(() => {
       shiftAbsoluteElementIntoView(wrapper, this._root);
     });
@@ -69142,7 +69204,9 @@ var DockviewComponent = class extends BaseGrid {
     this._onWillDrop = new Emitter2();
     this.onWillDrop = this._onWillDrop.event;
     this._mutationDepth = 0;
+    this._syncMutationDepth = 0;
     this._pendingLocationChanges = /* @__PURE__ */ new Map();
+    this._openingPopoutWindows = /* @__PURE__ */ new Set();
     this._origin = "user";
     this._originDepth = 0;
     this._onWillMutateLayout = new Emitter2();
@@ -69226,6 +69290,10 @@ var DockviewComponent = class extends BaseGrid {
       });
     }));
     this.popupService = new PopupService(this.element);
+    this.addDisposables(this.popupService, Disposable.from(() => {
+      for (const opening2 of this._openingPopoutWindows) opening2.dispose();
+      this._openingPopoutWindows.clear();
+    }));
     this._api = new DockviewApi(this);
     this.disableResizing = true;
     this.element.remove();
@@ -69370,9 +69438,15 @@ var DockviewComponent = class extends BaseGrid {
     const popoutWindowDisposable = new CompositeDisposable(_window, _window.onDidClose(() => {
       popoutWindowDisposable.dispose();
     }));
+    this._openingPopoutWindows.add(popoutWindowDisposable);
     const openError = getPopoutUrlError(popoutUrl);
     return (openError ? Promise.resolve(null) : _window.open()).then((popoutContainer) => {
       var _options$referenceGro, _options$overridePopo4;
+      this._openingPopoutWindows.delete(popoutWindowDisposable);
+      if (this.isDisposed) {
+        popoutWindowDisposable.dispose();
+        return false;
+      }
       if (_window.isDisposed) {
         const failure2 = _window.failure;
         if (failure2 && !this.isDisposed) {
@@ -69556,6 +69630,7 @@ var DockviewComponent = class extends BaseGrid {
       for (const { panel, from } of movedPanels) this.fireDidMovePanel(panel, from);
       return true;
     }).catch((err) => {
+      this._openingPopoutWindows.delete(popoutWindowDisposable);
       console.error("dockview: failed to create popout.", err);
       return false;
     });
@@ -70079,6 +70154,7 @@ var DockviewComponent = class extends BaseGrid {
       group.dispose();
       this._groups.delete(group.id);
       this._onDidRemoveGroup.fire(group);
+      this.activateFallbackGroupIfRemoved(group);
     });
   }
   setEdgeGroupCollapsed(group, collapsed) {
@@ -70251,10 +70327,12 @@ var DockviewComponent = class extends BaseGrid {
         const record = this._groups.get(temporaryGroup.api.id);
         this._groups.delete(temporaryGroup.api.id);
         temporaryGroupDisposables.push(Disposable.from(() => {
+          var _this$headerActionsSe2;
           this.movingLock(() => {
             for (const panel of temporaryGroup.panels.slice()) temporaryGroup.model.removePanel(panel);
           });
           record === null || record === void 0 || record.disposable.dispose();
+          (_this$headerActionsSe2 = this.headerActionsService) === null || _this$headerActionsSe2 === void 0 || _this$headerActionsSe2.disposeGroup(temporaryGroup);
           temporaryGroup.dispose();
         }));
         return temporaryGroup;
@@ -70873,9 +70951,12 @@ var DockviewComponent = class extends BaseGrid {
   */
   mutation(kind, func) {
     const close = this.openMutation(kind);
+    this._syncMutationDepth++;
     try {
       return func();
     } finally {
+      this._syncMutationDepth--;
+      if (this._syncMutationDepth === 0) this.releaseDisposedActiveGroup();
       close();
     }
   }
@@ -70922,6 +71003,7 @@ var DockviewComponent = class extends BaseGrid {
     return () => {
       this._mutationDepth--;
       if (this._mutationDepth === 0) {
+        this.releaseDisposedActiveGroup();
         this.flushLocationChanges();
         this._onDidMutateLayout.fire({
           kind,
@@ -70930,6 +71012,11 @@ var DockviewComponent = class extends BaseGrid {
       }
     };
   }
+  /** Covers removals with `skipActive` that disposed the active group. */
+  releaseDisposedActiveGroup() {
+    var _this$_activeGroup;
+    if (!this.isDisposed && ((_this$_activeGroup = this._activeGroup) === null || _this$_activeGroup === void 0 ? void 0 : _this$_activeGroup.model.isDisposed)) this.activateFallbackGroupIfRemoved(this._activeGroup);
+  }
   /**
   * Coalesce a panel's `onDidLocationChange` to the end of the enclosing
   * transaction, or fire it immediately when no transaction is in flight.
@@ -71058,7 +71145,7 @@ var DockviewComponent = class extends BaseGrid {
         skipSetActiveGroup: true
       }));
       if (!removedPanel) throw new Error(`dockview: No panel with id ${sourceItemId}`);
-      if (!options.keepEmptyGroups && sourceGroup.model.size === 0) this.doRemoveGroup(sourceGroup, { skipActive: true });
+      if (!options.keepEmptyGroups && sourceGroup.model.size === 0 && sourceGroup !== destinationGroup) this.doRemoveGroup(sourceGroup, { skipActive: true });
       const isDestinationGroupEmpty = destinationGroup.model.size === 0;
       this.movingLock(() => {
         var _options$skipSetActiv;
@@ -71192,6 +71279,7 @@ var DockviewComponent = class extends BaseGrid {
     const from = options.from.group;
     const to = options.to.group;
     const target = options.to.position;
+    if (target === "center" && from === to) return;
     let source = from;
     let mergedPanels;
     if (target === "center") {
@@ -81176,7 +81264,7 @@ lit-html/static.js:
 dockview-core/dist/package/main.esm.mjs:
   (**
    * dockview-core
-   * @version 8.4.0
+   * @version 8.4.1
    * @link https://github.com/dockview/dockview
    * @license MIT
    *)