@ai-ecoverse/slicc-shared-web 1.4.0 → 1.4.1

package/README.md

@@ -63,12 +63,13 @@ test('boots', async (t) => {
 | `args` | Extra Chromium flags, such as `--host-resolver-rules` or `--ignore-certificate-errors` | none |
 | `timeout` | How long `page.until` polls, in ms | `30000` |
 
-`chrome.page(t)` opens a tab and returns the page API: `goto(path)`, `reload()`, `evaluate(fn, ...args)`, `until(fn, ...args)`, `press(key, ...modifiers)` (a key name like `Enter` or `F5`, or a single character typed with its US-layout key code), `type(text)`, `insert(text)`, `enter()`, `init(fn)` (runs in every new document), `expose(name, handler)` (a binding the page calls with a JSON string), `screenshot(file)`, `tab()` (another tab in the same context), `close()`, `errors`, `responses` and `dir` (the test's artifact directory). `chrome.requests` lists the paths the server saw in this test, `chrome.overrides` is a `Map` of paths to bodies served instead of files, and `chrome.cdn` takes `status` (answer every intercepted request with it), `corrupt` (flip the last byte) and lists the intercepted `requests`. All of them reset with each test. `serve(options)` starts the same server on its own, for an `npm start`.
+`chrome.page(t)` opens a tab and returns the page API: `goto(path)`, `reload()`, `evaluate(fn, ...args)`, `until(fn, ...args)`, `press(key, ...modifiers)` (a key name like `Enter` or `F5`, or a single character typed with its US-layout key code), `type(text)`, `insert(text)`, `enter()`, `init(fn)` (runs in every new document), `expose(name, handler)` (a binding the page calls with a JSON string), `screenshot(file)`, `tab()` (another tab in the same context), `close()`, `errors`, `responses` and `dir` (the test's artifact directory). `goto` and `reload` wait until the new document is complete and no longer `about:blank`, and retry the navigation once if that never happens. `until` polls until the function returns a truthy value (not only strict `true`) and resolves with that value; the timeout error names the last result. `chrome.requests` lists the paths the server saw in this test, `chrome.overrides` is a `Map` of paths to bodies served instead of files, and `chrome.cdn` takes `status` (answer every intercepted request with it), `corrupt` (flip the last byte) and lists the intercepted `requests`. All of them reset with each test. `serve(options)` starts the same server on its own, for an `npm start`.
 
 Why it works the way it does:
 
 - Playwright detaches from shared workers, which resumes them early, so their coverage started late about half the time. Raw CDP keeps every worker paused until the profiler runs.
-- `debugger;` pauses in `beforeunload` but not in `pagehide` or `pageswap`, so a `beforeunload` hook, installed after `Page.enable`, takes the coverage of a page before it navigates. The pause only answers CDP when the page itself starts the navigation, so `goto` and `reload` go through `location`, never `Page.navigate` or `Page.reload`.
+- `debugger;` pauses in `beforeunload` but not in `pagehide` or `pageswap`, so a `beforeunload` hook, installed after `Page.enable`, takes the coverage of a page before it navigates. The pause only answers CDP when the page itself starts the navigation, so `goto` and `reload` go through `location`, never `Page.navigate` or `Page.reload`. Navigating away from `about:blank` skips the coverage dump so the first real load is not held in `beforeunload` for a useless snapshot.
+- `goto` used to return as soon as the document swapped (`window.stale` cleared), which is before `readyState` is `complete` and before module scripts run. About 1 load in 20 then looked blank to the next assertion. It now waits for a complete, non-blank document.
 - `takePreciseCoverage` resets the counters, so every snapshot is a delta, and all of them are kept and summed.
 - monocart's `add()` from parallel test processes loses data, so each test writes raw JSON and the teardown merges it once.
 - Coverage of a script served from `chrome.overrides` would be mapped onto the file on disk, so a path overridden during a test is left out of that test's coverage.

package/harness/page.mjs

@@ -73,7 +73,15 @@ export function mark() {
 }
 
 export function fresh() {
-  return !window.stale;
+  return !window.stale && document.readyState === 'complete' && location.href !== 'about:blank';
+}
+
+const specials = { Infinity, '-Infinity': -Infinity, NaN, '-0': -0 };
+
+export function decoded({ value, unserializableValue }) {
+  if (unserializableValue === undefined) return value;
+  if (unserializableValue.endsWith('n')) return BigInt(unserializableValue.slice(0, -1));
+  return specials[unserializableValue];
 }
 
 export function page(cdp, { sessionId, targetId }, server, timeout = 30000) {
@@ -99,18 +107,24 @@ export function page(cdp, { sessionId, targetId }, server, timeout = 30000) {
       returnByValue: true,
     });
     if (exceptionDetails) throw new Error(exceptionDetails.exception?.description);
-    return result.value;
+    return decoded(result);
   }
 
   async function until(fn, ...args) {
     const deadline = Date.now() + timeout;
     let last;
     while (Date.now() < deadline) {
-      last = await evaluate(fn, ...args).catch((error) => error.message);
-      if (last === true) return;
+      try {
+        last = await evaluate(fn, ...args);
+        if (last) return last;
+      } catch (error) {
+        last = error.message;
+      }
       await sleep(25);
     }
-    throw new Error(`Timed out waiting for ${fn}\nlast result: ${JSON.stringify(last)}`);
+    throw new Error(
+      `Timed out waiting for a truthy result from ${fn}\nlast result: ${JSON.stringify(last)}`
+    );
   }
 
   async function press(key, ...modifiers) {
@@ -120,9 +134,16 @@ export function page(cdp, { sessionId, targetId }, server, timeout = 30000) {
   }
 
   async function navigate(expression) {
-    await evaluate(mark);
-    await send('Runtime.evaluate', { expression });
-    await until(fresh);
+    for (let attempt = 0; attempt < 2; attempt++) {
+      await evaluate(mark);
+      await send('Runtime.evaluate', { expression });
+      try {
+        await until(fresh);
+        return;
+      } catch (error) {
+        if (attempt === 1) throw error;
+      }
+    }
   }
 
   return {

package/harness/recorder.mjs

@@ -154,7 +154,12 @@ export function recorder(cdp, server, { coverage = ['/'], exits = new Map() } =
   async function paused(sessionId) {
     const target = sessions.get(sessionId);
     if (target?.type === 'worker') await dump(sessionId, target, false);
-    else await checkpoint();
+    else {
+      const { result } = await cdp
+        .send('Runtime.evaluate', { expression: 'location.href', returnByValue: true }, sessionId)
+        .catch(() => ({ result: {} }));
+      if (result?.value && result.value !== 'about:blank') await checkpoint();
+    }
     await cdp.send('Debugger.resume', {}, sessionId).catch(ignore);
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ai-ecoverse/slicc-shared-web",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Shared Renovate, Biome, TypeScript, lefthook and GitHub Actions configuration, plus the CDP integration-test harness, for SLICC's web repos",
   "type": "module",
   "license": "Apache-2.0",