@ai-ecoverse/slicc-browsers 1.20.2 → 1.20.3

package/extension-frame.mjs

@@ -938,7 +938,48 @@ async function driveCast(client, page, frameMs) {
   };
 }
 
-export async function driveReveal(client, reader, page, observer, frameMs, missing, side) {
+function classifyRevealOverlap(
+  captureStartedAt,
+  revealAt,
+  pendingWhenRevealAcknowledged,
+  captureSettledAt
+) {
+  if (typeof captureStartedAt !== 'number' || typeof revealAt !== 'number') return 'unknown';
+  if (revealAt <= captureStartedAt) return 'before';
+  if (pendingWhenRevealAcknowledged) return 'during';
+  if (typeof captureSettledAt === 'number' && captureSettledAt < revealAt) return 'after';
+  return 'unknown';
+}
+
+function revealRaceVerdict(overlap, side, ok, shownRefused) {
+  if (overlap === 'during' || overlap === 'before') return side === 'control' ? ok : shownRefused;
+  if (overlap === 'after') return ok || shownRefused;
+  return false;
+}
+
+async function finishReveal(
+  client,
+  reader,
+  page,
+  observer,
+  frameMs,
+  { ok, text, overlap, revealRacePass }
+) {
+  const revealedPress = await click(client, reader, page, observer);
+  await style(reader, observer, 'hidden', frameMs);
+  const rehidden = await shot(client, page);
+  return {
+    revealedShot: ok,
+    revealedRefusal: text,
+    revealOverlap: overlap,
+    revealRacePass,
+    revealedClick: revealedPress.ok,
+    revealedClickRefusal: refusal(revealedPress.out),
+    rehiddenShot: rehidden.ok,
+  };
+}
+
+async function attemptRevealCapture(client, reader, page, observer, side) {
   const captureStartedAt = await observe(reader, observer, 'performance.now()');
   let captureSettled = false;
   let captureSettledAt;
@@ -963,31 +1004,38 @@ export async function driveReveal(client, reader, page, observer, frameMs, missi
   const out = await pending;
   const ok = out.ok && typeof out.result?.data === 'string' && out.result.data.length > 0;
   const text = refusal(out);
-  let overlap = 'unknown';
-  if (typeof captureStartedAt !== 'number' || typeof revealAt !== 'number') overlap = 'unknown';
-  else if (revealAt <= captureStartedAt) overlap = 'before';
-  else if (pendingWhenRevealAcknowledged) overlap = 'during';
-  else if (typeof captureSettledAt === 'number' && captureSettledAt < revealAt) overlap = 'after';
-  if (overlap === 'unknown') missing.push('reveal/capture overlap unproven');
+  const overlap = classifyRevealOverlap(
+    captureStartedAt,
+    revealAt,
+    pendingWhenRevealAcknowledged,
+    captureSettledAt
+  );
   const shownRefused = Boolean(text && (text === SHOWN || /^slicc: refused/.test(text)));
-  let revealRacePass = false;
-  if (overlap === 'during' || overlap === 'before')
-    revealRacePass = side === 'control' ? ok : shownRefused;
-  else if (overlap === 'after') revealRacePass = ok || shownRefused;
-  const revealedPress = await click(client, reader, page, observer);
-  await style(reader, observer, 'hidden', frameMs);
-  const rehidden = await shot(client, page);
   return {
-    revealedShot: ok,
-    revealedRefusal: text,
-    revealOverlap: overlap,
-    revealRacePass,
-    revealedClick: revealedPress.ok,
-    revealedClickRefusal: refusal(revealedPress.out),
-    rehiddenShot: rehidden.ok,
+    ok,
+    text,
+    overlap,
+    revealRacePass: revealRaceVerdict(overlap, side, ok, shownRefused),
   };
 }
 
+export async function driveReveal(client, reader, page, observer, frameMs, missing, side) {
+  const maxAttempts = 3;
+  let last = null;
+  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+    last = await attemptRevealCapture(client, reader, page, observer, side);
+    if (last.overlap !== 'unknown')
+      return finishReveal(client, reader, page, observer, frameMs, last);
+    if (attempt < maxAttempts) await style(reader, observer, 'hidden', frameMs);
+  }
+  missing.push(`reveal/capture overlap unproven (${maxAttempts} attempts)`);
+  return finishReveal(client, reader, page, observer, frameMs, {
+    ...last,
+    overlap: 'unknown',
+    revealRacePass: false,
+  });
+}
+
 function frameObservations({ pageAttached, origin, read, leaks, picture, input, captures }) {
   return {
     exists: true,

package/guard-vectors.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
-  "setVersion": "1.20.2",
+  "setVersion": "1.20.3",
   "sources": [
     {
       "repo": "ai-ecoverse/slicc-cli",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ai-ecoverse/slicc-browsers",
-  "version": "1.20.2",
+  "version": "1.20.3",
   "description": "SLICC's shared browser catalog, JSON schemas and discovery conformance corpus",
   "type": "module",
   "license": "Apache-2.0",
@@ -84,7 +84,7 @@
     "test:unit:guard": "mkdir -p coverage/unit && node --experimental-vm-modules --no-warnings --experimental-test-coverage --test --test-concurrency=1 --test-coverage-include=guard-runner.mjs --test-coverage-include=guard-driver.mjs --test-coverage-include=extension-frame.mjs --test-coverage-include=fixture-server.mjs --test-coverage-include=fixture-client.mjs --test-coverage-include=observer-target.mjs --test-coverage-include=frame-read.mjs --test-coverage-include=bfcache-restore.mjs --test-coverage-include=protected-error-page.mjs --test-coverage-include=unparseable-url.mjs --test-coverage-include=scripts/browser-runner.mjs --test-coverage-include=scripts/validate.mjs --test-reporter=lcov --test-reporter-destination=coverage/unit/guard.lcov test/unit/guard-*.test.mjs && slicc-diff-cover coverage/unit/guard.lcov"
   },
   "devDependencies": {
-    "@ai-ecoverse/slicc-cdp": "1.46.1",
+    "@ai-ecoverse/slicc-cdp": "1.46.2",
     "@ai-ecoverse/slicc-shared-web": "2.13.10",
     "@biomejs/biome": "2.6.4",
     "ajv": "8.20.0",