@ai-ecoverse/slicc-browsers 1.13.2 → 1.14.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ai-ecoverse/slicc-browsers",
-  "version": "1.13.2",
+  "version": "1.14.2",
   "description": "SLICC's shared browser catalog, JSON schemas and discovery conformance corpus",
   "type": "module",
   "license": "Apache-2.0",
@@ -61,19 +61,19 @@
     "fixture-client.mjs"
   ],
   "scripts": {
-    "prepare": "lefthook install",
+    "prepare": "slicc-install-hooks",
     "corpus": "node scripts/corpus.mjs",
     "validate": "node scripts/validate.mjs",
     "lint": "slicc-lint && test -z \"$(gofmt -l .)\" && go mod tidy -diff && go vet ./... && golangci-lint run && cargo fmt --check && cargo clippy --all-features --all-targets -- -D warnings",
     "format": "biome check --write . && gofmt -w . && cargo fmt",
-    "test": "npm run validate && node --test test/integration/self-contained.test.mjs test/integration/browser-runner.test.mjs test/integration/fixture-client.test.mjs test/integration/git-retry.test.mjs && go test -race -count=1 ./test/integration/... && cargo test --all-features",
+    "test": "npm run validate && node --test test/integration/self-contained.test.mjs test/integration/browser-runner.test.mjs test/integration/fixture-client.test.mjs test/integration/git-retry.test.mjs test/integration/dist-tag.test.mjs test/integration/guard-incomplete.test.mjs test/integration/guard-stall.test.mjs && go test -race -count=1 ./test/integration/... && cargo test --all-features",
     "test:unit": "go test -race -cover ./...",
     "build": "go build ./... && cargo build --all-features && cargo build --target wasm32-wasip1 --all-features && npm pack --dry-run",
     "trust": "npx fledgling sync -y --skip-publish",
     "trust:dry": "npx fledgling sync --dry-run -y --skip-publish",
     "release": "semantic-release",
     "test:guard": "npm run test:guard-integration && npm run test:guard-sweep",
-    "test:guard-integration": "node --test --test-concurrency=2 test/integration/guard-lifecycle.test.mjs test/integration/guard-fit.test.mjs test/integration/guard-chain.test.mjs test/integration/guard-validation.test.mjs test/integration/guard-liveness.test.mjs test/integration/guard-observations.test.mjs test/integration/guard-child-latency.test.mjs test/integration/guard-adoption.test.mjs test/integration/guard-scoping.test.mjs test/integration/guard-late-pause.test.mjs test/integration/guard-legs.test.mjs test/integration/guard-fetch-enable.test.mjs test/integration/guard-diagnostics.test.mjs test/integration/guard-chrome.test.mjs test/integration/guard-worlds.test.mjs test/integration/guard-world-discovery.test.mjs test/integration/guard-world-guesses.test.mjs test/integration/guard-unparseable.test.mjs test/integration/guard-redirect-secret.test.mjs test/integration/guard-error-page.test.mjs test/integration/guard-discovery.test.mjs test/integration/guard-browser-page.test.mjs test/integration/guard-scales.test.mjs test/integration/guard-shared-log.test.mjs test/integration/guard-pre-beacon.test.mjs test/integration/guard-world-pause.test.mjs test/integration/self-contained.test.mjs",
+    "test:guard-integration": "node --test --test-concurrency=2 test/integration/guard-lifecycle.test.mjs test/integration/guard-fit.test.mjs test/integration/guard-chain.test.mjs test/integration/guard-validation.test.mjs test/integration/guard-liveness.test.mjs test/integration/guard-observations.test.mjs test/integration/guard-child-latency.test.mjs test/integration/guard-adoption.test.mjs test/integration/guard-scoping.test.mjs test/integration/guard-late-pause.test.mjs test/integration/guard-legs.test.mjs test/integration/guard-fetch-enable.test.mjs test/integration/guard-diagnostics.test.mjs test/integration/guard-chrome.test.mjs test/integration/guard-worlds.test.mjs test/integration/guard-world-discovery.test.mjs test/integration/guard-world-guesses.test.mjs test/integration/guard-unparseable.test.mjs test/integration/guard-redirect-secret.test.mjs test/integration/guard-error-page.test.mjs test/integration/guard-discovery.test.mjs test/integration/guard-browser-page.test.mjs test/integration/guard-scales.test.mjs test/integration/guard-shared-log.test.mjs test/integration/guard-pre-beacon.test.mjs test/integration/guard-world-pause.test.mjs test/integration/guard-parallel.test.mjs test/integration/self-contained.test.mjs",
     "test:guard-sweep": "node scripts/test-guards.mjs",
     "test:gates": "node --test test/integration/gates.test.mjs",
     "test:guard-target": "node --test test/integration/guard-runner.test.mjs",
@@ -81,7 +81,7 @@
     "test:unit:guard": "mkdir -p coverage/unit && node --experimental-vm-modules --no-warnings --experimental-test-coverage --test --test-coverage-include=guard-runner.mjs --test-coverage-include=fixture-server.mjs --test-coverage-include=fixture-client.mjs --test-coverage-include=observer-target.mjs --test-coverage-include=protected-error-page.mjs --test-coverage-include=unparseable-url.mjs --test-coverage-include=scripts/browser-runner.mjs --test-coverage-include=scripts/validate.mjs --test-reporter=lcov --test-reporter-destination=coverage/unit/guard.lcov test/unit/guard-*.test.mjs && slicc-diff-cover coverage/unit/guard.lcov"
   },
   "devDependencies": {
-    "@ai-ecoverse/slicc-shared-web": "2.2.0",
+    "@ai-ecoverse/slicc-shared-web": "2.3.5",
     "@biomejs/biome": "2.5.15",
     "ajv": "8.20.0",
     "ajv-formats": "3.0.1",

package/protected-error-page.mjs

@@ -1,19 +1,10 @@
-import { outcome } from './guard-driver.mjs';
+import { outcome, waitFor } from './guard-driver.mjs';
 import { createObserverTarget } from './observer-target.mjs';
 
 const pause = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
 const refused = (out) => !out.ok && /^slicc: refused:/.test(out.error?.message ?? '');
 
-async function until(check) {
-  const deadline = Date.now() + 5000;
-  do {
-    if (await check()) return true;
-    await pause(25);
-  } while (Date.now() < deadline);
-  return false;
-}
-
-async function loadedDocument(reader, observer, url) {
+async function loadedDocument(reader, observer, url, until) {
   return until(async () => {
     const { frameTree } = await reader.send('Page.getFrameTree', {}, observer);
     if (frameTree.frame.url !== url || frameTree.frame.unreachableUrl) return false;
@@ -89,6 +80,18 @@ async function redaction({
     : 'not-supported';
 }
 
+async function seed(reader, observer, loaded, initial, allowed) {
+  const out = await outcome(
+    (async () => {
+      await reader.send('Page.enable', {}, observer);
+      if (!(await loaded(initial))) return 'history seed did not commit';
+      await reader.send('Page.navigate', { url: allowed }, observer);
+      if (!(await loaded(allowed))) return 'allowed document did not commit';
+    })()
+  );
+  return out.ok ? out.result : `observer setup failed: ${out.error.message}`;
+}
+
 const secrets = {
   all: (tag) => `/doc/path-secret-${tag}?query-secret=${tag}#fragment-secret-${tag}`,
   query: (tag) => `/doc?query-secret=${tag}`,
@@ -107,10 +110,13 @@ export async function protectedErrorPage({
   secret = 'all',
   discovery = true,
   notes = [],
+  budget = 5000,
 }) {
   const initial = `${protectedOrigin}/doc?n=${tag}-history`;
   const failedURL = `${protectedOrigin}${secrets[secret](tag)}`;
   const result = {};
+  const until = (check) => waitFor(check, budget);
+  const missing = (reason) => ({ ...result, incomplete: `protected-error-page: ${reason}` });
   if (!discovery) notes.push('eventsRedacted: not-supported:discovery');
   const start = client.events.length;
   const { targetId } = await createObserverTarget(
@@ -126,7 +132,7 @@ export async function protectedErrorPage({
   observer = sessionId;
   internalSessions.add(observer);
   const frame = async () => (await reader.send('Page.getFrameTree', {}, observer)).frameTree.frame;
-  const loaded = (url) => loadedDocument(reader, observer, url);
+  const loaded = (url) => loadedDocument(reader, observer, url, until);
   let stopped = false;
   const fail = (async () => {
     while (!stopped) {
@@ -147,12 +153,8 @@ export async function protectedErrorPage({
     }
   })();
   try {
-    await reader.send('Page.enable', {}, observer);
-    if (!(await loaded(initial)))
-      throw new Error('protected-error-page: history seed did not commit');
-    await reader.send('Page.navigate', { url: `${ordinary}/blank` }, observer);
-    if (!(await loaded(`${ordinary}/blank`)))
-      throw new Error('protected-error-page: allowed document did not commit');
+    const unseeded = await seed(reader, observer, loaded, initial, `${ordinary}/blank`);
+    if (unseeded) return missing(unseeded);
     const attached = await outcome(
       client.send('Target.attachToTarget', { targetId, flatten: true })
     );
@@ -174,10 +176,11 @@ export async function protectedErrorPage({
       { expression: `setTimeout(()=>location.href=${JSON.stringify(failedURL)},0)` },
       session
     );
-    result.live = await until(async () => {
+    let evidence;
+    const live = await until(async () => {
       const f = await frame();
       const { targetInfo } = await reader.send('Target.getTargetInfo', { targetId });
-      result.evidence = { frame: f, targetInfo };
+      evidence = { frame: f, targetInfo };
       return (
         f.url === 'chrome-error://chromewebdata/' &&
         f.securityOrigin === '://' &&
@@ -185,11 +188,11 @@ export async function protectedErrorPage({
         targetInfo.url === failedURL
       );
     });
-    if (!result.live && side !== 'control') return result;
-    if (!result.live)
-      throw new Error(
-        `protected-error-page: missing error commit ${JSON.stringify(result.evidence)}`
-      );
+    result.evidence = evidence;
+    if (!live && side === 'control')
+      return missing(`missing error commit ${JSON.stringify(evidence)}`);
+    result.live = live;
+    if (!live) return result;
     await redaction({ client, targetId, failedURL, protectedOrigin, start, result, discovery });
     const beforeReload = (await frame()).loaderId;
     result.reload = (await outcome(client.send('Page.reload', {}, session))).ok;
@@ -227,14 +230,14 @@ export async function protectedErrorPage({
     failing = false;
     const { entries, currentIndex } = await reader.send('Page.getNavigationHistory', {}, observer);
     const index = entries.findIndex((e) => e.url === initial);
-    if (index < 0) throw new Error('protected-error-page: missing protected history');
+    if (index < 0) return missing('missing protected history');
     const beforeRestore = reader.events.length;
     await reader.send(
       'Runtime.evaluate',
       { expression: `setTimeout(() => history.go(${index - currentIndex}), 0)` },
       observer
     );
-    result.restored = await until(() =>
+    const restored = await until(() =>
       reader.events
         .slice(beforeRestore)
         .some(
@@ -245,8 +248,8 @@ export async function protectedErrorPage({
             e.params.frame.url === initial
         )
     );
-    if (!result.restored)
-      throw new Error('protected-error-page: real protected BFCache restore required');
+    if (!restored) return missing('real protected BFCache restore required');
+    result.restored = true;
     await pause(100);
     if (mode === 'sticky') {
       await reader.send('Target.detachFromTarget', { sessionId: observer });
@@ -260,11 +263,9 @@ export async function protectedErrorPage({
         observer
       );
       await reader.send('Page.navigate', { url: failedURL }, observer);
-      result.stickyError = await until(async () => (await frame()).unreachableUrl === failedURL);
-      if (!result.stickyError)
-        throw new Error(
-          `protected-error-page: missing sticky error ${JSON.stringify(await frame())}`
-        );
+      if (!(await until(async () => (await frame()).unreachableUrl === failedURL)))
+        return missing(`missing sticky error ${JSON.stringify(await frame())}`);
+      result.stickyError = true;
       await pause(100);
     }
     await lockChecks({ client, session, targetId, result });

package/redirect-secret.mjs

@@ -1,4 +1,4 @@
-import { load, outcome } from './guard-driver.mjs';
+import { load, outcome, waitFor } from './guard-driver.mjs';
 import { redirectFragments } from './redirect-fragments.mjs';
 
 const pause = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
@@ -47,28 +47,33 @@ const headersTextMatch = (text, to) =>
       )
   );
 
-export function containsSecret(value, marker) {
+export function containsSecret(value, marker, seen = new Map()) {
   const visit = (value, depth = 0) => {
     if (typeof value === 'string') {
-      if (value.includes(marker)) return true;
-      if (depth >= 8) return false;
-      const decoded = [];
-      try {
-        decoded.push(decodeURIComponent(value));
-      } catch {}
-      try {
-        decoded.push(JSON.parse(value));
-      } catch {}
-      try {
-        decoded.push(JSON.parse(`"${value}"`));
-      } catch {}
-      decoded.push(...decodedBase64(value));
-      return decoded.some((text) => text !== value && visit(text, depth + 1));
+      const key = `${depth}:${value}`;
+      if (!seen.has(key)) seen.set(key, text(value, depth));
+      return seen.get(key);
     }
     if (value && typeof value === 'object')
       return Object.values(value).some((v) => visit(v, depth));
     return false;
   };
+  const text = (value, depth) => {
+    if (value.includes(marker)) return true;
+    if (depth >= 8) return false;
+    const decoded = [];
+    try {
+      decoded.push(decodeURIComponent(value));
+    } catch {}
+    try {
+      decoded.push(JSON.parse(value));
+    } catch {}
+    try {
+      decoded.push(JSON.parse(`"${value}"`));
+    } catch {}
+    decoded.push(...decodedBase64(value));
+    return decoded.some((text) => text !== value && visit(text, depth + 1));
+  };
   return visit(value);
 }
 
@@ -85,6 +90,7 @@ class RedirectProbe {
     this.jobs = new Set();
     this.networkBodies = new Set();
     this.registrations = [];
+    this.seen = new Map();
     this.protectedURLs = [
       `https://seven.sliccy.ai/auth/callback?code=${encodeURIComponent(this.marker)}&state=${encodeURIComponent(this.marker)}`,
       `https://vault.sliccy.ai/oauth/mcp-callback?code=${encodeURIComponent(this.marker)}`,
@@ -158,7 +164,23 @@ class RedirectProbe {
     await load(this.reader, this.observer, `${this.ordinary}/doc?n=${this.tag}-${suffix}`);
   }
 
-  async setup() {
+  contains(value) {
+    return containsSecret(value, this.marker, this.seen);
+  }
+
+  async scan(items) {
+    const flags = [];
+    let slice = Date.now();
+    for (const item of items) {
+      flags.push(this.contains(item));
+      if (Date.now() - slice < 10) continue;
+      await pause(0);
+      slice = Date.now();
+    }
+    return flags;
+  }
+
+  async observe() {
     this.observer = (
       await this.reader.send('Target.attachToTarget', { targetId: this.targetId, flatten: true })
     ).sessionId;
@@ -176,6 +198,9 @@ class RedirectProbe {
         },
       ],
     });
+  }
+
+  async setup() {
     for (const domain of ['Page', 'Network', 'Runtime', 'Log', 'Audits'])
       await this.send(`${domain}.enable`);
     await this.send('Fetch.enable', {
@@ -249,9 +274,9 @@ class RedirectProbe {
       resourceContentAttempted: true,
       snapshotAttempted: true,
       domSnapshotAttempted: true,
-      ordinaryResource: containsSecret(resource, this.marker),
-      ordinarySnapshot: containsSecret(snapshot, this.marker),
-      ordinaryDOM: containsSecret(dom, this.marker),
+      ordinaryResource: this.contains(resource),
+      ordinarySnapshot: this.contains(snapshot),
+      ordinaryDOM: this.contains(dom),
     });
   }
 
@@ -262,9 +287,8 @@ class RedirectProbe {
     await this.send('Runtime.evaluate', {
       expression: `fetch(${JSON.stringify(this.holdURL)}).catch(()=>{});void 0`,
     });
-    const deadline = Date.now() + 5000;
-    while (!this.held && Date.now() < deadline) await pause(10);
-    if (!this.held) throw new Error('redirect body: Fetch override pause missing');
+    if (!(await waitFor(() => Boolean(this.held), 5000, 10)))
+      throw new Error('redirect body: Fetch override pause missing');
     const requestId = this.held.params.requestId;
     const out = await this.send('Fetch.continueRequest', { requestId, url });
     this.responses.push({
@@ -330,8 +354,8 @@ class RedirectProbe {
     const dom = await this.send('DOMSnapshot.captureSnapshot', { computedStyles: [] });
     this.responses.push({
       iframeSnapshotAttempted: true,
-      ordinaryIframeSnapshot: containsSecret(snapshot, this.marker),
-      ordinaryIframeDOM: containsSecret(dom, this.marker),
+      ordinaryIframeSnapshot: this.contains(snapshot),
+      ordinaryIframeDOM: this.contains(dom),
     });
   }
 
@@ -345,11 +369,13 @@ class RedirectProbe {
     });
     const events = this.client.events.slice(this.eventsStart);
     const messages = this.client.messages?.slice(this.messagesStart) ?? [];
+    const eventLeaks = await this.scan(events);
     const ordinaryEvents = events.filter(
-      (event) =>
-        containsSecret(event, this.marker) &&
-        JSON.stringify(event).includes(new URL(this.plainURL).host)
+      (event, index) =>
+        eventLeaks[index] && JSON.stringify(event).includes(new URL(this.plainURL).host)
     );
+    const replies = [...messages, ...this.responses];
+    const replyLeaks = await this.scan(replies);
     const extra = events.filter(
       (event) =>
         event.sessionId === this.session &&
@@ -377,14 +403,14 @@ class RedirectProbe {
         entry.url.includes(`/redirect-secret/${this.tag}`)
       ),
       rawRecorded: this.messagesStart !== undefined && messages.length > events.length,
-      leakChannels: [...messages, ...this.responses]
-        .filter((message) => containsSecret(message, this.marker))
+      leakChannels: replies
+        .filter((_, index) => replyLeaks[index])
         .map((message) =>
           typeof message === 'string'
             ? (JSON.parse(message).method ?? 'reply')
             : (message.method ?? 'reply')
         ),
-      secretHidden: !containsSecret([...messages, ...this.responses], this.marker),
+      secretHidden: !replyLeaks.includes(true),
       sessionSurvives: survives.ok && survives.result?.result?.value === 'doc',
       fetchBodyAttempted: attempted('Fetch.getResponseBody'),
       networkBodyAttempted: attempted('Network.getResponseBody'),
@@ -396,7 +422,7 @@ class RedirectProbe {
         events,
         replies: this.responses,
         protectedOrigins: this.protectedURLs.map((url) => new URL(url).origin),
-        contains: (value) => containsSecret(value, this.marker),
+        contains: (value) => this.contains(value),
       }),
       redirectLocation: ordinaryEvents.some(
         (event) =>
@@ -472,6 +498,11 @@ export async function redirectSecret(options) {
     throw new Error('redirectSecret fixture registration required');
   const probe = new RedirectProbe(options);
   try {
+    const observed = await outcome(probe.observe());
+    if (!observed.ok)
+      return {
+        incomplete: `redirect-secret: observer setup failed: ${observed.error.message}`,
+      };
     await probe.setup();
     if (options.mode === 'body') await probe.body();
     else await probe.headers();