@ai-devkit/agent-manager 0.9.0 → 0.11.0

package/src/__tests__/adapters/GeminiCliAdapter.test.ts

@@ -760,6 +760,139 @@ describe('GeminiCliAdapter', () => {
             expect(adapter.getConversation(sessionPath)).toEqual([]);
         });
     });
+
+    describe('listSessions', () => {
+        it('returns empty when ~/.gemini/tmp does not exist', async () => {
+            // tmpHome has no .gemini dir by default
+            const result = await adapter.listSessions();
+            expect(result).toEqual([]);
+        });
+
+        it('walks every shortId/chats dir and returns sessions', async () => {
+            writeSession(tmpHome, 'aaa', 'session-1', {
+                sessionId: 's-1',
+                projectHash: hashProjectRoot('/repo-a'),
+                startTime: '2025-01-01T00:00:00Z',
+                lastUpdated: '2025-01-01T00:01:00Z',
+                directories: ['/repo-a'],
+                messages: [
+                    { type: 'user', timestamp: '2025-01-01T00:00:00Z', content: [{ text: 'hello a' }] },
+                ],
+            });
+            writeSession(tmpHome, 'bbb', 'session-2', {
+                sessionId: 's-2',
+                projectHash: hashProjectRoot('/repo-b'),
+                startTime: '2025-01-02T00:00:00Z',
+                lastUpdated: '2025-01-02T00:01:00Z',
+                directories: ['/repo-b'],
+                messages: [
+                    { type: 'user', timestamp: '2025-01-02T00:00:00Z', content: [{ text: 'hello b' }] },
+                ],
+            });
+
+            const result = await adapter.listSessions();
+
+            expect(result).toHaveLength(2);
+            const byId = Object.fromEntries(result.map((r) => [r.sessionId, r]));
+            expect(byId['s-1']).toMatchObject({
+                type: 'gemini_cli',
+                cwd: '/repo-a',
+                firstUserMessage: 'hello a',
+            });
+            expect(byId['s-2']).toMatchObject({
+                type: 'gemini_cli',
+                cwd: '/repo-b',
+                firstUserMessage: 'hello b',
+            });
+        });
+
+        it('applies strict-equality cwd filter against directories[0]', async () => {
+            writeSession(tmpHome, 'aaa', 'session-keep', {
+                sessionId: 'keep',
+                projectHash: hashProjectRoot('/repo'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/repo'],
+                messages: [{ type: 'user', timestamp: '2025-01-01T00:00:00Z', content: 'yes' }],
+            });
+            writeSession(tmpHome, 'bbb', 'session-drop', {
+                sessionId: 'drop',
+                projectHash: hashProjectRoot('/other'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/other'],
+                messages: [{ type: 'user', timestamp: '2025-01-01T00:00:00Z', content: 'no' }],
+            });
+
+            const result = await adapter.listSessions({ cwd: '/repo' });
+
+            expect(result).toHaveLength(1);
+            expect(result[0].sessionId).toBe('keep');
+        });
+
+        it('skips malformed JSON files', async () => {
+            const chatsDir = path.join(tmpHome, '.gemini', 'tmp', 'aaa', 'chats');
+            fs.mkdirSync(chatsDir, { recursive: true });
+            fs.writeFileSync(path.join(chatsDir, 'session-bad.json'), '{ not json');
+            writeSession(tmpHome, 'aaa', 'session-good', {
+                sessionId: 'good',
+                projectHash: hashProjectRoot('/repo'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/repo'],
+                messages: [{ type: 'user', timestamp: '2025-01-01T00:00:00Z', content: 'ok' }],
+            });
+
+            const result = await adapter.listSessions();
+            expect(result).toHaveLength(1);
+            expect(result[0].sessionId).toBe('good');
+        });
+
+        it('skips files missing sessionId', async () => {
+            writeSession(tmpHome, 'aaa', 'session-no-id', {
+                projectHash: hashProjectRoot('/repo'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/repo'],
+                messages: [],
+            });
+
+            const result = await adapter.listSessions();
+            expect(result).toEqual([]);
+        });
+
+        it('captures the first user-typed message as firstUserMessage', async () => {
+            writeSession(tmpHome, 'aaa', 'session-x', {
+                sessionId: 's',
+                projectHash: hashProjectRoot('/repo'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/repo'],
+                messages: [
+                    { type: 'gemini', timestamp: '2025-01-01T00:00:00Z', content: 'preamble' },
+                    { type: 'user', timestamp: '2025-01-01T00:00:01Z', content: [{ text: 'first user' }] },
+                    { type: 'user', timestamp: '2025-01-01T00:00:02Z', content: 'second user' },
+                ],
+            });
+
+            const result = await adapter.listSessions({ cwd: '/repo' });
+
+            expect(result).toHaveLength(1);
+            expect(result[0].firstUserMessage).toBe('first user');
+        });
+
+        it('returns empty firstUserMessage when no user message exists', async () => {
+            writeSession(tmpHome, 'aaa', 'session-x', {
+                sessionId: 's',
+                projectHash: hashProjectRoot('/repo'),
+                startTime: '2025-01-01T00:00:00Z',
+                directories: ['/repo'],
+                messages: [
+                    { type: 'gemini', timestamp: '2025-01-01T00:00:00Z', content: 'agent only' },
+                ],
+            });
+
+            const result = await adapter.listSessions({ cwd: '/repo' });
+
+            expect(result).toHaveLength(1);
+            expect(result[0].firstUserMessage).toBe('');
+        });
+    });
 });
 
 /**

package/src/__tests__/utils/ClaudeSessionParser.test.ts

@@ -0,0 +1,195 @@
+/**
+ * Tests for utils/ClaudeSessionParser.ts — focused on stripping
+ * harness-injected XML tags from conversation content.
+ */
+
+import { describe, it, expect, beforeEach, afterEach } from '@jest/globals';
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
+import { ClaudeSessionParser } from '../../utils/ClaudeSessionParser';
+
+interface JsonlEntry {
+    type: 'user' | 'assistant' | 'system';
+    message: { content: string | Array<{ type: string; text?: string; content?: string; name?: string; input?: unknown; is_error?: boolean }> };
+    timestamp?: string;
+}
+
+function writeSession(entries: JsonlEntry[]): string {
+    const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'parser-test-'));
+    const filePath = path.join(dir, 'session.jsonl');
+    fs.writeFileSync(filePath, entries.map(e => JSON.stringify(e)).join('\n'));
+    return filePath;
+}
+
+describe('ClaudeSessionParser.getConversation — harness tag stripping', () => {
+    let parser: ClaudeSessionParser;
+    const tempFiles: string[] = [];
+
+    beforeEach(() => {
+        parser = new ClaudeSessionParser();
+    });
+
+    afterEach(() => {
+        for (const f of tempFiles) {
+            try {
+                fs.rmSync(path.dirname(f), { recursive: true, force: true });
+            } catch { /* best effort */ }
+        }
+        tempFiles.length = 0;
+    });
+
+    function makeSession(entries: JsonlEntry[]): string {
+        const f = writeSession(entries);
+        tempFiles.push(f);
+        return f;
+    }
+
+    it('strips <system-reminder> blocks from text content', () => {
+        const file = makeSession([
+            {
+                type: 'assistant',
+                message: {
+                    content: [{
+                        type: 'text',
+                        text: 'Real response here.\n<system-reminder>\nDo not mention this reminder.\n</system-reminder>\nMore response.',
+                    }],
+                },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv).toHaveLength(1);
+        expect(conv[0].content).toBe('Real response here.\n\nMore response.');
+    });
+
+    it('strips <local-command-stdout> blocks', () => {
+        const file = makeSession([
+            {
+                type: 'system',
+                message: { content: 'before <local-command-stdout>\nRunning...\nDone\n</local-command-stdout> after' },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('before  after');
+    });
+
+    it('strips <user-prompt-submit-hook> blocks', () => {
+        const file = makeSession([
+            {
+                type: 'user',
+                message: { content: '<user-prompt-submit-hook>hook output</user-prompt-submit-hook>\nactual question' },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('actual question');
+    });
+
+    it('strips bash and command stdout/stderr blocks', () => {
+        const file = makeSession([
+            {
+                type: 'assistant',
+                message: {
+                    content: [{
+                        type: 'text',
+                        text: 'Output:\n<bash-input>ls</bash-input>\n<bash-stdout>file.txt</bash-stdout>\n<bash-stderr></bash-stderr>\n<command-stdout>x</command-stdout>\n<command-stderr>y</command-stderr>\nEnd.',
+                    }],
+                },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('Output:\n\n\n\n\n\nEnd.'.replace(/\n{3,}/g, '\n\n'));
+        expect(conv[0].content).not.toMatch(/<bash-/);
+        expect(conv[0].content).not.toMatch(/<command-stdout>|<command-stderr>/);
+    });
+
+    it('collapses <command-name>/<command-args> into "/name args" shorthand', () => {
+        const file = makeSession([
+            {
+                type: 'user',
+                message: {
+                    content: '<command-message>debug</command-message>\n<command-name>/debug</command-name>\n<command-args>fix the bug</command-args>',
+                },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('/debug fix the bug');
+    });
+
+    it('handles <command-name> without <command-args>', () => {
+        const file = makeSession([
+            {
+                type: 'user',
+                message: {
+                    content: '<command-message>clear</command-message>\n<command-name>/clear</command-name>',
+                },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('/clear');
+    });
+
+    it('handles multiple harness tags mixed together', () => {
+        const file = makeSession([
+            {
+                type: 'user',
+                message: {
+                    content: [{
+                        type: 'text',
+                        text: '<system-reminder>ignore me</system-reminder>\n<command-message>build</command-message>\n<command-name>/build</command-name>\n<command-args>--watch</command-args>\n<local-command-stdout>build output here</local-command-stdout>',
+                    }],
+                },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('/build --watch');
+    });
+
+    it('leaves text without harness tags unchanged', () => {
+        const file = makeSession([
+            {
+                type: 'assistant',
+                message: { content: [{ type: 'text', text: 'Hello, world!' }] },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('Hello, world!');
+    });
+
+    it('drops a message that becomes empty after stripping', () => {
+        const file = makeSession([
+            {
+                type: 'system',
+                message: { content: '<system-reminder>only this</system-reminder>' },
+            },
+            {
+                type: 'assistant',
+                message: { content: [{ type: 'text', text: 'kept' }] },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv).toHaveLength(1);
+        expect(conv[0].content).toBe('kept');
+    });
+
+    it('strips tags spanning multiple lines', () => {
+        const multilineReminder = '<system-reminder>\nLine 1\nLine 2\nLine 3\n</system-reminder>';
+        const file = makeSession([
+            {
+                type: 'assistant',
+                message: { content: [{ type: 'text', text: `before\n${multilineReminder}\nafter` }] },
+            },
+        ]);
+
+        const conv = parser.getConversation(file);
+        expect(conv[0].content).toBe('before\n\nafter');
+    });
+});

package/src/__tests__/utils/process.test.ts

@@ -3,7 +3,7 @@
  */
 
 import { describe, it, expect, jest, beforeEach } from '@jest/globals';
-import { execSync } from 'child_process';
+import { execFileSync } from 'child_process';
 import {
     listAgentProcesses,
     batchGetProcessCwds,
@@ -12,18 +12,18 @@ import {
 } from '../../utils/process';
 
 jest.mock('child_process', () => ({
-    execSync: jest.fn(),
+    execFileSync: jest.fn(),
 }));
 
-const mockedExecSync = execSync as jest.MockedFunction<typeof execSync>;
+const mockedExecFileSync = execFileSync as jest.MockedFunction<typeof execFileSync>;
 
 describe('listAgentProcesses', () => {
     beforeEach(() => {
-        mockedExecSync.mockReset();
+        mockedExecFileSync.mockReset();
     });
 
     it('should parse ps aux | grep output and post-filter by executable name', () => {
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             'user  78070  1.0  0.5 485636016 245952 s018  S+   11:18PM   1:55.14 claude\n' +
             'user  55106  0.1  0.4 485620368  72496 s015  S+    9Mar26   8:06.36 claude\n',
         );
@@ -38,7 +38,7 @@ describe('listAgentProcesses', () => {
     });
 
     it('should filter out non-matching executables', () => {
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             'user  100  0.0  0.0 0 0 s001  S  1:00PM  0:00 claude\n' +
             'user  200  0.0  0.0 0 0 s002  S  1:00PM  0:00 claude-helper --pid 100\n' +
             'user  300  0.0  0.0 0 0 s003  S  1:00PM  0:00 /usr/bin/claude\n',
@@ -50,46 +50,46 @@ describe('listAgentProcesses', () => {
     });
 
     it('should return empty array on command failure', () => {
-        mockedExecSync.mockImplementation(() => { throw new Error('fail'); });
+        mockedExecFileSync.mockImplementation(() => { throw new Error('fail'); });
         expect(listAgentProcesses('claude')).toEqual([]);
     });
 
     it('should handle empty output', () => {
-        mockedExecSync.mockReturnValue('');
+        mockedExecFileSync.mockReturnValue('');
         expect(listAgentProcesses('claude')).toEqual([]);
     });
 
     it('should reject empty pattern', () => {
         expect(listAgentProcesses('')).toEqual([]);
-        expect(mockedExecSync).not.toHaveBeenCalled();
+        expect(mockedExecFileSync).not.toHaveBeenCalled();
     });
 
     it('should reject patterns with shell injection characters', () => {
         expect(listAgentProcesses('claude; rm -rf /')).toEqual([]);
         expect(listAgentProcesses("claude' || true")).toEqual([]);
         expect(listAgentProcesses('$(whoami)')).toEqual([]);
-        expect(mockedExecSync).not.toHaveBeenCalled();
+        expect(mockedExecFileSync).not.toHaveBeenCalled();
     });
 
     it('should accept valid patterns with dashes and underscores', () => {
-        mockedExecSync.mockReturnValue('');
+        mockedExecFileSync.mockReturnValue('');
         listAgentProcesses('claude-code');
-        expect(mockedExecSync).toHaveBeenCalled();
+        expect(mockedExecFileSync).toHaveBeenCalled();
 
-        mockedExecSync.mockReset();
-        mockedExecSync.mockReturnValue('');
+        mockedExecFileSync.mockReset();
+        mockedExecFileSync.mockReturnValue('');
         listAgentProcesses('my_agent');
-        expect(mockedExecSync).toHaveBeenCalled();
+        expect(mockedExecFileSync).toHaveBeenCalled();
     });
 });
 
 describe('batchGetProcessCwds', () => {
     beforeEach(() => {
-        mockedExecSync.mockReset();
+        mockedExecFileSync.mockReset();
     });
 
     it('should parse batched lsof output', () => {
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             'p78070\nn/Users/user/ai-devkit\np55106\nn/Users/user/other-project\n',
         );
 
@@ -104,7 +104,7 @@ describe('batchGetProcessCwds', () => {
 
     it('should return partial results when lsof succeeds for some PIDs', () => {
         // lsof might not return entries for dead processes
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             'p78070\nn/Users/user/ai-devkit\n',
         );
 
@@ -114,7 +114,7 @@ describe('batchGetProcessCwds', () => {
     });
 
     it('should return empty map on total failure', () => {
-        mockedExecSync.mockImplementation(() => { throw new Error('fail'); });
+        mockedExecFileSync.mockImplementation(() => { throw new Error('fail'); });
         const cwds = batchGetProcessCwds([78070]);
         // Falls through to pwdx fallback which also fails
         expect(cwds.size).toBe(0);
@@ -123,11 +123,11 @@ describe('batchGetProcessCwds', () => {
 
 describe('batchGetProcessStartTimes', () => {
     beforeEach(() => {
-        mockedExecSync.mockReset();
+        mockedExecFileSync.mockReset();
     });
 
     it('should parse ps lstart output', () => {
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             ' 78070 Wed Mar 18 23:18:01 2026\n' +
             ' 55106 Mon Mar  9 21:41:42 2026\n',
         );
@@ -143,7 +143,7 @@ describe('batchGetProcessStartTimes', () => {
     });
 
     it('should skip lines with unparseable dates', () => {
-        mockedExecSync.mockReturnValue(
+        mockedExecFileSync.mockReturnValue(
             ' 78070 Wed Mar 18 23:18:01 2026\n' +
             ' 99999 INVALID_DATE\n',
         );
@@ -154,20 +154,20 @@ describe('batchGetProcessStartTimes', () => {
     });
 
     it('should return empty map on failure', () => {
-        mockedExecSync.mockImplementation(() => { throw new Error('fail'); });
+        mockedExecFileSync.mockImplementation(() => { throw new Error('fail'); });
         expect(batchGetProcessStartTimes([78070])).toEqual(new Map());
     });
 });
 
 describe('enrichProcesses', () => {
     beforeEach(() => {
-        mockedExecSync.mockReset();
+        mockedExecFileSync.mockReset();
     });
 
     it('should populate cwd and startTime on processes', () => {
         // First call: batchGetProcessCwds (lsof)
         // Second call: batchGetProcessStartTimes (ps lstart)
-        mockedExecSync
+        mockedExecFileSync
             .mockReturnValueOnce('p100\nn/projects/app\n')
             .mockReturnValueOnce(' 100 Wed Mar 18 23:18:01 2026\n');
 
@@ -182,12 +182,12 @@ describe('enrichProcesses', () => {
 
     it('should return empty array for empty input', () => {
         expect(enrichProcesses([])).toEqual([]);
-        expect(mockedExecSync).not.toHaveBeenCalled();
+        expect(mockedExecFileSync).not.toHaveBeenCalled();
     });
 
     it('should handle partial failures', () => {
         // lsof succeeds, ps lstart fails
-        mockedExecSync
+        mockedExecFileSync
             .mockReturnValueOnce('p100\nn/projects/app\n')
             .mockImplementationOnce(() => { throw new Error('fail'); });