@ai-dev-methodologies/rlp-desk 0.15.6 → 0.16.0

package/CHANGELOG.md

@@ -11,6 +11,17 @@ For pre-v0.15.4 versions, refer to `git log` and individual GitHub release notes
 - Post-v0.15.6: remove `RLP_LIFECYCLE_METRICS` flag entirely (per plan v3 ADR follow-ups).
 - Phase D.1 (handoff documents) + Phase D.2 (per-stage agent role specialization) — both deferred per `docs/plans/v0.15.4-release-runbook.md` §7.6.
 
+## [0.16.0] — 2026-06-18
+
+Leader consolidation (ADR-001): `--mode tmux` is now the canonical production leader, self-verification works on it, and the deprecated `--mode agent` Node-CLI path is on a dated removal schedule.
+
+### Added
+- **Self-verification now works under `--mode tmux`.** `--with-self-verification` previously required the deprecated `--mode agent` path; the report is now generated by a pure-filesystem post-pass that runs after the zsh leader exits (reading the campaign's done-claim/verdict artifacts), so the canonical production path gets SV reports without the `claude --print` no-TTY hang.
+
+### Deprecated
+- **`node run.mjs run <slug> --mode agent` (Node-leader CLI alpha) is on a dated removal schedule** (ADR-001): 0.16.x louder banner → **0.17.0 hard-error** (and the Node-CLI default flips to `tmux`) → 0.18.0 dispatch branch removed. The `src/node/**` engine modules are retained throughout. Migrate direct-CLI wrappers to `--mode tmux` (canonical). This does NOT affect the slash command's `--mode native` default.
+- **The flywheel (`--flywheel` / `--flywheel-guard`) is deprecated.** It was only ever implemented in the deprecated `--mode agent` Node path (never in the canonical zsh leader, despite a stale comment that claimed otherwise). Its only output, the advisory `next_mission_candidate` field, has no shipped runnable consumer. It will not be ported to the canonical leader; use a consumer-side wrapper for multi-mission chaining.
+
 ## [0.15.6] — 2026-06-18
 
 Patch: CI/test integrity, a codex command-builder security fix, and documentation reconciliation.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ai-dev-methodologies/rlp-desk",
-  "version": "0.15.6",
+  "version": "0.16.0",
   "description": "Fresh-context iterative loops for Claude Code — autonomous task completion with independent verification",
   "scripts": {
     "postinstall": "node scripts/postinstall.js",

package/src/commands/rlp-desk.md

@@ -303,7 +303,7 @@ Legacy `--mode agent` typed against this slash command emits a deprecation notic
 
 #### Tmux Mode (`--mode tmux`)
 
-When `--mode tmux` is specified (v0.14.0+: `run.mjs` accepts the same flags as before but spawns `run_ralph_desk.zsh` as a subprocess and inherits stdio. Flywheel and self-verification flags are not honored under tmux mode — they currently require the deprecated Node-leader direct-CLI path `node run.mjs --mode agent` (see "Direct Node CLI invocation" below). Native Agent() port is a post-Node-leader-retirement task):
+When `--mode tmux` is specified (v0.14.0+: `run.mjs` accepts the same flags as before but spawns `run_ralph_desk.zsh` as a subprocess and inherits stdio. ARCH Wave C: `--with-self-verification` **is honored** under tmux mode via a Node post-pass that runs after the zsh leader exits (see §348). `--flywheel`/`--flywheel-guard` are deprecated (ADR-001) and remain unimplemented in the zsh leader):
 
 1. **Validate scaffold** — same as Agent() mode: check `.rlp-desk/prompts/<slug>.worker.prompt.md` etc.
 2. **Check sentinels** — same as Agent() mode.
@@ -345,7 +345,7 @@ node ~/.claude/ralph-desk/node/run.mjs run '<slug>' \
 - MUST launch with `run_in_background: true` so `/rlp-desk` returns control immediately while preserving live tmux visibility.
 - Run-in-background is used so the shell can keep the command visible and keep the pane layout stable for status checks and completion flow.
 - Do NOT kill panes after completion. Panes stay alive for inspection. User cleans up with `/rlp-desk clean <slug> --kill-session`.
-- v0.14.0: `--with-self-verification`, `--flywheel`, and `--flywheel-guard` are **not honored** under `--mode tmux` — the zsh runner has no SV/flywheel implementation. The Node leader emits a stderr WARNING listing the dropped flags. For SV/flywheel today, use the deprecated Node-leader direct-CLI path `node run.mjs --mode agent` (see "Direct Node CLI invocation" below). The slash command's Native Agent() (`--mode native`) does not yet implement SV/flywheel — port is a post-Node-leader-retirement task.
+- ARCH Wave C (ADR-001): `--with-self-verification` **is honored** under `--mode tmux`. The zsh leader cannot generate the SV report in-pane (`claude --print` hangs without a TTY — hence its `$TMUX` early-return), so `run.mjs` runs the **pure-filesystem** `generateSVReport` as a **post-pass after the zsh child exits**, reading the campaign's on-disk done-claim/verdict artifacts. `--flywheel` and `--flywheel-guard` are **deprecated** (ADR-001) and remain unimplemented in the zsh leader; the Node leader emits a stderr WARNING for those two only. The slash command's Native Agent() (`--mode native`) does not yet implement SV/flywheel.
 - **For `--mode tmux` only**: the slash command invokes `node ~/.claude/ralph-desk/node/run.mjs run --mode tmux ...`. Do NOT invoke `~/.claude/ralph-desk/run_ralph_desk.zsh` directly — the Node router resolves the runner path, runs legacy detection, and surfaces actionable errors when the runner is missing. **For `--mode native`**, the slash command does NOT invoke the Node CLI — it acts as the leader itself; see Native Agent() Mode section below.
 
 **tmux UX model (5 items):**
@@ -374,7 +374,17 @@ This contract MUST be observed in every iteration of the leader loop below. Futu
 
 #### Direct Node CLI invocation (`node run.mjs run <slug> --mode agent` — deprecated alpha)
 
-Direct invocation of `node ~/.claude/ralph-desk/node/run.mjs run <slug> --mode agent` is **the deprecated Node-leader alpha path**. This is unrelated to the slash command's Native Agent() path above — different code, different leader, different lifecycle. The Node leader currently retains SV/flywheel implementations not yet ported to Native Agent(). The Node CLI emits a deprecation banner on this mode and is scheduled for hard-error in the next major release. For production tmux orchestration, use `--mode tmux`. For Claude Code Native Agent() campaigns, use `/rlp-desk run <slug> --mode native` from a Claude Code session.
+Direct invocation of `node ~/.claude/ralph-desk/node/run.mjs run <slug> --mode agent` is **the deprecated Node-leader alpha path**. This is unrelated to the slash command's Native Agent() path above — different code, different leader, different lifecycle. The Node leader currently retains SV/flywheel implementations not yet ported to Native Agent(). For production tmux orchestration, use `--mode tmux` (the **canonical** leader). For Claude Code Native Agent() campaigns, use `/rlp-desk run <slug> --mode native` from a Claude Code session.
+
+**Deprecation schedule** (per [ADR-001](../../docs/plans/adr-001-leader-consolidation.md) §3 — applies to the Node-CLI `--mode agent` entry point ONLY; the `src/node/**` engine modules are retained throughout):
+
+| Version | Behavior of `node run.mjs run <slug> --mode agent` |
+|---------|-----------------------------------------------------|
+| 0.16.x  | runs, with a louder deprecation banner |
+| **0.17.0** | **hard-errors** (exit 2) with a redirect to `--mode tmux` / `--mode native`; the Node-CLI default also flips to `tmux` |
+| 0.18.0  | the `--mode agent` dispatch branch is removed (engine modules stay) |
+
+External wrappers calling `--mode agent` must migrate to `--mode tmux` by 0.17.0. This is a breaking CLI change for that entry point, announced in CHANGELOG at each step.
 
 ### Preparation
 1. Validate scaffold: `.rlp-desk/prompts/<slug>.worker.prompt.md` etc.

package/src/node/run.mjs

@@ -5,7 +5,7 @@ import { spawn, spawnSync } from 'node:child_process';
 import { fileURLToPath } from 'node:url';
 
 import { initCampaign } from './init/campaign-initializer.mjs';
-import { readStatus } from './reporting/campaign-reporting.mjs';
+import { readStatus, generateSVReport } from './reporting/campaign-reporting.mjs';
 import {
   run as runCampaignMain,
   detectLegacyDeskInRunMode,
@@ -318,6 +318,10 @@ function buildZshEnv(slug, options, parentEnv) {
     AUTONOMOUS_MODE: options.autonomous ? '1' : '0',
     LANE_MODE: options.laneStrict ? 'strict' : 'warn',
     TEST_DENSITY_MODE: options.testDensityStrict ? 'strict' : 'warn',
+    // ARCH Wave C-SV: forwarded for traceability only. The zsh leader keeps its
+    // $TMUX early-return (no in-pane `claude --print`); the SV report itself is
+    // produced by the Node post-pass in runTmuxViaZsh after the zsh child exits.
+    WITH_SELF_VERIFICATION: options.withSelfVerification ? '1' : '0',
   };
 }
 
@@ -360,23 +364,47 @@ async function runTmuxViaZsh(slug, options, deps) {
     return 1;
   }
 
-  // Surface flags the zsh runner cannot honor. Flywheel and self-verification
-  // remain Node-leader features, available only in --mode agent. Warn loudly
-  // instead of silent no-op so the operator understands the trade-off.
+  // Surface flags the zsh runner cannot honor. ARCH Wave C: --with-self-verification
+  // IS now honored in tmux mode via a post-zsh-return pass (see below) — only the
+  // flywheel flags remain unsupported here. Warn loudly instead of silent no-op.
   const unsupported = [];
   if (options.flywheel !== 'off') unsupported.push('--flywheel');
   if (options.flywheelGuard !== 'off') unsupported.push('--flywheel-guard');
-  if (options.withSelfVerification) unsupported.push('--with-self-verification');
   if (unsupported.length > 0) {
     write(
       deps.stderr,
-      `WARNING: ${unsupported.join(', ')} not honored in --mode tmux (zsh runner). Use --mode agent for those features.`,
+      `WARNING: ${unsupported.join(', ')} not honored in --mode tmux (zsh runner). Flywheel is deprecated (ADR-001) — use --mode agent if you still need it.`,
     );
   }
 
   const env = buildZshEnv(slug, options, process.env);
   const spawnZsh = deps.spawnZsh ?? defaultSpawnZsh;
-  return spawnZsh(zshPath, env, options.rootDir);
+  const exitCode = await spawnZsh(zshPath, env, options.rootDir);
+
+  // ARCH Wave C-SV: home self-verification onto --mode tmux. The zsh runner cannot
+  // produce the SV report itself (`claude --print` hangs without a TTY in a tmux
+  // pane — that is why lib_ralph_desk.zsh keeps its $TMUX early-return). Instead we
+  // run the Node PURE-FS generateSVReport as a post-pass AFTER the zsh child exits:
+  // real stdout, no pane, no TTY → no hang. It reads the campaign's on-disk
+  // iter-*-done-claim/verify-verdict artifacts the zsh leader already wrote.
+  if (options.withSelfVerification) {
+    try {
+      const paths = buildPaths(options.rootDir, slug);
+      const sv = await generateSVReport({
+        slug,
+        logsDir: paths.campaignLogDir,
+        prdFile: paths.prdFile,
+        testSpecFile: paths.testSpecFile,
+        analyticsFile: paths.analyticsFile,
+        outputDir: paths.analyticsDir,
+      });
+      write(deps.stdout, `\nSelf-verification report (tmux post-pass): ${sv.summary ?? 'generated'}`);
+    } catch (err) {
+      write(deps.stderr, `WARNING: self-verification post-pass failed: ${err.message}`);
+    }
+  }
+
+  return exitCode;
 }
 
 async function runRunCommand(args, deps) {
@@ -478,7 +506,7 @@ async function runRunCommand(args, deps) {
     // not a replacement. See docs/plans/v0.15-stabilization-plan.md.
     write(
       deps.stderr,
-      'SCHEDULED REMOVAL: --mode agent (Node CLI alpha) will be removed in a future major release. Date TBD until stabilization milestones complete.',
+      'SCHEDULED REMOVAL (ADR-001): --mode agent (Node CLI alpha) hard-errors in 0.17.0 (Node-CLI default flips to tmux) and the dispatch branch is removed in 0.18.0. Engine modules stay. Migrate to --mode tmux.',
     );
     write(
       deps.stderr,

package/src/scripts/run_ralph_desk.zsh

@@ -67,8 +67,12 @@ SV_SKIPPED_REASON=""                                         # set when SV is di
 # no-progress, stale-context, claude model upgrade chain, etc.), so the
 # Node leader is now reserved for `--mode agent` (LLM-driven) only.
 # `--mode tmux` invocations from src/node/run.mjs delegate here as a
-# subprocess via env vars. zsh continues to honor FLYWHEEL,
-# FLYWHEEL_GUARD, WITH_SELF_VERIFICATION.
+# subprocess via env vars. ARCH Wave C / ADR-001: FLYWHEEL and FLYWHEEL_GUARD
+# are NOT implemented in the zsh leader (no dispatch site) and are deprecated —
+# do NOT claim otherwise. WITH_SELF_VERIFICATION is forwarded for traceability,
+# but the SV report is produced by the Node post-pass in run.mjs runTmuxViaZsh
+# after this script exits (this script keeps its $TMUX early-return to avoid the
+# `claude --print` no-TTY hang).
 AUTONOMOUS_MODE="${AUTONOMOUS_MODE:-0}"    # 1=don't stop on ambiguity, PRD is authoritative
 # P1-E Lane enforcement: WARN-only by default; --lane-strict opts into BLOCKED
 # escalation. governance §7¾. The opt-in defaults to "warn"; "strict" trips