@ai-dev-methodologies/rlp-desk 0.15.4 → 0.15.5

package/CHANGELOG.md

@@ -11,7 +11,23 @@ For pre-v0.15.4 versions, refer to `git log` and individual GitHub release notes
 - Post-v0.15.6: remove `RLP_LIFECYCLE_METRICS` flag entirely (per plan v3 ADR follow-ups).
 - Phase D.1 (handoff documents) + Phase D.2 (per-stage agent role specialization) — both deferred per `docs/plans/v0.15.4-release-runbook.md` §7.6.
 
-## [0.15.4] — 2026-05-08 (pending release)
+## [0.15.5] — 2026-06-17
+
+Patch: fixes surfaced by a fresh-context live dogfood of the tmux and agent run modes, plus packaging hygiene.
+
+### Fixed
+- **Curl-install (`install.sh`) produced a Node leader that could not start.** `src/node/MANIFEST.txt` was missing three runtime modules, so a curl-installed `--mode agent` / Node leader threw `ERR_MODULE_NOT_FOUND` at startup. MANIFEST regenerated. (npm installs were unaffected.)
+- **Tmux-mode leader could hang at startup.** A bare `> "$COST_LOG"` redirect runs zsh's `$NULLCMD` (`cat`), which blocks reading stdin when launched with an open TTY (interactive shell / tmux pane). Changed to `: > "$COST_LOG"`.
+- **Worker sometimes printed the iteration signal instead of writing it.** The per-iteration prompt now explicitly instructs the worker to WRITE the verify signal to the iter-signal file (resolved path in tmux mode).
+- **Clearer error for mis-leveled PRD user-story headings.** When user stories use `###` instead of `## US-NNN` (H2), the Node leader now hints at the correct heading level instead of a bare "No user stories found".
+
+### Added
+- **`clean <slug> [--kill-session]` for the Node CLI.** Resets a campaign — removes sentinels, signal/claim/verdict files, and runtime state, while preserving the PRD, test-spec, prompts, memory, and reports. Previously unimplemented in the Node rewrite, which left a blocked campaign with no recovery path.
+
+### Changed
+- **Smaller published package.** The tarball no longer ships internal research docs, dev planning handoffs, or example runtime state (73 → 53 files, ~364 → ~244 kB).
+
+## [0.15.4] — 2026-05-08
 
 Phase B: tmux/process lifecycle hardening + observability + real-LLM SV strengthening. 4 sequential PRs (B1, B2-FIX, B4, B3) merged to main, plus pre-release audit fix branch addressing 16 findings (3 CRITICAL, 6 HIGH, 5 MEDIUM, 2 LOW).
 

package/package.json

@@ -1,10 +1,12 @@
 {
   "name": "@ai-dev-methodologies/rlp-desk",
-  "version": "0.15.4",
+  "version": "0.15.5",
   "description": "Fresh-context iterative loops for Claude Code — autonomous task completion with independent verification",
   "scripts": {
     "postinstall": "node scripts/postinstall.js",
     "uninstall": "node scripts/uninstall.js",
+    "manifest:check": "node scripts/build-node-manifest.js --check",
+    "prepublishOnly": "node scripts/build-node-manifest.js --check",
     "test:node": "node --test 'tests/node/*.mjs' 'tests/node/*.test.mjs'",
     "test:zsh": "for f in tests/test_*.sh; do echo \"=== $f ===\"; zsh \"$f\" || exit 1; done",
     "test:fast": "npm run test:node",
@@ -19,8 +21,12 @@
     "src/governance.md",
     "src/model-upgrade-table.md",
     "scripts/",
-    "docs/rlp-desk/",
-    "examples/",
+    "docs/rlp-desk/*.md",
+    "docs/rlp-desk/blueprints/",
+    "examples/calculator/.claude/ralph-desk/context/",
+    "examples/calculator/.claude/ralph-desk/memos/",
+    "examples/calculator/.claude/ralph-desk/plans/",
+    "examples/calculator/.claude/ralph-desk/prompts/",
     "install.sh",
     "README.md",
     "CHANGELOG.md",

package/src/node/MANIFEST.txt

@@ -7,9 +7,12 @@ reporting/campaign-reporting.mjs
 run.mjs
 runner/campaign-main-loop.mjs
 runner/leader-registry.mjs
+runner/prompt-detector.mjs
 runner/prompt-dismisser.mjs
 shared/fs.mjs
 shared/paths.mjs
 tmux/pane-manager.mjs
 util/debug-log.mjs
+util/desk-root.mjs
+util/lifecycle-metrics.mjs
 util/shell-quote.mjs

package/src/node/prompts/prompt-assembler.mjs

@@ -150,8 +150,8 @@ export async function assembleWorkerPrompt({
       } else {
         promptLines.push(`- **Test Spec**: Read \`${fullTestSpecPath}\` (full — find ${nextUs} section)`);
       }
-      promptLines.push(`When done, signal verify with us_id="${nextUs}" (not "ALL").`);
-      promptLines.push(`Signal format: {"iteration": N, "status": "verify", "us_id": "${nextUs}", ...}`);
+      promptLines.push(`When done, you MUST WRITE (not just print) the verify signal to the iter-signal FILE — Path: \`memos/<slug>-iter-signal.json\` (see the MANDATORY signal-file instruction in the base prompt).`);
+      promptLines.push(`Write this exact JSON to that file (us_id="${nextUs}", not "ALL"): {"iteration": N, "status": "verify", "us_id": "${nextUs}", "summary": "what was done", "timestamp": "ISO"}`);
       promptLines.push('');
       promptLines.push(`**Update the campaign memory's 'Next Iteration Contract' to reflect ${nextUs}.**`);
     } else if (verifiedUs.length > 0) {

package/src/node/run.mjs

@@ -1,7 +1,7 @@
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
-import { spawn } from 'node:child_process';
+import { spawn, spawnSync } from 'node:child_process';
 import { fileURLToPath } from 'node:url';
 
 import { initCampaign } from './init/campaign-initializer.mjs';
@@ -9,6 +9,7 @@ import { readStatus } from './reporting/campaign-reporting.mjs';
 import {
   run as runCampaignMain,
   detectLegacyDeskInRunMode,
+  buildPaths,
 } from './runner/campaign-main-loop.mjs';
 import { isClaudeEngine } from './cli/command-builder.mjs';
 
@@ -51,7 +52,7 @@ function buildHelpText() {
     '  run <slug> [options]         Run loop (tmux=zsh leader [production], agent=Node leader [deprecated alpha], native=slash-only error)',
     '  status <slug>                Show loop status',
     '  logs <slug> [N]              Show iteration log (not implemented in the Node rewrite yet)',
-    '  clean <slug> [--kill-session] Reset for re-run (not implemented in the Node rewrite yet)',
+    '  clean <slug> [--kill-session] Reset for re-run (removes sentinels + runtime/; preserves PRD/prompts/memory)',
     '  resume <slug>                Resume loop (not implemented in the Node rewrite yet)',
     '',
     'Run Options:',
@@ -217,6 +218,71 @@ async function runStatusCommand(args, deps) {
   return 0;
 }
 
+// D-6 (dogfood): real `clean` for the Node leader. Previously "not implemented",
+// which left a blocked campaign with NO recovery path (a transient parse error
+// wrote a blocked sentinel that bricked re-runs). Removes the transient/terminal
+// state (sentinels, signal/claim/verdict, runtime/) while PRESERVING the durable
+// inputs (PRD, test-spec, prompts, context, memory) and the campaign report.
+async function runCleanCommand(args, deps) {
+  if (args.length === 0 || args[0] === '--help') {
+    write(deps.stdout, 'Usage: node src/node/run.mjs clean <slug> [--kill-session]');
+    return 0;
+  }
+  const slug = args[0];
+  const killSession = args.includes('--kill-session');
+  const paths = buildPaths(deps.cwd, slug);
+
+  // --kill-session: read the session name from runtime/session-config.json
+  // BEFORE removing runtime, then best-effort tmux teardown.
+  if (killSession) {
+    try {
+      const cfgPath = path.join(paths.runtimeDir, 'session-config.json');
+      if (deps.fileExists(cfgPath)) {
+        const cfg = JSON.parse(fs.readFileSync(cfgPath, 'utf8'));
+        if (cfg && cfg.session_name) {
+          spawnSync('tmux', ['kill-session', '-t', cfg.session_name], { stdio: 'ignore' });
+        }
+      }
+    } catch { /* best-effort */ }
+  }
+
+  const transient = [
+    paths.blockedSentinel,
+    paths.blockedSentinel.replace(/\.md$/, '.json'),
+    paths.completeSentinel,
+    paths.completeSentinel.replace(/\.md$/, '.json'),
+    paths.signalFile,
+    paths.doneClaimFile,
+    paths.verdictFile,
+    paths.flywheelSignalFile,
+    paths.flywheelGuardVerdictFile,
+  ];
+  let removed = 0;
+  for (const target of transient) {
+    try {
+      if (fs.existsSync(target)) {
+        // Sentinels may be chmod 0o444 (write-lock); relax before unlink.
+        try { fs.chmodSync(target, 0o644); } catch { /* ignore */ }
+        fs.rmSync(target, { force: true });
+        removed += 1;
+      }
+    } catch { /* best-effort per-file */ }
+  }
+  try {
+    if (fs.existsSync(paths.runtimeDir)) {
+      fs.rmSync(paths.runtimeDir, { recursive: true, force: true });
+      removed += 1;
+    }
+  } catch { /* best-effort */ }
+
+  write(
+    deps.stdout,
+    `Cleaned ${slug}: removed ${removed} transient artifact(s) (sentinels, signal/claim/verdict, runtime/`
+      + `${killSession ? ', tmux session' : ''}). Preserved PRD, test-spec, prompts, context, memory, reports.`,
+  );
+  return 0;
+}
+
 // v0.14.0: Default location of the zsh runner installed by postinstall.js
 // (Phase 3 of the v0.14.0 plan re-enables this sync). Overridable via
 // RLP_DESK_ZSH_RUNNER for development checkouts that point to src/scripts.
@@ -466,9 +532,10 @@ export async function main(argv = process.argv.slice(2), overrides = {}) {
         return await runRunCommand(rest, deps);
       case 'status':
         return await runStatusCommand(rest, deps);
+      case 'clean':
+        return await runCleanCommand(rest, deps);
       case 'brainstorm':
       case 'logs':
-      case 'clean':
       case 'resume':
         throw new Error(`${command} is not implemented in the Node rewrite yet`);
       default:

package/src/node/runner/campaign-main-loop.mjs

@@ -93,7 +93,7 @@ export function detectLegacyDeskInRunMode(rootDir, env = process.env) {
   return { legacyPath, newPath, message };
 }
 
-function buildPaths(rootDir, slug, env = process.env) {
+export function buildPaths(rootDir, slug, env = process.env) {
   const deskRoot = resolveDeskRoot(rootDir, env);
   const campaignLogDir = path.join(deskRoot, 'logs', slug);
 
@@ -1462,7 +1462,18 @@ async function _runCampaignBody(slug, options, paths, rootDir) {
   const usList = await readUsList(paths, slug);
 
   if (usList.length === 0) {
-    throw new Error(`No user stories found for ${slug}`);
+    // D-5 (dogfood): both leaders parse only H2 `## US-NNN:`. A common mistake is
+    // authoring `### US-NNN` (H3+), which yields zero stories. Surface an actionable
+    // hint instead of a bare "not found" (the zsh leader silently degrades here;
+    // Node fail-closes — the safer behavior, now recoverable via `clean`).
+    let hint = '';
+    try {
+      const prdRaw = await fs.readFile(paths.prdFile, 'utf8');
+      if (/^#{3,}\s+US-\d{3}\b/m.test(prdRaw)) {
+        hint = ' — found US-NNN heading(s) at level ### or deeper; US headings must be H2 ("## US-NNN:")';
+      }
+    } catch { /* best-effort hint */ }
+    throw new Error(`No user stories found for ${slug}${hint}`);
   }
 
   if (!state.current_us) {

package/src/scripts/run_ralph_desk.zsh

@@ -929,7 +929,9 @@ create_session() {
   BASELINE_COMMIT=$(git -C "$ROOT" rev-parse HEAD 2>/dev/null || echo "none")
 
   # Truncate cost-log for fresh run (previous data in versioned campaign reports)
-  > "$COST_LOG"
+  # NOTE: ': >' not bare '>' — in zsh a bare redirect with no command runs $NULLCMD
+  # (=cat), which blocks reading stdin when the leader has an open TTY (D-1 dogfood hang).
+  : > "$COST_LOG"
 
   # v5.7 §4.2: WITH_SELF_VERIFICATION=1 is hard-rejected at script entry now,
   # so by the time we reach create_session() the flag is guaranteed to be 0.
@@ -1853,8 +1855,8 @@ write_worker_trigger() {
         else
           echo "- **Test Spec**: Read \`$DESK/plans/test-spec-${SLUG}.md\` (full — find ${next_us} section)"
         fi
-        echo "When done, signal verify with us_id=\"${next_us}\" (not \"ALL\")."
-        echo "Signal format: {\"iteration\": N, \"status\": \"verify\", \"us_id\": \"${next_us}\", ...}"
+        echo "When done, you MUST WRITE (not just print) the verify signal to the iter-signal FILE at: ${SIGNAL_FILE}"
+        echo "Write this exact JSON to that file (us_id=\"${next_us}\", not \"ALL\"): {\"iteration\": N, \"status\": \"verify\", \"us_id\": \"${next_us}\", \"summary\": \"what was done\", \"timestamp\": \"ISO\"}"
         echo ""
         echo "**Update the campaign memory's 'Next Iteration Contract' to reflect ${next_us}.**"
       elif [[ -n "$VERIFIED_US" ]]; then