@ai-content-space/loopx 0.2.1 → 0.2.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (36) hide show
  1. package/package.json +1 -1
  2. package/plugins/loopx/.codex-plugin/plugin.json +1 -1
  3. package/plugins/loopx/skills/clarify/SKILL.md +1 -1
  4. package/plugins/loopx/skills/debug/SKILL.md +1 -1
  5. package/plugins/loopx/skills/exec/SKILL.md +1 -1
  6. package/plugins/loopx/skills/final-review/SKILL.md +89 -0
  7. package/plugins/loopx/skills/final-review/final-reviewer.md +135 -0
  8. package/plugins/loopx/skills/finish/SKILL.md +8 -1
  9. package/plugins/loopx/skills/fix-review/SKILL.md +1 -1
  10. package/plugins/loopx/skills/go-style/SKILL.md +1 -1
  11. package/plugins/loopx/skills/kratos/SKILL.md +7 -1
  12. package/plugins/loopx/skills/plan/SKILL.md +1 -1
  13. package/plugins/loopx/skills/refactor-plan/SKILL.md +1 -1
  14. package/plugins/loopx/skills/review/SKILL.md +1 -1
  15. package/plugins/loopx/skills/spec/SKILL.md +1 -1
  16. package/plugins/loopx/skills/subagent-exec/SKILL.md +7 -6
  17. package/plugins/loopx/skills/tdd/SKILL.md +1 -1
  18. package/plugins/loopx/skills/verify/SKILL.md +1 -1
  19. package/skills/RESOLVER.md +7 -4
  20. package/skills/clarify/SKILL.md +1 -1
  21. package/skills/debug/SKILL.md +1 -1
  22. package/skills/exec/SKILL.md +1 -1
  23. package/skills/final-review/SKILL.md +89 -0
  24. package/skills/final-review/final-reviewer.md +135 -0
  25. package/skills/finish/SKILL.md +8 -1
  26. package/skills/fix-review/SKILL.md +1 -1
  27. package/skills/go-style/SKILL.md +1 -1
  28. package/skills/kratos/SKILL.md +7 -1
  29. package/skills/plan/SKILL.md +1 -1
  30. package/skills/refactor-plan/SKILL.md +1 -1
  31. package/skills/review/SKILL.md +1 -1
  32. package/skills/spec/SKILL.md +1 -1
  33. package/skills/subagent-exec/SKILL.md +7 -6
  34. package/skills/tdd/SKILL.md +1 -1
  35. package/skills/verify/SKILL.md +1 -1
  36. package/src/install-discovery.mjs +1 -0
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "@ai-content-space/loopx",
3
3
  "type": "module",
4
- "version": "0.2.1",
4
+ "version": "0.2.2",
5
5
  "description": "Skill-first workflow suite for agentic coding assistants",
6
6
  "repository": {
7
7
  "type": "git",
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "loopx",
3
- "version": "0.2.1",
3
+ "version": "0.2.2",
4
4
  "description": "Skill-first workflow suite for agentic coding assistants",
5
5
  "skills": "./skills/",
6
6
  "interface": {
@@ -3,7 +3,7 @@ name: clarify
3
3
  description: "Grills ambiguous loopx work until material questions are answered, then routes to spec or plan using a design gate. Not for clear implementation tasks, approved specs, or code changes."
4
4
  when_to_use: "clarify, requirements, ambiguous request, unclear scope, non-goals, decision boundaries, acceptance criteria, 需求澄清, 范围不清"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # loopx Clarify
@@ -3,7 +3,7 @@ name: debug
3
3
  description: "Finds root cause for bugs, failing tests, build failures, regressions, and unexpected behavior before fixes. Not for new feature planning or routine code review."
4
4
  when_to_use: "debug, bug, test failure, build failure, regression, unexpected behavior, root cause, 报错, 失败, 回归, 排查"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Systematic Debugging
@@ -3,7 +3,7 @@ name: exec
3
3
  description: "Executes a written loopx implementation plan sequentially with review checkpoints. Not for unclear plans, missing requirements, or subagent-first execution."
4
4
  when_to_use: "written implementation plan, inline execution, sequential plan execution, review checkpoints, no subagent lane"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Exec
@@ -0,0 +1,89 @@
1
+ ---
2
+ name: final-review
3
+ description: "Performs whole-feature review after implementation and staged task review. Not for per-task review, unresolved scope, implementation, or pure documentation polish."
4
+ when_to_use: "final-review, final code review, whole feature review, integration review, pre-finish review, after subagent-exec, runtime risk review, 最终评审"
5
+ metadata:
6
+ version: "0.2.2"
7
+ ---
8
+
9
+ # Final Review
10
+
11
+ Run the final whole-feature review after implementation is complete and before `finish`.
12
+
13
+ **Core principle:** Per-task review catches local issues. Final review hunts integration and runtime risk across the complete feature.
14
+
15
+ **Announce at start:** "I'm using the final-review skill to review the completed feature."
16
+
17
+ ## When to Use
18
+
19
+ Use this after:
20
+ - `subagent-exec` completed all planned tasks and per-task reviews
21
+ - `exec` completed a full plan with verification checkpoints
22
+ - ad-hoc implementation is complete and ready for final risk review
23
+
24
+ Do not use this for:
25
+ - reviewing one task or one small checkpoint (`review` is for that)
26
+ - fixing review feedback (`fix-review` is for that)
27
+ - polishing documentation wording
28
+ - incomplete implementation or failing verification
29
+
30
+ ## Required Inputs
31
+
32
+ Before dispatching the reviewer, collect:
33
+ - Full feature git range: base SHA before implementation, head SHA now
34
+ - Source requirements: spec, plan, issue, PRD, or accepted task brief
35
+ - Implementation summary: what changed and why
36
+ - Verification evidence: commands run and results
37
+ - Per-task review artifacts, if available
38
+
39
+ If the git range or requirements are unclear, stop and ask. A final review without a concrete scope is not useful.
40
+
41
+ ## Review Priority
42
+
43
+ The reviewer must prioritize findings in this order:
44
+
45
+ 1. Runtime bugs, data loss, broken CLI behavior, state corruption
46
+ 2. Cross-task integration bugs
47
+ 3. Missing edge cases not covered by tests
48
+ 4. Test quality problems
49
+ 5. Architecture and maintainability issues
50
+ 6. Documentation defects that can mislead users or maintainers, omit required operational facts, or contradict actual behavior
51
+
52
+ Do not report pure documentation polish, style preferences, or wording tweaks. Do report documentation problems that create wrong usage, wrong maintenance decisions, missing required commands, missing migration notes, or false claims.
53
+
54
+ ## Dispatch
55
+
56
+ Use the platform's native subagent mechanism when available and fill template at `final-reviewer.md`.
57
+
58
+ **Placeholders:**
59
+ - `{DESCRIPTION}` - concise summary of the completed feature
60
+ - `{REQUIREMENTS}` - source requirements or plan/spec excerpts
61
+ - `{VERIFICATION}` - test commands and results
62
+ - `{PER_TASK_REVIEWS}` - review artifacts or "not available"
63
+ - `{BASE_SHA}` - commit before implementation began
64
+ - `{HEAD_SHA}` - current commit
65
+
66
+ ## Handle Feedback
67
+
68
+ - Critical and Important findings must be handled before `finish`
69
+ - Use `fix-review` for received feedback
70
+ - Push back only with code, test, or requirement evidence
71
+ - After fixes, run verification again and repeat final review if the fix changed integration behavior
72
+
73
+ ## Common Mistakes
74
+
75
+ **Running normal review again**
76
+ - Problem: reviewer repeats per-task or documentation comments
77
+ - Fix: use `final-reviewer.md`, which focuses on whole-feature runtime risk
78
+
79
+ **Letting docs hide real risk**
80
+ - Problem: "docs only" findings are ignored even when users would be misled
81
+ - Fix: distinguish pure polish from operationally incorrect or missing documentation
82
+
83
+ **Reviewing without base/head SHAs**
84
+ - Problem: reviewer sees an unclear or stale diff
85
+ - Fix: provide an exact git range every time
86
+
87
+ **Skipping verification evidence**
88
+ - Problem: reviewer cannot judge whether tests prove real behavior
89
+ - Fix: include exact commands and pass/fail output summary
@@ -0,0 +1,135 @@
1
+ # Final Reviewer Prompt Template
2
+
3
+ Use this template when dispatching a final-review subagent.
4
+
5
+ **Purpose:** Review the complete feature for integration and runtime risk after task-level implementation and review are already done.
6
+
7
+ ```
8
+ Native subagent:
9
+ description: "Final review completed feature"
10
+ prompt: |
11
+ You are a Senior Final Reviewer. Task-level implementation and review have
12
+ already happened. Your job is not to repeat per-task review. Your job is to
13
+ find whole-feature risks that can still break users, corrupt state, lose
14
+ data, or leave important behavior untested.
15
+
16
+ ## What Was Implemented
17
+
18
+ {DESCRIPTION}
19
+
20
+ ## Requirements / Plan / Spec
21
+
22
+ {REQUIREMENTS}
23
+
24
+ ## Verification Evidence
25
+
26
+ {VERIFICATION}
27
+
28
+ ## Per-Task Reviews
29
+
30
+ {PER_TASK_REVIEWS}
31
+
32
+ ## Full Feature Git Range
33
+
34
+ **Base:** {BASE_SHA}
35
+ **Head:** {HEAD_SHA}
36
+
37
+ ```bash
38
+ git diff --stat {BASE_SHA}..{HEAD_SHA}
39
+ git diff {BASE_SHA}..{HEAD_SHA}
40
+ ```
41
+
42
+ ## Review Priority
43
+
44
+ Review in this exact priority order:
45
+
46
+ 1. Runtime bugs, data loss, broken CLI behavior, state corruption
47
+ 2. Cross-task integration bugs
48
+ 3. Missing edge cases not covered by tests
49
+ 4. Test quality problems
50
+ 5. Architecture and maintainability issues
51
+ 6. Documentation defects that can mislead users or maintainers, omit
52
+ required operational facts, or contradict actual behavior
53
+
54
+ Do not report pure documentation polish, style preferences, or wording
55
+ tweaks. Do report documentation problems that create wrong usage, wrong
56
+ maintenance decisions, missing required commands, missing migration notes,
57
+ or false claims.
58
+
59
+ ## What to Check
60
+
61
+ **Runtime and state risk:**
62
+ - Can any command crash, hang, silently no-op, or report success incorrectly?
63
+ - Can repeated runs corrupt files, state, locks, indexes, caches, or config?
64
+ - Can user data, generated artifacts, branches, or worktrees be lost?
65
+ - Are filesystem, process, permission, platform, and concurrency errors handled?
66
+
67
+ **Integration risk:**
68
+ - Do task outputs match later task inputs?
69
+ - Do CLI flags, exported functions, filenames, state keys, and schemas align?
70
+ - Does the feature work as a complete workflow, not just as isolated pieces?
71
+ - Are old data, missing files, and partially completed states handled?
72
+
73
+ **Tests:**
74
+ - Do tests execute real behavior rather than only mocks or snapshots?
75
+ - Are failure paths, edge cases, repeat runs, and integration paths covered?
76
+ - Are the verification commands sufficient for the changed surface area?
77
+
78
+ **Architecture:**
79
+ - Is the implementation maintainable within existing module boundaries?
80
+ - Did the feature add avoidable coupling or hidden global state?
81
+ - Are abstractions justified by actual complexity?
82
+
83
+ **Documentation defects:**
84
+ - Does documentation contradict actual behavior?
85
+ - Are required user or maintainer steps missing?
86
+ - Would a future agent follow the docs and make the wrong change?
87
+
88
+ ## Output Format
89
+
90
+ ### Findings
91
+
92
+ #### Critical
93
+ [Must fix before finish: data loss, state corruption, broken workflow,
94
+ security issue, or reliable runtime failure]
95
+
96
+ #### Important
97
+ [Should fix before finish: integration bug, untested edge case, weak test
98
+ proving too little, misleading docs that affect usage or maintenance]
99
+
100
+ #### Minor
101
+ [Low-risk maintainability or clarity issues. No pure polish.]
102
+
103
+ For each finding:
104
+ - File:line reference
105
+ - What is wrong
106
+ - Why it matters
107
+ - How to fix or what evidence would resolve it
108
+
109
+ ### Coverage Notes
110
+ [Briefly state which runtime paths and tests you inspected.]
111
+
112
+ ### Assessment
113
+
114
+ **Ready for finish?** [Yes | No | With fixes]
115
+
116
+ **Reasoning:** [1-2 sentence risk-based assessment]
117
+
118
+ ## Critical Rules
119
+
120
+ **DO:**
121
+ - Read the actual diff, not only reports
122
+ - Focus on complete workflow behavior
123
+ - Treat tests as evidence to audit, not proof to trust blindly
124
+ - Report documentation defects that can mislead or omit required facts
125
+ - Give file:line references
126
+
127
+ **DON'T:**
128
+ - Repeat task-level nits unless they create whole-feature risk
129
+ - Report pure documentation polish
130
+ - Assume per-task reviews caught integration bugs
131
+ - Give a vague "looks good"
132
+ - Avoid a clear verdict
133
+ ```
134
+
135
+ **Reviewer returns:** Findings by severity, Coverage Notes, Assessment.
@@ -3,7 +3,7 @@ name: finish
3
3
  description: "Finishes completed loopx development work after tests pass by presenting merge, PR, keep, or discard options. Not for unfinished work or failing verification."
4
4
  when_to_use: "implementation complete, tests pass, finish branch, create pull request, merge locally, keep branch, discard work"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Finish
@@ -78,6 +78,13 @@ Allowed inputs:
78
78
  - existing `.loopx/memory/MEMORY.md` and `.loopx/memory/index.jsonl`
79
79
  - existing `docs/loopx/specs/*.md`
80
80
 
81
+ Learning extraction priority:
82
+ 1. Durable behavior, contracts, or constraints proven by the implementation
83
+ 2. State, file, CLI, API, install, migration, compatibility, or test invariants
84
+ 3. Explicit user decisions that constrain future work
85
+ 4. Review findings or fixes that reveal a reusable pitfall, pattern, or boundary
86
+ 5. Documentation changes when they define, correct, or preserve one of the above
87
+
81
88
  Do not infer durable rules from agent intuition alone. Do not promote unverified implementation details.
82
89
 
83
90
  #### Memory
@@ -3,7 +3,7 @@ name: fix-review
3
3
  description: "Handles received code review feedback with verification, technical evaluation, pushback, and one-item-at-a-time fixes. Not for requesting a new review or implementing unrelated changes."
4
4
  when_to_use: "fix-review, received code review feedback, review comments, reviewer suggestions, requested changes, 处理评审意见"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Fix Review
@@ -3,7 +3,7 @@ name: go-style
3
3
  description: "Applies loopx Go coding style for .go edits, tests, errors, context, naming, and interface boundaries. Not for non-Go code or Kratos-specific architecture by itself."
4
4
  when_to_use: "go-style, Go, golang, .go files, go tests, gofmt, idiomatic Go, Go style, Go 代码"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Go Style
@@ -3,7 +3,7 @@ name: kratos
3
3
  description: "Supports Go-Kratos microservices, proto/buf APIs, service/biz/data layers, middleware, auth, config, and troubleshooting. Not for generic Go style alone."
4
4
  when_to_use: "kratos, Go-Kratos, proto, buf, service layer, biz layer, data layer, middleware, auth, config, Kratos 微服务"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Kratos
@@ -56,6 +56,12 @@ Use only the reference file needed for the current task:
56
56
  - Use validation annotations when the project already uses `buf.validate` or `protovalidate`.
57
57
  - Regenerate code with the repository's existing command, such as `buf generate`, `make api`, or project scripts.
58
58
 
59
+ ## Database DDL
60
+
61
+ - MySQL `CREATE TABLE` statements must include a table-level `COMMENT`.
62
+ - MySQL column definitions in `CREATE TABLE` or `ALTER TABLE ... ADD COLUMN` statements must include column-level `COMMENT`.
63
+ - When using Ent schema for MySQL tables, add `.Comment(...)` to fields that are persisted as columns.
64
+
59
65
  ## Integration With Other loopx Skills
60
66
 
61
67
  - Use `go-style` for handwritten `.go` edits.
@@ -3,7 +3,7 @@ name: plan
3
3
  description: "Creates bite-sized implementation plans from approved requirements, clarify output, or design specs with exact files, tests, commands, expected output, and execution handoff. Not for unresolved requirements, design decisions, PRD generation, or code changes."
4
4
  when_to_use: "plan, implementation plan, execution plan, task breakdown, approved requirements, approved design spec, docs/loopx/design, 实施计划, 执行计划, 任务拆分"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  argument-hint: "<design spec path or feature name>"
8
8
  ---
9
9
 
@@ -3,7 +3,7 @@ name: refactor-plan
3
3
  description: "Creates a behavior-preserving refactor plan with user interview, repo evidence, tiny commits, scope boundaries, and testing decisions. Not for feature changes or immediate implementation."
4
4
  when_to_use: "refactor-plan, refactor request, refactoring RFC, tiny commits, behavior-preserving cleanup, architecture cleanup, 重构计划"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  This skill will be invoked when the user wants to create a refactor request. You should go through the steps below. You may skip steps if you don't consider them necessary.
@@ -3,7 +3,7 @@ name: review
3
3
  description: "Dispatches a loopx code reviewer subagent against a concrete git range and requirements. Not for implementation, planning, or unresolved review scope."
4
4
  when_to_use: "request code review, completed task review, major feature review, pre-merge review, subagent code quality check"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Review
@@ -3,7 +3,7 @@ name: spec
3
3
  description: "Writes software design specs from already-clarified requirements, including solution approach, architecture outline, detailed design, tradeoffs, verification design, and handoff context. Not for unresolved requirements, PRD generation, implementation task planning, or code changes."
4
4
  when_to_use: "spec, design spec, technical design, design proposal, detailed design, architecture design, 设计方案, 概要设计, 详细设计, 技术方案"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # loopx Spec
@@ -3,7 +3,7 @@ name: subagent-exec
3
3
  description: "Executes approved loopx implementation plans with fresh subagents per independent task and staged review. Not for planning, unclear requirements, or tightly coupled edits."
4
4
  when_to_use: "approved implementation plan, independent tasks, subagent execution, staged spec review, code quality review, parallel-capable execution"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Subagent Exec
@@ -65,7 +65,7 @@ digraph process {
65
65
 
66
66
  "Read plan, extract all tasks with full text, note context, create update_plan" [shape=box];
67
67
  "More tasks remain?" [shape=diamond];
68
- "Dispatch final code reviewer subagent for entire implementation" [shape=box];
68
+ "Use loopx:final-review for entire implementation" [shape=box];
69
69
  "Use loopx:finish" [shape=box style=filled fillcolor=lightgreen];
70
70
 
71
71
  "Read plan, extract all tasks with full text, note context, create update_plan" -> "Dispatch implementer subagent (./implementer-prompt.md)";
@@ -84,8 +84,8 @@ digraph process {
84
84
  "Code quality reviewer subagent approves?" -> "Mark task complete in update_plan" [label="yes"];
85
85
  "Mark task complete in update_plan" -> "More tasks remain?";
86
86
  "More tasks remain?" -> "Dispatch implementer subagent (./implementer-prompt.md)" [label="yes"];
87
- "More tasks remain?" -> "Dispatch final code reviewer subagent for entire implementation" [label="no"];
88
- "Dispatch final code reviewer subagent for entire implementation" -> "Use loopx:finish";
87
+ "More tasks remain?" -> "Use loopx:final-review for entire implementation" [label="no"];
88
+ "Use loopx:final-review for entire implementation" -> "Use loopx:finish";
89
89
  }
90
90
  ```
91
91
 
@@ -199,8 +199,8 @@ Code reviewer: ✅ Approved
199
199
  ...
200
200
 
201
201
  [After all tasks]
202
- [Dispatch final code-reviewer]
203
- Final reviewer: All requirements met, ready to merge
202
+ [Use loopx:final-review]
203
+ Final reviewer: No whole-feature runtime or integration risks found. Ready for finish.
204
204
 
205
205
  Done!
206
206
  ```
@@ -273,6 +273,7 @@ Done!
273
273
 
274
274
  - **loopx:plan** - Creates the plan this skill executes
275
275
  - **loopx:review** - Code review template for reviewer subagents
276
+ - **loopx:final-review** - Final whole-feature runtime and integration risk review
276
277
  - **loopx:finish** - Complete development after all tasks
277
278
 
278
279
  **Subagents should use:**
@@ -3,7 +3,7 @@ name: tdd
3
3
  description: "Guides feature and bugfix implementation through a failing test before production code and red-green-refactor discipline. Not for generated files or throwaway prototypes."
4
4
  when_to_use: "tdd, failing test first, feature implementation, bugfix, regression test, red green refactor, 测试先行"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Test-Driven Development (TDD)
@@ -3,7 +3,7 @@ name: verify
3
3
  description: "Requires fresh verification evidence before claiming work is complete, fixed, passing, review-ready, or ready to commit. Not for speculative confidence or stale results."
4
4
  when_to_use: "verify, completion claim, fixed claim, tests pass, review-ready, commit, fresh evidence, 验证, 完成前检查"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Verification Before Completion
@@ -14,6 +14,7 @@ Read the selected skill file before acting. If multiple skills match, read every
14
14
  | Approved plan has independent tasks and should run with subagents plus staged review | `skills/subagent-exec/SKILL.md` |
15
15
  | Approved plan should run inline or without subagent-first execution | `skills/exec/SKILL.md` |
16
16
  | Completed task, major feature, or pre-merge work needs independent code review | `skills/review/SKILL.md` |
17
+ | Completed full feature needs final integration, runtime-risk, and test-gap review before finish | `skills/final-review/SKILL.md` |
17
18
  | Existing code review feedback needs technical evaluation and implementation | `skills/fix-review/SKILL.md` |
18
19
  | Completed implementation with passing tests needs merge, PR, keep, or discard decision | `skills/finish/SKILL.md` |
19
20
  | Refactor request needs interview, tiny commits, behavior-preserving scope, and RFC/issue output | `skills/refactor-plan/SKILL.md` |
@@ -36,10 +37,12 @@ Read the selected skill file before acting. If multiple skills match, read every
36
37
  4. `plan` writes `docs/loopx/plans/*.md` and then offers `subagent-exec` or `exec`.
37
38
  5. Use `subagent-exec` when subagents are available and the plan has independent tasks.
38
39
  6. Use `exec` when the user chooses inline execution or subagents are unavailable.
39
- 7. Use `review` to request code review of completed work. Use `fix-review` only after feedback exists.
40
- 8. Use `finish` only after implementation and verification are complete.
41
- 9. Use `refactor-plan` for behavior-preserving refactor planning. If the refactor changes external behavior or contracts, route to `clarify` or `spec`.
42
- 10. Treat `tdd`, `debug`, `verify`, `go-style`, and `kratos` as support lenses unless the user explicitly invokes them directly.
40
+ 7. Use `review` to request code review of completed task or checkpoint work.
41
+ 8. Use `final-review` after the whole feature is implemented and before `finish`.
42
+ 9. Use `fix-review` only after feedback exists.
43
+ 10. Use `finish` only after implementation, final review, and verification are complete.
44
+ 11. Use `refactor-plan` for behavior-preserving refactor planning. If the refactor changes external behavior or contracts, route to `clarify` or `spec`.
45
+ 12. Treat `tdd`, `debug`, `verify`, `go-style`, and `kratos` as support lenses unless the user explicitly invokes them directly.
43
46
 
44
47
  ## Deterministic Guard
45
48
 
@@ -3,7 +3,7 @@ name: clarify
3
3
  description: "Grills ambiguous loopx work until material questions are answered, then routes to spec or plan using a design gate. Not for clear implementation tasks, approved specs, or code changes."
4
4
  when_to_use: "clarify, requirements, ambiguous request, unclear scope, non-goals, decision boundaries, acceptance criteria, 需求澄清, 范围不清"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # loopx Clarify
@@ -3,7 +3,7 @@ name: debug
3
3
  description: "Finds root cause for bugs, failing tests, build failures, regressions, and unexpected behavior before fixes. Not for new feature planning or routine code review."
4
4
  when_to_use: "debug, bug, test failure, build failure, regression, unexpected behavior, root cause, 报错, 失败, 回归, 排查"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Systematic Debugging
@@ -3,7 +3,7 @@ name: exec
3
3
  description: "Executes a written loopx implementation plan sequentially with review checkpoints. Not for unclear plans, missing requirements, or subagent-first execution."
4
4
  when_to_use: "written implementation plan, inline execution, sequential plan execution, review checkpoints, no subagent lane"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Exec
@@ -0,0 +1,89 @@
1
+ ---
2
+ name: final-review
3
+ description: "Performs whole-feature review after implementation and staged task review. Not for per-task review, unresolved scope, implementation, or pure documentation polish."
4
+ when_to_use: "final-review, final code review, whole feature review, integration review, pre-finish review, after subagent-exec, runtime risk review, 最终评审"
5
+ metadata:
6
+ version: "0.2.2"
7
+ ---
8
+
9
+ # Final Review
10
+
11
+ Run the final whole-feature review after implementation is complete and before `finish`.
12
+
13
+ **Core principle:** Per-task review catches local issues. Final review hunts integration and runtime risk across the complete feature.
14
+
15
+ **Announce at start:** "I'm using the final-review skill to review the completed feature."
16
+
17
+ ## When to Use
18
+
19
+ Use this after:
20
+ - `subagent-exec` completed all planned tasks and per-task reviews
21
+ - `exec` completed a full plan with verification checkpoints
22
+ - ad-hoc implementation is complete and ready for final risk review
23
+
24
+ Do not use this for:
25
+ - reviewing one task or one small checkpoint (`review` is for that)
26
+ - fixing review feedback (`fix-review` is for that)
27
+ - polishing documentation wording
28
+ - incomplete implementation or failing verification
29
+
30
+ ## Required Inputs
31
+
32
+ Before dispatching the reviewer, collect:
33
+ - Full feature git range: base SHA before implementation, head SHA now
34
+ - Source requirements: spec, plan, issue, PRD, or accepted task brief
35
+ - Implementation summary: what changed and why
36
+ - Verification evidence: commands run and results
37
+ - Per-task review artifacts, if available
38
+
39
+ If the git range or requirements are unclear, stop and ask. A final review without a concrete scope is not useful.
40
+
41
+ ## Review Priority
42
+
43
+ The reviewer must prioritize findings in this order:
44
+
45
+ 1. Runtime bugs, data loss, broken CLI behavior, state corruption
46
+ 2. Cross-task integration bugs
47
+ 3. Missing edge cases not covered by tests
48
+ 4. Test quality problems
49
+ 5. Architecture and maintainability issues
50
+ 6. Documentation defects that can mislead users or maintainers, omit required operational facts, or contradict actual behavior
51
+
52
+ Do not report pure documentation polish, style preferences, or wording tweaks. Do report documentation problems that create wrong usage, wrong maintenance decisions, missing required commands, missing migration notes, or false claims.
53
+
54
+ ## Dispatch
55
+
56
+ Use the platform's native subagent mechanism when available and fill template at `final-reviewer.md`.
57
+
58
+ **Placeholders:**
59
+ - `{DESCRIPTION}` - concise summary of the completed feature
60
+ - `{REQUIREMENTS}` - source requirements or plan/spec excerpts
61
+ - `{VERIFICATION}` - test commands and results
62
+ - `{PER_TASK_REVIEWS}` - review artifacts or "not available"
63
+ - `{BASE_SHA}` - commit before implementation began
64
+ - `{HEAD_SHA}` - current commit
65
+
66
+ ## Handle Feedback
67
+
68
+ - Critical and Important findings must be handled before `finish`
69
+ - Use `fix-review` for received feedback
70
+ - Push back only with code, test, or requirement evidence
71
+ - After fixes, run verification again and repeat final review if the fix changed integration behavior
72
+
73
+ ## Common Mistakes
74
+
75
+ **Running normal review again**
76
+ - Problem: reviewer repeats per-task or documentation comments
77
+ - Fix: use `final-reviewer.md`, which focuses on whole-feature runtime risk
78
+
79
+ **Letting docs hide real risk**
80
+ - Problem: "docs only" findings are ignored even when users would be misled
81
+ - Fix: distinguish pure polish from operationally incorrect or missing documentation
82
+
83
+ **Reviewing without base/head SHAs**
84
+ - Problem: reviewer sees an unclear or stale diff
85
+ - Fix: provide an exact git range every time
86
+
87
+ **Skipping verification evidence**
88
+ - Problem: reviewer cannot judge whether tests prove real behavior
89
+ - Fix: include exact commands and pass/fail output summary
@@ -0,0 +1,135 @@
1
+ # Final Reviewer Prompt Template
2
+
3
+ Use this template when dispatching a final-review subagent.
4
+
5
+ **Purpose:** Review the complete feature for integration and runtime risk after task-level implementation and review are already done.
6
+
7
+ ```
8
+ Native subagent:
9
+ description: "Final review completed feature"
10
+ prompt: |
11
+ You are a Senior Final Reviewer. Task-level implementation and review have
12
+ already happened. Your job is not to repeat per-task review. Your job is to
13
+ find whole-feature risks that can still break users, corrupt state, lose
14
+ data, or leave important behavior untested.
15
+
16
+ ## What Was Implemented
17
+
18
+ {DESCRIPTION}
19
+
20
+ ## Requirements / Plan / Spec
21
+
22
+ {REQUIREMENTS}
23
+
24
+ ## Verification Evidence
25
+
26
+ {VERIFICATION}
27
+
28
+ ## Per-Task Reviews
29
+
30
+ {PER_TASK_REVIEWS}
31
+
32
+ ## Full Feature Git Range
33
+
34
+ **Base:** {BASE_SHA}
35
+ **Head:** {HEAD_SHA}
36
+
37
+ ```bash
38
+ git diff --stat {BASE_SHA}..{HEAD_SHA}
39
+ git diff {BASE_SHA}..{HEAD_SHA}
40
+ ```
41
+
42
+ ## Review Priority
43
+
44
+ Review in this exact priority order:
45
+
46
+ 1. Runtime bugs, data loss, broken CLI behavior, state corruption
47
+ 2. Cross-task integration bugs
48
+ 3. Missing edge cases not covered by tests
49
+ 4. Test quality problems
50
+ 5. Architecture and maintainability issues
51
+ 6. Documentation defects that can mislead users or maintainers, omit
52
+ required operational facts, or contradict actual behavior
53
+
54
+ Do not report pure documentation polish, style preferences, or wording
55
+ tweaks. Do report documentation problems that create wrong usage, wrong
56
+ maintenance decisions, missing required commands, missing migration notes,
57
+ or false claims.
58
+
59
+ ## What to Check
60
+
61
+ **Runtime and state risk:**
62
+ - Can any command crash, hang, silently no-op, or report success incorrectly?
63
+ - Can repeated runs corrupt files, state, locks, indexes, caches, or config?
64
+ - Can user data, generated artifacts, branches, or worktrees be lost?
65
+ - Are filesystem, process, permission, platform, and concurrency errors handled?
66
+
67
+ **Integration risk:**
68
+ - Do task outputs match later task inputs?
69
+ - Do CLI flags, exported functions, filenames, state keys, and schemas align?
70
+ - Does the feature work as a complete workflow, not just as isolated pieces?
71
+ - Are old data, missing files, and partially completed states handled?
72
+
73
+ **Tests:**
74
+ - Do tests execute real behavior rather than only mocks or snapshots?
75
+ - Are failure paths, edge cases, repeat runs, and integration paths covered?
76
+ - Are the verification commands sufficient for the changed surface area?
77
+
78
+ **Architecture:**
79
+ - Is the implementation maintainable within existing module boundaries?
80
+ - Did the feature add avoidable coupling or hidden global state?
81
+ - Are abstractions justified by actual complexity?
82
+
83
+ **Documentation defects:**
84
+ - Does documentation contradict actual behavior?
85
+ - Are required user or maintainer steps missing?
86
+ - Would a future agent follow the docs and make the wrong change?
87
+
88
+ ## Output Format
89
+
90
+ ### Findings
91
+
92
+ #### Critical
93
+ [Must fix before finish: data loss, state corruption, broken workflow,
94
+ security issue, or reliable runtime failure]
95
+
96
+ #### Important
97
+ [Should fix before finish: integration bug, untested edge case, weak test
98
+ proving too little, misleading docs that affect usage or maintenance]
99
+
100
+ #### Minor
101
+ [Low-risk maintainability or clarity issues. No pure polish.]
102
+
103
+ For each finding:
104
+ - File:line reference
105
+ - What is wrong
106
+ - Why it matters
107
+ - How to fix or what evidence would resolve it
108
+
109
+ ### Coverage Notes
110
+ [Briefly state which runtime paths and tests you inspected.]
111
+
112
+ ### Assessment
113
+
114
+ **Ready for finish?** [Yes | No | With fixes]
115
+
116
+ **Reasoning:** [1-2 sentence risk-based assessment]
117
+
118
+ ## Critical Rules
119
+
120
+ **DO:**
121
+ - Read the actual diff, not only reports
122
+ - Focus on complete workflow behavior
123
+ - Treat tests as evidence to audit, not proof to trust blindly
124
+ - Report documentation defects that can mislead or omit required facts
125
+ - Give file:line references
126
+
127
+ **DON'T:**
128
+ - Repeat task-level nits unless they create whole-feature risk
129
+ - Report pure documentation polish
130
+ - Assume per-task reviews caught integration bugs
131
+ - Give a vague "looks good"
132
+ - Avoid a clear verdict
133
+ ```
134
+
135
+ **Reviewer returns:** Findings by severity, Coverage Notes, Assessment.
@@ -3,7 +3,7 @@ name: finish
3
3
  description: "Finishes completed loopx development work after tests pass by presenting merge, PR, keep, or discard options. Not for unfinished work or failing verification."
4
4
  when_to_use: "implementation complete, tests pass, finish branch, create pull request, merge locally, keep branch, discard work"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Finish
@@ -78,6 +78,13 @@ Allowed inputs:
78
78
  - existing `.loopx/memory/MEMORY.md` and `.loopx/memory/index.jsonl`
79
79
  - existing `docs/loopx/specs/*.md`
80
80
 
81
+ Learning extraction priority:
82
+ 1. Durable behavior, contracts, or constraints proven by the implementation
83
+ 2. State, file, CLI, API, install, migration, compatibility, or test invariants
84
+ 3. Explicit user decisions that constrain future work
85
+ 4. Review findings or fixes that reveal a reusable pitfall, pattern, or boundary
86
+ 5. Documentation changes when they define, correct, or preserve one of the above
87
+
81
88
  Do not infer durable rules from agent intuition alone. Do not promote unverified implementation details.
82
89
 
83
90
  #### Memory
@@ -3,7 +3,7 @@ name: fix-review
3
3
  description: "Handles received code review feedback with verification, technical evaluation, pushback, and one-item-at-a-time fixes. Not for requesting a new review or implementing unrelated changes."
4
4
  when_to_use: "fix-review, received code review feedback, review comments, reviewer suggestions, requested changes, 处理评审意见"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Fix Review
@@ -3,7 +3,7 @@ name: go-style
3
3
  description: "Applies loopx Go coding style for .go edits, tests, errors, context, naming, and interface boundaries. Not for non-Go code or Kratos-specific architecture by itself."
4
4
  when_to_use: "go-style, Go, golang, .go files, go tests, gofmt, idiomatic Go, Go style, Go 代码"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Go Style
@@ -3,7 +3,7 @@ name: kratos
3
3
  description: "Supports Go-Kratos microservices, proto/buf APIs, service/biz/data layers, middleware, auth, config, and troubleshooting. Not for generic Go style alone."
4
4
  when_to_use: "kratos, Go-Kratos, proto, buf, service layer, biz layer, data layer, middleware, auth, config, Kratos 微服务"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Kratos
@@ -56,6 +56,12 @@ Use only the reference file needed for the current task:
56
56
  - Use validation annotations when the project already uses `buf.validate` or `protovalidate`.
57
57
  - Regenerate code with the repository's existing command, such as `buf generate`, `make api`, or project scripts.
58
58
 
59
+ ## Database DDL
60
+
61
+ - MySQL `CREATE TABLE` statements must include a table-level `COMMENT`.
62
+ - MySQL column definitions in `CREATE TABLE` or `ALTER TABLE ... ADD COLUMN` statements must include column-level `COMMENT`.
63
+ - When using Ent schema for MySQL tables, add `.Comment(...)` to fields that are persisted as columns.
64
+
59
65
  ## Integration With Other loopx Skills
60
66
 
61
67
  - Use `go-style` for handwritten `.go` edits.
@@ -3,7 +3,7 @@ name: plan
3
3
  description: "Creates bite-sized implementation plans from approved requirements, clarify output, or design specs with exact files, tests, commands, expected output, and execution handoff. Not for unresolved requirements, design decisions, PRD generation, or code changes."
4
4
  when_to_use: "plan, implementation plan, execution plan, task breakdown, approved requirements, approved design spec, docs/loopx/design, 实施计划, 执行计划, 任务拆分"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  argument-hint: "<design spec path or feature name>"
8
8
  ---
9
9
 
@@ -3,7 +3,7 @@ name: refactor-plan
3
3
  description: "Creates a behavior-preserving refactor plan with user interview, repo evidence, tiny commits, scope boundaries, and testing decisions. Not for feature changes or immediate implementation."
4
4
  when_to_use: "refactor-plan, refactor request, refactoring RFC, tiny commits, behavior-preserving cleanup, architecture cleanup, 重构计划"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  This skill will be invoked when the user wants to create a refactor request. You should go through the steps below. You may skip steps if you don't consider them necessary.
@@ -3,7 +3,7 @@ name: review
3
3
  description: "Dispatches a loopx code reviewer subagent against a concrete git range and requirements. Not for implementation, planning, or unresolved review scope."
4
4
  when_to_use: "request code review, completed task review, major feature review, pre-merge review, subagent code quality check"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Review
@@ -3,7 +3,7 @@ name: spec
3
3
  description: "Writes software design specs from already-clarified requirements, including solution approach, architecture outline, detailed design, tradeoffs, verification design, and handoff context. Not for unresolved requirements, PRD generation, implementation task planning, or code changes."
4
4
  when_to_use: "spec, design spec, technical design, design proposal, detailed design, architecture design, 设计方案, 概要设计, 详细设计, 技术方案"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # loopx Spec
@@ -3,7 +3,7 @@ name: subagent-exec
3
3
  description: "Executes approved loopx implementation plans with fresh subagents per independent task and staged review. Not for planning, unclear requirements, or tightly coupled edits."
4
4
  when_to_use: "approved implementation plan, independent tasks, subagent execution, staged spec review, code quality review, parallel-capable execution"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Subagent Exec
@@ -65,7 +65,7 @@ digraph process {
65
65
 
66
66
  "Read plan, extract all tasks with full text, note context, create update_plan" [shape=box];
67
67
  "More tasks remain?" [shape=diamond];
68
- "Dispatch final code reviewer subagent for entire implementation" [shape=box];
68
+ "Use loopx:final-review for entire implementation" [shape=box];
69
69
  "Use loopx:finish" [shape=box style=filled fillcolor=lightgreen];
70
70
 
71
71
  "Read plan, extract all tasks with full text, note context, create update_plan" -> "Dispatch implementer subagent (./implementer-prompt.md)";
@@ -84,8 +84,8 @@ digraph process {
84
84
  "Code quality reviewer subagent approves?" -> "Mark task complete in update_plan" [label="yes"];
85
85
  "Mark task complete in update_plan" -> "More tasks remain?";
86
86
  "More tasks remain?" -> "Dispatch implementer subagent (./implementer-prompt.md)" [label="yes"];
87
- "More tasks remain?" -> "Dispatch final code reviewer subagent for entire implementation" [label="no"];
88
- "Dispatch final code reviewer subagent for entire implementation" -> "Use loopx:finish";
87
+ "More tasks remain?" -> "Use loopx:final-review for entire implementation" [label="no"];
88
+ "Use loopx:final-review for entire implementation" -> "Use loopx:finish";
89
89
  }
90
90
  ```
91
91
 
@@ -199,8 +199,8 @@ Code reviewer: ✅ Approved
199
199
  ...
200
200
 
201
201
  [After all tasks]
202
- [Dispatch final code-reviewer]
203
- Final reviewer: All requirements met, ready to merge
202
+ [Use loopx:final-review]
203
+ Final reviewer: No whole-feature runtime or integration risks found. Ready for finish.
204
204
 
205
205
  Done!
206
206
  ```
@@ -273,6 +273,7 @@ Done!
273
273
 
274
274
  - **loopx:plan** - Creates the plan this skill executes
275
275
  - **loopx:review** - Code review template for reviewer subagents
276
+ - **loopx:final-review** - Final whole-feature runtime and integration risk review
276
277
  - **loopx:finish** - Complete development after all tasks
277
278
 
278
279
  **Subagents should use:**
@@ -3,7 +3,7 @@ name: tdd
3
3
  description: "Guides feature and bugfix implementation through a failing test before production code and red-green-refactor discipline. Not for generated files or throwaway prototypes."
4
4
  when_to_use: "tdd, failing test first, feature implementation, bugfix, regression test, red green refactor, 测试先行"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Test-Driven Development (TDD)
@@ -3,7 +3,7 @@ name: verify
3
3
  description: "Requires fresh verification evidence before claiming work is complete, fixed, passing, review-ready, or ready to commit. Not for speculative confidence or stale results."
4
4
  when_to_use: "verify, completion claim, fixed claim, tests pass, review-ready, commit, fresh evidence, 验证, 完成前检查"
5
5
  metadata:
6
- version: "0.2.1"
6
+ version: "0.2.2"
7
7
  ---
8
8
 
9
9
  # Verification Before Completion
@@ -21,6 +21,7 @@ const LOOPX_SKILLS = [
21
21
  'subagent-exec',
22
22
  'exec',
23
23
  'review',
24
+ 'final-review',
24
25
  'fix-review',
25
26
  'finish',
26
27
  'refactor-plan',