@ai-agent-lead/skills 1.2.0 → 1.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (35) hide show
  1. package/package.json +1 -1
  2. package/skills/README.md +19 -18
  3. package/skills/SKILL-TEMPLATE.md +5 -1
  4. package/skills/TRIGGERS.md +3 -3
  5. package/skills/WORKFLOWS.md +12 -15
  6. package/skills/bench/SKILL.md +0 -2
  7. package/skills/bench/templates/benchmark-report.md +10 -1
  8. package/skills/bootstrap/SKILL.md +0 -2
  9. package/skills/caveman/SKILL.md +0 -2
  10. package/skills/debug/SKILL.md +0 -2
  11. package/skills/design/ILLEGAL-STATES.md +12 -1
  12. package/skills/design/SKILL.md +1 -3
  13. package/skills/feature-doc/SKILL.md +3 -3
  14. package/skills/feature-doc/templates/feature-template.md +13 -1
  15. package/skills/formats/ADR-FORMAT.md +12 -2
  16. package/skills/{code-hygiene/SKILL.md → formats/CODE-HYGIENE.md} +27 -39
  17. package/skills/formats/CONTEXT-FORMAT.md +26 -0
  18. package/skills/formats/DOC-DRIFT-AUDIT.md +55 -0
  19. package/skills/formats/OKF.md +82 -0
  20. package/skills/formats/STYLE-comments.md +33 -44
  21. package/skills/grill-plan/SKILL.md +1 -3
  22. package/skills/improve-codebase-architecture/SKILL.md +1 -3
  23. package/skills/investigate/SKILL.md +0 -2
  24. package/skills/investigate/templates/research-note.md +13 -1
  25. package/skills/pr-review/SKILL.md +7 -20
  26. package/skills/prod-ready/SKILL.md +8 -8
  27. package/skills/security-review/SKILL.md +0 -2
  28. package/skills/simplify/SKILL.md +4 -12
  29. package/skills/system-design/SKILL.md +1 -3
  30. package/skills/tdd/SKILL.md +5 -2
  31. package/skills/tdd-rounds/SKILL.md +2 -14
  32. package/skills/verify-real-deps/SKILL.md +0 -2
  33. package/skills/verify-real-deps/templates/known-issues.md +11 -0
  34. package/skills/zoom-out/SKILL.md +0 -2
  35. package/skills/sync-check/SKILL.md +0 -69
@@ -1,69 +0,0 @@
1
- ---
2
- name: sync-check
3
- description: Diagnostic "Context Auditor" that scans code changes for terminology drift against `CONTEXT.md` and architectural contradictions against `docs/adr/`. Use before `pr-review`, after significant refactors, or when names feel "off." Prevents term collisions (e.g., "Account" vs "Customer") and silent deviations from established architectural decisions. Pairs with `grill-plan` (to resolve contradictions found) and `pr-review` (downstream gate).
4
- complexity: low
5
- expected_duration: 10 minutes
6
- ---
7
-
8
- # Sync Check (Context Auditor)
9
-
10
- The discipline of ensuring that the code's implementation matches the project's **Domain Language** and **Architectural History**.
11
-
12
- ## Why this skill exists
13
-
14
- As a codebase grows, it is easy for synonyms ("User", "Account", "Profile") to bleed into the code, diluting the domain model. Similarly, architectural decisions recorded in ADRs are often forgotten by developers (or LLMs) focused on local implementation. `sync-check` is the background auditor that surfaces these drifts before they calcify.
15
-
16
- ## When to use
17
-
18
- - Before starting a `pr-review` (as a primary step).
19
- - After a large refactor round in `tdd-rounds`.
20
- - When you encounter a term in the code that isn't in `CONTEXT.md`.
21
- - When the user asks "is this consistent with our model?" or "are we following our ADRs?"
22
-
23
- ## When to skip
24
-
25
- - Initial project setup (pre-vocabulary).
26
- - Pure doc/comment changes.
27
- - Trivial typo/config fixes.
28
-
29
- ## Process
30
-
31
- ### 1. Identify the Scope
32
-
33
- Map the files changed in the current branch or round to their corresponding domain contexts.
34
- - Use `CONTEXT-MAP.md` if it exists.
35
- - Otherwise, use the root `CONTEXT.md`.
36
-
37
- ### 2. Terminology Audit
38
-
39
- Scan the `git diff` for new or changed public identifiers (classes, functions, types, variables).
40
-
41
- - **Term Collision**: Check if a new term is listed as an `_Avoid_:` alias in `CONTEXT.md`.
42
- - **Fuzzy Mapping**: Check if a term exists in the code but is missing from the glossary.
43
- - **Synonym Drift**: Check if the code uses two different words for the same domain concept.
44
-
45
- ### 3. ADR Consistency Check
46
-
47
- Read the `docs/adr/` entries relevant to the changed packages.
48
-
49
- - **Direct Contradiction**: Does the change perform an action explicitly forbidden by an ADR (e.g., using an ORM when an ADR mandates manual SQL)?
50
- - **Surprise Deviation**: Does the change introduce a pattern that warrants a new ADR (hard to reverse, surprising, real trade-off)?
51
-
52
- ### 4. Report Drifts
53
-
54
- Output a numbered list of findings. For each:
55
- - **Location**: `file:line` or `ADR-NNNN`.
56
- - **Severity**: `Blocker` (direct contradiction/collision) or `Suggestion` (fuzzy mapping).
57
- - **Finding**: "Code uses 'Account', but `CONTEXT.md` specifies 'Customer'."
58
- - **Recommended Action**: "Rename to 'Customer' or update `CONTEXT.md` if the concept is genuinely new."
59
-
60
- ## Done when
61
-
62
- - All changed files have been cross-referenced with the glossary and relevant ADRs.
63
- - Every "Avoid" alias found in the diff has been flagged.
64
- - Every architectural deviation from active ADRs has been surfaced.
65
-
66
- ## Handoff
67
-
68
- - If contradictions are found → run `grill-plan` to resolve the terminology or architectural mismatch.
69
- - If clean → proceed to `pr-review`.