@ahmedsamirelsaka/react-native-local-release 2.0.0-rc.2 → 2.0.0-rc.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 2.0.0-rc.3
+
+- Fix: Fastlane now materializes Android signing passwords from macOS Keychain when `credentials.provider` is `keychain`.
+  `yarn release:beta` (direct Fastlane) no longer fails with `Missing MYAPP_UPLOAD_STORE_PASSWORD` after a Keychain install.
+- Treat literal empty quotes in `.env` / `keystore.properties` as empty values.
+
 ## 2.0.0-rc.2
 
 - Remove maintainer-only `docs/PUBLISHING.md` from the published package and GitHub tree.
@@ -28,7 +34,7 @@ Security-first rewrite for bare React Native apps (release candidate).
 - CI: SHA-pinned actions, npm provenance publish workflow, Dependabot.
 
 ### Migration
-1. Install `2.0.0-rc.2` (or newer) from npm (dist-tag `next`).
+1. Install `2.0.0-rc.3` (or newer) from npm (dist-tag `next`).
 2. Run `rn-local-release migrate --project .` (or reinstall; existing config is merged).
 3. Prefer Keychain credentials: `rn-local-release configure --project .`
 4. Confirm `.gitignore` includes `logs/`, `versions/`, and the marked credential block.

package/README.md

@@ -3,7 +3,7 @@
 Security-first local Fastlane release toolkit for **bare** React Native apps (iOS + Android).
 
 Package: [`@ahmedsamirelsaka/react-native-local-release`](https://www.npmjs.com/package/@ahmedsamirelsaka/react-native-local-release)  
-Version: **2.0.0-rc.2** (npm dist-tag `next`)
+Version: **2.0.0-rc.3** (npm dist-tag `next`)
 
 ## Supported
 
@@ -22,10 +22,10 @@ Version: **2.0.0-rc.2** (npm dist-tag `next`)
 
 ```bash
 # From your React Native app root
-npx @ahmedsamirelsaka/react-native-local-release@2.0.0-rc.2 install --project .
+npx @ahmedsamirelsaka/react-native-local-release@2.0.0-rc.3 install --project .
 
 # Prefer an exact version in package.json so daily commands do not float:
-# "devDependencies": { "@ahmedsamirelsaka/react-native-local-release": "2.0.0-rc.2" }
+# "devDependencies": { "@ahmedsamirelsaka/react-native-local-release": "2.0.0-rc.3" }
 ```
 
 Useful flags:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ahmedsamirelsaka/react-native-local-release",
-  "version": "2.0.0-rc.2",
+  "version": "2.0.0-rc.3",
   "description": "Security-first local Fastlane release toolkit for React Native iOS and Android",
   "type": "module",
   "license": "MIT",

package/template/fastlane/lib/rn_local_release.rb

@@ -122,19 +122,73 @@ def load_keystore_properties
   props
 end
 
+def keychain_service_name
+  "rn-local-release:#{File.basename(repo_root)}"
+end
+
+def keychain_get(account)
+  return nil unless FastlaneCore::Helper.mac?
+
+  out, status = Open3.capture2(
+    "security",
+    "find-generic-password",
+    "-s",
+    keychain_service_name,
+    "-a",
+    account,
+    "-w"
+  )
+  return nil unless status.success?
+
+  value = out.to_s.strip
+  value.empty? ? nil : value
+rescue StandardError
+  nil
+end
+
+# Keychain provider stores passwords in macOS Keychain and intentionally leaves
+# them blank in fastlane/.env + android/keystore.properties. Yarn release:*
+# invokes Fastlane directly, so Fastlane must materialize them itself.
+def materialize_keychain_secrets!
+  return unless config.dig("credentials", "provider").to_s == "keychain"
+  return unless FastlaneCore::Helper.mac?
+
+  {
+    "MYAPP_UPLOAD_STORE_PASSWORD" => keychain_get("MYAPP_UPLOAD_STORE_PASSWORD"),
+    "MYAPP_UPLOAD_KEY_PASSWORD" => keychain_get("MYAPP_UPLOAD_KEY_PASSWORD"),
+    "MYAPP_UPLOAD_KEY_ALIAS" => keychain_get("MYAPP_UPLOAD_KEY_ALIAS"),
+    "ASC_KEY_ID" => keychain_get("ASC_KEY_ID"),
+    "ASC_ISSUER_ID" => keychain_get("ASC_ISSUER_ID")
+  }.each do |key, value|
+    next if value.nil? || value.empty?
+    next unless ENV[key].to_s.strip.empty?
+
+    ENV[key] = value
+  end
+end
+
 def signing_value(name, default: nil)
+  materialize_keychain_secrets!
+
   from_env = ENV[name].to_s.strip
+  # dotenv / Keychain installs may leave literal empty quotes in .env
+  from_env = "" if from_env == '""' || from_env == "''"
   return from_env unless from_env.empty?
 
   from_file = load_keystore_properties[name].to_s.strip
+  from_file = "" if from_file == '""' || from_file == "''"
   return from_file unless from_file.empty?
 
+  from_keychain = keychain_get(name)
+  return from_keychain unless from_keychain.nil? || from_keychain.empty?
+
   return default unless default.nil?
 
   UI.user_error!("Missing #{name}. Set it in fastlane/.env, Keychain, or android/keystore.properties.")
 end
 
 def apply_android_signing_env!
+  materialize_keychain_secrets!
   {
     "MYAPP_UPLOAD_STORE_FILE" => signing_value("MYAPP_UPLOAD_STORE_FILE", default: "keystore.jks"),
     "MYAPP_UPLOAD_STORE_PASSWORD" => signing_value("MYAPP_UPLOAD_STORE_PASSWORD"),