@ahmednawaz/crank 0.2.2 → 0.2.3

package/bin/crank.js

@@ -635,7 +635,11 @@ async function main() {
       console.log(`[Crank] Installed package (${result.installCommand})`);
     } else if (result.installError) {
       console.warn(`[Crank] Package install warning: ${result.installError}`);
-      console.warn('[Crank] Try: pnpm add -D @ahmednawaz/crank');
+      if (result.installHint) {
+        console.warn(`[Crank] Run manually:\n  ${result.installHint}`);
+      } else {
+        console.warn('[Crank] Try: pnpm add -D @ahmednawaz/crank');
+      }
     }
     if (result.reactWire?.wired) {
       console.log(`[Crank] Patched ${result.reactWire.file}`);

package/lib/wire-react.js

@@ -226,44 +226,153 @@ function wireReactEntry(projectRoot) {
   return { wired: true, file: entryPath };
 }
 
-function detectInstallCommand(projectRoot) {
-  if (
-    exists(path.join(projectRoot, 'pnpm-lock.yaml')) ||
-    exists(path.join(projectRoot, 'pnpm-workspace.yaml'))
-  ) {
-    return { cmd: 'pnpm', args: ['add', '-D', '@ahmednawaz/crank'] };
+function findPnpmWorkspaceRoot(startDir) {
+  let dir = path.resolve(startDir);
+  for (let i = 0; i < 12; i++) {
+    if (
+      exists(path.join(dir, 'pnpm-workspace.yaml')) ||
+      exists(path.join(dir, 'pnpm-workspace.yml'))
+    ) {
+      return dir;
+    }
+    // lockfile alone can mean pnpm without workspaces
+    if (exists(path.join(dir, 'pnpm-lock.yaml')) && i === 0) {
+      return dir;
+    }
+    const parent = path.dirname(dir);
+    if (parent === dir) break;
+    dir = parent;
   }
-  if (exists(path.join(projectRoot, 'yarn.lock'))) {
-    return { cmd: 'yarn', args: ['add', '-D', '@ahmednawaz/crank'] };
+  // Prefer ancestor with lockfile if no workspace file
+  dir = path.resolve(startDir);
+  for (let i = 0; i < 12; i++) {
+    if (exists(path.join(dir, 'pnpm-lock.yaml'))) {
+      return dir;
+    }
+    const parent = path.dirname(dir);
+    if (parent === dir) break;
+    dir = parent;
   }
-  return { cmd: 'npm', args: ['install', '-D', '@ahmednawaz/crank'] };
+  return null;
 }
 
-function installCrankPackage(projectRoot) {
-  const { execFileSync } = require('child_process');
-  const { cmd, args } = detectInstallCommand(projectRoot);
-  const result = { installed: false, installCommand: `${cmd} ${args.join(' ')}` };
+function readPackageName(projectRoot) {
   try {
-    execFileSync(cmd, args, { cwd: projectRoot, stdio: 'inherit', env: process.env });
-    result.installed = true;
-    return result;
-  } catch (err) {
-    result.installError = err.message;
+    const pkg = JSON.parse(
+      fs.readFileSync(path.join(projectRoot, 'package.json'), 'utf8')
+    );
+    return pkg.name || null;
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Build install attempts for this project (pnpm monorepo-aware).
+ * Never uses npm as a fallback inside a pnpm workspace.
+ */
+function detectInstallAttempts(projectRoot) {
+  const root = path.resolve(projectRoot);
+  const pnpmRoot = findPnpmWorkspaceRoot(root);
+  const attempts = [];
+
+  if (pnpmRoot) {
+    const isWorkspace = exists(path.join(pnpmRoot, 'pnpm-workspace.yaml')) ||
+      exists(path.join(pnpmRoot, 'pnpm-workspace.yml'));
+    const pkgName = readPackageName(root);
+    const relFilter = path.relative(pnpmRoot, root).replace(/\\/g, '/') || '.';
+
+    // 1) From the package directory (works when cwd is the workspace package)
+    attempts.push({
+      cmd: 'pnpm',
+      args: ['add', '-D', '@ahmednawaz/crank'],
+      cwd: root,
+      label: `pnpm add -D @ahmednawaz/crank (in ${relFilter})`
+    });
+
+    if (isWorkspace && pnpmRoot !== root) {
+      // 2) From monorepo root with --filter by package name
+      if (pkgName) {
+        attempts.push({
+          cmd: 'pnpm',
+          args: ['add', '-D', '@ahmednawaz/crank', '--filter', pkgName],
+          cwd: pnpmRoot,
+          label: `pnpm add -D @ahmednawaz/crank --filter ${pkgName}`
+        });
+      }
+      // 3) From monorepo root with --filter by path
+      attempts.push({
+        cmd: 'pnpm',
+        args: ['add', '-D', '@ahmednawaz/crank', '--filter', `./${relFilter}`],
+        cwd: pnpmRoot,
+        label: `pnpm add -D @ahmednawaz/crank --filter ./${relFilter}`
+      });
+    }
+
+    return attempts;
   }
-  if (cmd !== 'npm') {
+
+  if (exists(path.join(root, 'yarn.lock'))) {
+    return [
+      {
+        cmd: 'yarn',
+        args: ['add', '-D', '@ahmednawaz/crank'],
+        cwd: root,
+        label: 'yarn add -D @ahmednawaz/crank'
+      }
+    ];
+  }
+
+  return [
+    {
+      cmd: 'npm',
+      args: ['install', '-D', '@ahmednawaz/crank'],
+      cwd: root,
+      label: 'npm install -D @ahmednawaz/crank'
+    }
+  ];
+}
+
+function detectInstallCommand(projectRoot) {
+  const attempts = detectInstallAttempts(projectRoot);
+  const first = attempts[0];
+  return { cmd: first.cmd, args: first.args, cwd: first.cwd };
+}
+
+function installCrankPackage(projectRoot) {
+  const { execFileSync } = require('child_process');
+  const attempts = detectInstallAttempts(projectRoot);
+  const result = {
+    installed: false,
+    installCommand: attempts[0]?.label || '',
+    installAttempts: []
+  };
+
+  for (const attempt of attempts) {
+    result.installAttempts.push(attempt.label);
     try {
-      execFileSync('npm', ['install', '-D', '@ahmednawaz/crank'], {
-        cwd: projectRoot,
+      execFileSync(attempt.cmd, attempt.args, {
+        cwd: attempt.cwd,
         stdio: 'inherit',
         env: process.env
       });
       result.installed = true;
-      result.installCommand = 'npm install -D @ahmednawaz/crank';
+      result.installCommand = attempt.label;
       delete result.installError;
-    } catch (err2) {
-      result.installError = err2.message;
+      return result;
+    } catch (err) {
+      result.installError = err.message;
     }
   }
+
+  // Hint for humans / agents — do not npm-install into a pnpm monorepo
+  const pkgName = readPackageName(projectRoot);
+  if (findPnpmWorkspaceRoot(projectRoot)) {
+    result.installHint = pkgName
+      ? `pnpm add -D @ahmednawaz/crank --filter ${pkgName}`
+      : `pnpm add -D @ahmednawaz/crank --filter ${path.basename(projectRoot)}`;
+  }
+
   return result;
 }
 
@@ -293,5 +402,7 @@ module.exports = {
   installCrankPackage,
   injectCrank,
   findEntry,
-  detectInstallCommand
+  detectInstallCommand,
+  detectInstallAttempts,
+  findPnpmWorkspaceRoot
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ahmednawaz/crank",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Internal Motive UX copy iteration: select UI text → Glean variants → MCP apply. Cursor, Replit, Claude.",
   "repository": {
     "type": "git",