@agoric/swingset-liveslots 0.10.3-dev-ff1e301.0 → 0.10.3-dev-e90f87b.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agoric/swingset-liveslots",
-  "version": "0.10.3-dev-ff1e301.0+ff1e301",
+  "version": "0.10.3-dev-e90f87b.0+e90f87b",
   "description": "SwingSet ocap support layer",
   "type": "module",
   "main": "src/index.js",
@@ -17,10 +17,10 @@
     "lint:eslint": "eslint ."
   },
   "dependencies": {
-    "@agoric/assert": "0.6.1-dev-ff1e301.0+ff1e301",
-    "@agoric/internal": "0.3.3-dev-ff1e301.0+ff1e301",
-    "@agoric/store": "0.9.3-dev-ff1e301.0+ff1e301",
-    "@agoric/vat-data": "0.5.3-dev-ff1e301.0+ff1e301",
+    "@agoric/assert": "0.6.1-dev-e90f87b.0+e90f87b",
+    "@agoric/internal": "0.3.3-dev-e90f87b.0+e90f87b",
+    "@agoric/store": "0.9.3-dev-e90f87b.0+e90f87b",
+    "@agoric/vat-data": "0.5.3-dev-e90f87b.0+e90f87b",
     "@endo/eventual-send": "^0.17.2",
     "@endo/exo": "^0.2.2",
     "@endo/far": "^0.2.18",
@@ -61,5 +61,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "ff1e3013a79972ab47a155914df2d96eacc96c5b"
+  "gitHead": "e90f87b24c5fa53a0f5c00f41cb633a07497d0b1"
 }

package/src/virtualObjectManager.js

@@ -16,10 +16,19 @@ import {
 
 /** @template T @typedef {import('@agoric/vat-data').DefineKindOptions<T>} DefineKindOptions */
 
-const { hasOwn, defineProperty, getOwnPropertyNames } = Object;
+const { hasOwn, defineProperty, getOwnPropertyNames, entries } = Object;
 const { ownKeys } = Reflect;
 const { quote: q } = assert;
 
+// See https://github.com/Agoric/agoric-sdk/issues/8005
+// Once agoric-sdk is upgraded to depend on endo post
+// https://github.com/endojs/endo/pull/1606 then remove this
+// definition of `b` and say instead
+// ```js
+//   const { quote: q, base: b } = assert;
+// ```
+const b = index => q(Number(index));
+
 // import { kdebug } from './kdebug.js';
 
 // TODO Use environment-options.js currently in ses/src after factoring it out
@@ -141,9 +150,8 @@ const makeContextCache = (makeState, makeContext) => {
  * @param {*} getSlotForVal
  * @returns {ContextProvider}
  */
-const makeContextProvider = (contextCache, getSlotForVal) => {
-  return harden(rep => contextCache.get(getSlotForVal(rep)));
-};
+const makeContextProvider = (contextCache, getSlotForVal) =>
+  harden(rep => contextCache.get(getSlotForVal(rep)));
 
 const makeContextProviderKit = (contextCache, getSlotForVal, facetNames) => {
   /** @type { Record<string, any> } */
@@ -260,15 +268,15 @@ const makeFacets = (
 };
 
 const insistDurableCapdata = (vrm, what, capdata, valueFor) => {
-  capdata.slots.forEach((vref, idx) => {
+  for (const [idx, vref] of entries(capdata.slots)) {
     if (!vrm.isDurable(vref)) {
       if (valueFor) {
-        Fail`value for ${what} is not durable: slot ${q(idx)} of ${capdata}`;
+        Fail`value for ${what} is not durable: slot ${b(idx)} of ${capdata}`;
       } else {
-        Fail`${what} is not durable: slot ${q(idx)} of ${capdata}`;
+        Fail`${what} is not durable: slot ${b(idx)} of ${capdata}`;
       }
     }
-  });
+  }
 };
 
 const insistSameCapData = (oldCD, newCD) => {
@@ -281,11 +289,11 @@ const insistSameCapData = (oldCD, newCD) => {
   if (oldCD.slots.length !== newCD.slots.length) {
     Fail`durable Kind stateShape mismatch (slots.length)`;
   }
-  oldCD.slots.forEach((oldVref, idx) => {
+  for (const [idx, oldVref] of entries(oldCD.slots)) {
     if (newCD.slots[idx] !== oldVref) {
       Fail`durable Kind stateShape mismatch (slot[${idx}])`;
     }
-  });
+  }
 };
 
 /**
@@ -707,7 +715,7 @@ export const makeVirtualObjectManager = (
     durableKindDescriptor = undefined, // only for durables
   ) => {
     const {
-      finish,
+      finish = undefined,
       stateShape = undefined,
       thisfulMethods = false,
       interfaceGuard = undefined,
@@ -974,9 +982,9 @@ export const makeVirtualObjectManager = (
       let doMoreGC = false;
       const record = dataCache.get(baseRef);
       for (const valueCD of Object.values(record.capdatas)) {
-        valueCD.slots.forEach(vref => {
+        for (const vref of valueCD.slots) {
           doMoreGC = vrm.removeReachableVref(vref) || doMoreGC;
-        });
+        }
       }
       dataCache.delete(baseRef);
       return doMoreGC;
@@ -1015,6 +1023,7 @@ export const makeVirtualObjectManager = (
         if (isDurable) {
           insistDurableCapdata(vrm, prop, valueCD, true);
         }
+        // eslint-disable-next-line github/array-foreach
         valueCD.slots.forEach(vrm.addReachableVref);
         capdatas[prop] = valueCD;
         valueMap.set(prop, value);