@agoric/inter-protocol 0.16.2-dev-5dc325b.0 → 0.16.2-getting-started-dev-d127d1d.0

package/src/proposals/committee-proposal.js

@@ -4,14 +4,14 @@ import { reserveThenDeposit } from './utils.js';
 
 const { values } = Object;
 
-/** @type {<X, Y>(xs: X[], ys: Y[]) => [X, Y][]} */
+/** @type { <X, Y>(xs: X[], ys: Y[]) => [X, Y][]} */
 const zip = (xs, ys) => xs.map((x, i) => [x, ys[i]]);
 
 const EC_HIGH_PRIORITY_SENDERS_NAMESPACE = 'economicCommittee';
 
 /**
  * @param {import('./econ-behaviors').EconomyBootstrapPowers} powers
- * @param {{ options: { voterAddresses: Record<string, string> } }} param1
+ * @param {{ options: { voterAddresses: Record<string, string> }}} param1
  */
 export const inviteCommitteeMembers = async (
   {
@@ -26,14 +26,18 @@ export const inviteCommitteeMembers = async (
 
   const highPrioritySendersManager = await consume.highPrioritySendersManager;
 
-  /** @param {[string, Promise<Invitation>][]} addrInvitations */
+  /**
+   * @param {[string, Promise<Invitation>][]} addrInvitations
+   */
   const distributeInvitations = async addrInvitations => {
     await Promise.all(
       addrInvitations.map(async ([addr, invitationP]) => {
-        const debugName = `econ committee member ${addr}`;
-        await reserveThenDeposit(debugName, namesByAddressAdmin, addr, [
-          invitationP,
-        ]).catch(err => console.error(`failed deposit to ${debugName}`, err));
+        await reserveThenDeposit(
+          `econ committee member ${addr}`,
+          namesByAddressAdmin,
+          addr,
+          [invitationP],
+        );
         if (highPrioritySendersManager) {
           await E(highPrioritySendersManager).add(
             EC_HIGH_PRIORITY_SENDERS_NAMESPACE,
@@ -44,14 +48,14 @@ export const inviteCommitteeMembers = async (
     );
   };
 
-  // This doesn't resolve until the committee members create their smart wallets.
-  // Don't block bootstrap on it.
-  void distributeInvitations(zip(values(voterAddresses), invitations));
+  await distributeInvitations(zip(values(voterAddresses), invitations));
 };
 
 harden(inviteCommitteeMembers);
 
-/** @param {import('./econ-behaviors').EconomyBootstrapPowers} powers */
+/**
+ * @param {import('./econ-behaviors').EconomyBootstrapPowers} powers
+ */
 export const startEconCharter = async ({
   consume: { zoe },
   produce: { econCharterKit },
@@ -127,7 +131,7 @@ harden(addGovernorsToEconCharter);
 
 /**
  * @param {import('./econ-behaviors').EconomyBootstrapPowers} powers
- * @param {{ options: { voterAddresses: Record<string, string> } }} param1
+ * @param {{ options: { voterAddresses: Record<string, string> }}} param1
  */
 export const inviteToEconCharter = async (
   { consume: { namesByAddressAdmin, econCharterKit } },
@@ -135,15 +139,15 @@ export const inviteToEconCharter = async (
 ) => {
   const { creatorFacet } = E.get(econCharterKit);
 
-  // This doesn't resolve until the committee members create their smart wallets.
-  // Don't block bootstrap on it.
-  void Promise.all(
-    values(voterAddresses).map(async addr => {
-      const debugName = `econ charter member ${addr}`;
-      reserveThenDeposit(debugName, namesByAddressAdmin, addr, [
-        E(creatorFacet).makeCharterMemberInvitation(),
-      ]).catch(err => console.error(`failed deposit to ${debugName}`, err));
-    }),
+  await Promise.all(
+    values(voterAddresses).map(async addr =>
+      reserveThenDeposit(
+        `econ charter member ${addr}`,
+        namesByAddressAdmin,
+        addr,
+        [E(creatorFacet).makeCharterMemberInvitation()],
+      ),
+    ),
   );
 };
 
@@ -176,6 +180,8 @@ export const getManifestForInviteCommittee = async (
       [addGovernorsToEconCharter.name]: {
         consume: {
           auctioneerKit: t,
+          reserveGovernorCreatorFacet: t,
+          vaultFactoryGovernorCreator: t,
           econCharterKit: t,
           zoe: t,
           agoricNames: t,

package/src/proposals/core-proposal.js

@@ -1,6 +1,6 @@
 // @jessie-check
 
-import { Stable } from '@agoric/internal/src/tokens.js';
+import { Stable } from '@agoric/vats/src/tokens.js';
 import * as econBehaviors from './econ-behaviors.js';
 import { ECON_COMMITTEE_MANIFEST } from './startEconCommittee.js';
 
@@ -15,7 +15,9 @@ export * from './startEconCommittee.js'; // eslint-disable-line import/export
 // require updating a lot of tests. So for now, we just
 // grab the kits afterward and store them.
 
-/** @param {import('./econ-behaviors.js').EconomyBootstrapPowers} powers */
+/**
+ * @param {import('./econ-behaviors.js').EconomyBootstrapPowers} powers
+ */
 export const storeInterContractStartKits = async ({
   consume: {
     contractKits,
@@ -29,15 +31,13 @@ export const storeInterContractStartKits = async ({
   },
 }) => {
   /**
-   * @param {Promise<MapStore<string, { instance: Instance }>>} storeP
-   * @param {Promise<{ instance: Instance }>[]} kitPs
+   * @param {Promise<MapStore<string, {instance: Instance}>>} storeP
+   * @param {Promise<{instance: Instance}>[]} kitPs
    */
   const storeAll = async (storeP, kitPs) => {
     const store = await storeP;
     const kits = await Promise.all(kitPs);
-    for (const kit of kits) {
-      store.init(kit.instance, kit);
-    }
+    kits.forEach(kit => store.init(kit.instance, kit));
   };
 
   await storeAll(contractKits, [

package/src/proposals/econ-behaviors.js

@@ -6,9 +6,11 @@ import { AmountMath } from '@agoric/ertp';
 import '@agoric/governance/exported.js';
 import { deeplyFulfilledObject, makeTracer } from '@agoric/internal';
 import { makeStorageNodeChild } from '@agoric/internal/src/lib-chainStorage.js';
+import '@agoric/vats/exported.js';
+import '@agoric/vats/src/core/types.js';
+import { Stable } from '@agoric/vats/src/tokens.js';
 import { E } from '@endo/far';
 import { makeScalarBigMapStore } from '@agoric/vat-data';
-import { Stable } from '@agoric/internal/src/tokens.js';
 import { makeGovernedTerms as makeGovernedATerms } from '../auction/params.js';
 import { makeReserveTerms } from '../reserve/params.js';
 import { makeGovernedTerms as makeGovernedVFTerms } from '../vaultFactory/params.js';
@@ -22,9 +24,7 @@ export const SECONDS_PER_WEEK = 7n * SECONDS_PER_DAY;
 
 /**
  * @typedef {import('../vaultFactory/vaultFactory.js').VaultFactoryContract['publicFacet']} VaultFactoryPublicFacet
- *
  * @typedef {import('../auction/auctioneer.js').AuctioneerPublicFacet} AuctioneerPublicFacet
- *
  * @typedef {import('../auction/auctioneer.js').AuctioneerCreatorFacet} AuctioneerCreatorFacet
  */
 
@@ -33,65 +33,43 @@ export const SECONDS_PER_WEEK = 7n * SECONDS_PER_DAY;
  * @property {string} label
  * @property {Instance} psm
  * @property {Instance} psmGovernor
- * @property {Awaited<
- *   ReturnType<
- *     Awaited<
- *       ReturnType<import('../psm/psm.js')['start']>
- *     >['creatorFacet']['getLimitedCreatorFacet']
- *   >
- * >} psmCreatorFacet
- * @property {GovernorCreatorFacet<import('../../src/psm/psm.js')['start']>} psmGovernorCreatorFacet
+ * @property {Awaited<ReturnType<Awaited<ReturnType<import('../psm/psm.js')['prepare']>>['creatorFacet']['getLimitedCreatorFacet']>>} psmCreatorFacet
+ * @property {GovernorCreatorFacet<import('../../src/psm/psm.js')['prepare']>} psmGovernorCreatorFacet
  * @property {AdminFacet} psmAdminFacet
  */
 
-/** @typedef {GovernanceFacetKit<import('../auction/auctioneer.js').start>} AuctioneerKit */
+/**
+ * @typedef {GovernanceFacetKit<import('../auction/auctioneer.js').start>} AuctioneerKit
+ */
 
 /**
- * @typedef {WellKnownSpaces & ChainBootstrapSpace & EconomyBootstrapSpace} EconomyBootstrapPowers
- *
+ * @typedef { WellKnownSpaces & ChainBootstrapSpace & EconomyBootstrapSpace
+ * } EconomyBootstrapPowers
  * @typedef {PromiseSpaceOf<{
- *   economicCommitteeKit: CommitteeStartResult;
- *   economicCommitteeCreatorFacet: import('@agoric/governance/src/committee.js').CommitteeElectorateCreatorFacet;
- *   feeDistributorKit: StartedInstanceKit<
- *     typeof import('../feeDistributor.js').start
- *   >;
- *   periodicFeeCollectors: MapStore<
- *     number,
- *     import('../feeDistributor.js').PeriodicFeeCollector
- *   >;
- *   psmKit: MapStore<Brand, PSMKit>;
- *   anchorBalancePayments: MapStore<Brand, Payment<'nat'>>;
- *   econCharterKit: EconCharterStartResult;
- *   reserveKit: GovernanceFacetKit<
- *     import('../reserve/assetReserve.js')['start']
- *   >;
- *   vaultFactoryKit: GovernanceFacetKit<
- *     import('../vaultFactory/vaultFactory.js')['start']
- *   >;
- *   auctioneerKit: AuctioneerKit;
- *   minInitialDebt: NatValue;
+ *   economicCommitteeKit: CommitteeStartResult,
+ *   economicCommitteeCreatorFacet: import('@agoric/governance/src/committee.js').CommitteeElectorateCreatorFacet,
+ *   feeDistributorKit: StartedInstanceKit<typeof import('../feeDistributor.js').start>,
+ *   periodicFeeCollectors: MapStore<number, import('../feeDistributor.js').PeriodicFeeCollector>,
+ *   psmKit: MapStore<Brand, PSMKit>,
+ *   anchorBalancePayments: MapStore<Brand, Payment<'nat'>>,
+ *   econCharterKit: EconCharterStartResult,
+ *   reserveKit: GovernanceFacetKit<import('../reserve/assetReserve.js')['prepare']>,
+ *   vaultFactoryKit: GovernanceFacetKit<import('../vaultFactory/vaultFactory.js')['prepare']>,
+ *   auctioneerKit: AuctioneerKit,
+ *   minInitialDebt: NatValue,
  * }>} EconomyBootstrapSpace
  */
 
-/**
- * @typedef {import('@agoric/zoe/src/zoeService/utils.js').StartedInstanceKit<
- *   import('../econCommitteeCharter')['start']
- * >} EconCharterStartResult
- */
-/**
- * @typedef {import('@agoric/zoe/src/zoeService/utils.js').StartedInstanceKit<
- *   import('@agoric/governance/src/committee.js')['start']
- * >} CommitteeStartResult
- */
+/** @typedef {import('@agoric/zoe/src/zoeService/utils.js').StartedInstanceKit<import('../econCommitteeCharter')['prepare']>} EconCharterStartResult */
+/** @typedef {import('@agoric/zoe/src/zoeService/utils.js').StartedInstanceKit<import('@agoric/governance/src/committee.js')['prepare']>} CommitteeStartResult */
 
 /**
  * @file A collection of productions, each of which declares inputs and outputs.
- *   Each function is passed a set of powers for reading from and writing to the
- *   vat config.
+ * Each function is passed a set of powers for reading from and writing to the vat config.
  *
- *   Each of the things they produce they're responsible for resolving or setting.
+ * Each of the things they produce they're responsible for resolving or setting.
  *
- *   In production called by @agoric/vats to bootstrap.
+ * In production called by @agoric/vats to bootstrap.
  */
 
 /** @param {EconomyBootstrapPowers} powers */
@@ -323,11 +301,7 @@ export const startVaultFactory = async (
     }),
   );
 
-  /**
-   * @type {GovernorStartedInstallationKit<
-   *   typeof vaultFactoryInstallation
-   * >}
-   */
+  /** @type {GovernorStartedInstallationKit<typeof vaultFactoryInstallation>} */
   const g = await E(consume.zoe).startInstance(
     contractGovernorInstallation,
     undefined,
@@ -376,8 +350,8 @@ export const startVaultFactory = async (
 };
 
 /**
- * Grant access to the VaultFactory creatorFacet to up to one user based on
- * address.
+ * Grant access to the VaultFactory creatorFacet
+ * to up to one user based on address.
  *
  * @param {EconomyBootstrapPowers} powers
  * @param {object} [root0]
@@ -463,8 +437,9 @@ export const startRewardDistributor = async ({
 
   /**
    * @type {Awaited<
-   *   ReturnType<typeof import('../feeDistributor.js').makeFeeDistributor>
-   * > & { adminFacet: AdminFacet; instance: Instance }}
+   *   ReturnType<typeof import('../feeDistributor.js').makeFeeDistributor>>
+   *   & { adminFacet: AdminFacet, instance: Instance }
+   * }
    */
   const instanceKit = await E(zoe).startInstance(
     feeDistributor,

package/src/proposals/price-feed-proposal.js

@@ -1,20 +1,13 @@
 // @ts-nocheck -- lots of type errors. low prio b/c proposals are like scripts
-import { makeTracer } from '@agoric/internal';
+import { E } from '@endo/far';
 import {
-  assertPathSegment,
   makeStorageNodeChild,
+  assertPathSegment,
 } from '@agoric/internal/src/lib-chainStorage.js';
-import { E } from '@endo/far';
+import { makeTracer } from '@agoric/internal';
 
 import { unitAmount } from '@agoric/zoe/src/contractSupport/priceQuote.js';
-import {
-  oracleBrandFeedName,
-  reserveThenDeposit,
-  reserveThenGetNames,
-} from './utils.js';
-
-// backwards compatibility
-export { oracleBrandFeedName as instanceNameFor };
+import { reserveThenDeposit, reserveThenGetNames } from './utils.js';
 
 const trace = makeTracer('RunPriceFeed', true);
 
@@ -27,12 +20,12 @@ const sanitizePathSegment = name => {
 
 /**
  * @typedef {{
- *   brandIn?: ERef<Brand<'nat'> | undefined>;
- *   brandOut?: ERef<Brand<'nat'> | undefined>;
- *   IN_BRAND_NAME: string;
- *   IN_BRAND_DECIMALS: string;
- *   OUT_BRAND_NAME: string;
- *   OUT_BRAND_DECIMALS: string;
+ * brandIn?: ERef<Brand<'nat'> | undefined>,
+ * brandOut?: ERef<Brand<'nat'> | undefined>,
+ * IN_BRAND_NAME: string,
+ * IN_BRAND_DECIMALS: string,
+ * OUT_BRAND_NAME: string,
+ * OUT_BRAND_DECIMALS: string,
  * }} PriceFeedOptions
  */
 
@@ -40,7 +33,7 @@ const sanitizePathSegment = name => {
  * Create inert brands (no mint or issuer) referred to by price oracles.
  *
  * @param {ChainBootstrapSpace & NamedVatPowers} space
- * @param {{ options: { priceFeedOptions: PriceFeedOptions } }} opt
+ * @param {{options: {priceFeedOptions: PriceFeedOptions}}} opt
  * @returns {Promise<[Brand<'nat'>, Brand<'nat'>]>}
  */
 export const ensureOracleBrands = async (
@@ -69,6 +62,7 @@ export const ensureOracleBrands = async (
     let b = await brand;
     if (!b) {
       // not 1st await
+      // eslint-disable-next-line @jessie.js/no-nested-await
       b = await E(agoricNames).provideInertBrand(
         name,
         harden({ decimalPlaces: parseInt(decimals, 10) }),
@@ -85,17 +79,7 @@ export const ensureOracleBrands = async (
 
 /**
  * @param {ChainBootstrapSpace} powers
- * @param {{
- *   options: {
- *     priceFeedOptions: {
- *       AGORIC_INSTANCE_NAME: string;
- *       oracleAddresses: string[];
- *       contractTerms: import('@agoric/inter-protocol/src/price/fluxAggregatorKit.js').ChainlinkConfig;
- *       IN_BRAND_NAME: string;
- *       OUT_BRAND_NAME: string;
- *     };
- *   };
- * }} config
+ * @param {{options: {priceFeedOptions: {AGORIC_INSTANCE_NAME: string, oracleAddresses: string[], contractTerms: import('@agoric/inter-protocol/src/price/fluxAggregatorKit.js').ChainlinkConfig, IN_BRAND_NAME: string, OUT_BRAND_NAME: string}}}} config
  */
 export const createPriceFeed = async (
   {
@@ -112,7 +96,6 @@ export const createPriceFeed = async (
       priceAuthorityAdmin,
       startGovernedUpgradable,
     },
-    instance: { produce: produceInstance },
   },
   {
     options: {
@@ -134,17 +117,9 @@ export const createPriceFeed = async (
   const timer = await chainTimerService;
 
   /**
-   * Values come from economy-template.json, which at this writing had IN:ATOM,
-   * OUT:USD
+   * Values come from economy-template.json, which at this writing had IN:ATOM, OUT:USD
    *
-   * @type {[
-   *   [Brand<'nat'>, Brand<'nat'>],
-   *   [
-   *     Installation<
-   *       import('@agoric/inter-protocol/src/price/fluxAggregatorContract.js')['start]
-   *     >,
-   *   ],
-   * ]}
+   * @type {[[Brand<'nat'>, Brand<'nat'>], [Installation<import('@agoric/inter-protocol/src/price/fluxAggregatorContract.js').prepare>]]}
    */
   const [[brandIn, brandOut], [priceAggregator]] = await Promise.all([
     reserveThenGetNames(E(agoricNamesAdmin).lookupAdmin('oracleBrand'), [
@@ -186,27 +161,11 @@ export const createPriceFeed = async (
     installation: priceAggregator,
   });
 
-  // Publish price feed in home.priceAuthority.
-  const forceReplace = true;
-  // Make sure this PA is registered before sharing the instance in agoricNames,
-  // which allows contracts that depend on the registry value to wait for it and
-  // prevent a race.
-  await E(priceAuthorityAdmin).registerPriceAuthority(
-    E(faKit.publicFacet).getPriceAuthority(),
-    brandIn,
-    brandOut,
-    forceReplace,
-  );
-
-  await E(E(agoricNamesAdmin).lookupAdmin('instance'))
+  E(E(agoricNamesAdmin).lookupAdmin('instance'))
     .update(AGORIC_INSTANCE_NAME, faKit.instance)
     .catch(err =>
       console.error(`🚨 failed to update ${AGORIC_INSTANCE_NAME}`, err),
     );
-  // being after the above awaits means that when this resolves, the consumer
-  // gets notified that the authority is in the registry and its instance is in
-  // agoricNames.
-  produceInstance[AGORIC_INSTANCE_NAME].resolve(faKit.instance);
 
   E(E.get(econCharterKit).creatorFacet).addInstance(
     faKit.instance,
@@ -215,6 +174,15 @@ export const createPriceFeed = async (
   );
   trace('registered', AGORIC_INSTANCE_NAME, faKit.instance);
 
+  // Publish price feed in home.priceAuthority.
+  const forceReplace = true;
+  void E(priceAuthorityAdmin).registerPriceAuthority(
+    E(faKit.publicFacet).getPriceAuthority(),
+    brandIn,
+    brandOut,
+    forceReplace,
+  );
+
   /**
    * Initialize a new oracle and send an invitation to administer it.
    *
@@ -222,23 +190,22 @@ export const createPriceFeed = async (
    */
   const addOracle = async addr => {
     const invitation = await E(faKit.creatorFacet).makeOracleInvitation(addr);
-    const debugName = `${AGORIC_INSTANCE_NAME} member ${addr}`;
-    await reserveThenDeposit(debugName, namesByAddressAdmin, addr, [
-      invitation,
-    ]).catch(err => console.error(`failed deposit to ${debugName}`, err));
+    await reserveThenDeposit(
+      `${AGORIC_INSTANCE_NAME} member ${addr}`,
+      namesByAddressAdmin,
+      addr,
+      [invitation],
+    );
   };
 
   trace('distributing invitations', oracleAddresses);
-  // This doesn't resolve until oracle operators create their smart wallets.
-  // Don't block bootstrap on it.
-  void Promise.all(oracleAddresses.map(addOracle));
+  await Promise.all(oracleAddresses.map(addOracle));
   trace('createPriceFeed complete');
 };
 
 const t = 'priceFeed';
 /**
- * Add a price feed to a running chain, returning the manifest, installations,
- * and options.
+ * Add a price feed to a running chain, returning the manifest, installations, and options.
  *
  * @param {object} utils
  * @param {(ref: unknown) => Promise<unknown>} [utils.restoreRef]
@@ -256,16 +223,15 @@ export const getManifestForPriceFeed = async (
         chainStorage: t,
         chainTimerService: t,
         client: t,
+        contractGovernor: t,
         econCharterKit: t,
+        economicCommitteeCreatorFacet: t,
         highPrioritySendersManager: t,
         namesByAddressAdmin: t,
         priceAuthority: t,
         priceAuthorityAdmin: t,
         startGovernedUpgradable: t,
       },
-      instance: {
-        produce: t,
-      },
     },
     [ensureOracleBrands.name]: {
       namedVat: {
@@ -277,7 +243,6 @@ export const getManifestForPriceFeed = async (
     },
   },
   installations: {
-    // ??? will every eval of price-feed-proposal install priceAggregator ?
     priceAggregator: restoreRef(priceFeedOptions.priceAggregatorRef),
   },
   options: {
@@ -338,7 +303,7 @@ export const startPriceFeeds = async (
     {
       options: {
         priceFeedOptions: {
-          AGORIC_INSTANCE_NAME: oracleBrandFeedName(inBrandName, outBrandName),
+          AGORIC_INSTANCE_NAME: `${inBrandName}-${outBrandName} price feed`,
           contractTerms: {
             minSubmissionCount: 2,
             minSubmissionValue: 1,

package/src/proposals/startEconCommittee.js

@@ -22,7 +22,7 @@ const sanitizePathSegment = name => {
 
 /**
  * @param {import('./econ-behaviors').EconomyBootstrapPowers} powers
- * @param {object} config
+ * @param {object} [config]
  * @param {object} [config.options]
  * @param {EconCommitteeOptions} [config.options.econCommitteeOptions]
  */

package/src/proposals/startPSM.js

@@ -6,14 +6,14 @@ import { CONTRACT_ELECTORATE, ParamTypes } from '@agoric/governance';
 import { makeStorageNodeChild } from '@agoric/internal/src/lib-chainStorage.js';
 import { makeRatio } from '@agoric/zoe/src/contractSupport/index.js';
 import { E } from '@endo/far';
+import { Stable } from '@agoric/vats/src/tokens.js';
 import {
   makeHistoryReviver,
   makeBoardRemote,
   slotToBoardRemote,
-} from '@agoric/internal/src/marshal.js';
+} from '@agoric/vats/tools/board-utils.js';
 import { deeplyFulfilledObject } from '@agoric/internal';
 import { makeScalarBigMapStore } from '@agoric/vat-data';
-import { Stable } from '@agoric/internal/src/tokens.js';
 
 import { reserveThenGetNamePaths } from './utils.js';
 
@@ -35,13 +35,10 @@ export { inviteCommitteeMembers, startEconCharter, inviteToEconCharter };
 const stablePsmKey = `published.psm.${Stable.symbol}`;
 
 /**
- * @param {[key: string, value: string][]} chainStorageEntries
+ * @param {Array<[key: string, value: string]>} chainStorageEntries
  * @param {string} keyword
- * @param {{ minted: Brand<'nat'>; anchor: Brand<'nat'> }} brands
- * @returns {{
- *   metrics?: MetricsNotification;
- *   governance?: GovernanceSubscriptionState;
- * }}
+ * @param {{ minted: Brand<'nat'>, anchor: Brand<'nat'> }} brands
+ * @returns {{ metrics?: MetricsNotification, governance?: GovernanceSubscriptionState }}
  */
 const findOldPSMState = (chainStorageEntries, keyword, brands) => {
   // In this reviver, object references are revived as boardIDs
@@ -83,7 +80,7 @@ const findOldPSMState = (chainStorageEntries, keyword, brands) => {
  * @param {bigint} [config.WantMintedFeeBP]
  * @param {bigint} [config.GiveMintedFeeBP]
  * @param {bigint} [config.MINT_LIMIT]
- * @param {{ anchorOptions?: AnchorOptions }} [config.options]
+ * @param {{ anchorOptions?: AnchorOptions } } [config.options]
  */
 export const startPSM = async (
   {
@@ -294,16 +291,16 @@ harden(startPSM);
  */
 
 /**
- * Make anchor issuer out of a Cosmos asset; presumably USDC over IBC. Add it to
- * BankManager.
+ * Make anchor issuer out of a Cosmos asset; presumably
+ * USDC over IBC. Add it to BankManager.
  *
- * Also, if vatParameters shows an anchorPoolBalance for this asset, mint a
- * payment for that balance.
+ * Also, if vatParameters shows an anchorPoolBalance for this asset,
+ * mint a payment for that balance.
  *
  * TODO: address redundancy with publishInterchainAssetFromBank
  *
  * @param {EconomyBootstrapPowers & WellKnownSpaces & ChainStorageVatParams} powers
- * @param {{ options: { anchorOptions?: AnchorOptions } }} config
+ * @param {{options?: { anchorOptions?: AnchorOptions } }} [config]
  */
 export const makeAnchorAsset = async (
   {
@@ -348,18 +345,13 @@ export const makeAnchorAsset = async (
     }),
   );
 
-  const { creatorFacet: mint, publicFacet: issuer } = /**
-   * @type {{
-   *   creatorFacet: ERef<Mint<'nat'>>;
-   *   publicFacet: ERef<Issuer<'nat'>>;
-   * }}
-   */ (
-    await E(startUpgradable)({
-      installation: mintHolder,
-      label: keyword,
-      terms,
-    })
-  );
+  /** @type {{ creatorFacet: ERef<Mint<'nat'>>, publicFacet: ERef<Issuer<'nat'>> }} */
+  // @ts-expect-error cast
+  const { creatorFacet: mint, publicFacet: issuer } = await E(startUpgradable)({
+    installation: mintHolder,
+    label: keyword,
+    terms,
+  });
 
   const brand = await E(issuer).getBrand();
   const kit = harden({ mint, issuer, brand });
@@ -371,25 +363,23 @@ export const makeAnchorAsset = async (
     slotToBoardRemote,
   );
   const metricsKey = `${stablePsmKey}.${keyword}.metrics`;
-  const maybeReviveMetrics = async () => {
-    if (!toSlotReviver.has(metricsKey)) {
-      return;
-    }
+  if (toSlotReviver.has(metricsKey)) {
     const metrics = toSlotReviver.getItem(metricsKey);
     produceAnchorBalancePayments.resolve(
       makeScalarBigMapStore('Anchor balance payments', { durable: true }),
     );
     // XXX this rule should only apply to the 1st await
+    // eslint-disable-next-line @jessie.js/no-nested-await
     const anchorPaymentMap = await anchorBalancePayments;
 
     // TODO: validate that `metrics.anchorPoolBalance.value` is
     // pass-by-copy PureData (e.g., contains no remotables).
+    // eslint-disable-next-line @jessie.js/no-nested-await
     const pmt = await E(mint).mintPayment(
       AmountMath.make(brand, metrics.anchorPoolBalance.value),
     );
     anchorPaymentMap.init(brand, pmt);
-  };
-  await maybeReviveMetrics();
+  }
 
   await Promise.all([
     E(E(agoricNamesAdmin).lookupAdmin('issuer')).update(keyword, kit.issuer),