@agoric/cosmos 0.34.2-dev-3c8aafe.0 → 0.34.2-dev-74fbe43.0.74fbe43

package/cmd/agd/main.go

@@ -10,7 +10,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/cometbft/cometbft/libs/log"
+	"cosmossdk.io/log"
 	"github.com/spf13/cast"
 
 	gaia "github.com/Agoric/agoric-sdk/golang/cosmos/app"

package/cmd/libdaemon/main.go

@@ -17,7 +17,7 @@ import (
 	"path/filepath"
 	"runtime/debug"
 
-	log "github.com/cometbft/cometbft/libs/log"
+	"cosmossdk.io/log"
 
 	gaia "github.com/Agoric/agoric-sdk/golang/cosmos/app"
 	"github.com/Agoric/agoric-sdk/golang/cosmos/daemon"
@@ -38,7 +38,7 @@ type goReturn = struct {
 
 const SwingSetPort = 123
 
-var logger = log.NewTMLogger(log.NewSyncWriter(os.Stderr)).With("module", "cmd/libdaemon")
+var logger = log.NewLogger(os.Stderr).With("module", "cmd/libdaemon")
 
 var vmClientCodec *vm.ClientCodec
 var agdServer *vm.AgdServer

package/daemon/cmd/root.go

@@ -10,12 +10,15 @@ import (
 
 	serverconfig "github.com/cosmos/cosmos-sdk/server/config"
 
-	rosettaCmd "cosmossdk.io/tools/rosetta/cmd"
+	rosettaCmd "github.com/cosmos/rosetta/cmd"
 
-	dbm "github.com/cometbft/cometbft-db"
+	"cosmossdk.io/log"
+	"cosmossdk.io/simapp/params"
+	simdcmd "cosmossdk.io/simapp/simd/cmd"
+	confixcmd "cosmossdk.io/tools/confix/cmd"
 	tmcfg "github.com/cometbft/cometbft/config"
 	tmcli "github.com/cometbft/cometbft/libs/cli"
-	"github.com/cometbft/cometbft/libs/log"
+	dbm "github.com/cosmos/cosmos-db"
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/config"
 	"github.com/cosmos/cosmos-sdk/client/debug"
@@ -24,23 +27,32 @@ import (
 	"github.com/cosmos/cosmos-sdk/client/pruning"
 	"github.com/cosmos/cosmos-sdk/client/rpc"
 	"github.com/cosmos/cosmos-sdk/client/snapshot"
+	"github.com/cosmos/cosmos-sdk/codec/address"
 	"github.com/cosmos/cosmos-sdk/server"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
+	simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims"
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/types/module"
 	authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
 	"github.com/cosmos/cosmos-sdk/x/auth/types"
 	vestingcli "github.com/cosmos/cosmos-sdk/x/auth/vesting/client/cli"
 	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
+	"github.com/cosmos/cosmos-sdk/x/crisis"
 	genutilcli "github.com/cosmos/cosmos-sdk/x/genutil/client/cli"
 	"github.com/spf13/cast"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 
+	"github.com/cosmos/cosmos-sdk/types/tx/signing"
+	"github.com/cosmos/cosmos-sdk/x/auth/tx"
+	authtxconfig "github.com/cosmos/cosmos-sdk/x/auth/tx/config"
+
 	gaia "github.com/Agoric/agoric-sdk/golang/cosmos/app"
-	"github.com/Agoric/agoric-sdk/golang/cosmos/app/params"
+	"github.com/Agoric/agoric-sdk/golang/cosmos/app/txconfig"
 	"github.com/Agoric/agoric-sdk/golang/cosmos/vm"
 	swingset "github.com/Agoric/agoric-sdk/golang/cosmos/x/swingset"
 	swingsetkeeper "github.com/Agoric/agoric-sdk/golang/cosmos/x/swingset/keeper"
+	rosetta "github.com/cosmos/rosetta"
 )
 
 var AppName = "agd"
@@ -53,6 +65,7 @@ type CustomAppConfig struct {
 	// Swingset must be named as expected by swingset.DefaultConfigTemplate
 	// and must use a mapstructure key matching swingset.ConfigPrefix.
 	Swingset swingset.SwingsetConfig `mapstructure:"swingset"`
+	Rosetta  rosetta.Config          `mapstructure:"rosetta"`
 }
 
 type cobraRunE func(cmd *cobra.Command, args []string) error
@@ -75,9 +88,27 @@ func appendToPreRunE(cmd *cobra.Command, fn cobraRunE) {
 // NewRootCmd creates a new root command for simd. It is called once in the
 // main function.
 func NewRootCmd(sender vm.Sender) (*cobra.Command, params.EncodingConfig) {
-	encodingConfig := gaia.MakeEncodingConfig()
+	// we "pre"-instantiate the application for getting the injected/configured encoding configuration
+	// note, this is not necessary when using app wiring, as depinject can be directly used (see root_v2.go)
+
+	appOpts := make(simtestutil.AppOptionsMap, 0)
+	tempApp := gaia.NewSimApp(
+		log.NewNopLogger(),
+		dbm.NewMemDB(),
+		nil,
+		false, // we don't want to run the app, just get the encoding config
+		appOpts,
+	)
+
+	encodingConfig := params.EncodingConfig{
+		Codec:             tempApp.AppCodec(),
+		InterfaceRegistry: tempApp.InterfaceRegistry(),
+		TxConfig:          tempApp.GetTxConfig(),
+		Amino:             tempApp.LegacyAmino(),
+	}
+
 	initClientCtx := client.Context{}.
-		WithCodec(encodingConfig.Marshaler).
+		WithCodec(encodingConfig.Codec).
 		WithInterfaceRegistry(encodingConfig.InterfaceRegistry).
 		WithTxConfig(encodingConfig.TxConfig).
 		WithLegacyAmino(encodingConfig.Amino).
@@ -94,6 +125,7 @@ func NewRootCmd(sender vm.Sender) (*cobra.Command, params.EncodingConfig) {
 			cmd.SetOut(cmd.OutOrStdout())
 			cmd.SetErr(cmd.ErrOrStderr())
 
+			initClientCtx = initClientCtx.WithCmdContext(cmd.Context())
 			initClientCtx, err := client.ReadPersistentCommandFlags(initClientCtx, cmd.Flags())
 			if err != nil {
 				return err
@@ -104,22 +136,51 @@ func NewRootCmd(sender vm.Sender) (*cobra.Command, params.EncodingConfig) {
 				return err
 			}
 
+			// This needs to go after ReadFromClientConfig, as that function
+			// sets the RPC client needed for SIGN_MODE_TEXTUAL. This sign mode
+			// is only available if the client is online.
+			if !initClientCtx.Offline {
+				enabledSignModes := append(tx.DefaultSignModes, signing.SignMode_SIGN_MODE_TEXTUAL)
+				txConfigOpts := tx.ConfigOptions{
+					EnabledSignModes:           enabledSignModes,
+					TextualCoinMetadataQueryFn: authtxconfig.NewGRPCCoinMetadataQueryFn(initClientCtx),
+				}
+				txConfig, err := txconfig.NewTxConfigWithOptionsWithCustomEncoders(
+					initClientCtx.Codec,
+					txConfigOpts,
+				)
+				if err != nil {
+					return err
+				}
+
+				initClientCtx = initClientCtx.WithTxConfig(txConfig)
+			}
+
 			if err := client.SetCmdClientContextHandler(initClientCtx, cmd); err != nil {
 				return err
 			}
 
 			customAppTemplate, customAppConfig := initAppConfig()
-			customTMConfig := initTendermintConfig()
-			return server.InterceptConfigsPreRunHandler(cmd, customAppTemplate, customAppConfig, customTMConfig)
+			customCMTConfig := initCometBFTConfig()
+
+			return server.InterceptConfigsPreRunHandler(cmd, customAppTemplate, customAppConfig, customCMTConfig)
 		},
 	}
 
-	initRootCmd(sender, rootCmd, encodingConfig)
+	initRootCmd(sender, rootCmd, encodingConfig, tempApp.BasicModuleManager)
+
+	// add keyring to autocli opts
+	autoCliOpts := tempApp.AutoCliOpts()
+	autoCliOpts.ClientCtx = initClientCtx
+
+	if err := autoCliOpts.EnhanceRootCommand(rootCmd); err != nil {
+		panic(err)
+	}
 
 	return rootCmd, encodingConfig
 }
 
-func initTendermintConfig() *tmcfg.Config {
+func initCometBFTConfig() *tmcfg.Config {
 	cfg := tmcfg.DefaultConfig()
 	// customize config here
 	return cfg
@@ -149,7 +210,7 @@ func initAppConfig() (string, interface{}) {
 	return customAppTemplate, customAppConfig
 }
 
-func initRootCmd(sender vm.Sender, rootCmd *cobra.Command, encodingConfig params.EncodingConfig) {
+func initRootCmd(sender vm.Sender, rootCmd *cobra.Command, encodingConfig params.EncodingConfig, basicManager module.BasicManager) {
 	cfg := sdk.GetConfig()
 	cfg.Seal()
 
@@ -160,12 +221,12 @@ func initRootCmd(sender vm.Sender, rootCmd *cobra.Command, encodingConfig params
 
 	genesisCmd := genutilcli.GenesisCoreCommand(
 		encodingConfig.TxConfig,
-		gaia.ModuleBasics,
+		basicManager,
 		gaia.DefaultNodeHome,
 	)
 
 	rootCmd.AddCommand(
-		genutilcli.InitCmd(gaia.ModuleBasics, gaia.DefaultNodeHome),
+		genutilcli.InitCmd(basicManager, gaia.DefaultNodeHome),
 		genesisCmd,
 	)
 	// Alias all the genesis commands to the top level as well.
@@ -174,14 +235,19 @@ func initRootCmd(sender vm.Sender, rootCmd *cobra.Command, encodingConfig params
 	)
 	rootCmd.AddCommand(
 		tmcli.NewCompletionCmd(rootCmd, true),
-		NewTestnetCmd(gaia.ModuleBasics, banktypes.GenesisBalancesIterator{}, AppName),
+		simdcmd.NewTestnetCmd(basicManager, banktypes.GenesisBalancesIterator{}, AppName),
 		debug.Cmd(),
-		config.Cmd(),
+		confixcmd.ConfigCommand(),
 		pruning.Cmd(ac.newSnapshotsApp, gaia.DefaultNodeHome),
 		snapshot.Cmd(ac.newSnapshotsApp),
 	)
 
-	server.AddCommands(rootCmd, gaia.DefaultNodeHome, ac.newApp, ac.appExport, addStartFlags)
+	server.AddCommandsWithStartCmdOptions(rootCmd, gaia.DefaultNodeHome, ac.newApp, ac.appExport, server.StartCmdOptions{
+		AddFlags: func(startCmd *cobra.Command) {
+			addStartFlags(startCmd)
+			crisis.AddModuleInitFlags(startCmd)
+		},
+	})
 
 	for _, command := range rootCmd.Commands() {
 		switch command.Name() {
@@ -219,14 +285,21 @@ func initRootCmd(sender vm.Sender, rootCmd *cobra.Command, encodingConfig params
 	}
 
 	// add keybase, auxiliary RPC, query, and tx child commands
+	qcmd := queryCommand()
+	tcmd := txCommand()
+
+	basicManager.AddQueryCommands(qcmd)
+	basicManager.AddTxCommands(tcmd)
 	rootCmd.AddCommand(
-		rpc.StatusCommand(),
-		queryCommand(),
-		txCommand(),
-		keys.Commands(gaia.DefaultNodeHome),
+		server.StatusCommand(),
+		qcmd,
+		tcmd,
+		keys.Commands(),
 	)
 	// add rosetta
-	rootCmd.AddCommand(rosettaCmd.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Marshaler))
+	rootCmd.AddCommand(
+		rosettaCmd.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Codec),
+	)
 }
 
 const (
@@ -266,16 +339,14 @@ func queryCommand() *cobra.Command {
 	}
 
 	cmd.AddCommand(
-		authcmd.GetAccountCmd(),
+		rpc.WaitTxCmd(),
 		rpc.ValidatorCommand(),
-		rpc.BlockCommand(),
+		server.QueryBlockCmd(),
 		authcmd.QueryTxsByEventsCmd(),
+		server.QueryBlocksCmd(),
 		authcmd.QueryTxCmd(),
 	)
 
-	gaia.ModuleBasics.AddQueryCommands(cmd)
-	cmd.PersistentFlags().String(flags.FlagChainID, "", "The network chain ID")
-
 	return cmd
 }
 
@@ -298,12 +369,10 @@ func txCommand() *cobra.Command {
 		authcmd.GetBroadcastCommand(),
 		authcmd.GetEncodeCommand(),
 		authcmd.GetDecodeCommand(),
-		authcmd.GetAuxToFeeCommand(),
 		flags.LineBreak,
-		vestingcli.GetTxCmd(),
+		vestingcli.GetTxCmd(address.NewBech32Codec(sdk.Bech32PrefixAccAddr)),
 	)
 
-	gaia.ModuleBasics.AddTxCommands(cmd)
 	cmd.PersistentFlags().String(flags.FlagChainID, "", "The network chain ID")
 
 	return cmd
@@ -506,7 +575,7 @@ func (ac appCreator) appExport(
 		appOpts,
 	)
 
-	if height != -1 {
+	if !loadLatest {
 		if err := gaiaApp.LoadHeight(height); err != nil {
 			return servertypes.ExportedApp{}, err
 		}

package/daemon/cmd/root_test.go

@@ -10,8 +10,8 @@ import (
 	"github.com/spf13/pflag"
 	"github.com/stretchr/testify/require"
 
-	dbm "github.com/cometbft/cometbft-db"
-	"github.com/cometbft/cometbft/libs/log"
+	"cosmossdk.io/log"
+	dbm "github.com/cosmos/cosmos-db"
 	"github.com/cosmos/cosmos-sdk/server"
 	svrcmd "github.com/cosmos/cosmos-sdk/server/cmd"
 	serverconfig "github.com/cosmos/cosmos-sdk/server/config"
@@ -39,10 +39,8 @@ func TestCLIFlags(t *testing.T) {
 	// handling should not be added in the Agoric app (most likely in root.go)
 	expectedFlagNames := map[string]interface{}{
 		"abci":                  "",
-		"abci-client-type":      "",
 		"address":               "",
 		"app-db-backend":        "",
-		"block_sync":            "",
 		"cpu-profile":           "",
 		"db_backend":            "",
 		"db_dir":                "",
@@ -53,7 +51,6 @@ func TestCLIFlags(t *testing.T) {
 		"home":                  "",
 		"iavl-cache-size":       "",
 		"iavl-disable-fastnode": "",
-		"iavl-lazy-loading":     "",
 		"index-events":          "",
 		"inter-block-cache":     "",
 		"inv-check-period":      "",
@@ -65,11 +62,13 @@ func TestCLIFlags(t *testing.T) {
 		"pruning":               "default",
 		"pruning-interval":      "",
 		"pruning-keep-recent":   "",
+		"query-gas-limit":       "",
+		"shutdown-grace":        "",
 		"trace":                 "",
 		"trace-store":           "",
 		"transport":             "",
 		"unsafe-skip-upgrades":  "",
-		"with-tendermint":       "",
+		"with-comet":            "",
 
 		"api.address":              "",
 		"api.enable":               "",
@@ -84,9 +83,7 @@ func TestCLIFlags(t *testing.T) {
 		"consensus.create_empty_blocks_interval": "",
 		"consensus.double_sign_check_height":     "",
 
-		"grpc-web.address":            "",
-		"grpc-web.enable":             "",
-		"grpc-web.enable-unsafe-cors": "",
+		"grpc-web.enable": "",
 
 		"grpc.address":           "",
 		"grpc.enable":            "",
@@ -109,27 +106,12 @@ func TestCLIFlags(t *testing.T) {
 		"rpc.pprof_laddr": "",
 		"rpc.unsafe":      "",
 
-		"rosetta.address":               "",
-		"rosetta.blockchain":            "",
-		"rosetta.denom-to-suggest":      "",
-		"rosetta.enable-fee-suggestion": "",
-		"rosetta.enable":                "",
-		"rosetta.gas-to-suggest":        "",
-		"rosetta.network":               "",
-		"rosetta.offline":               "",
-		"rosetta.retries":               "",
-
 		"state-sync.snapshot-interval":    "",
 		"state-sync.snapshot-keep-recent": "",
 
-		"store.streamers": "",
-
-		"streamers.file.fsync":              "",
-		"streamers.file.keys":               "",
-		"streamers.file.output-metadata":    "",
-		"streamers.file.prefix":             "",
-		"streamers.file.stop-node-on-error": "",
-		"streamers.file.write_dir":          "",
+		"streaming.abci.plugin":           "",
+		"streaming.abci.keys":             "",
+		"streaming.abci.stop-node-on-err": "",
 
 		"telemetry.enable-hostname-label":     "",
 		"telemetry.enable-hostname":           "",
@@ -138,6 +120,9 @@ func TestCLIFlags(t *testing.T) {
 		"telemetry.global-labels":             "",
 		"telemetry.prometheus-retention-time": "",
 		"telemetry.service-name":              "",
+		"telemetry.metrics-sink":              "",
+		"telemetry.datadog-hostname":          "",
+		"telemetry.statsd-addr":               "",
 	}
 	unknownFlagNames := []string{}
 	missingFlagNames := map[string]bool{}

package/daemon/main.go

@@ -7,7 +7,6 @@ import (
 	"os/signal"
 	"syscall"
 
-	"github.com/cosmos/cosmos-sdk/server"
 	svrcmd "github.com/cosmos/cosmos-sdk/server/cmd"
 
 	"github.com/Agoric/agoric-sdk/golang/cosmos/agoric"
@@ -46,13 +45,7 @@ func RunWithController(sendToController vm.Sender) {
 
 	rootCmd, _ := cmd.NewRootCmd(sendToController)
 	if err := svrcmd.Execute(rootCmd, "", app.DefaultNodeHome); err != nil {
-		switch e := err.(type) {
-		case server.ErrorCode:
-			os.Exit(e.Code)
-
-		default:
-			fmt.Fprintf(os.Stderr, "Error: %v\n", e)
-			os.Exit(1)
-		}
+		fmt.Fprintf(os.Stderr, "Error: %v\n", err)
+		os.Exit(1)
 	}
 }

package/git-revision.txt

@@ -1 +1 @@
-3c8aafe
+74fbe43