@aglyn/plugins-data 1.0.0-beta.234 → 1.0.0-beta.236

package/src/lib/components/host-datasets-card.component.js

@@ -40,6 +40,7 @@ import { DatasetRecordDialog } from "./dataset-record-dialog.component.js";
 import { datasetRecordFilter, planRecordQuery, recordColumn } from "./dataset-record-filter.js";
 import { coerceDocumentValues, datasetIntegrityUpdate, datasetValueToInput, effectiveDatasetModel, formatDatasetValue, modelFromFieldEntries, validateDocument } from "../model/dataset-models.js";
 import { fillRecordAddresses } from "../record-pages/record-pages.js";
+import { planReferenceFixups, referencingFieldIds, restrictedDeleteMessage } from "../model/dataset-record-delete-plan.js";
 import { datasetDisplayName, parseDatasetFieldEntries } from "../model/datasets.js";
 import { datasetTransferResourceKey } from "../transfer/dataset-transfer-key.js";
 /**
@@ -861,11 +862,7 @@ export function newDatasetSharingNote(siteOnly) {
        * is not consulted; only a server route could close that.
        */ for (const other of datasets){
                 const otherModel = effectiveDatasetModel(other);
-                const referencing = otherModel.order.filter((fieldId)=>{
-                    var _otherModel_fields_fieldId, _otherModel_fields_fieldId_reference, _otherModel_fields_fieldId1;
-                    return ((_otherModel_fields_fieldId = otherModel.fields[fieldId]) == null ? void 0 : _otherModel_fields_fieldId.type) === 'reference' && ((_otherModel_fields_fieldId1 = otherModel.fields[fieldId]) == null ? void 0 : (_otherModel_fields_fieldId_reference = _otherModel_fields_fieldId1.reference) == null ? void 0 : _otherModel_fields_fieldId_reference.datasetId) === selected.$id;
-                });
-                if (!referencing.length) continue;
+                if (!referencingFieldIds(otherModel, selected.$id).length) continue;
                 let snapshot;
                 try {
                     snapshot = await getDocs(query(collection(firestore, dataScope[0], dataScope[1], 'datasets', other.$id, 'records'), where('referencedIds', 'array-contains', record.$id)));
@@ -874,18 +871,16 @@ export function newDatasetSharingNote(siteOnly) {
                         variant: 'error'
                     });
                 }
-                const hits = snapshot.docs.filter((docSnapshot)=>referencing.some((fieldId)=>{
-                        var _docSnapshot_get;
-                        const stored = (_docSnapshot_get = docSnapshot.get('values')) == null ? void 0 : _docSnapshot_get[fieldId];
-                        return Array.isArray(stored) ? stored.includes(record.$id) : stored === record.$id;
-                    }));
-                if (!hits.length) continue;
-                const restricted = referencing.some((fieldId)=>{
-                    var _otherModel_fields_fieldId_reference, _otherModel_fields_fieldId;
-                    return ((_otherModel_fields_fieldId = otherModel.fields[fieldId]) == null ? void 0 : (_otherModel_fields_fieldId_reference = _otherModel_fields_fieldId.reference) == null ? void 0 : _otherModel_fields_fieldId_reference.onDelete) === 'restrict';
-                });
-                if (restricted) {
-                    return void enqueueSnackbar(`Cannot delete: referenced by ${hits.length} document` + `${hits.length === 1 ? '' : 's'} in "${datasetDisplayName(other)}"`, {
+                // The verdict is shared with `/api/orgs/datasets` `delete-record`
+                // (`planReferenceFixups`): the per-field test keeps the query EXACT,
+                // since `referencedIds` is the union across every reference field.
+                const plan = planReferenceFixups(otherModel, selected.$id, record.$id, snapshot.docs.map((docSnapshot)=>({
+                        id: docSnapshot.id,
+                        values: docSnapshot.get('values')
+                    })));
+                if (plan.kind === 'none') continue;
+                if (plan.kind === 'restricted') {
+                    return void enqueueSnackbar(restrictedDeleteMessage(plan.holders, datasetDisplayName(other)), {
                         variant: 'warning',
                         persist: false
                     });
@@ -893,22 +888,14 @@ export function newDatasetSharingNote(siteOnly) {
                 // Chunked under Firestore's 500-writes-per-batch cap. The query is no
                 // longer bounded by a page size, so the number of holders is whatever
                 // the collection really holds.
-                for(let start = 0; start < hits.length; start += 400){
+                for(let start = 0; start < plan.updates.length; start += 400){
                     const batch = writeBatch(firestore);
-                    for (const hit of hits.slice(start, start + 400)){
-                        var _hit_get;
-                        const values = _extends({}, (_hit_get = hit.get('values')) != null ? _hit_get : {});
-                        for (const fieldId of referencing){
-                            const stored = values[fieldId];
-                            if (Array.isArray(stored)) {
-                                values[fieldId] = stored.filter((id)=>id !== record.$id);
-                            } else if (stored === record.$id) {
-                                delete values[fieldId];
-                            }
-                        }
-                        batch.update(hit.ref, _extends({
-                            values
-                        }, datasetIntegrityUpdate(otherModel, values, deleteField())));
+                    for (const update of plan.updates.slice(start, start + 400)){
+                        const holder = snapshot.docs.find((docSnapshot)=>docSnapshot.id === update.id);
+                        if (!holder) continue;
+                        batch.update(holder.ref, _extends({
+                            values: update.values
+                        }, datasetIntegrityUpdate(otherModel, update.values, deleteField())));
                     }
                     await batch.commit();
                 }