@aglyn/plugins-crm 1.0.0-beta.221 → 1.0.0-beta.222

package/src/lib/server/contact-reports-to.js

@@ -0,0 +1,114 @@
+/**
+ * @license
+ * Copyright 2026 Aglyn LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */ import { CONTACT_FACETS_FIELD, contactFacetPath, readContactFacet } from "@aglyn/aglyn/app-utils/contacts";
+import { FieldValue } from "firebase-admin/firestore";
+/**
+ * A CONTACT'S REPORTS-TO (AGL-3515): Salesforce's Reports To, the person's
+ * manager, as another contact's id in the holder's facet.
+ *
+ * The pointer is per holder like the rest of the profile, so a chain is
+ * walked through ONE holder's facets: who reports to whom is one business's
+ * knowledge of an org chart, and another holder's guess at it is not part
+ * of this one's chain.
+ */ /** The longest chain a loop check walks — far past any real org chart. */ export const CONTACT_REPORTS_TO_DEPTH = 25;
+export const CONTACT_REPORTS_TO_SELF_REFUSAL = 'A contact cannot report to themselves.';
+export const CONTACT_REPORTS_TO_LOOP_REFUSAL = 'That would make a loop: the person picked already reports, through others, to this contact.';
+/**
+ * Whether making `contactId` report to `managerId` closes a loop: the
+ * manager's own chain, through `groupId`'s facets, reaches `contactId`.
+ * A chain longer than {@link CONTACT_REPORTS_TO_DEPTH} is treated as a loop,
+ * because a walk that cannot finish cannot prove there is none.
+ */ export async function contactReportsToLoops(read, contactId, managerId, groupId) {
+    let current = managerId;
+    const seen = new Set();
+    for(let step = 0; current && step < CONTACT_REPORTS_TO_DEPTH; step += 1){
+        if (current === contactId) return true;
+        // A loop above the contact that does not pass through it is someone
+        // else's to untangle, and does not stop this write.
+        if (seen.has(current)) return false;
+        seen.add(current);
+        const doc = await read(current);
+        if (!doc) return false;
+        current = readContactFacet(doc, groupId).reportsToContactId || undefined;
+    }
+    return Boolean(current);
+}
+/** A reader over one org's contacts that reads each document once. */ export function cachedContactReader(contacts) {
+    const cache = new Map();
+    return (contactId)=>{
+        let pending = cache.get(contactId);
+        if (!pending) {
+            pending = contacts.doc(contactId).get().then((snapshot)=>{
+                var _snapshot_data;
+                return snapshot.exists ? (_snapshot_data = snapshot.data()) != null ? _snapshot_data : {} : null;
+            });
+            cache.set(contactId, pending);
+        }
+        return pending;
+    };
+}
+/** How many pointing rows one pass reads and one batch writes. */ const PAGE = 400;
+/** A ceiling on passes per holder. */ const PASSES = 25;
+/**
+ * Every contact that reports to `from`, in any of `groupIds`' facets,
+ * pointed at `to` — or, with `to` null, cleared. A contact that would
+ * then report to itself is cleared instead. Answers how many pointers moved.
+ *
+ * Queried per holder, because the pointer lives at
+ * `facets.{groupId}.reportsToContactId` and a query names one path. Each
+ * failure is logged and the sweep goes on: a stale pointer is read as
+ * "nobody" by every surface, which is the safe way for one to be left.
+ */ export async function repointContactReportsTo(firestore, contacts, groupIds, from, to, label) {
+    let moved = 0;
+    for (const groupId of new Set(groupIds)){
+        if (!groupId) continue;
+        const path = contactFacetPath(groupId, 'reportsToContactId');
+        try {
+            for(let pass = 0; pass < PASSES; pass += 1){
+                const page = await contacts.where(path, '==', from).limit(PAGE).get();
+                if (page.empty) break;
+                const batch = firestore.batch();
+                for (const row of page.docs){
+                    batch.update(row.ref, {
+                        [path]: to && row.id !== to ? to : FieldValue.delete(),
+                        updatedAt: FieldValue.serverTimestamp()
+                    });
+                }
+                await batch.commit();
+                moved += page.size;
+                if (page.size < PAGE) break;
+            }
+        } catch (error) {
+            console.error(`${label}: reports-to sweep failed for a holder`, error);
+        }
+    }
+    return moved;
+}
+/** The holders a contact document carries a facet for — every facet a pointer at it can sit in. */ export function contactFacetHolders(contact) {
+    const facets = contact[CONTACT_FACETS_FIELD];
+    return facets && typeof facets === 'object' && !Array.isArray(facets) ? Object.keys(facets) : [];
+}
+/**
+ * Every reports-to in `groupIds`' facets that names `contactId`, cleared —
+ * a contact deleted, or let go by those holders (AGL-3537). A holder can
+ * point only at a contact it holds, so the holders of the removed record
+ * are every facet a pointer can sit in; the sweep is `repointContactReportsTo`
+ * to nobody, which logs a failure and goes on rather than failing the removal.
+ */ export function clearReportsToOf(firestore, contacts, groupIds, contactId) {
+    return repointContactReportsTo(firestore, contacts, groupIds, contactId, null, 'contact delete');
+}
+
+//# sourceMappingURL=contact-reports-to.js.map

package/src/lib/server/contact-reports-to.js.map

@@ -0,0 +1 @@
+{"version":3,"sources":["../../../../../../../libs/plugins/crm/src/lib/server/contact-reports-to.ts"],"sourcesContent":["/**\n * @license\n * Copyright 2026 Aglyn LLC\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *   http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n\nimport {\n  CONTACT_FACETS_FIELD,\n  contactFacetPath,\n  readContactFacet,\n} from '@aglyn/aglyn/app-utils/contacts'\nimport { FieldValue } from 'firebase-admin/firestore'\n\n/**\n * A CONTACT'S REPORTS-TO (AGL-3515): Salesforce's Reports To, the person's\n * manager, as another contact's id in the holder's facet.\n *\n * The pointer is per holder like the rest of the profile, so a chain is\n * walked through ONE holder's facets: who reports to whom is one business's\n * knowledge of an org chart, and another holder's guess at it is not part\n * of this one's chain.\n */\n\n/** The longest chain a loop check walks — far past any real org chart. */\nexport const CONTACT_REPORTS_TO_DEPTH = 25\n\nexport const CONTACT_REPORTS_TO_SELF_REFUSAL = 'A contact cannot report to themselves.'\n\nexport const CONTACT_REPORTS_TO_LOOP_REFUSAL =\n  'That would make a loop: the person picked already reports, through others, to this contact.'\n\n/** A contact document by id, or `null` when there is none. */\nexport type ContactReader = (contactId: string) => Promise<Record<string, unknown> | null>\n\n/**\n * Whether making `contactId` report to `managerId` closes a loop: the\n * manager's own chain, through `groupId`'s facets, reaches `contactId`.\n * A chain longer than {@link CONTACT_REPORTS_TO_DEPTH} is treated as a loop,\n * because a walk that cannot finish cannot prove there is none.\n */\nexport async function contactReportsToLoops(\n  read: ContactReader,\n  contactId: string,\n  managerId: string,\n  groupId: string,\n): Promise<boolean> {\n  let current: string | undefined = managerId\n  const seen = new Set<string>()\n  for (let step = 0; current && step < CONTACT_REPORTS_TO_DEPTH; step += 1) {\n    if (current === contactId) return true\n    // A loop above the contact that does not pass through it is someone\n    // else's to untangle, and does not stop this write.\n    if (seen.has(current)) return false\n    seen.add(current)\n    const doc = await read(current)\n    if (!doc) return false\n    current = readContactFacet(doc, groupId).reportsToContactId || undefined\n  }\n  return Boolean(current)\n}\n\n/** A reader over one org's contacts that reads each document once. */\nexport function cachedContactReader(\n  contacts: FirebaseFirestore.CollectionReference,\n): ContactReader {\n  const cache = new Map<string, Promise<Record<string, unknown> | null>>()\n  return (contactId) => {\n    let pending = cache.get(contactId)\n    if (!pending) {\n      pending = contacts\n        .doc(contactId)\n        .get()\n        .then((snapshot) =>\n          snapshot.exists ? ((snapshot.data() ?? {}) as Record<string, unknown>) : null,\n        )\n      cache.set(contactId, pending)\n    }\n    return pending\n  }\n}\n\n/** How many pointing rows one pass reads and one batch writes. */\nconst PAGE = 400\n/** A ceiling on passes per holder. */\nconst PASSES = 25\n\n/**\n * Every contact that reports to `from`, in any of `groupIds`' facets,\n * pointed at `to` — or, with `to` null, cleared. A contact that would\n * then report to itself is cleared instead. Answers how many pointers moved.\n *\n * Queried per holder, because the pointer lives at\n * `facets.{groupId}.reportsToContactId` and a query names one path. Each\n * failure is logged and the sweep goes on: a stale pointer is read as\n * \"nobody\" by every surface, which is the safe way for one to be left.\n */\nexport async function repointContactReportsTo(\n  firestore: FirebaseFirestore.Firestore,\n  contacts: FirebaseFirestore.CollectionReference,\n  groupIds: Iterable<string>,\n  from: string,\n  to: string | null,\n  label: string,\n): Promise<number> {\n  let moved = 0\n  for (const groupId of new Set(groupIds)) {\n    if (!groupId) continue\n    const path = contactFacetPath(groupId, 'reportsToContactId')\n    try {\n      for (let pass = 0; pass < PASSES; pass += 1) {\n        const page = await contacts.where(path, '==', from).limit(PAGE).get()\n        if (page.empty) break\n        const batch = firestore.batch()\n        for (const row of page.docs) {\n          batch.update(row.ref, {\n            [path]: to && row.id !== to ? to : FieldValue.delete(),\n            updatedAt: FieldValue.serverTimestamp(),\n          })\n        }\n        await batch.commit()\n        moved += page.size\n        if (page.size < PAGE) break\n      }\n    } catch (error) {\n      console.error(`${label}: reports-to sweep failed for a holder`, error)\n    }\n  }\n  return moved\n}\n\n/** The holders a contact document carries a facet for — every facet a pointer at it can sit in. */\nexport function contactFacetHolders(contact: Record<string, unknown>): string[] {\n  const facets = contact[CONTACT_FACETS_FIELD]\n  return facets && typeof facets === 'object' && !Array.isArray(facets) ? Object.keys(facets) : []\n}\n\n/**\n * Every reports-to in `groupIds`' facets that names `contactId`, cleared —\n * a contact deleted, or let go by those holders (AGL-3537). A holder can\n * point only at a contact it holds, so the holders of the removed record\n * are every facet a pointer can sit in; the sweep is `repointContactReportsTo`\n * to nobody, which logs a failure and goes on rather than failing the removal.\n */\nexport function clearReportsToOf(\n  firestore: FirebaseFirestore.Firestore,\n  contacts: FirebaseFirestore.CollectionReference,\n  groupIds: Iterable<string>,\n  contactId: string,\n): Promise<number> {\n  return repointContactReportsTo(firestore, contacts, groupIds, contactId, null, 'contact delete')\n}\n"],"names":["CONTACT_FACETS_FIELD","contactFacetPath","readContactFacet","FieldValue","CONTACT_REPORTS_TO_DEPTH","CONTACT_REPORTS_TO_SELF_REFUSAL","CONTACT_REPORTS_TO_LOOP_REFUSAL","contactReportsToLoops","read","contactId","managerId","groupId","current","seen","Set","step","has","add","doc","reportsToContactId","undefined","Boolean","cachedContactReader","contacts","cache","Map","pending","get","then","snapshot","exists","data","set","PAGE","PASSES","repointContactReportsTo","firestore","groupIds","from","to","label","moved","path","pass","page","where","limit","empty","batch","row","docs","update","ref","id","delete","updatedAt","serverTimestamp","commit","size","error","console","contactFacetHolders","contact","facets","Array","isArray","Object","keys","clearReportsToOf"],"mappings":"AAAA;;;;;;;;;;;;;;;CAeC,GAED,SACEA,oBAAoB,EACpBC,gBAAgB,EAChBC,gBAAgB,QACX,kCAAiC;AACxC,SAASC,UAAU,QAAQ,2BAA0B;AAErD;;;;;;;;CAQC,GAED,wEAAwE,GACxE,OAAO,MAAMC,2BAA2B,GAAE;AAE1C,OAAO,MAAMC,kCAAkC,yCAAwC;AAEvF,OAAO,MAAMC,kCACX,8FAA6F;AAK/F;;;;;CAKC,GACD,OAAO,eAAeC,sBACpBC,IAAmB,EACnBC,SAAiB,EACjBC,SAAiB,EACjBC,OAAe;IAEf,IAAIC,UAA8BF;IAClC,MAAMG,OAAO,IAAIC;IACjB,IAAK,IAAIC,OAAO,GAAGH,WAAWG,OAAOX,0BAA0BW,QAAQ,EAAG;QACxE,IAAIH,YAAYH,WAAW,OAAO;QAClC,oEAAoE;QACpE,oDAAoD;QACpD,IAAII,KAAKG,GAAG,CAACJ,UAAU,OAAO;QAC9BC,KAAKI,GAAG,CAACL;QACT,MAAMM,MAAM,MAAMV,KAAKI;QACvB,IAAI,CAACM,KAAK,OAAO;QACjBN,UAAUV,iBAAiBgB,KAAKP,SAASQ,kBAAkB,IAAIC;IACjE;IACA,OAAOC,QAAQT;AACjB;AAEA,oEAAoE,GACpE,OAAO,SAASU,oBACdC,QAA+C;IAE/C,MAAMC,QAAQ,IAAIC;IAClB,OAAO,CAAChB;QACN,IAAIiB,UAAUF,MAAMG,GAAG,CAAClB;QACxB,IAAI,CAACiB,SAAS;YACZA,UAAUH,SACPL,GAAG,CAACT,WACJkB,GAAG,GACHC,IAAI,CAAC,CAACC;oBACeA;uBAApBA,SAASC,MAAM,IAAKD,iBAAAA,SAASE,IAAI,cAAbF,iBAAmB,CAAC,IAAiC;;YAE7EL,MAAMQ,GAAG,CAACvB,WAAWiB;QACvB;QACA,OAAOA;IACT;AACF;AAEA,gEAAgE,GAChE,MAAMO,OAAO;AACb,oCAAoC,GACpC,MAAMC,SAAS;AAEf;;;;;;;;;CASC,GACD,OAAO,eAAeC,wBACpBC,SAAsC,EACtCb,QAA+C,EAC/Cc,QAA0B,EAC1BC,IAAY,EACZC,EAAiB,EACjBC,KAAa;IAEb,IAAIC,QAAQ;IACZ,KAAK,MAAM9B,WAAW,IAAIG,IAAIuB,UAAW;QACvC,IAAI,CAAC1B,SAAS;QACd,MAAM+B,OAAOzC,iBAAiBU,SAAS;QACvC,IAAI;YACF,IAAK,IAAIgC,OAAO,GAAGA,OAAOT,QAAQS,QAAQ,EAAG;gBAC3C,MAAMC,OAAO,MAAMrB,SAASsB,KAAK,CAACH,MAAM,MAAMJ,MAAMQ,KAAK,CAACb,MAAMN,GAAG;gBACnE,IAAIiB,KAAKG,KAAK,EAAE;gBAChB,MAAMC,QAAQZ,UAAUY,KAAK;gBAC7B,KAAK,MAAMC,OAAOL,KAAKM,IAAI,CAAE;oBAC3BF,MAAMG,MAAM,CAACF,IAAIG,GAAG,EAAE;wBACpB,CAACV,KAAK,EAAEH,MAAMU,IAAII,EAAE,KAAKd,KAAKA,KAAKpC,WAAWmD,MAAM;wBACpDC,WAAWpD,WAAWqD,eAAe;oBACvC;gBACF;gBACA,MAAMR,MAAMS,MAAM;gBAClBhB,SAASG,KAAKc,IAAI;gBAClB,IAAId,KAAKc,IAAI,GAAGzB,MAAM;YACxB;QACF,EAAE,OAAO0B,OAAO;YACdC,QAAQD,KAAK,CAAC,GAAGnB,MAAM,sCAAsC,CAAC,EAAEmB;QAClE;IACF;IACA,OAAOlB;AACT;AAEA,iGAAiG,GACjG,OAAO,SAASoB,oBAAoBC,OAAgC;IAClE,MAAMC,SAASD,OAAO,CAAC9D,qBAAqB;IAC5C,OAAO+D,UAAU,OAAOA,WAAW,YAAY,CAACC,MAAMC,OAAO,CAACF,UAAUG,OAAOC,IAAI,CAACJ,UAAU,EAAE;AAClG;AAEA;;;;;;CAMC,GACD,OAAO,SAASK,iBACdhC,SAAsC,EACtCb,QAA+C,EAC/Cc,QAA0B,EAC1B5B,SAAiB;IAEjB,OAAO0B,wBAAwBC,WAAWb,UAAUc,UAAU5B,WAAW,MAAM;AACjF"}

package/src/lib/server/contact-update.d.ts

@@ -69,8 +69,10 @@
  * company deleted in between cannot fail the save of the people at it — the
  * company page's live aggregate is what corrects a count that did not move.
  */
-import { type PluginApiHandler } from '@aglyn/aglyn/server';
+import { type ContactCompanyLinkPlan, type ContactCustomValue, type PluginApiHandler } from '@aglyn/aglyn/server';
 import { type ContactUpdateFields } from '../model/contact-update';
+/** The sentence a `name` that contradicts the holder's first and last names is refused with. */
+export declare const CONTACT_COMPOSED_NAME_REFUSAL = "This person's name is made of their first and last name \u2014 change those instead.";
 /**
  * The act a request is refused for on a plan without the CRM: the first
  * field it carries, in the order the route reads them. Every field is the
@@ -89,4 +91,43 @@ export declare function readContactUpdateFields(input: unknown): {
     ok: false;
     error: string;
 };
+/**
+ * Salesforce's standard contact fields (AGL-3515) a create may carry beside
+ * the identity — every one `upsertHostContact` writes into the capturing
+ * facet. The reports-to is not one: it names another record, which only
+ * this route checks the holder can see.
+ */
+export declare const CONTACT_CREATE_PROFILE_FIELDS: readonly ["salutation", "firstName", "lastName", "department", "mobilePhone", "homePhone", "otherPhone", "fax", "birthdate", "assistantName", "assistantPhone", "otherAddress", "doNotCall"];
+/**
+ * Those fields of a create's body, read by the same rules an update reads
+ * them with — or the sentence refusing one. A body naming none of them
+ * reads as no fields.
+ */
+export declare function readContactCreateProfile(body: Record<string, unknown>): {
+    ok: true;
+    fields: ContactUpdateFields;
+} | {
+    ok: false;
+    error: string;
+};
+/** One contact's planned write, and the company counts it moves. */
+export interface ContactWrite {
+    contactId: string;
+    ref: FirebaseFirestore.DocumentReference;
+    update: Record<string, unknown>;
+    counts: ContactCompanyLinkPlan['counts'];
+}
+/**
+ * One contact's update for one holder, or the sentence refusing the row.
+ * `update` is `null` when the document already says everything asked — a tag
+ * the row already carries, a link already made.
+ */
+export declare function contactPatch(contact: Record<string, unknown>, groupId: string, fields: ContactUpdateFields, custom: Record<string, ContactCustomValue> | undefined, linkedCompanyName: string): {
+    update: Record<string, unknown> | null;
+    counts: ContactCompanyLinkPlan['counts'];
+} | {
+    refused: string;
+};
+/** Each company's contacts count moved once, by the sum of what the written links moved. */
+export declare function settleCompanyCounts(companies: FirebaseFirestore.CollectionReference, writes: readonly ContactWrite[]): Promise<void>;
 export declare const crmContactUpdateHandler: PluginApiHandler;

package/src/lib/server/contact-update.js

@@ -68,7 +68,7 @@ import { _ as _extends } from "@swc/helpers/_/_extends";
  * link: summed per company and settled once the contacts are written, so a
  * company deleted in between cannot fail the save of the people at it — the
  * company page's live aggregate is what corrects a count that did not move.
- */ import { consentGroupForHost, CONTACT_FIELDS_MAX_PER_ORG, containerMembershipValue, contactContainerFieldPath, contactFacetPath, CRM_COLLECTIONS, CRM_LEAD_SOURCE_PICKLIST, CRM_MEDIA_IDS_FIELD, crmReadTokens, effectiveCrmLeadSourcePicklist, isOrgWideMember, judgeCrmLeadSource, normalizeAddress, normalizeCrmMediaIds, normalizeCrmPicklistLabel, normalizePhone, planContactCompanyLink, readContactCompanyLink, readContactFacet, readCrmCustomInput, visibleToTokens } from "@aglyn/aglyn/server";
+ */ import { composeContactName, CONTACT_BIRTHDATE_REFUSAL, CONTACT_EXTRA_PHONE_FIELDS, CONTACT_PHONE_FIELD_LABELS, consentGroupForHost, CONTACT_FIELDS_MAX_PER_ORG, containerMembershipValue, contactContainerFieldPath, contactFacetPath, CRM_COLLECTIONS, CRM_LEAD_SOURCE_PICKLIST, CRM_MEDIA_IDS_FIELD, CRM_SALUTATION_PICKLIST, crmReadTokens, effectiveCrmLeadSourcePicklist, isOrgWideMember, judgeCrmLeadSource, judgeCrmPicklistValue, normalizeAddress, normalizeContactBirthdate, normalizeCrmMediaIds, normalizeCrmPicklistLabel, normalizePhone, planContactCompanyLink, readContactCompanyLink, readContactFacet, readCrmCustomInput, visibleToTokens } from "@aglyn/aglyn/server";
 import { companyContactsCountFields, contactCompanyLinkFields, firebaseAdmin, resolveOrgMembership, restampCrmListFieldsOf } from "@aglyn/tenant-data-admin";
 import { FieldValue } from "firebase-admin/firestore";
 import { CONTACT_UPDATE_FIELDS, CRM_CONTACT_UPDATE_MAX } from "../model/contact-update.js";
@@ -77,12 +77,28 @@ import { readCrmRouteScope } from "./org-caller.js";
 import { crmSuiteRefusal } from "./suite-gate.js";
 import { authorizeCrmWriter, canReach } from "./task-routes.js";
 import { contactPrimaryGroup } from "../model/contact-holder.js";
+import { cachedContactReader, CONTACT_REPORTS_TO_LOOP_REFUSAL, CONTACT_REPORTS_TO_SELF_REFUSAL, contactReportsToLoops } from "./contact-reports-to.js";
+import { readCrmPicklist } from "./read-picklist.js";
 /** What the suite gate names for each field a request can carry. */ const SUITE_ACTS = {
     name: "Editing a contact's profile",
+    salutation: "Editing a contact's profile",
+    firstName: "Editing a contact's profile",
+    lastName: "Editing a contact's profile",
     phone: "Editing a contact's profile",
+    mobilePhone: "Editing a contact's profile",
+    homePhone: "Editing a contact's profile",
+    otherPhone: "Editing a contact's profile",
+    fax: "Editing a contact's profile",
     jobTitle: "Editing a contact's profile",
+    department: "Editing a contact's profile",
+    birthdate: "Editing a contact's profile",
+    assistantName: "Editing a contact's profile",
+    assistantPhone: "Editing a contact's profile",
+    reportsToContactId: "Editing a contact's profile",
     leadSource: "Editing a contact's profile",
     address: "Editing a contact's profile",
+    otherAddress: "Editing a contact's profile",
+    doNotCall: "Editing a contact's profile",
     notes: "Editing a contact's notes",
     tags: 'Tagging a contact',
     addTag: 'Tagging a contact',
@@ -94,6 +110,7 @@ import { contactPrimaryGroup } from "../model/contact-holder.js";
     custom: "Editing a contact's custom fields",
     mediaIds: 'Attaching files to a contact'
 };
+/** The sentence a `name` that contradicts the holder's first and last names is refused with. */ export const CONTACT_COMPOSED_NAME_REFUSAL = "This person's name is made of their first and last name — change those instead.";
 /** A contact read at the organization level that no site has captured. */ const NO_HOLDER_REFUSAL = 'No site holds this contact yet, so it has no profile to edit.';
 /**
  * The act a request is refused for on a plan without the CRM: the first
@@ -125,22 +142,66 @@ import { contactPrimaryGroup } from "../model/contact-holder.js";
     }
     const fields = {};
     if ('name' in raw) fields.name = typed(raw['name'], 120);
-    if ('phone' in raw) {
-        const text = typed(raw['phone'], 40);
+    for (const key of [
+        'phone',
+        ...CONTACT_EXTRA_PHONE_FIELDS
+    ]){
+        if (!(key in raw)) continue;
+        const text = typed(raw[key], 40);
         const phone = text ? normalizePhone(text) : '';
-        if (phone === null) return {
+        if (phone === null) {
+            return {
+                ok: false,
+                error: key === 'phone' ? CONTACT_PHONE_REFUSAL : `${CONTACT_PHONE_FIELD_LABELS[key]}: ${CONTACT_PHONE_REFUSAL}`
+            };
+        }
+        fields[key] = phone;
+    }
+    if ('jobTitle' in raw) fields.jobTitle = typed(raw['jobTitle'], 120);
+    // Held to the label's shape here and judged against the org's list by the
+    // handler, like the lead source (AGL-3515).
+    if ('salutation' in raw) fields.salutation = normalizeCrmPicklistLabel(raw['salutation']);
+    if ('firstName' in raw) fields.firstName = composeContactName(raw['firstName'], '');
+    if ('lastName' in raw) fields.lastName = composeContactName('', raw['lastName']);
+    if ('department' in raw) fields.department = typed(raw['department'], 120);
+    if ('assistantName' in raw) fields.assistantName = typed(raw['assistantName'], 120);
+    if ('birthdate' in raw) {
+        const birthdate = normalizeContactBirthdate(raw['birthdate']);
+        if (birthdate === null) return {
             ok: false,
-            error: CONTACT_PHONE_REFUSAL
+            error: CONTACT_BIRTHDATE_REFUSAL
         };
-        fields.phone = phone;
+        fields.birthdate = birthdate;
+    }
+    if ('reportsToContactId' in raw) {
+        const reportsTo = raw['reportsToContactId'] === null ? '' : typed(raw['reportsToContactId'], 200);
+        if (reportsTo.includes('/')) {
+            return {
+                ok: false,
+                error: 'The contact this person reports to could not be read.'
+            };
+        }
+        fields.reportsToContactId = reportsTo || null;
+    }
+    if ('doNotCall' in raw) {
+        if (typeof raw['doNotCall'] !== 'boolean') {
+            return {
+                ok: false,
+                error: 'Do not call must be true or false.'
+            };
+        }
+        fields.doNotCall = raw['doNotCall'];
     }
-    if ('jobTitle' in raw) fields.jobTitle = typed(raw['jobTitle'], 120);
     // Held to the label's shape here; judged against the org's list by the
     // handler, which alone can read it (AGL-3298).
     if ('leadSource' in raw) fields.leadSource = normalizeCrmPicklistLabel(raw['leadSource']);
-    if ('address' in raw) {
-        const address = raw['address'];
-        fields.address = address && typeof address === 'object' && !Array.isArray(address) ? normalizeAddress(address) : null;
+    for (const key of [
+        'address',
+        'otherAddress'
+    ]){
+        if (!(key in raw)) continue;
+        const address = raw[key];
+        fields[key] = address && typeof address === 'object' && !Array.isArray(address) ? normalizeAddress(address) : null;
     }
     if ('notes' in raw) fields.notes = String((_raw_notes = raw['notes']) != null ? _raw_notes : '').slice(0, CONTACT_NOTES_MAX);
     // One write may carry one transform per field, so the tags are replaced,
@@ -222,6 +283,41 @@ import { contactPrimaryGroup } from "../model/contact-holder.js";
         fields
     };
 }
+/**
+ * Salesforce's standard contact fields (AGL-3515) a create may carry beside
+ * the identity — every one `upsertHostContact` writes into the capturing
+ * facet. The reports-to is not one: it names another record, which only
+ * this route checks the holder can see.
+ */ export const CONTACT_CREATE_PROFILE_FIELDS = [
+    'salutation',
+    'firstName',
+    'lastName',
+    'department',
+    'mobilePhone',
+    'homePhone',
+    'otherPhone',
+    'fax',
+    'birthdate',
+    'assistantName',
+    'assistantPhone',
+    'otherAddress',
+    'doNotCall'
+];
+/**
+ * Those fields of a create's body, read by the same rules an update reads
+ * them with — or the sentence refusing one. A body naming none of them
+ * reads as no fields.
+ */ export function readContactCreateProfile(body) {
+    const given = Object.fromEntries(CONTACT_CREATE_PROFILE_FIELDS.filter((key)=>body[key] !== undefined).map((key)=>[
+            key,
+            body[key]
+        ]));
+    if (!Object.keys(given).length) return {
+        ok: true,
+        fields: {}
+    };
+    return readContactUpdateFields(given);
+}
 /** The ids a body names, deduplicated — or `null` when any is unreadable or there are too many. */ function readContactIds(value) {
     if (!Array.isArray(value) || !value.length || value.length > CRM_CONTACT_UPDATE_MAX) {
         return null;
@@ -250,27 +346,66 @@ const refused = (contactId, error)=>({
  * One contact's update for one holder, or the sentence refusing the row.
  * `update` is `null` when the document already says everything asked — a tag
  * the row already carries, a link already made.
- */ function contactPatch(contact, groupId, fields, custom, linkedCompanyName) {
-    var _readContactFacet_tags;
+ */ export function contactPatch(contact, groupId, fields, custom, linkedCompanyName) {
+    var _fields_firstName, _fields_lastName, _stored_tags;
     const path = (field)=>contactFacetPath(groupId, field);
     /** A text field as stored: the value, or the field's absence. */ const text = (value)=>value || FieldValue.delete();
     const update = {};
     let counts = [];
-    if (fields.name !== undefined) update[path('name')] = text(fields.name);
+    const stored = readContactFacet(contact, groupId);
+    /*
+   * THE NAME FOLLOWS THE FIRST AND LAST NAMES (AGL-3515). While the holder
+   * keeps either, the facet's `name` is their composition, written whenever
+   * either moves; a `name` sent beside them must agree, because a save that
+   * stored one and showed the other would read as a save that kept both.
+   * Both cleared leaves the name as it stands, unless one was sent.
+   */ const namesSent = fields.firstName !== undefined || fields.lastName !== undefined;
+    const composed = composeContactName((_fields_firstName = fields.firstName) != null ? _fields_firstName : stored.firstName, (_fields_lastName = fields.lastName) != null ? _fields_lastName : stored.lastName);
+    if (composed && fields.name !== undefined && fields.name !== composed) {
+        return {
+            refused: CONTACT_COMPOSED_NAME_REFUSAL
+        };
+    }
+    if (fields.firstName !== undefined) update[path('firstName')] = text(fields.firstName);
+    if (fields.lastName !== undefined) update[path('lastName')] = text(fields.lastName);
+    if (namesSent && composed) update[path('name')] = composed;
+    else if (fields.name !== undefined && !composed) update[path('name')] = text(fields.name);
+    if (fields.salutation !== undefined) update[path('salutation')] = text(fields.salutation);
     if (fields.phone !== undefined) {
         update[path('phone')] = text(fields.phone);
         // The search echo — see `HostContact.phone`.
         update['phone'] = text(fields.phone);
     }
+    for (const key of CONTACT_EXTRA_PHONE_FIELDS){
+        var _fields_key;
+        if (fields[key] !== undefined) update[path(key)] = text((_fields_key = fields[key]) != null ? _fields_key : '');
+    }
     if (fields.jobTitle !== undefined) update[path('jobTitle')] = text(fields.jobTitle);
+    if (fields.department !== undefined) update[path('department')] = text(fields.department);
+    if (fields.birthdate !== undefined) update[path('birthdate')] = text(fields.birthdate);
+    if (fields.assistantName !== undefined) {
+        update[path('assistantName')] = text(fields.assistantName);
+    }
+    if (fields.reportsToContactId !== undefined) {
+        var _fields_reportsToContactId;
+        update[path('reportsToContactId')] = text((_fields_reportsToContactId = fields.reportsToContactId) != null ? _fields_reportsToContactId : '');
+    }
+    if (fields.doNotCall !== undefined) {
+        // Stored only as `true` — see `ContactFacet.doNotCall`.
+        update[path('doNotCall')] = fields.doNotCall ? true : FieldValue.delete();
+    }
     if (fields.leadSource !== undefined) update[path('leadSource')] = text(fields.leadSource);
     if (fields.address !== undefined) {
         var _fields_address;
         update[path('address')] = (_fields_address = fields.address) != null ? _fields_address : FieldValue.delete();
     }
+    if (fields.otherAddress !== undefined) {
+        var _fields_otherAddress;
+        update[path('otherAddress')] = (_fields_otherAddress = fields.otherAddress) != null ? _fields_otherAddress : FieldValue.delete();
+    }
     if (fields.notes !== undefined) update[path('notes')] = fields.notes;
     if (fields.tags !== undefined) update[path('tags')] = fields.tags;
-    const held = ((_readContactFacet_tags = readContactFacet(contact, groupId).tags) != null ? _readContactFacet_tags : []).map((tag)=>String(tag).toLowerCase());
+    const held = ((_stored_tags = stored.tags) != null ? _stored_tags : []).map((tag)=>String(tag).toLowerCase());
     if (fields.addTag && !held.includes(fields.addTag)) {
         // The record page's cap, which a selection must not slip past.
         if (held.length >= CONTACT_TAGS_MAX) {
@@ -350,7 +485,7 @@ const refused = (contactId, error)=>({
     await restampCrmListFieldsOf(writes.filter((write)=>!failed.has(write.contactId)).map((write)=>write.ref), 'contacts');
     return failed;
 }
-/** Each company's contacts count moved once, by the sum of what the written links moved. */ async function settleCompanyCounts(companies, writes) {
+/** Each company's contacts count moved once, by the sum of what the written links moved. */ export async function settleCompanyCounts(companies, writes) {
     const deltas = new Map();
     for (const write of writes){
         for (const count of write.counts){
@@ -438,6 +573,8 @@ export const crmContactUpdateHandler = async (req, res)=>{
      * Judged per contact below, because a contact keeps the value it
      * already holds even when the list has since deactivated it.
      */ const leadSources = fields.leadSource ? effectiveCrmLeadSourcePicklist((await orgRef.collection(CRM_COLLECTIONS.picklists).doc(CRM_LEAD_SOURCE_PICKLIST).get()).data()) : null;
+        // The org's salutations (AGL-3515), judged per contact like the lead source.
+        const salutations = fields.salutation ? await readCrmPicklist(firestore, writer.orgId, CRM_SALUTATION_PICKLIST) : null;
         if (fields.ownerUid) {
             const owner = await resolveOrgMembership(fields.ownerUid, writer.orgId).catch(()=>null);
             if (!(owner == null ? void 0 : owner.member)) {
@@ -463,9 +600,24 @@ export const crmContactUpdateHandler = async (req, res)=>{
             linkedCompanyName = typed(company.get('name'), 120);
         }
         const contacts = orgRef.collection('contacts');
+        const readContact = cachedContactReader(contacts);
+        // The manager a reports-to names has to be a contact the caller and the
+        // site can see, for the company link's reason (AGL-3515).
+        if (fields.reportsToContactId) {
+            const manager = await contacts.doc(fields.reportsToContactId).get();
+            const tokens = manager.exists ? manager.get('visibleTo') : undefined;
+            const visible = manager.exists && canReach(writer, tokens) && (!siteTokens || visibleToTokens(tokens, siteTokens));
+            if (!visible) {
+                res.status(404).json({
+                    error: 'Unknown contact to report to'
+                });
+                return;
+            }
+        }
         const snapshots = await firestore.getAll(...contactIds.map((id)=>contacts.doc(id)));
         const outcomes = new Map();
         const writes = [];
+        const rows = [];
         snapshots.forEach((snapshot, index)=>{
             var _snapshot_data;
             const contactId = contactIds[index];
@@ -488,22 +640,51 @@ export const crmContactUpdateHandler = async (req, res)=>{
                 outcomes.set(contactId, refused(contactId, NO_HOLDER_REFUSAL));
                 return;
             }
+            rows.push({
+                contactId,
+                snapshot,
+                data,
+                groupId: group.groupId
+            });
+        });
+        for (const { contactId, snapshot, data, groupId } of rows){
+            if (fields.reportsToContactId) {
+                if (fields.reportsToContactId === contactId) {
+                    outcomes.set(contactId, refused(contactId, CONTACT_REPORTS_TO_SELF_REFUSAL));
+                    continue;
+                }
+                if (await contactReportsToLoops(readContact, contactId, fields.reportsToContactId, groupId)) {
+                    outcomes.set(contactId, refused(contactId, CONTACT_REPORTS_TO_LOOP_REFUSAL));
+                    continue;
+                }
+            }
             let rowFields = fields;
-            if (leadSources && fields.leadSource) {
+            if (salutations && fields.salutation) {
                 var _judged_value;
-                const judged = judgeCrmLeadSource(leadSources, fields.leadSource, readContactFacet(data, group.groupId).leadSource);
+                const judged = judgeCrmPicklistValue(CRM_SALUTATION_PICKLIST, salutations, fields.salutation, readContactFacet(data, groupId).salutation);
+                if (judged.ok === false) {
+                    outcomes.set(contactId, refused(contactId, judged.error));
+                    continue;
+                }
+                rowFields = _extends({}, rowFields, {
+                    salutation: (_judged_value = judged.value) != null ? _judged_value : ''
+                });
+            }
+            if (leadSources && fields.leadSource) {
+                var _judged_value1;
+                const judged = judgeCrmLeadSource(leadSources, fields.leadSource, readContactFacet(data, groupId).leadSource);
                 if (judged.ok === false) {
                     outcomes.set(contactId, refused(contactId, judged.error));
-                    return;
+                    continue;
                 }
-                rowFields = _extends({}, fields, {
-                    leadSource: (_judged_value = judged.value) != null ? _judged_value : ''
+                rowFields = _extends({}, rowFields, {
+                    leadSource: (_judged_value1 = judged.value) != null ? _judged_value1 : ''
                 });
             }
-            const patch = contactPatch(data, group.groupId, rowFields, custom, linkedCompanyName);
+            const patch = contactPatch(data, groupId, rowFields, custom, linkedCompanyName);
             if ('refused' in patch) {
                 outcomes.set(contactId, refused(contactId, patch.refused));
-                return;
+                continue;
             }
             outcomes.set(contactId, {
                 contactId,
@@ -517,7 +698,7 @@ export const crmContactUpdateHandler = async (req, res)=>{
                     counts: patch.counts
                 });
             }
-        });
+        }
         const failed = await commitContactWrites(firestore, writes);
         for (const contactId of failed){
             outcomes.set(contactId, refused(contactId, 'The contact could not be saved.'));