@aglyn/aglyn 1.0.0 → 1.2.0

package/src/lib/app-utils/crm.js

@@ -121,26 +121,26 @@ export * from "./crm-kinds.js";
  * The field the per-record activity ceiling is counted on, or `null` for an
  * activity that names no record at all.
  *
- * The contact leads, then the company, then the deal: an activity logged
- * from a contact's page carries the company beside it (the automation step
- * copies the facet's `companyId` onto every record it creates), and a
+ * The contact leads, then the deal, then the company: every activity about
+ * a contact or a deal carries the company it rolls up to (AGL-4123), and a
  * ceiling counted on the company would let one busy account exhaust every
- * contact filed under it. The record whose PAGE the log is read on is the
- * one whose log has the limit. Shared by the client dialog and the two
+ * contact and deal filed under it. The record whose PAGE the log is read on
+ * is the one whose log has the limit, so a company's own entries are counted
+ * with everything that rolled up to it. Shared by the client dialog and the
  * server writers so they count the same thing.
  */ export function crmActivityCeilingLink(link) {
     if (link.contactId) return {
         field: 'contactId',
         id: String(link.contactId)
     };
-    if (link.companyId) return {
-        field: 'companyId',
-        id: String(link.companyId)
-    };
     if (link.dealId) return {
         field: 'dealId',
         id: String(link.dealId)
     };
+    if (link.companyId) return {
+        field: 'companyId',
+        id: String(link.companyId)
+    };
     // Last, because a converted lead's activities carry the contact beside it
     // and the contact is the record whose page they are read on.
     if (link.leadId) return {
@@ -518,7 +518,7 @@ export const CRM_TASK_KIND_LABELS = {
  * How a kind reads after a direction — "Inbound call", "Outbound WhatsApp
  * message". Its own map rather than the label lowercased, because a brand
  * keeps its capitals and a channel's name is not the thing that was sent.
- */ const CRM_ACTIVITY_KIND_NOUNS = {
+ */ export const CRM_ACTIVITY_KIND_NOUNS = {
     call: 'call',
     email: 'email',
     text: 'text message',
@@ -1641,13 +1641,25 @@ const blank = (value)=>value === null || typeof value === 'string' && value.trim
  * `crm.defaultRecordScope` when the org has set it. Before AGL-3662 the CRM
  * read the org's dataset default, `defaultResourceScope`, so an org that set
  * that to All sites keeps CRM records org-wide until it chooses separately.
- * Neither set reads `undefined`, which every caller treats as `'host'`.
+ *
+ * Neither set reads `'org'`: a record belongs to the whole organization, and
+ * the site it came in on is where it came from, not who may see it. Keeping
+ * each site's records apart is the choice an agency makes, so that one
+ * client's collaborator never sees another client's people — a setting it
+ * turns on, never a default the rest live with.
+ *
+ * `undefined` only when there is no org document to read — a surface whose
+ * org has not loaded yet. Every caller treats that as `'host'`, the site the
+ * record came in on: an org that keeps its sites apart must never have a
+ * record stamped for everyone because its document was a moment late, and
+ * a record kept to its site is still visible where it was made.
  */ export function crmDefaultScopeOf(orgDocument) {
-    const settings = (orgDocument != null ? orgDocument : {})[ORG_CRM_SETTINGS_FIELD];
+    if (!orgDocument || typeof orgDocument !== 'object') return undefined;
+    const settings = orgDocument[ORG_CRM_SETTINGS_FIELD];
     const own = settings && typeof settings === 'object' && !Array.isArray(settings) ? settings['defaultRecordScope'] : undefined;
     if (own === 'org' || own === 'host') return own;
-    const legacy = (orgDocument != null ? orgDocument : {})['defaultResourceScope'];
-    return legacy === 'org' || legacy === 'host' ? legacy : undefined;
+    const legacy = orgDocument['defaultResourceScope'];
+    return legacy === 'org' || legacy === 'host' ? legacy : 'org';
 }
 /**
  * Whether a capture from a work email domain no visible company carries
@@ -1879,16 +1891,19 @@ export function readCrmAssignmentSettings(orgDocument) {
  * The contact create path's own expression (`upsertHostContact`), lifted
  * here so that a company, a deal or a task created from a site's console
  * lands in exactly the scope a contact captured on that site would: the
- * whole org when the org's CRM default (`crmDefaultScopeOf`) is `'org'`, and
- * otherwise the sites that present as one sender — which, undeclared, is
- * this site alone. That is the agency's isolation, arrived at with nothing
- * configured, and the reason this is a function rather than a convention
- * eight creators are asked to remember.
+ * whole org when the org's CRM default (`crmDefaultScopeOf`) is `'org'` —
+ * which it is unless the org chose otherwise — and otherwise the sites that
+ * present as one sender, which, undeclared, is this site alone. That second
+ * answer is the agency's isolation, which it turns on in CRM → Settings, and
+ * the reason this is a function rather than a convention eight creators are
+ * asked to remember: a creator that spelled its own could stamp a kept-apart
+ * org's record for everyone.
  *
- * Widening past the group is an ACT — an org-wide member editing the scope
- * on the record — never a default. The rules refuse a scoped member creating
- * a record outside their own tokens, so a creator that bypassed this could
- * only make its record invisible to itself, never wider.
+ * Under a kept-apart org, widening past the group is an ACT — an org-wide
+ * member editing the scope on the record — never a default. The rules refuse
+ * a scoped member creating a record outside their own tokens, so a creator
+ * that bypassed this could only make its record invisible to itself, never
+ * wider.
  */ export function crmScopeTokens(org, group) {
     return crmDefaultScopeOf(org) === 'org' ? [
         ORG_SCOPE_TOKEN
@@ -2894,9 +2909,9 @@ export function isCrmPicklistObject(value) {
 };
 /**
  * Salesforce's Opportunity Contact Role (AGL-3521): the part a contact
- * plays on a deal. Plain; the label sits in each entry of the deal's
- * `contactRoles`, and `contactRoleKeys` lists their keys, which is how a
- * rename or a delete finds the deals to rewrite.
+ * plays on a deal, and on a company (AGL-4122). Plain; the label sits in each
+ * entry of the record's `contactRoles`, and `contactRoleKeys` lists their
+ * keys, which is how a rename or a delete finds the records to rewrite.
  */ const OPPORTUNITY_CONTACT_ROLE_DEFINITION = {
     id: 'opportunityContactRole',
     label: 'Contact role',
@@ -2947,6 +2962,12 @@ export function isCrmPicklistObject(value) {
             field: 'contactRoles',
             arrayKey: 'role',
             keyField: 'contactRoleKeys'
+        },
+        {
+            object: 'company',
+            field: 'contactRoles',
+            arrayKey: 'role',
+            keyField: 'contactRoleKeys'
         }
     ]
 };