@agility/plenum-ui 2.0.0-rc24 → 2.0.0-rc26

package/dist/types/stories/atoms/icons/DynamicIcon.d.ts

@@ -6,10 +6,10 @@ import { TablerIconName } from "./tablerIconNames";
 import { ClassNameWithAutocomplete } from "@/utils/types";
 export type IconName = keyof typeof SolidIcons | keyof typeof OutlineIcons;
 export type FAIconName = keyof typeof FA;
-export type UnifiedIconName = IconName | TablerIconName | FAIconName;
+export type UnifiedIconName = IconName | TablerIconName;
 export declare function isHeroIcon(name: UnifiedIconName): name is keyof typeof SolidIcons | keyof typeof OutlineIcons;
 export declare function isTablerIcon(name: UnifiedIconName): name is TablerIconName;
-export declare function isFAIcon(name: UnifiedIconName): name is keyof typeof FA;
+export declare function isFAIcon(name: UnifiedIconName): boolean;
 export declare function isUnifiedIconName(name: UnifiedIconName): name is UnifiedIconName;
 export interface IDynamicIconProps {
     icon: UnifiedIconName;

package/dist/types/stories/organisms/DropdownComponent/DropdownComponent.d.ts

@@ -1,4 +1,4 @@
-import React, { HTMLAttributes } from "react";
+import React from "react";
 import { Placement } from "@floating-ui/react";
 import { ClassNameWithAutocomplete } from "utils/types";
 import { IDynamicIconProps } from "@/stories/atoms/icons";
@@ -10,7 +10,7 @@ export interface IItemProp {
     isEmphasized?: boolean;
     key: React.Key;
 }
-export interface IDropdownProps extends HTMLAttributes<HTMLDivElement> {
+export interface IDropdownProps {
     items: IItemProp[][];
     label: string;
     CustomDropdownTrigger?: React.ReactNode;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@agility/plenum-ui",
-	"version": "2.0.0-rc24",
+	"version": "2.0.0-rc26",
 	"license": "MIT",
 	"main": "dist/index.js",
 	"module": "dist/index.js",

package/stories/atoms/icons/DynamicIcon.stories.ts

@@ -35,7 +35,7 @@ export const TablerIconOutline: Story = {
 }
 export const FAIcon: Story = {
 	args: {
-		icon: "FaGithub",
+		icon: "IconBrandGithub",
 		outline: true
 	}
 }

package/stories/atoms/icons/DynamicIcon.tsx

@@ -14,7 +14,7 @@ export type IconName = keyof typeof SolidIcons | keyof typeof OutlineIcons
 
 export type FAIconName = keyof typeof FA
 
-export type UnifiedIconName = IconName | TablerIconName | FAIconName
+export type UnifiedIconName = IconName | TablerIconName //HACK to eliminate some icons... | FAIconName
 
 export function isHeroIcon(name: UnifiedIconName): name is keyof typeof SolidIcons | keyof typeof OutlineIcons {
 	return name in SolidIcons || name in OutlineIcons
@@ -24,9 +24,15 @@ export function isTablerIcon(name: UnifiedIconName): name is TablerIconName {
 	return tablerIconNames.includes(name as TablerIconName)
 }
 
-export function isFAIcon(name: UnifiedIconName): name is keyof typeof FA {
-	return name in FA
+// export function isFAIcon(name: UnifiedIconName): name is keyof typeof FA {
+// 	return name in FA
+// }
+
+//HACK
+export function isFAIcon(name: UnifiedIconName) {
+	return false
 }
+
 export function isUnifiedIconName(name: UnifiedIconName): name is UnifiedIconName {
 	return isTablerIcon(name) || isFAIcon(name)
 }
@@ -50,6 +56,8 @@ export const DynamicIcon = ({
 		return <i {...{ ...props, className: "flex items-center justify-center" }}>{CustomSVG}</i>
 	}
 
+	const iconStr = icon as string
+
 	if (isTablerIcon(icon)) {
 		return (
 			<TablerIcon
@@ -63,18 +71,19 @@ export const DynamicIcon = ({
 			/>
 		)
 	}
-	if (isFAIcon(icon)) {
-		const Icon = FA[icon]
-		return (
-			<i {...{ ...props, className: "flex items-center justify-center" }}>
-				<Icon
-					className={cn(className, {
-						"h-5 w-5 text-gray-600": !className
-					})}
-				/>
-			</i>
-		)
-	}
+	//HACK
+	// if (isFAIcon(icon)) {
+	// 	const Icon = FA[icon]
+	// 	return (
+	// 		<i {...{ ...props, className: "flex items-center justify-center" }}>
+	// 			<Icon
+	// 				className={cn(className, {
+	// 					"h-5 w-5 text-gray-600": !className
+	// 				})}
+	// 			/>
+	// 		</i>
+	// 	)
+	// }
 	if (isHeroIcon(icon)) {
 		const Icon = outline ? OutlineIcons[icon] : SolidIcons[icon]
 		return (

package/stories/atoms/icons/IconWithShadow.stories.ts

@@ -35,7 +35,7 @@ export const TablerIconOutline: Story = {
 }
 export const FAIcon: Story = {
 	args: {
-		icon: "FaGithub",
+		icon: "IconBrandGithub",
 		outline: true
 	}
 }

package/stories/organisms/ButtonDropdown/ButtonDropdown.stories.tsx

@@ -12,13 +12,14 @@ const dropdownDataWithIcons: IItemProp[][] = [
 	[
 		{
 			icon: {
-				icon: "IconClipboardCopy"
+				icon: "IconCopy"
 
 				// className: "h-5 w-5",
 				// outline: false
 			},
+			iconPosition: "leading",
 			key: "Copy",
-			label: "Copy",
+			label: "Copy The Thing",
 			onClick: () => {
 				console.log("Copy action")
 			}
@@ -45,7 +46,7 @@ const dropdownDataWithIcons: IItemProp[][] = [
 				className: "h-5 w-5",
 				outline: false
 			},
-			iconPosition: "trailing",
+			iconPosition: "leading",
 			key: "View Batch",
 			label: "View Batch",
 			onClick: () => {

package/stories/organisms/DropdownComponent/DropdownComponent.tsx

@@ -20,7 +20,7 @@ import { ClassNameWithAutocomplete } from "utils/types"
 import { DynamicIcon, IDynamicIconProps, UnifiedIconName } from "@/stories/atoms/icons"
 
 export interface IItemProp {
-	//Don't think this needs to extaned HtmlButton... extends HTMLAttributes<HTMLButtonElement> {
+	//Don't think this needs to extend HtmlButton... extends HTMLAttributes<HTMLButtonElement> {
 	icon?: IDynamicIconProps
 	iconPosition?: "trailing" | "leading"
 	label: string
@@ -29,7 +29,8 @@ export interface IItemProp {
 	key: React.Key
 }
 
-export interface IDropdownProps extends HTMLAttributes<HTMLDivElement> {
+export interface IDropdownProps {
+	//this doesn't need to extend div... extends HTMLAttributes<HTMLDivElement> {
 	items: IItemProp[][]
 	label: string
 	CustomDropdownTrigger?: React.ReactNode

package/stories/organisms/DropdownComponent/dropdownItems.ts

@@ -10,7 +10,7 @@ export const dropdownDataBase: IItemProp[][] = [
 				// outline: false
 			},
 			key: "Copy",
-			label: "Copy",
+			label: "Copy to Clipboard",
 			onClick: () => {
 				console.log("Copy action")
 			}
@@ -66,13 +66,13 @@ export const dropdownDataWithIcons: IItemProp[][] = [
 	[
 		{
 			icon: {
-				icon: "IconClipboardCopy",
+				icon: "IconCopy",
 				className: "h-5 w-5",
 				outline: false
 			},
 			iconPosition: "leading",
 			key: "Copy",
-			label: "Copy",
+			label: "Copy Item",
 			onClick: () => {
 				console.log("Copy action")
 			}