@agilebot/eslint-plugin 0.3.13 → 0.4.0

package/dist/index.js

@@ -1,5 +1,5 @@
 /**
- * @license @agilebot/eslint-plugin v0.3.13
+ * @license @agilebot/eslint-plugin v0.4.0
  *
  * Copyright (c) Agilebot, Inc. and its affiliates.
  *
@@ -32,6 +32,9 @@ function _interopNamespaceDefault(e) {
 var fs__namespace = /*#__PURE__*/_interopNamespaceDefault(fs);
 var path__namespace = /*#__PURE__*/_interopNamespaceDefault(path);
 
+const rule = require('eslint-plugin-deprecation/dist/rules/deprecation')["default"];
+var deprecation = eslintUtils.fixupRule(rule);
+
 var enforceMuiIconAlias = eslintUtils.createESLintRule({
   meta: {
     type: 'problem',
@@ -674,15 +677,20 @@ var noThenCatchFinally = eslintUtils.createESLintRule({
   create(context) {
     const configuration = context.options[0] || {};
     const restrictedFunctions = configuration.restrictedFunctions || [];
-    function isTopLevelScoped() {
-      return context.getScope().block.type === 'Program';
+    const getScope = typeof context.getScope === 'function' ? () => {
+      return context.getScope();
+    } : node => {
+      return context.sourceCode.getScope(node);
+    };
+    function isTopLevelScoped(node) {
+      return getScope(node).block.type === 'Program';
     }
     function isThenCatchFinally(node) {
       return node.property && (node.property.name === 'then' || node.property.name === 'catch' || node.property.name === 'finally');
     }
     return {
       'CallExpression > MemberExpression.callee'(node) {
-        if (isTopLevelScoped()) {
+        if (isTopLevelScoped(node)) {
           return;
         }
         if (!isThenCatchFinally(node)) {
@@ -797,6 +805,16 @@ var reactBetterExhaustiveDeps = {
       }
       context.report(problem);
     }
+    const getSource = typeof context.getSource === 'function' ? node => {
+      return context.getSource(node);
+    } : node => {
+      return context.sourceCode.getText(node);
+    };
+    const getScope = typeof context.getScope === 'function' ? () => {
+      return context.getScope();
+    } : node => {
+      return context.sourceCode.getScope(node);
+    };
     const scopeManager = context.getSourceCode().scopeManager;
     const setStateCallSites = new WeakMap();
     const stateVariables = new WeakSet();
@@ -1099,7 +1117,7 @@ var reactBetterExhaustiveDeps = {
         staleAssignments.add(key);
         reportProblem({
           node: writeExpr,
-          message: "Assignments to the '".concat(key, "' variable from inside React Hook ") + "".concat(context.getSource(reactiveHook), " will be lost after each ") + "render. To preserve the value over time, store it in a useRef " + "Hook and keep the mutable value in the '.current' property. " + "Otherwise, you can move this variable directly inside " + "".concat(context.getSource(reactiveHook), ".")
+          message: "Assignments to the '".concat(key, "' variable from inside React Hook ") + "".concat(getSource(reactiveHook), " will be lost after each ") + "render. To preserve the value over time, store it in a useRef " + "Hook and keep the mutable value in the '.current' property. " + "Otherwise, you can move this variable directly inside " + "".concat(getSource(reactiveHook), ".")
         });
       }
       const stableDependencies = new Set();
@@ -1174,7 +1192,7 @@ var reactBetterExhaustiveDeps = {
       if (declaredDependenciesNode.type !== 'ArrayExpression') {
         reportProblem({
           node: declaredDependenciesNode,
-          message: "React Hook ".concat(context.getSource(reactiveHook), " was passed a ") + 'dependency list that is not an array literal. This means we ' + "can't statically verify whether you've passed the correct " + 'dependencies.'
+          message: "React Hook ".concat(getSource(reactiveHook), " was passed a ") + 'dependency list that is not an array literal. This means we ' + "can't statically verify whether you've passed the correct " + 'dependencies.'
         });
       } else {
         declaredDependenciesNode.elements.forEach(declaredDependencyNode => {
@@ -1184,7 +1202,7 @@ var reactBetterExhaustiveDeps = {
           if (declaredDependencyNode.type === 'SpreadElement') {
             reportProblem({
               node: declaredDependencyNode,
-              message: "React Hook ".concat(context.getSource(reactiveHook), " has a spread ") + "element in its dependency array. This means we can't " + "statically verify whether you've passed the " + 'correct dependencies.'
+              message: "React Hook ".concat(getSource(reactiveHook), " has a spread ") + "element in its dependency array. This means we can't " + "statically verify whether you've passed the " + 'correct dependencies.'
             });
             return;
           }
@@ -1208,7 +1226,7 @@ var reactBetterExhaustiveDeps = {
               } else {
                 reportProblem({
                   node: declaredDependencyNode,
-                  message: "React Hook ".concat(context.getSource(reactiveHook), " has a ") + "complex expression in the dependency array. " + 'Extract it to a separate variable so it can be statically checked.'
+                  message: "React Hook ".concat(getSource(reactiveHook), " has a ") + "complex expression in the dependency array. " + 'Extract it to a separate variable so it can be statically checked.'
                 });
               }
               return;
@@ -1368,7 +1386,7 @@ var reactBetterExhaustiveDeps = {
           }
         }
         if (isPropsOnlyUsedInMembers) {
-          extraWarning = " However, 'props' will change when *any* prop changes, so the " + "preferred fix is to destructure the 'props' object outside of " + "the ".concat(reactiveHookName, " call and refer to those specific props ") + "inside ".concat(context.getSource(reactiveHook), ".");
+          extraWarning = " However, 'props' will change when *any* prop changes, so the " + "preferred fix is to destructure the 'props' object outside of " + "the ".concat(reactiveHookName, " call and refer to those specific props ") + "inside ".concat(getSource(reactiveHook), ".");
         }
       }
       if (!extraWarning && missingDependencies.size > 0) {
@@ -1474,7 +1492,7 @@ var reactBetterExhaustiveDeps = {
       }
       reportProblem({
         node: declaredDependenciesNode,
-        message: "React Hook ".concat(context.getSource(reactiveHook), " has ") + (
+        message: "React Hook ".concat(getSource(reactiveHook), " has ") + (
         getWarningMessage(missingDependencies, 'a', 'missing', 'include') || getWarningMessage(unnecessaryDependencies, 'an', 'unnecessary', 'exclude') || getWarningMessage(duplicateDependencies, 'a', 'duplicate', 'omit')) + extraWarning,
         suggest: [{
           desc: "Update the dependencies array to be: [".concat(suggestedDeps.map(element => formatDependency(element)).join(', '), "]"),
@@ -1522,7 +1540,7 @@ var reactBetterExhaustiveDeps = {
           if (declaredDependenciesNode.elements && declaredDependenciesNode.elements.some(el => el && el.type === 'Identifier' && el.name === callback.name)) {
             return;
           }
-          const variable = context.getScope().set.get(callback.name);
+          const variable = getScope(callback).set.get(callback.name);
           if (variable == null || variable.defs == null) {
             return;
           }
@@ -2713,6 +2731,24 @@ var varNaming = eslintUtils.createESLintRule({
               name: fnName
             });
           }
+        } else if (node.id && node.init && node.init.type === 'LogicalExpression') {
+          const varName = node.id.name;
+          const parts = [node.init.left, node.init.right];
+          let partIsReactComponent = false;
+          for (const part of parts) {
+            if (['FunctionExpression', 'ArrowFunctionExpression'].includes(part.type)) {
+              const isReactComponent = checkJSXElement(part.body);
+              if (isReactComponent) {
+                partIsReactComponent = true;
+              }
+            }
+          }
+          if (!partIsReactComponent) {
+            validate('var', {
+              node,
+              name: varName
+            });
+          }
         } else if (node.id) {
           const varName = node.id.name;
           for (const excludeRegex of exclude) {
@@ -2755,6 +2791,7 @@ var varNaming = eslintUtils.createESLintRule({
 
 var ruleFiles = /*#__PURE__*/Object.freeze({
   __proto__: null,
+  rules_deprecation: deprecation,
   rules_enforce_mui_icon_alias: enforceMuiIconAlias,
   rules_import_monorepo: importMonorepo,
   rules_intl_id_missing: intlIdMissing,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agilebot/eslint-plugin",
-  "version": "0.3.13",
+  "version": "0.4.0",
   "description": "Agilebot's ESLint plugin",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -18,11 +18,12 @@
     "node": "^18.18.0 || >=20.0.0"
   },
   "dependencies": {
+    "eslint-plugin-deprecation": "^3.0.0",
     "eslint-plugin-react": "^7.35.0",
-    "@agilebot/eslint-utils": "0.3.13"
+    "@agilebot/eslint-utils": "0.4.0"
   },
   "peerDependencies": {
-    "eslint": "^7.0.0 || ^8.0.0"
+    "eslint": "^7.0.0 || ^8.0.0 || ^9.0.0"
   },
   "files": [
     "dist"
@@ -31,11 +32,11 @@
     "@types/color-name": "^1.1.4",
     "@types/estree": "^1.0.5",
     "color-name": "^2.0.0",
-    "eslint-vitest-rule-tester": "^0.3.3",
-    "typescript-eslint": "^7.16.0"
+    "eslint-vitest-rule-tester": "^0.6.1",
+    "typescript-eslint": "^8.0.0"
   },
   "scripts": {
     "build": "rollup -c rollup.config.mjs",
-    "lint": "eslint src --fix"
+    "lint": "eslint-agilebot src"
   }
 }