@agilebot/eslint-plugin 0.3.0 → 0.3.2

package/dist/index.d.ts

@@ -4,6 +4,8 @@ declare namespace _default {
         namespace recommended {
             export let plugins: string[];
             let rules_1: {
+                '@agilebot/no-unnecessary-template-literals': string;
+                '@agilebot/no-async-array-methods': string;
                 '@agilebot/react-prefer-named-property-access': string;
                 '@agilebot/react-hook-use-ref': string;
                 '@agilebot/react-prefer-sx-prop': string;
@@ -12,7 +14,6 @@ declare namespace _default {
                 '@agilebot/tss-class-naming': string;
                 '@agilebot/import-enforce-icon-alias': string;
                 '@agilebot/import-monorepo': string;
-                '@agilebot/stylistic-no-unnecessary-template-literals': string;
             };
             export { rules_1 as rules };
             export namespace settings {

package/dist/index.js

@@ -1,5 +1,5 @@
 /**
- * @license @agilebot/eslint-plugin v0.3.0
+ * @license @agilebot/eslint-plugin v0.3.2
  *
  * Copyright (c) Agilebot, Inc. and its affiliates.
  *
@@ -766,41 +766,6 @@ var unusedClasses = {
   }
 };
 
-var noUnnecessaryTemplateLiterals = {
-  meta: {
-    type: 'problem',
-    docs: {
-      description: 'Check if a template string contains only one ${}',
-      recommended: true
-    },
-    fixable: 'code',
-    schema: []
-  },
-  create(context) {
-    return {
-      TemplateLiteral(node) {
-        const code = context.sourceCode.getText(node);
-        if (
-          code.startsWith('`${') &&
-          code.endsWith('}`') &&
-          code.split('${').length === 2
-        ) {
-          context.report({
-            node,
-            message: 'Unnecessary template string with only one ${}.',
-            fix(fixer) {
-              return fixer.replaceText(
-                node,
-                code.substring(3, code.length - 2)
-              );
-            }
-          });
-        }
-      }
-    };
-  }
-};
-
 var betterExhaustiveDeps = {
   meta: {
     type: 'suggestion',
@@ -2532,6 +2497,91 @@ var preferSxProp = {
   }
 };
 
+var noAsyncArrayMethods = {
+  meta: {
+    docs: {
+      description:
+        'No async callback for Array methods forEach, map, filter, reduce, some, every, etc.',
+      category: 'Array',
+      recommended: true
+    },
+    fixable: undefined,
+    schema: []
+  },
+  create: function (context) {
+    return {
+      ExpressionStatement: function (node) {
+        const notAllowedArrayMethods = [
+          'forEach',
+          'filter',
+          'some',
+          'every',
+          'map',
+          'reduce',
+          'reduceRight',
+          'flatMap',
+          'find',
+          'findIndex',
+          'findLast',
+          'findLastIndex'
+        ];
+        const { callee } = node.expression;
+        if (!callee || !callee.property || !callee.property.name) {
+          return;
+        }
+        if (notAllowedArrayMethods.includes(callee.property.name)) {
+          const functionArguments = node.expression.arguments.find(n => {
+            return ['ArrowFunctionExpression', 'FunctionExpression'].includes(
+              n.type
+            );
+          });
+          if (functionArguments && functionArguments.async) {
+            context.report({
+              node,
+              message: `No async function in method '${callee.property.name}'`
+            });
+          }
+        }
+      }
+    };
+  }
+};
+
+var noUnnecessaryTemplateLiterals = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Check if a template string contains only one ${}',
+      recommended: true
+    },
+    fixable: 'code',
+    schema: []
+  },
+  create(context) {
+    return {
+      TemplateLiteral(node) {
+        const code = context.sourceCode.getText(node);
+        if (
+          code.startsWith('`${') &&
+          code.endsWith('}`') &&
+          code.split('${').length === 2
+        ) {
+          context.report({
+            node,
+            message: 'Unnecessary template string with only one ${}.',
+            fix(fixer) {
+              return fixer.replaceText(
+                node,
+                code.substring(3, code.length - 2)
+              );
+            }
+          });
+        }
+      }
+    };
+  }
+};
+
 var ruleFiles = /*#__PURE__*/Object.freeze({
   __proto__: null,
   rules_import_enforce_icon_alias: enforceIconAlias,
@@ -2544,15 +2594,16 @@ var ruleFiles = /*#__PURE__*/Object.freeze({
   rules_react_hook_use_ref: hookUseRef,
   rules_react_prefer_named_property_access: preferNamedPropertyAccess,
   rules_react_prefer_sx_prop: preferSxProp,
-  rules_stylistic_no_unnecessary_template_literals: noUnnecessaryTemplateLiterals,
   rules_tss_class_naming: classNaming,
   rules_tss_no_color_value: noColorValue,
-  rules_tss_unused_classes: unusedClasses
+  rules_tss_unused_classes: unusedClasses,
+  rules_unprefixed_no_async_array_methods: noAsyncArrayMethods,
+  rules_unprefixed_no_unnecessary_template_literals: noUnnecessaryTemplateLiterals
 });
 
 const rules = {};
 Object.keys(ruleFiles).forEach(key => {
-  const ruleKey = key.replace(/^rules_/, '');
+  const ruleKey = key.replace(/^rules_/, '').replace(/^unprefixed_/, '');
   const finalKey = ruleKey.replace(/_/g, '-');
   rules[finalKey] = ruleFiles[key];
 });
@@ -2562,6 +2613,8 @@ var index = {
     recommended: {
       plugins: ['@agilebot'],
       rules: {
+        '@agilebot/no-unnecessary-template-literals': 'error',
+        '@agilebot/no-async-array-methods': 'error',
         '@agilebot/react-prefer-named-property-access': 'error',
         '@agilebot/react-hook-use-ref': 'warn',
         '@agilebot/react-prefer-sx-prop': 'error',
@@ -2569,8 +2622,7 @@ var index = {
         '@agilebot/tss-no-color-value': 'error',
         '@agilebot/tss-class-naming': 'error',
         '@agilebot/import-enforce-icon-alias': 'error',
-        '@agilebot/import-monorepo': 'error',
-        '@agilebot/stylistic-no-unnecessary-template-literals': 'error'
+        '@agilebot/import-monorepo': 'error'
       },
       settings: {
         react: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agilebot/eslint-plugin",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "description": "Agilebot's ESLint plugin",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -20,7 +20,7 @@
   "dependencies": {
     "@typescript-eslint/utils": "~7.7.0",
     "eslint-plugin-react": "^7.34.1",
-    "@agilebot/eslint-utils": "0.3.0"
+    "@agilebot/eslint-utils": "0.3.2"
   },
   "peerDependencies": {
     "eslint": "^7.0.0 || ^8.0.0"