@agilebot/eslint-plugin 0.1.6 → 0.2.1

package/lib/index.js

@@ -24,26 +24,6 @@ module.exports.configs = {
   recommended: {
     plugins: ['@agilebot'],
     rules: {
-      'react-hooks/exhaustive-deps': 'off',
-      '@agilebot/react/better-exhaustive-deps': [
-        'warn',
-        {
-          checkMemoizedVariableIsStatic: true,
-          staticHooks: {
-            'useIpc.*': {
-              value: true,
-              regexp: true
-            },
-            useDialog: true,
-            useSnackbar: true,
-            useForm: true,
-            'use.*Store': {
-              value: true,
-              regexp: true
-            }
-          }
-        }
-      ],
       '@agilebot/react/prefer-named-property-access': 'error',
       '@agilebot/react/hook-use-ref': 'warn',
       '@agilebot/react/no-inline-styles': 'error',
@@ -53,6 +33,11 @@ module.exports.configs = {
       '@agilebot/import/enforce-icon-alias': 'error',
       '@agilebot/import/monorepo': 'error',
       '@agilebot/others/no-unnecessary-template-literals': 'error'
+    },
+    settings: {
+      react: {
+        version: '18.0.0'
+      }
     }
   }
 };

package/lib/rules/import/enforce-icon-alias.js

@@ -28,12 +28,11 @@ module.exports = {
             context.report({
               node,
               message: `Import for ${node.source.value} should be aliased.`,
-              fix: fixer => {
-                return fixer.replaceText(
+              fix: fixer =>
+                fixer.replaceText(
                   specifier,
                   `${specifier.imported.name} as ${specifier.imported.name}Icon`
-                );
-              }
+                )
             });
           }
         }

package/lib/rules/intl/id-missing.js

@@ -88,17 +88,23 @@ module.exports = {
     return {
       JSXIdentifier: function (node) {
         const attrNode = findFormattedMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       CallExpression: function (node) {
         const attrNode = findFormatMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       Property: function (node) {
         const attrNode =
           findAttrNodeInDefineMessages(node, 'id') ||
           findAttrNodeInDefineMessage(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       }
     };
   }

package/lib/rules/intl/id-prefix.js

@@ -80,17 +80,23 @@ module.exports = {
     return {
       JSXIdentifier: function (node) {
         const attrNode = findFormattedMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       CallExpression: function (node) {
         const attrNode = findFormatMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       Property: function (node) {
         const attrNode =
           findAttrNodeInDefineMessages(node, 'id') ||
           findAttrNodeInDefineMessage(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       }
     };
   }

package/lib/rules/intl/id-unused.js

@@ -93,17 +93,23 @@ module.exports = {
     return {
       JSXIdentifier: function (node) {
         const attrNode = findFormattedMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       CallExpression: function (node) {
         const attrNode = findFormatMessageAttrNode(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       Property: function (node) {
         const attrNode =
           findAttrNodeInDefineMessages(node, 'id') ||
           findAttrNodeInDefineMessage(node, 'id');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       'Program:exit': function () {
         // 将usedIdSet转为数组，然后与translatedIds取差集，即为未使用的id

package/lib/rules/intl/no-default.js

@@ -39,18 +39,24 @@ module.exports = {
     return {
       JSXIdentifier: function (node) {
         const attrNode = findFormattedMessageAttrNode(node, 'defaultMessage');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       CallExpression: function (node) {
         const attrNode = findFormatMessageAttrNode(node, 'defaultMessage');
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       },
       Property: function (node) {
         const attrNode =
           findAttrNodeInDefineMessages(node, 'defaultMessage') ||
           findAttrNodeInDefineMessage(node, 'defaultMessage');
 
-        if (attrNode) return processAttrNode(attrNode);
+        if (attrNode) {
+          return processAttrNode(attrNode);
+        }
       }
     };
   }

package/lib/rules/react/better-exhaustive-deps.js

@@ -326,7 +326,9 @@ module.exports = {
           // useMemo(() => { ... }, []) / useCallback((...) => { ... }, [])
           const hookArgs = callee.parent.arguments;
           // check it has dependency list
-          if (hookArgs.length < 2) return false;
+          if (hookArgs.length < 2) {
+            return false;
+          }
 
           const dependencies = hookArgs[1].elements;
           if (dependencies.length === 0) {

package/lib/rules/react/hook-use-ref.js

@@ -11,27 +11,25 @@ module.exports = {
     hasSuggestions: true
   },
 
-  create: Components.detect((context, component, util) => {
-    return {
-      CallExpression(node) {
-        const isImmediateReturn =
-          node.parent && node.parent.type === 'ReturnStatement';
+  create: Components.detect((context, component, util) => ({
+    CallExpression(node) {
+      const isImmediateReturn =
+        node.parent && node.parent.type === 'ReturnStatement';
 
-        if (isImmediateReturn || !util.isReactHookCall(node, ['useRef'])) {
-          return;
-        }
-        if (node.parent.id.type !== 'Identifier') {
-          return;
-        }
-        const variable = node.parent.id.name;
+      if (isImmediateReturn || !util.isReactHookCall(node, ['useRef'])) {
+        return;
+      }
+      if (node.parent.id.type !== 'Identifier') {
+        return;
+      }
+      const variable = node.parent.id.name;
 
-        if (!variable.endsWith('Ref')) {
-          context.report({
-            node: node,
-            message: 'useRef call is not end with "Ref"'
-          });
-        }
+      if (!variable.endsWith('Ref')) {
+        context.report({
+          node: node,
+          message: 'useRef call is not end with "Ref"'
+        });
       }
-    };
-  })
+    }
+  }))
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agilebot/eslint-plugin",
-  "version": "0.1.6",
+  "version": "0.2.1",
   "description": "Agilebot's ESLint plugin",
   "main": "lib",
   "license": "MIT",
@@ -18,7 +18,9 @@
   },
   "dependencies": {
     "@typescript-eslint/utils": "^7.6.0",
-    "fast-glob": "^3.3.2"
+    "eslint-plugin-react": "^7.34.1",
+    "fast-glob": "^3.3.2",
+    "@agilebot/eslint-utils": "0.2.1"
   },
   "peerDependencies": {
     "eslint": "^7.0.0 || ^8.0.0"