@agiflowai/scaffold-mcp 1.0.21 → 1.0.23

package/dist/{useScaffoldMethod-DlrzH-3H.mjs → claudeCode-lHW7zQ5G.mjs}

@@ -1,12 +1,169 @@
-import { t as ListScaffoldingMethodsTool } from "./ListScaffoldingMethodsTool-DjhhMWjh.mjs";
-import path from "node:path";
+import { t as ListScaffoldingMethodsTool } from "./ListScaffoldingMethodsTool-Cx-0gpV3.mjs";
+import "./tools-DtGTxmf-.mjs";
 import { ProjectFinderService, TemplatesManagerService } from "@agiflowai/aicode-utils";
+import path from "node:path";
 import fs from "node:fs/promises";
 import os from "node:os";
 import { DECISION_ALLOW, DECISION_DENY, DECISION_SKIP, ExecutionLogService } from "@agiflowai/hooks-adapter";
+import { execFileSync } from "node:child_process";
 
+//#region src/hooks/claudeCode/phantomCodeCheck.ts
+/**
+* PhantomCodeCheck Hook for Claude Code
+*
+* DESIGN PATTERNS:
+* - Class-based hook pattern: Encapsulates lifecycle hooks in a single class
+* - Fail-open pattern: Errors allow operation to proceed (return DECISION_SKIP)
+* - Marker-based detection: Scans for scaffold marker comments in code files
+*
+* CODING STANDARDS:
+* - Export a class with stop, userPromptSubmit, taskCompleted methods
+* - Handle all errors gracefully with fail-open behavior
+* - Use execFileSync with args array to avoid shell injection
+*
+* AVOID:
+* - Blocking operations on errors
+* - Shell injection via marker parameter
+* - Mutating context object
+*/
+const EXCLUDED_DIRS = [
+	"node_modules",
+	"dist",
+	".git",
+	".next",
+	"build",
+	"coverage",
+	".claude"
+];
+/**
+* PhantomCodeCheckHook — scans for unimplemented scaffold files containing marker comments.
+*
+* Checks at session boundaries (Stop, UserPromptSubmit, TaskCompleted) whether
+* any generated files still carry the `// <marker>` comment, indicating they
+* have not yet been implemented by the AI agent.
+*/
+var PhantomCodeCheckHook = class {
+	markerComment;
+	constructor(marker = "@scaffold-generated") {
+		this.markerComment = `// ${marker}`;
+	}
+	/**
+	* Scans cwd for files containing the scaffold marker comment.
+	* Returns relative file paths. Returns empty array on any error (fail-open).
+	*/
+	scanForPhantomFiles(cwd) {
+		try {
+			return execFileSync("grep", [
+				"-rl",
+				this.markerComment,
+				"--include=*.ts",
+				"--include=*.tsx",
+				"--include=*.js",
+				"--include=*.jsx",
+				...EXCLUDED_DIRS.map((dir) => `--exclude-dir=${dir}`),
+				"."
+			], {
+				cwd,
+				timeout: 1e4,
+				encoding: "utf8"
+			}).trim().split("\n").filter(Boolean).map((f) => f.replace(/^\.\//, ""));
+		} catch (error) {
+			if (error instanceof Error && "status" in error && error.status === 1) return [];
+			return [];
+		}
+	}
+	/**
+	* Stop hook — blocks session end if phantom files are found.
+	* Returns DECISION_DENY to prevent Claude from stopping with unimplemented files.
+	*/
+	async stop(context) {
+		try {
+			const phantomFiles = this.scanForPhantomFiles(context.cwd);
+			if (phantomFiles.length === 0) return {
+				decision: DECISION_SKIP,
+				message: "No phantom scaffold files found"
+			};
+			const fileList = phantomFiles.map((f) => `  - ${f}`).join("\n");
+			return {
+				decision: DECISION_DENY,
+				message: `⚠️ ${phantomFiles.length} scaffold file(s) still contain \`${this.markerComment}\` and have not been implemented:\n${fileList}\n\nPlease implement these files and remove the marker comment before ending the session.`
+			};
+		} catch {
+			return {
+				decision: DECISION_SKIP,
+				message: "PhantomCodeCheckHook.stop error — skipping"
+			};
+		}
+	}
+	/**
+	* UserPromptSubmit hook — warns about phantom files without blocking.
+	* Returns DECISION_ALLOW with userMessage written to stderr (visible to user, not LLM).
+	*/
+	async userPromptSubmit(context) {
+		try {
+			const phantomFiles = this.scanForPhantomFiles(context.cwd);
+			if (phantomFiles.length === 0) return {
+				decision: DECISION_SKIP,
+				message: "No phantom scaffold files found"
+			};
+			const fileList = phantomFiles.map((f) => `  - ${f}`).join("\n");
+			return {
+				decision: DECISION_ALLOW,
+				message: "",
+				userMessage: `⚠️ Reminder: ${phantomFiles.length} scaffold file(s) still contain \`${this.markerComment}\`:\n${fileList}\n\nPlease implement these files and remove the marker comment.`
+			};
+		} catch {
+			return {
+				decision: DECISION_SKIP,
+				message: "PhantomCodeCheckHook.userPromptSubmit error — skipping"
+			};
+		}
+	}
+	/**
+	* TaskCompleted hook — blocks task completion if phantom files are found.
+	* Returns DECISION_DENY with exitCode 2 to signal incomplete scaffolding.
+	*/
+	async taskCompleted(context) {
+		try {
+			const phantomFiles = this.scanForPhantomFiles(context.cwd);
+			if (phantomFiles.length === 0) return {
+				decision: DECISION_SKIP,
+				message: "No phantom scaffold files found"
+			};
+			const fileList = phantomFiles.map((f) => `  - ${f}`).join("\n");
+			return {
+				decision: DECISION_DENY,
+				exitCode: 2,
+				message: `⚠️ ${phantomFiles.length} scaffold file(s) still contain \`${this.markerComment}\` and have not been implemented:\n${fileList}\n\nTask cannot complete until all scaffold files are implemented.`
+			};
+		} catch {
+			return {
+				decision: DECISION_SKIP,
+				message: "PhantomCodeCheckHook.taskCompleted error — skipping"
+			};
+		}
+	}
+};
+
+//#endregion
 //#region src/hooks/claudeCode/useScaffoldMethod.ts
 /**
+* Type guard for ScaffoldMethodsResponse
+*/
+function isScaffoldMethodsResponse(value) {
+	if (typeof value !== "object" || value === null) return false;
+	if ("methods" in value && !Array.isArray(value.methods)) return false;
+	if ("nextCursor" in value && typeof value.nextCursor !== "string") return false;
+	return true;
+}
+/**
+* Type guard for PendingScaffoldLogEntry
+*/
+function isPendingScaffoldLogEntry(value) {
+	if (typeof value !== "object" || value === null) return false;
+	return "scaffoldId" in value && typeof value.scaffoldId === "string" && "generatedFiles" in value && Array.isArray(value.generatedFiles) && "projectPath" in value && typeof value.projectPath === "string";
+}
+/**
 * UseScaffoldMethod Hook class for Claude Code
 *
 * Provides lifecycle hooks for tool execution:
@@ -37,6 +194,17 @@ var UseScaffoldMethodHook = class {
 				decision: DECISION_SKIP,
 				message: "File is outside working directory - skipping scaffold method check"
 			};
+			let fileExists = false;
+			try {
+				await fs.access(absoluteFilePath);
+				fileExists = true;
+			} catch (accessErr) {
+				if (!(accessErr instanceof Error && "code" in accessErr && accessErr.code === "ENOENT")) throw accessErr;
+			}
+			if (fileExists) return {
+				decision: DECISION_SKIP,
+				message: "File already exists - skipping scaffold method check"
+			};
 			const executionLog = new ExecutionLogService(context.session_id);
 			if (await executionLog.hasExecuted({
 				filePath,
@@ -67,7 +235,12 @@ var UseScaffoldMethodHook = class {
 				decision: DECISION_SKIP,
 				message: "⚠️ Invalid response format from scaffolding methods tool"
 			};
-			const data = JSON.parse(resultText);
+			const parsed = JSON.parse(resultText);
+			if (!isScaffoldMethodsResponse(parsed)) return {
+				decision: DECISION_SKIP,
+				message: "⚠️ Unexpected response shape from scaffolding methods tool"
+			};
+			const data = parsed;
 			if (!data.methods || data.methods.length === 0) {
 				await executionLog.logExecution({
 					filePath,
@@ -79,19 +252,9 @@ var UseScaffoldMethodHook = class {
 					message: "No scaffolding methods are available for this project template. You should write new files directly using the Write tool."
 				};
 			}
-			let message = "🎯 **Scaffolding Methods Available**\\n\\n";
-			message += "Before writing new files, check if any of these scaffolding methods match your needs:\\n\\n";
-			for (const method of data.methods) {
-				message += `**${method.name}**\\n`;
-				message += `${method.instruction || method.description || "No description available"}\\n`;
-				if (method.variables_schema?.required && method.variables_schema.required.length > 0) message += `Required: ${method.variables_schema.required.join(", ")}\\n`;
-				message += "\\n";
-			}
-			if (data.nextCursor) message += `\\n_Note: More methods available. Use cursor "${data.nextCursor}" to see more._\\n\\n`;
-			message += "\\n**Instructions:**\\n";
-			message += "1. If one of these scaffold methods matches what you need to create, use the `use-scaffold-method` MCP tool instead of writing files manually\\n";
-			message += "2. If none of these methods are relevant to your task, proceed to write new files directly using the Write tool\\n";
-			message += "3. Using scaffold methods ensures consistency with project patterns and includes all necessary boilerplate\\n";
+			let message = "Before writing new files, use `use-scaffold-method` if any of these match your needs:\n\n";
+			for (const method of data.methods) message += `- **${method.name}**: ${method.description || "No description available"}\n`;
+			if (data.nextCursor) message += `\n_More methods available (cursor: "${data.nextCursor}")._\n`;
 			await executionLog.logExecution({
 				filePath,
 				operation: "list-scaffold-methods",
@@ -178,7 +341,7 @@ var UseScaffoldMethodHook = class {
 				};
 			}
 			if (isScaffoldedFile) {
-				const remainingFilesList = remainingFiles.map((f) => `  - ${f}`).join("\\n");
+				const remainingFilesList = remainingFiles.map((f) => `  - ${f}`).join("\n");
 				return {
 					decision: DECISION_ALLOW,
 					message: `
@@ -214,7 +377,8 @@ function extractScaffoldId(toolResult) {
 			if (match) return match[1];
 		}
 		return null;
-	} catch {
+	} catch (error) {
+		console.error("extractScaffoldId: failed to parse tool result:", error);
 		return null;
 	}
 }
@@ -222,28 +386,38 @@ function extractScaffoldId(toolResult) {
 * Helper function to get the last scaffold execution for a session
 */
 async function getLastScaffoldExecution(executionLog) {
-	const entries = await executionLog.loadLog();
-	for (let i = entries.length - 1; i >= 0; i--) {
-		const entry = entries[i];
-		if (entry.operation === "scaffold" && entry.scaffoldId && entry.generatedFiles && entry.generatedFiles.length > 0) return {
-			scaffoldId: entry.scaffoldId,
-			generatedFiles: entry.generatedFiles,
-			featureName: entry.featureName
-		};
+	try {
+		const entries = await executionLog.loadLog();
+		for (let i = entries.length - 1; i >= 0; i--) {
+			const entry = entries[i];
+			if (entry.operation === "scaffold" && entry.scaffoldId && entry.generatedFiles && entry.generatedFiles.length > 0) return {
+				scaffoldId: entry.scaffoldId,
+				generatedFiles: entry.generatedFiles,
+				featureName: entry.featureName
+			};
+		}
+		return null;
+	} catch (error) {
+		console.error("getLastScaffoldExecution: failed to load log:", error);
+		return null;
 	}
-	return null;
 }
 /**
 * Helper function to get list of edited scaffold files
 */
 async function getEditedScaffoldFiles(executionLog, scaffoldId) {
-	const entries = await executionLog.loadLog();
-	const editedFiles = [];
-	for (const entry of entries) if (entry.operation === "scaffold-file-edit" && entry.filePath.startsWith(`scaffold-edit-${scaffoldId}-`)) {
-		const filePath = entry.filePath.replace(`scaffold-edit-${scaffoldId}-`, "");
-		editedFiles.push(filePath);
+	try {
+		const entries = await executionLog.loadLog();
+		const editedFiles = [];
+		for (const entry of entries) if (entry.operation === "scaffold-file-edit" && entry.filePath.startsWith(`scaffold-edit-${scaffoldId}-`)) {
+			const filePath = entry.filePath.replace(`scaffold-edit-${scaffoldId}-`, "");
+			editedFiles.push(filePath);
+		}
+		return editedFiles;
+	} catch (error) {
+		console.error("getEditedScaffoldFiles: failed to load log:", error);
+		return [];
 	}
-	return editedFiles;
 }
 /**
 * Process pending scaffold logs from temp file and copy to ExecutionLogService
@@ -252,27 +426,33 @@ async function getEditedScaffoldFiles(executionLog, scaffoldId) {
 async function processPendingScaffoldLogs(sessionId, scaffoldId) {
 	const tempLogFile = path.join(os.tmpdir(), `scaffold-mcp-pending-${scaffoldId}.jsonl`);
 	try {
-		const lines = (await fs.readFile(tempLogFile, "utf-8")).trim().split("\\n").filter(Boolean);
+		const lines = (await fs.readFile(tempLogFile, "utf-8")).trim().split("\n").filter(Boolean);
 		const executionLog = new ExecutionLogService(sessionId);
 		try {
 			for (const line of lines) try {
-				const entry = JSON.parse(line);
+				const parsed = JSON.parse(line);
+				if (!isPendingScaffoldLogEntry(parsed)) {
+					console.error("processPendingScaffoldLogs: skipping malformed entry:", line);
+					continue;
+				}
 				await executionLog.logExecution({
-					filePath: `scaffold-${entry.scaffoldId}`,
+					filePath: `scaffold-${parsed.scaffoldId}`,
 					operation: "scaffold",
 					decision: DECISION_ALLOW,
-					generatedFiles: entry.generatedFiles,
-					scaffoldId: entry.scaffoldId,
-					projectPath: entry.projectPath,
-					featureName: entry.featureName
+					generatedFiles: parsed.generatedFiles,
+					scaffoldId: parsed.scaffoldId,
+					projectPath: parsed.projectPath,
+					featureName: parsed.featureName
 				});
 			} catch (parseError) {
-				console.error("Failed to parse pending scaffold log entry:", parseError);
+				console.error("processPendingScaffoldLogs: failed to parse line:", parseError);
 			}
 		} finally {
 			try {
 				await fs.unlink(tempLogFile);
-			} catch {}
+			} catch (unlinkError) {
+				if (!(unlinkError instanceof Error && "code" in unlinkError && unlinkError.code === "ENOENT")) console.error("processPendingScaffoldLogs: failed to delete temp log file:", unlinkError);
+			}
 		}
 	} catch (error) {
 		if (error instanceof Error && "code" in error && error.code !== "ENOENT") console.error("Error processing pending scaffold logs:", error);
@@ -280,4 +460,4 @@ async function processPendingScaffoldLogs(sessionId, scaffoldId) {
 }
 
 //#endregion
-export { UseScaffoldMethodHook };
+export { PhantomCodeCheckHook, UseScaffoldMethodHook };