@agfpd/iapeer 0.2.97 → 0.2.98

package/README.md

@@ -81,6 +81,7 @@ Planned, not yet built:
 - **More agent runtimes** — `opencode` and `antigravity`, two further CLI runtimes alongside Claude Code and Codex.
 - **Discord runtime** — a human-presence runtime for Discord, alongside Telegram.
 - **Permissions gate** — finer control over what an agent is allowed to do.
+- **Approve permissions over Telegram** — approve an agent's permission requests from the chat; today permissions are auto-allowed by flags.
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agfpd/iapeer",
-  "version": "0.2.97",
+  "version": "0.2.98",
   "description": "Foundation core for the iapeer multi-agent ecosystem: identity, registry, storage, codec.",
   "license": "Apache-2.0",
   "author": "agfpd",

package/src/cli/index.ts

@@ -63,8 +63,8 @@ import {
 } from '../identity/profileStandard.ts'
 import { runAlwaysOn } from '../launch/launchdRun.ts'
 import { ensureDaemonStarted, installDaemonPlist, startConfiguredDaemon } from '../daemon/main.ts'
-import { MARKETPLACE_NAME, onboardHost, tccFullDiskAccessNote } from '../onboard/index.ts'
-import { readMemoryProvider } from '../status/index.ts'
+import { MARKETPLACE_NAME, onboardHost, runtimeAuthNote, tccFullDiskAccessNote } from '../onboard/index.ts'
+import { probeFullDiskAccess, readMemoryProvider } from '../status/index.ts'
 import { appendLifecycleEvent } from '../lifecycle/eventlog.ts'
 import { pluginLogsDir } from '../storage/index.ts'
 
@@ -1096,9 +1096,22 @@ export async function runCli(argv: string[], env: NodeJS.ProcessEnv = process.en
         })
         const memLabel = mem.provider ? `${mem.provider.provider} ${mem.provider.version}` : 'none'
         out(`memory: ${mem.state}${mem.detail ? ` — ${mem.detail}` : ''} (slot: ${memLabel})\n`)
-        // macOS TCC advisory (manual grant — no flag/setting can): gated on a memory provider, since a
-        // vault (often an iCloud Obsidian dir) is the TCC-protected resource. Base ~/.iapeer needs none.
-        const tcc = tccFullDiskAccessNote({ memoryActive: mem.provider != null })
+        // Runtime auth readiness (clean-host prerequisite): a peer runs the runtime's
+        // interactive TUI; the launcher auto-clears first-run modals (theme/trust) but
+        // CANNOT complete a login OAuth flow. Warn for every INSTALLED runtime (marketplace
+        // state != runtime-missing) that has no positive auth evidence — before it ships a
+        // peer that would fail to wake on the login screen.
+        for (const m of r.marketplaces) {
+          if (m.state === 'runtime-missing') continue
+          const authNote = runtimeAuthNote(m.runtime, env)
+          if (authNote) errOut(authNote + '\n')
+        }
+        // macOS TCC advisory (manual grant — no flag/setting/script can): PROBE-DRIVEN, not
+        // memory-gated — a missing grant silently breaks file I/O (EPERM, no prompt/hang) on
+        // any TCC-protected path (iCloud vault, Documents/Desktop/Downloads peer cwd). Silent
+        // when granted / non-macOS / undeterminable.
+        const { iapeerBinPath } = await import('../install/index.ts')
+        const tcc = tccFullDiskAccessNote({ fda: probeFullDiskAccess(env), binPath: iapeerBinPath(env) })
         if (tcc) out(tcc)
         return daemonFailed || r.marketplaces.some(m => m.state === 'failed') || infraFailed ? 1 : 0
       }

package/src/launch/adapters/claude.ts

@@ -49,6 +49,12 @@ const CLAUDE_BOOT_DIALOG_MARKERS = [
   'I am using this for local development',
   'Resume from summary',
   'Resuming the full session',
+  // First-run theme picker ("Let's get started. Choose the text style…") — appears
+  // on a CLEAN host (fresh config dir) BEFORE the input prompt, verified live on
+  // claude 2.1.181 in a pty. NOT removed by --dangerously-skip-permissions; if not
+  // cleared the peer never reaches ready. (There is NO separate "accept dangerous
+  // permissions" screen in 2.1.181 — verified absent.)
+  'Choose the text style',
 ] as const
 
 function anyBootDialog(pane: string): boolean {
@@ -185,7 +191,16 @@ export const claudeAdapter: RuntimeAdapter = {
     if (
       pane.includes('trust this folder') ||
       pane.includes('Allow external CLAUDE.md file imports?') ||
-      pane.includes('I am using this for local development')
+      pane.includes('I am using this for local development') ||
+      // First-run theme picker (clean host): the default-highlighted row is always a
+      // valid theme (any choice is harmless for a headless peer), so a bare Enter
+      // accepts it. Without this the picker blocks the boot forever on a fresh host.
+      // NOTE: the LOGIN method picker that can follow on an UNAUTHENTICATED host is
+      // deliberately NOT auto-answered — selecting subscription opens a browser OAuth
+      // flow no headless peer can complete. Login is an onboard PREREQUISITE
+      // (ANTHROPIC_API_KEY or a one-time `claude login`); a never-authed host fails
+      // the wake LOUD at the boot deadline rather than auto-entering a dead OAuth.
+      pane.includes('Choose the text style')
     ) {
       return ['Enter']
     }

package/src/onboard/index.ts

@@ -12,7 +12,7 @@
 import { spawnSync } from 'child_process'
 import { homedir } from 'os'
 import { join } from 'path'
-import { accessSync, constants as FS } from 'fs'
+import { accessSync, constants as FS, existsSync, readFileSync } from 'fs'
 
 /** OUR marketplace — GitHub owner/repo, the source both runtimes' `marketplace add`
  *  takes; and the registered NAME both runtimes' `marketplace list` shows. */
@@ -216,23 +216,120 @@ export function onboardHost(opts: OnboardOptions = {}): OnboardResult {
 /**
  * macOS Full Disk Access (TCC) advisory printed at the END of onboard. The runtime permission layer
  * (`--add-dir` / `additionalDirectories` for claude, the sandbox flags for codex) governs what the
- * RUNTIME allows; macOS TCC is a SEPARATE OS layer that NO flag or settings key can grant — it is
- * user-granted in System Settings, by design. `~/.iapeer` lives under $HOME and is NOT TCC-protected,
- * so a BASE install needs nothing. The trigger that warrants the grant is a memory vault — commonly an
- * iCloud Obsidian dir, and iCloud Drive / Desktop / Documents / Downloads ARE TCC-protected — so the
- * note is GATED on a memory provider being present; a base ~/.iapeer-only host is never nagged.
- * Returns null when not applicable (caller prints nothing). Pure (no I/O) — unit-testable.
+ * RUNTIME allows; macOS TCC is a SEPARATE OS layer that NO flag, settings key, config, env var or
+ * script can grant — it is user-granted in System Settings, by design (the TCC db is SIP-protected).
+ *
+ * PROBE-DRIVEN, not memory-gated (was: gated on a memory provider). The advisory now fires off the
+ * REAL FDA state (`fda` from probeFullDiskAccess), because a missing grant is a latent fault no proxy
+ * captures: the DEFAULT memory vault is an iCloud Obsidian dir AND a peer work dir can itself sit in a
+ * protected location (Documents/Desktop/Downloads) with NO memory provider at all. So: grant present
+ * → silent; grant ABSENT on macOS → warn, every time.
+ *
+ * Failure mode is SILENT, not a hang: per Apple (DTS/Quinn, devforums 678819) a launchd-spawned CLI
+ * with no GUI front gets NO TCC dialog — the access is denied with EPERM. A peer therefore does NOT
+ * block; its file I/O on a protected path just silently fails. `~/.iapeer` (under $HOME) is NOT
+ * TCC-protected and needs nothing.
+ *
+ * Returns null when granted / undeterminable / non-macOS (`fda` true or null). Pure (no I/O) —
+ * the FDA probe and binPath are injected by the caller, so this stays unit-testable.
  */
-export function tccFullDiskAccessNote(opts: { memoryActive: boolean }): string | null {
-  if (!opts.memoryActive) return null
+export function tccFullDiskAccessNote(opts: { fda: boolean | null; binPath: string }): string | null {
+  if (opts.fda !== false) return null // granted, non-macOS, or undeterminable → nothing to nag
   return (
     [
-      'macOS Full Disk Access (manual — TCC cannot be set by any flag or settings key):',
-      '  ~/.iapeer needs none (it is under $HOME). BUT a memory vault or a peer work dir in a',
-      '  TCC-protected location (iCloud Drive, Desktop, Documents, Downloads — e.g. an iCloud',
-      '  Obsidian vault) does, or file tools silently fail to read/write there.',
-      '  Grant it to ~/.local/bin/iapeer (and to Terminal too, if you attach) in:',
+      'macOS Full Disk Access NOT granted (manual — TCC cannot be set by any flag, settings key or script):',
+      '  Without it, file I/O on TCC-protected paths SILENTLY FAILS with EPERM (no prompt, no hang) —',
+      '  a peer reading/writing an iCloud Obsidian vault (iCloud Drive / Desktop / Documents / Downloads)',
+      '  just gets denied. `~/.iapeer` itself is under $HOME and needs nothing.',
+      `  Grant it to ${opts.binPath} (and to Terminal too, if you attach) in:`,
       '    System Settings → Privacy & Security → Full Disk Access',
     ].join('\n') + '\n'
   )
 }
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Runtime auth readiness — the one CLEAN-HOST modal a launcher CANNOT auto-clear
+// ─────────────────────────────────────────────────────────────────────────────
+//
+// A headless peer runs the runtime's INTERACTIVE TUI (a pty), not `-p`. On a clean
+// host the first-run flow blocks on modals; the launcher auto-answers the ones it
+// recognizes (theme picker, folder-trust, …) — but the LOGIN screen cannot be
+// auto-answered (selecting subscription opens a browser OAuth flow no headless peer
+// can complete). So login is a PREREQUISITE: the host must be authenticated BEFORE
+// the first peer launches, or that peer's wake fails loud at the boot deadline.
+//
+// These probes are CONSERVATIVE: they return ready ONLY on positive evidence, so a
+// missing signal nags (one harmless advisory line) rather than letting an
+// unauthenticated host silently ship a peer that will fail to wake.
+
+/** Resolve claude's config dir (CLAUDE_CONFIG_DIR override, else ~/.claude). */
+function claudeConfigDir(env: NodeJS.ProcessEnv): string {
+  const override = env.CLAUDE_CONFIG_DIR?.trim()
+  if (override) return override
+  return join(env.HOME?.trim() || homedir(), '.claude')
+}
+
+/**
+ * True when claude is authenticated for a headless launch (won't block on the login
+ * picker). Positive evidence, in order: an auth env var; a completed onboarding +
+ * account in `~/.claude.json` (the subscription `claude login` path); or an
+ * `apiKeyHelper` in settings.json. Anything else → not ready (nag). Reads are
+ * env-rooted (HOME/CLAUDE_CONFIG_DIR) so a hermetic test isolates them.
+ */
+export function claudeAuthReady(env: NodeJS.ProcessEnv = process.env): boolean {
+  if (env.ANTHROPIC_API_KEY?.trim() || env.ANTHROPIC_AUTH_TOKEN?.trim() || env.CLAUDE_CODE_OAUTH_TOKEN?.trim()) {
+    return true
+  }
+  // `~/.claude.json` lives at HOME root (not inside the config dir) in the default
+  // layout the fleet uses; hasCompletedOnboarding + an account/key marker proves the
+  // first-run flow (theme + login) is done.
+  const statePath = join(env.HOME?.trim() || homedir(), '.claude.json')
+  try {
+    const j = JSON.parse(readFileSync(statePath, 'utf8')) as Record<string, unknown>
+    if (j.hasCompletedOnboarding === true && (j.oauthAccount != null || j.customApiKeyResponses != null)) return true
+  } catch {
+    /* absent/unreadable → fall through to settings */
+  }
+  try {
+    const s = JSON.parse(readFileSync(join(claudeConfigDir(env), 'settings.json'), 'utf8')) as Record<string, unknown>
+    if (typeof s.apiKeyHelper === 'string' && s.apiKeyHelper.trim()) return true
+  } catch {
+    /* no settings / no helper */
+  }
+  return false
+}
+
+/**
+ * True when codex is authenticated (won't block / error at startup). Positive
+ * evidence: `OPENAI_API_KEY` env, or an `auth.json` under $CODEX_HOME/~/.codex.
+ * Env-rooted for hermetic tests.
+ */
+export function codexAuthReady(env: NodeJS.ProcessEnv = process.env): boolean {
+  if (env.OPENAI_API_KEY?.trim()) return true
+  const codexHome = env.CODEX_HOME?.trim()
+  const authPath = codexHome
+    ? join(codexHome, 'auth.json')
+    : join(env.HOME?.trim() || homedir(), '.codex', 'auth.json')
+  return existsSync(authPath)
+}
+
+/**
+ * Advisory line for a runtime that is NOT authenticated (so the operator fixes it
+ * BEFORE launching peers). Returns null when the runtime is ready. Pure dispatch
+ * over the per-runtime probes above.
+ */
+export function runtimeAuthNote(runtime: OnboardRuntime, env: NodeJS.ProcessEnv = process.env): string | null {
+  if (runtime === 'claude') {
+    if (claudeAuthReady(env)) return null
+    return (
+      'claude: NOT authenticated — the first peer would block on the login screen (a launcher cannot\n' +
+      '  complete the browser OAuth flow). Before launching peers, either run `claude` once in your\n' +
+      '  terminal to sign in (subscription), or set ANTHROPIC_API_KEY in the daemon environment.'
+    )
+  }
+  if (codexAuthReady(env)) return null
+  return (
+    'codex: NOT authenticated — the first codex peer cannot reach the model. Before launching codex\n' +
+    '  peers, run `codex login` once (or set OPENAI_API_KEY in the daemon environment).'
+  )
+}