@agfpd/iapeer 0.2.74 → 0.2.75

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agfpd/iapeer",
-  "version": "0.2.74",
+  "version": "0.2.75",
   "description": "Foundation core for the iapeer multi-agent ecosystem: identity, registry, storage, codec.",
   "type": "module",
   "bin": {

package/src/transport/compactDone.test.ts

@@ -2,7 +2,14 @@ import { describe, expect, test } from 'bun:test'
 import { mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync, appendFileSync } from 'fs'
 import { tmpdir } from 'os'
 import { join } from 'path'
-import { compactDoneBaseline, compactTranscriptHasDone } from './index.ts'
+import { compactDoneBaseline, compactTranscriptHasDone, waitForCompactDone, type DeliveryTarget } from './index.ts'
+
+function claudeTarget(): DeliveryTarget {
+  return { runtime: 'claude', personality: 'tester', address: 'claude-tester', socketPath: '/tmp/iapeer-test-noop.sock' }
+}
+
+const CLAUDE_IDLE_PANE = '❯ \n bypass permissions on'
+const CLAUDE_BUSY_PANE = '· Compacting conversation… (esc to interrupt)\n  reloading context'
 
 function withHome(fn: (home: string, env: NodeJS.ProcessEnv) => void): void {
   const home = mkdtempSync(join(tmpdir(), 'iapeer-compact-gate-home-'))
@@ -58,3 +65,80 @@ describe('compact done transcript gate', () => {
     }
   }))
 })
+
+describe('waitForCompactDone — marker is authoritative, idle is a fast-path', () => {
+  function withClaudeMarker(
+    fn: (args: { cwd: string; env: NodeJS.ProcessEnv; writeMarker: () => void; baseline: ReturnType<typeof compactDoneBaseline> }) => void,
+  ): void {
+    withHome((home, env) => {
+      const cwd = mkdtempSync(join(tmpdir(), 'iapeer-compact-wait-cwd-'))
+      try {
+        const dir = join(home, '.claude', 'projects', claudeSlug(cwd))
+        mkdirSync(dir, { recursive: true })
+        const file = join(dir, 'session.jsonl')
+        writeFileSync(file, JSON.stringify({ type: 'user', message: { role: 'user', content: 'hi' } }) + '\n')
+        const baseline = compactDoneBaseline('claude', cwd, { env })
+        const writeMarker = () =>
+          appendFileSync(file, JSON.stringify({ type: 'system', subtype: 'compact_boundary', compactMetadata: { durationMs: 140708, preTokens: 535706, postTokens: 12524 } }) + '\n')
+        fn({ cwd, env, writeMarker, baseline })
+      } finally {
+        rmSync(cwd, { recursive: true, force: true })
+      }
+    })
+  }
+
+  // THE FIX: a large-context session that auto-continues into a working turn after compact
+  // keeps the composer busy (never idle). The marker proves completion → SUCCESS, not failure.
+  test('marker seen + composer never idle → success on the marker (signal: transcript)', () => withClaudeMarker(({ cwd, env, writeMarker, baseline }) => {
+    writeMarker()
+    const r = waitForCompactDone(claudeTarget(), cwd, baseline, {
+      env,
+      timeoutMs: 5000,
+      pollMs: 5,
+      graceMs: 20,
+      seam: { sessionAlive: () => true, capturePane: () => CLAUDE_BUSY_PANE },
+    })
+    expect(r.ok).toBe(true)
+    if (r.ok) expect(r.value.signal).toBe('transcript')
+  }))
+
+  // Clean common case unchanged: marker + idle composer → the historical 'transcript+ready'.
+  test('marker seen + composer idle → fast-path success (signal: transcript+ready)', () => withClaudeMarker(({ cwd, env, writeMarker, baseline }) => {
+    writeMarker()
+    const r = waitForCompactDone(claudeTarget(), cwd, baseline, {
+      env,
+      timeoutMs: 5000,
+      pollMs: 5,
+      graceMs: 5000,
+      seam: { sessionAlive: () => true, capturePane: () => CLAUDE_IDLE_PANE },
+    })
+    expect(r.ok).toBe(true)
+    if (r.ok) expect(r.value.signal).toBe('transcript+ready')
+  }))
+
+  // BOUNDARY preserved: no structured marker ever → honest failure (hung / never completed).
+  test('no marker → honest failure', () => withClaudeMarker(({ cwd, env, baseline }) => {
+    const r = waitForCompactDone(claudeTarget(), cwd, baseline, {
+      env,
+      timeoutMs: 40,
+      pollMs: 5,
+      graceMs: 20,
+      seam: { sessionAlive: () => true, capturePane: () => CLAUDE_BUSY_PANE },
+    })
+    expect(r.ok).toBe(false)
+    if (!r.ok) expect(r.error.message).toContain('no transcript compact marker')
+  }))
+
+  // Session death during the wait still fails (liveness boundary).
+  test('session vanished → failure', () => withClaudeMarker(({ cwd, env, baseline }) => {
+    const r = waitForCompactDone(claudeTarget(), cwd, baseline, {
+      env,
+      timeoutMs: 5000,
+      pollMs: 5,
+      graceMs: 20,
+      seam: { sessionAlive: () => false, capturePane: () => CLAUDE_BUSY_PANE },
+    })
+    expect(r.ok).toBe(false)
+    if (!r.ok) expect(r.error.message).toContain('session vanished')
+  }))
+})

package/src/transport/index.ts

@@ -603,7 +603,23 @@ export interface CompactDoneBaseline {
 export interface CompactDoneWaitResult {
   ok: true
   ms: number
-  signal: 'transcript+ready'
+  /** How completion was confirmed:
+   *   'transcript+ready' — marker seen AND the composer returned to idle (the clean,
+   *       common case: a small/medium compact that settles back to the prompt).
+   *   'transcript' — marker seen but the composer is still BUSY past the ready-grace
+   *       (a large-context session that auto-continues into a working turn right after
+   *       compact). The structured marker is the AUTHORITATIVE completion signal, so this
+   *       is SUCCESS, not a timeout. */
+  signal: 'transcript+ready' | 'transcript'
+}
+
+/** Test seam for waitForCompactDone — inject the tmux liveness + pane capture so the
+ *  marker/grace logic is covered hermetically (no live session). Omitting all = prod. */
+export interface CompactDoneWaitSeam {
+  /** Is the target session still alive? Default: the real tmux/host sessionAlive. */
+  sessionAlive?: (target: DeliveryTarget) => boolean
+  /** Capture the target pane; null = capture failed. Default: real tmux capture-pane. */
+  capturePane?: (target: DeliveryTarget) => string | null
 }
 
 function envHome(env: NodeJS.ProcessEnv | undefined): string {
@@ -763,41 +779,97 @@ function compactDonePollMs(env: NodeJS.ProcessEnv | undefined): number {
   return Number.isFinite(n) && n > 0 ? n : 1000
 }
 
+// Once the completion marker is seen, how long to keep PREFERRING the idle-composer
+// confirmation (the clean 'transcript+ready' signal) before reporting success on the
+// marker alone. A large-context session that auto-continues into a working turn never
+// goes idle — this bounds how long we wait for an idle that may never come, so the
+// busy case succeeds promptly instead of stalling to the overall deadline. Short by
+// design; the marker is already authoritative.
+function compactReadyGraceMs(env: NodeJS.ProcessEnv | undefined): number {
+  const raw = env?.IAPEER_COMPACT_READY_GRACE_MS
+  const n = raw === undefined ? NaN : Number(raw)
+  return Number.isFinite(n) && n >= 0 ? n : 5000
+}
+
 /**
  * Wait until a slash-/compact command has actually FINISHED, not merely until its
- * keystrokes were accepted. The primary signal is scroll-proof structured
- * transcript state written by the runtimes: Codex `context_compacted`, Claude
- * `compact_boundary`. The final input-ready check prevents a marker-only early
- * return while the TUI is still transitioning back to the composer/prompt.
+ * keystrokes were accepted. The AUTHORITATIVE signal is scroll-proof structured
+ * transcript state written by the runtimes at the END of the operation (with post-
+ * compact token metadata): Codex `context_compacted`, Claude `compact_boundary`.
+ * Once that marker is present the compact objectively completed.
+ *
+ * Idle-composer (`isInputReady`) is treated as a FAST-PATH confirmation, NOT a
+ * requirement. A healthy large-context session auto-continues into a working turn
+ * right after compact — its composer is legitimately busy (not idle) for a while, so
+ * requiring idle here false-failed a finished compact (live incident 15.06, boris:
+ * marker at 12:14:58, first post-compact idle only ~232s later, past the ~290s gate).
+ * Therefore: marker seen + composer idle → 'transcript+ready' (clean); marker seen +
+ * composer still busy past a short grace → 'transcript' (busy-but-done, still SUCCESS).
+ *
+ * BOUNDARY (preserved): a compact whose structured marker NEVER appears still fails
+ * honestly — that is the genuine "hung / never completed" case. Cross-runtime: the
+ * marker set + isInputReady are both per-adapter, so claude and codex share this path.
  */
 export function waitForCompactDone(
   target: DeliveryTarget,
   cwd: string,
   baseline: CompactDoneBaseline,
-  opts: { env?: NodeJS.ProcessEnv; timeoutMs?: number; pollMs?: number } = {},
+  opts: {
+    env?: NodeJS.ProcessEnv
+    timeoutMs?: number
+    pollMs?: number
+    graceMs?: number
+    seam?: CompactDoneWaitSeam
+  } = {},
 ): Result<CompactDoneWaitResult> {
   const env = opts.env ?? process.env
   const timeoutMs = opts.timeoutMs ?? compactDoneTimeoutMs(env)
   const pollMs = opts.pollMs ?? compactDonePollMs(env)
+  const graceMs = opts.graceMs ?? compactReadyGraceMs(env)
+  const aliveFn = opts.seam?.sessionAlive ?? ((t: DeliveryTarget) => sessionAlive(t.socketPath, t.address))
+  const captureFn =
+    opts.seam?.capturePane ??
+    ((t: DeliveryTarget) => {
+      const cap = tmux(t.socketPath, 'capture-pane', '-p', '-t', t.address)
+      return cap.ok ? cap.out : null
+    })
   const adapter = getAdapter(target.runtime)
   const started = monotonicMs()
   const deadline = started + timeoutMs
   let sawTranscriptDone = false
+  let markerSeenAtMs = -1
   let lastPane = ''
 
   do {
-    if (!sessionAlive(target.socketPath, target.address)) {
+    if (!aliveFn(target)) {
       return err(`compact did not complete: tmux session vanished`)
     }
-    sawTranscriptDone ||= compactTranscriptHasDone(baseline, { env })
-    const pane = tmux(target.socketPath, 'capture-pane', '-p', '-t', target.address)
-    if (pane.ok) lastPane = pane.out
-    if (sawTranscriptDone && pane.ok && adapter.isInputReady(pane.out)) {
-      return ok({ ok: true, ms: monotonicMs() - started, signal: 'transcript+ready' })
+    if (!sawTranscriptDone && compactTranscriptHasDone(baseline, { env })) {
+      sawTranscriptDone = true
+      markerSeenAtMs = monotonicMs()
+    }
+    const pane = captureFn(target)
+    if (pane !== null) lastPane = pane
+    if (sawTranscriptDone) {
+      // Fast clean path: the composer returned to idle (the historical signal).
+      if (pane !== null && adapter.isInputReady(pane)) {
+        return ok({ ok: true, ms: monotonicMs() - started, signal: 'transcript+ready' })
+      }
+      // Marker is authoritative: a busy composer after a held marker is a healthy
+      // auto-continue, not a failure. Succeed on the marker once the grace elapses.
+      if (monotonicMs() - markerSeenAtMs >= graceMs) {
+        return ok({ ok: true, ms: monotonicMs() - started, signal: 'transcript' })
+      }
     }
     sleepSync(pollMs)
   } while (monotonicMs() < deadline)
 
+  // Deadline hit. The marker is authoritative: if it was EVER seen, the compact did
+  // finish — a still-busy composer at the deadline is not a failure (succeed on the
+  // marker). Only a MISSING marker is an honest failure (hung / never-completed compact).
+  if (sawTranscriptDone) {
+    return ok({ ok: true, ms: monotonicMs() - started, signal: 'transcript' })
+  }
   const tail = lastPane
     .split(/\r?\n/)
     .map(line => line.trim())
@@ -807,8 +879,7 @@ export function waitForCompactDone(
     .replace(/"/g, "'")
     .slice(0, 240)
   return err(
-    `compact did not complete within ${timeoutMs}ms (` +
-      `${sawTranscriptDone ? 'transcript marker seen, input not ready' : 'no transcript compact marker'}` +
+    `compact did not complete within ${timeoutMs}ms (no transcript compact marker` +
       `${tail ? `; pane tail: ${tail}` : ''})`,
   )
 }