@agfpd/iapeer 0.2.17 → 0.2.18

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agfpd/iapeer",
-  "version": "0.2.17",
+  "version": "0.2.18",
   "description": "Foundation core for the iapeer multi-agent ecosystem: identity, registry, storage, codec.",
   "type": "module",
   "bin": {

package/src/cli/cli.test.ts

@@ -116,6 +116,9 @@ describe('remove (registry record via the locked writer)', () => {
     const o = await removePeerCli('zombie', { env: e })
     expect(o.action).toBe('removed')
     expect(findPeer(readPeersIndex({ env: e }), 'zombie')).toBeNull()
+    // the folder is deliberately KEPT; the outcome carries the cwd so the verb can
+    // say so instead of leaving silent orphans (boris 10.06)
+    expect(o.cwd).toBe('/tmp/zombie')
   })
   test('removing an absent peer is an idempotent no-op (not an error)', async () => {
     const o = await removePeerCli('never-existed', { env: env() })

package/src/cli/index.ts

@@ -11,7 +11,7 @@
 // sentinel-marked always-on plist) are stop/start-able.
 
 import { spawnSync } from 'child_process'
-import { readFileSync } from 'fs'
+import { existsSync, readFileSync } from 'fs'
 import { fileURLToPath } from 'url'
 import {
   isInfraRuntime,
@@ -255,6 +255,10 @@ export interface RemoveOutcome {
   personality: string
   action: 'removed' | 'absent' | 'refused-live'
   reason?: string
+  /** The removed peer's cwd (registry fact, captured BEFORE the removal). remove
+   *  deliberately keeps the folder — user data is never deleted by a registry reap
+   *  (boris's finding 10.06: say so in the output instead of leaving silent orphans). */
+  cwd?: string
 }
 
 /**
@@ -285,7 +289,7 @@ export async function removePeerCli(
     }
   }
   await removePeer(personality, { env })
-  return { personality, action: 'removed' }
+  return { personality, action: 'removed', cwd: peer.cwd }
 }
 
 // ─────────────────────────────────────────────────────────────────────────────
@@ -657,8 +661,14 @@ export async function runCli(argv: string[], env: NodeJS.ProcessEnv = process.en
         // peer unless --force (orphaning a running session from routing is the risk).
         if (!positionals[0]) return usage(errOut)
         const o = await removePeerCli(positionals[0], { force: flags.force === true, env })
-        if (o.action === 'removed') out(`removed "${o.personality}" from the registry\n`)
-        else if (o.action === 'absent') out(`"${o.personality}" not registered — no-op\n`)
+        if (o.action === 'removed') {
+          out(`removed "${o.personality}" from the registry\n`)
+          // Deliberate: the registry reap never deletes user data — but SAY so, or
+          // the default-location peers leave silent orphan folders (boris 10.06).
+          if (o.cwd && existsSync(o.cwd)) {
+            out(`folder kept: ${o.cwd} (remove never deletes peer data — \`rm -rf\` it yourself if it was a throwaway)\n`)
+          }
+        } else if (o.action === 'absent') out(`"${o.personality}" not registered — no-op\n`)
         else errOut(`remove: ${o.reason}\n`)
         return o.action === 'refused-live' ? 1 : 0
       }

package/src/onboard/index.ts

@@ -55,7 +55,7 @@ function runtimeBin(runtime: OnboardRuntime, env: NodeJS.ProcessEnv): string {
   return env.IAPEER_CODEX_BIN?.trim() || 'codex'
 }
 
-function isExecutable(binOrName: string): boolean {
+function isExecutable(binOrName: string, env: NodeJS.ProcessEnv = process.env): boolean {
   if (binOrName.includes('/')) {
     try {
       accessSync(binOrName, FS.X_OK)
@@ -64,13 +64,22 @@ function isExecutable(binOrName: string): boolean {
       return false
     }
   }
-  // bare name → resolved by spawnSync against PATH; probe with `which`-free spawn.
-  // HARD TIMEOUT (live find 10.06): `codex --version` HANGS FOREVER in a non-tty
-  // environment (three stray probes sat 25+ min; an onboard --dry-run piped to a
-  // file never printed a byte). A hung probe must degrade to 'runtime-missing',
-  // not wedge the whole onboard.
-  const r = spawnSync(binOrName, ['--version'], { stdio: 'ignore', timeout: 10_000 })
-  return r.error === undefined && r.status !== null
+  // bare name → PRESENCE probe over PATH (`command -v` semantics), NO spawn.
+  // History (both live finds 10.06): the original `--version` ANSWER probe HANGS
+  // FOREVER for codex in a non-tty (three stray probes sat 25+ min); the 10 s
+  // timeout that replaced it then DEGRADED a LIVE codex to 'runtime-missing' —
+  // masking a working runtime (boris's catch). The skip-decision only asks "is
+  // the runtime installed", and presence answers that without executing anything.
+  for (const dir of (env.PATH ?? '').split(':')) {
+    if (!dir) continue
+    try {
+      accessSync(join(dir, binOrName), FS.X_OK)
+      return true
+    } catch {
+      /* not in this PATH segment */
+    }
+  }
+  return false
 }
 
 /**
@@ -81,7 +90,11 @@ function isExecutable(binOrName: string): boolean {
  */
 export function isMarketplaceRegistered(runtime: OnboardRuntime, env: NodeJS.ProcessEnv = process.env): boolean {
   const bin = runtimeBin(runtime, env)
-  const r = spawnSync(bin, ['plugin', 'marketplace', 'list'], { encoding: 'utf8' })
+  // HARD TIMEOUT — the codex CLI hangs FOREVER in a non-tty on ANY subcommand
+  // (live 10.06: first `--version`, then `plugin marketplace list` after the
+  // presence-probe fix let a live codex through). Timeout → status null →
+  // "not registered" → the add (also time-bounded) decides; never a wedge.
+  const r = spawnSync(bin, ['plugin', 'marketplace', 'list'], { encoding: 'utf8', timeout: 60_000 })
   if (r.status !== 0) return false
   return isAgfpdInList(`${r.stdout ?? ''}`)
 }
@@ -102,8 +115,12 @@ export function isAgfpdInList(listOutput: string): boolean {
 /** Register OUR marketplace for this runtime (`<runtime> plugin marketplace add <ref>`). */
 function registerMarketplace(runtime: OnboardRuntime, env: NodeJS.ProcessEnv): { ok: boolean; detail?: string } {
   const bin = runtimeBin(runtime, env)
-  const r = spawnSync(bin, ['plugin', 'marketplace', 'add', MARKETPLACE_REF], { encoding: 'utf8' })
-  return r.status === 0 ? { ok: true } : { ok: false, detail: (r.stderr ?? '').trim() || `exit ${r.status}` }
+  // Same hard timeout as the list probe (codex non-tty hang class) — a wedged add
+  // degrades to a loud 'failed' line instead of freezing the host phase.
+  const r = spawnSync(bin, ['plugin', 'marketplace', 'add', MARKETPLACE_REF], { encoding: 'utf8', timeout: 120_000 })
+  return r.status === 0
+    ? { ok: true }
+    : { ok: false, detail: (r.stderr ?? '').trim() || (r.status === null ? 'timed out (non-tty hang?)' : `exit ${r.status}`) }
 }
 
 /**
@@ -119,7 +136,7 @@ export function onboardHost(opts: OnboardOptions = {}): OnboardResult {
   const runtimes = opts.runtimes ?? (['claude', 'codex'] as OnboardRuntime[])
   const marketplaces: OnboardRuntimeResult[] = []
   for (const runtime of runtimes) {
-    if (!isExecutable(runtimeBin(runtime, env))) {
+    if (!isExecutable(runtimeBin(runtime, env), env)) {
       marketplaces.push({ runtime, state: 'runtime-missing' })
       continue
     }