@agentuity/cli 0.0.54 → 0.0.56

package/src/cmd/build/ast.test.ts

@@ -1,565 +1,173 @@
 import { describe, test, expect } from 'bun:test';
-import { parseEvalMetadata } from './ast';
-
-const TEST_ROOT_DIR = '/test/root';
-const TEST_PROJECT_ID = 'test-project-id';
-const TEST_DEPLOYMENT_ID = 'test-deployment-id';
-
-describe('parseEvalMetadata', () => {
-	describe('eval with metadata.name', () => {
-		test('uses metadata.name when provided', () => {
-			const code = `
-				import agent from './agent';
-				export const myEval = agent.createEval({
-					metadata: {
-						name: 'custom-eval-name',
-						description: 'Test description'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('custom-eval-name');
-			expect(result[0].description).toBe('Test description');
-		});
-	});
+import { parseRoute } from './ast';
+import { writeFileSync, mkdirSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
 
-	describe('eval with variable name only', () => {
-		test('uses camelToKebab of variable name when metadata.name is not provided', () => {
-			const code = `
-				import agent from './agent';
-				export const myTestEval = agent.createEval({
-					metadata: {
-						description: 'Test description'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('my-test-eval');
-			expect(result[0].description).toBe('Test description');
-		});
-
-		test('uses camelToKebab of variable name when metadata is not provided', () => {
-			const code = `
-				import agent from './agent';
-				export const noMetadataEval = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('no-metadata-eval');
-		});
-
-		test('handles complex camelCase variable names correctly', () => {
-			const code = `
-				import agent from './agent';
-				export const complexCamelCaseEvalName = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('complex-camel-case-eval-name');
-		});
-	});
+const TEST_DIR = '/tmp/agentuity-cli-test-routes';
 
-	describe('eval with both metadata.name and variable name', () => {
-		test('prefers metadata.name over variable name', () => {
-			const code = `
-				import agent from './agent';
-				export const variableNameEval = agent.createEval({
-					metadata: {
-						name: 'metadata-name-takes-priority'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('metadata-name-takes-priority');
-		});
-	});
+describe('parseRoute - Crash Prevention Scenarios', () => {
+	const setup = () => {
+		rmSync(TEST_DIR, { recursive: true, force: true });
+		mkdirSync(TEST_DIR, { recursive: true });
+	};
+
+	const cleanup = () => {
+		rmSync(TEST_DIR, { recursive: true, force: true });
+	};
+
+	test('should handle files with interface definitions', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+const router = createRouter();
 
-	describe('eval with neither name', () => {
-		test('throws error when eval has neither metadata.name nor variable name', () => {
-			// This is a difficult case to test with valid JavaScript, as all valid
-			// variable declarations should have an identifier. However, we can verify
-			// the error handling exists by testing that the error message format is correct.
-			//
-			// In practice, this error should never occur with valid code, but we want
-			// to ensure the error is clear and helpful if it does happen.
-			//
-			// The error case would occur if:
-			// 1. vardecl.id.type is not 'Identifier' (e.g., destructuring pattern)
-			// 2. metadata.name is not provided
-			//
-			// Since acorn-loose parses valid JavaScript, and valid eval declarations
-			// should always have an identifier, this is primarily a defensive check.
-			//
-			// We verify the error path exists in the code by checking that normal
-			// cases work correctly, and the error handling is in place.
-
-			// Test that normal cases work (implicitly tests error path doesn't trigger)
-			const code = `
-				import agent from './agent';
-				export const validEval = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('valid-eval');
-
-			// Note: To fully test the error case, we would need to mock the AST structure
-			// or use code that parses but doesn't extract a variable name. This is
-			// difficult with acorn-loose parsing valid JavaScript. The error handling
-			// is verified to exist in the code, and will throw if the condition is met.
-		});
+interface SomeInterface {
+	foo: string;
+	bar: string;
+}
+
+router.get('/', (c) => c.json({ status: 'ok' }));
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		const routes = await parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1');
+		expect(routes).toHaveLength(1);
+		expect(routes[0].method).toBe('get');
+
+		cleanup();
 	});
 
-	describe('multiple evals', () => {
-		test('parses multiple evals in same file correctly', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const firstEval = agent.createEval({
-					metadata: {
-						name: 'first-eval',
-						description: 'First eval'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const secondEval = agent.createEval({
-					metadata: {
-						name: 'second-eval',
-						description: 'Second eval'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const thirdEval = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(3);
-			expect(result[0].name).toBe('first-eval');
-			expect(result[0].description).toBe('First eval');
-			expect(result[1].name).toBe('second-eval');
-			expect(result[1].description).toBe('Second eval');
-			expect(result[2].name).toBe('third-eval');
-		});
-
-		test('handles mix of metadata.name and variable name evals', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const withMetadataName = agent.createEval({
-					metadata: {
-						name: 'custom-name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const withoutMetadataName = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(2);
-			expect(result[0].name).toBe('custom-name');
-			expect(result[1].name).toBe('without-metadata-name');
-		});
+	test('should handle non-call expression statements', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+const router = createRouter();
+
+1 + 1;
+"string literal";
+true;
+
+router.get('/', (c) => c.text('ok'));
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		const routes = await parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1');
+		expect(routes).toHaveLength(1);
+
+		cleanup();
 	});
 
-	describe('export patterns', () => {
-		test('handles ExportNamedDeclaration pattern', () => {
-			const code = `
-				import agent from './agent';
-				export const exportedEval = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('exported-eval');
-		});
-
-		test('handles VariableDeclaration pattern (non-exported)', () => {
-			const code = `
-				import agent from './agent';
-				const nonExportedEval = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			// Non-exported evals should not be included in metadata
-			expect(result).toHaveLength(0);
-		});
+	test('should handle variable access identifiers', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+const router = createRouter();
+
+router; // Just accessing the variable
+
+router.get('/', (c) => c.text('ok'));
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		const routes = await parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1');
+		expect(routes).toHaveLength(1);
+
+		cleanup();
 	});
 
-	describe('eval ID generation', () => {
-		test('generates unique IDs for evals', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const eval1 = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval2 = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(2);
-			expect(result[0].id).toBeDefined();
-			expect(result[1].id).toBeDefined();
-			expect(result[0].id).not.toBe(result[1].id);
-		});
-
-		test('generates consistent IDs for same eval', () => {
-			const code = `
-				import agent from './agent';
-				export const myEval = agent.createEval({
-					metadata: {
-						name: 'test-eval'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result1] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			const [, result2] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result1[0].id).toBe(result2[0].id);
-		});
+	test('should handle direct function calls (not member expressions)', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+const router = createRouter();
+
+console.log("logging");
+(function() { })();
+
+router.get('/', (c) => c.text('ok'));
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		const routes = await parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1');
+		expect(routes).toHaveLength(1);
+
+		cleanup();
 	});
 
-	describe('edge cases', () => {
-		test('handles empty metadata object', () => {
-			const code = `
-				import agent from './agent';
-				export const emptyMetadataEval = agent.createEval({
-					metadata: {},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('empty-metadata-eval');
-		});
-
-		test('handles eval with only description in metadata', () => {
-			const code = `
-				import agent from './agent';
-				export const descriptionOnlyEval = agent.createEval({
-					metadata: {
-						description: 'Only description, no name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			const [, result] = parseEvalMetadata(
-				TEST_ROOT_DIR,
-				'/test/root/src/agents/test/eval.ts',
-				code,
-				TEST_PROJECT_ID,
-				TEST_DEPLOYMENT_ID
-			);
-
-			expect(result).toHaveLength(1);
-			expect(result[0].name).toBe('description-only-eval');
-			expect(result[0].description).toBe('Only description, no name');
-		});
+	test('should handle mixed complex scenarios', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+
+// Variable declarations
+const router = createRouter();
+const someVar = "test";
+
+// Interface
+interface User {
+	id: string;
+}
+
+// Function declaration
+function helper() {
+	return true;
+}
+
+// Direct call
+helper();
+
+// Non-route member expression
+console.log(someVar);
+
+// Valid route
+router.post('/users', (c) => c.json({ id: '1' }));
+
+// Another expression type
+if (true) {
+	console.log("block");
+}
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		const routes = await parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1');
+		expect(routes).toHaveLength(1);
+		expect(routes[0].method).toBe('post');
+
+		cleanup();
 	});
+	test('should reject invalid router method', async () => {
+		setup();
+		const routeFile = join(TEST_DIR, 'route.ts');
+		const code = `
+import { createRouter } from '@agentuity/runtime';
+
+// Variable declarations
+const router = createRouter();
+
+// Invalid route with unknown method
+router.foo('/users', (c) => c.json({ id: '1' }));
+
+export default router;
+		`;
+		writeFileSync(routeFile, code);
+
+		await expect(parseRoute(TEST_DIR, routeFile, 'proj_1', 'dep_1')).rejects.toThrow();
 
-	describe('duplicate eval names', () => {
-		test('throws error when duplicate eval names are found in same file', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const firstEval = agent.createEval({
-					metadata: {
-						name: 'duplicate-name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const secondEval = agent.createEval({
-					metadata: {
-						name: 'duplicate-name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			expect(() => {
-				parseEvalMetadata(
-					TEST_ROOT_DIR,
-					'/test/root/src/agents/test/eval.ts',
-					code,
-					TEST_PROJECT_ID,
-					TEST_DEPLOYMENT_ID
-				);
-			}).toThrow(/Duplicate eval names found in .*eval\.ts: duplicate-name/);
-		});
-
-		test('throws error when multiple duplicate eval names are found', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const eval1 = agent.createEval({
-					metadata: {
-						name: 'first-duplicate'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval2 = agent.createEval({
-					metadata: {
-						name: 'first-duplicate'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval3 = agent.createEval({
-					metadata: {
-						name: 'second-duplicate'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval4 = agent.createEval({
-					metadata: {
-						name: 'second-duplicate'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			expect(() => {
-				parseEvalMetadata(
-					TEST_ROOT_DIR,
-					'/test/root/src/agents/test/eval.ts',
-					code,
-					TEST_PROJECT_ID,
-					TEST_DEPLOYMENT_ID
-				);
-			}).toThrow(/Duplicate eval names found in .*eval\.ts: first-duplicate, second-duplicate/);
-		});
-
-		test('throws error when duplicate names come from variable names', () => {
-			// Note: We can't have two variables with the exact same name in valid JavaScript,
-			// but we can test that the validation works by using metadata.name to override
-			// variable names to create duplicates
-			const code = `
-				import agent from './agent';
-				
-				export const eval1 = agent.createEval({
-					metadata: {
-						name: 'duplicate-name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval2 = agent.createEval({
-					metadata: {
-						name: 'duplicate-name'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			expect(() => {
-				parseEvalMetadata(
-					TEST_ROOT_DIR,
-					'/test/root/src/agents/test/eval.ts',
-					code,
-					TEST_PROJECT_ID,
-					TEST_DEPLOYMENT_ID
-				);
-			}).toThrow(/Duplicate eval names found in .*eval\.ts: duplicate-name/);
-		});
-
-		test('throws error when duplicate names mix metadata.name and variable name', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const myEval = agent.createEval({
-					metadata: {
-						name: 'mixed-duplicate'
-					},
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const mixedDuplicate = agent.createEval({
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			expect(() => {
-				parseEvalMetadata(
-					TEST_ROOT_DIR,
-					'/test/root/src/agents/test/eval.ts',
-					code,
-					TEST_PROJECT_ID,
-					TEST_DEPLOYMENT_ID
-				);
-			}).toThrow(/Duplicate eval names found in .*eval\.ts: mixed-duplicate/);
-		});
-
-		test('error message includes filename and all duplicate names', () => {
-			const code = `
-				import agent from './agent';
-				
-				export const eval1 = agent.createEval({
-					metadata: { name: 'test-eval' },
-					handler: async () => ({ success: true, passed: true })
-				});
-
-				export const eval2 = agent.createEval({
-					metadata: { name: 'test-eval' },
-					handler: async () => ({ success: true, passed: true })
-				});
-			`;
-
-			let errorThrown = false;
-			try {
-				parseEvalMetadata(
-					TEST_ROOT_DIR,
-					'/test/root/src/agents/test/eval.ts',
-					code,
-					TEST_PROJECT_ID,
-					TEST_DEPLOYMENT_ID
-				);
-			} catch (error) {
-				errorThrown = true;
-				expect(error).toBeInstanceOf(Error);
-				const errorMessage = (error as Error).message;
-				expect(errorMessage).toContain('Duplicate eval names found in');
-				expect(errorMessage).toContain('eval.ts');
-				expect(errorMessage).toContain('test-eval');
-				expect(errorMessage).toContain(
-					'Eval names must be unique within the same file to prevent ID collisions'
-				);
-			}
-			expect(errorThrown).toBe(true);
-		});
+		cleanup();
 	});
 });