@agentuity/cli 0.0.43 → 0.0.44

package/src/cmd/bundle/plugin.ts

@@ -1,9 +1,12 @@
 import type { BunPlugin } from 'bun';
-import { dirname, basename, join } from 'node:path';
-import { existsSync, writeFileSync } from 'node:fs';
-import type { BuildMetadata } from '../../types';
-import { parseAgentMetadata, parseRoute } from './ast';
+import { dirname, basename, join, resolve } from 'node:path';
+import { existsSync, writeFileSync, mkdirSync } from 'node:fs';
+import type { BuildMetadata } from '@agentuity/server';
+import { parseAgentMetadata, parseRoute, parseEvalMetadata } from './ast';
 import { applyPatch, generatePatches } from './patch';
+import { detectSubagent } from '../../utils/detectSubagent';
+import { createLogger } from '@agentuity/server';
+import type { LogLevel } from '../../types';
 
 function toCamelCase(str: string): string {
 	return str
@@ -17,31 +20,139 @@ function toPascalCase(str: string): string {
 }
 
 function generateAgentRegistry(srcDir: string, agentInfo: Array<Record<string, string>>) {
+	// Separate parent agents and subagents
+	const parentAgents = agentInfo.filter((a) => !a.parent);
+	const subagents = agentInfo.filter((a) => a.parent);
+
+	// Group subagents by parent
+	const subagentsByParent = new Map<string, Array<Record<string, string>>>();
+	for (const subagent of subagents) {
+		const parentName = subagent.parent!;
+		if (!subagentsByParent.has(parentName)) {
+			subagentsByParent.set(parentName, []);
+		}
+		subagentsByParent.get(parentName)!.push(subagent);
+	}
+
+	// Detect naming collisions in generated identifiers
+	// Naming strategy: parent + child names are combined as `${parent}_${name}` then converted to camelCase
+	// Example: parent="user", child="profile" → "user_profile" → "userProfile"
+	// Potential collision: parent="user_profile", child="info" and parent="user", child="profile_info" both → "userProfileInfo"
+	const generatedNames = new Set<string>();
+	const collisions: string[] = [];
+
+	for (const agent of agentInfo) {
+		const fullName = agent.parent ? `${agent.parent}_${agent.name}` : agent.name;
+		const camelName = toCamelCase(fullName);
+
+		if (generatedNames.has(camelName)) {
+			collisions.push(`Identifier collision detected: "${camelName}" (from "${fullName}")`);
+		}
+		generatedNames.add(camelName);
+	}
+
+	if (collisions.length > 0) {
+		throw new Error(
+			`Agent identifier naming collisions detected:\n${collisions.join('\n')}\n\n` +
+				`This occurs when different agent names produce the same camelCase identifier.\n` +
+				`Please rename your agents to avoid this collision.`
+		);
+	}
+
+	// Generate imports for all agents
 	const imports = agentInfo
-		.map(({ name, path }) => {
-			const camelName = toCamelCase(name);
+		.map(({ name, path, parent }) => {
+			const fullName = parent ? `${parent}.${name}` : name;
+			const camelName = toCamelCase(fullName.replace('.', '_'));
 			const relativePath = path.replace(/^\.\/agents\//, './');
 			return `import ${camelName}Agent from '${relativePath}';`;
 		})
 		.join('\n');
 
-	const registry = agentInfo
-		.map(({ name }) => {
-			const camelName = toCamelCase(name);
-			return `  ${camelName}: ${camelName}Agent,`;
-		})
-		.join('\n');
+	// Evals are now imported in plugin.ts when agents are registered
+	// No need to import them in registry.generated.ts
+	const evalsImportsStr = '';
+
+	// Validate that child property names don't collide with parent agent properties
+	const reservedAgentProperties = ['metadata', 'run', 'inputSchema', 'outputSchema', 'stream'];
+	for (const parentAgent of parentAgents) {
+		const children = subagentsByParent.get(parentAgent.name) || [];
+		for (const child of children) {
+			const childPropertyName = toCamelCase(child.name);
+
+			// Check for collision with reserved agent properties
+			if (reservedAgentProperties.includes(childPropertyName)) {
+				throw new Error(
+					`Subagent property name collision detected: "${childPropertyName}" in parent "${parentAgent.name}"\n` +
+						`The child name "${child.name}" conflicts with a reserved agent property (${reservedAgentProperties.join(', ')}).\n` +
+						`Please rename the subagent to avoid this collision.`
+				);
+			}
+		}
+	}
+
+	// Generate nested registry structure
+	const registryLines: string[] = [];
+	for (const parentAgent of parentAgents) {
+		const parentCamelName = toCamelCase(parentAgent.name);
+		const children = subagentsByParent.get(parentAgent.name) || [];
+
+		if (children.length === 0) {
+			// No subagents, simple assignment
+			registryLines.push(`  ${parentCamelName}: ${parentCamelName}Agent,`);
+		} else {
+			// Has subagents, create nested structure using object spread (no mutation)
+			registryLines.push(`  ${parentCamelName}: {`);
+			registryLines.push(`    ...${parentCamelName}Agent,`);
+			for (const child of children) {
+				const childCamelName = toCamelCase(`${parentAgent.name}_${child.name}`);
+				registryLines.push(`    ${toCamelCase(child.name)}: ${childCamelName}Agent,`);
+			}
+			registryLines.push(`  },`);
+		}
+	}
+	const registry = registryLines.join('\n');
 
+	// Generate type exports for all agents
 	const typeExports = agentInfo
-		.map(({ name }) => {
-			const camelName = toCamelCase(name);
-			const pascalName = toPascalCase(name);
+		.map(({ name, parent }) => {
+			const fullName = parent ? `${parent}_${name}` : name;
+			const camelName = toCamelCase(fullName);
+			const pascalName = toPascalCase(fullName);
 			return `export type ${pascalName}AgentRunner = AgentRunner<typeof ${camelName}Agent['inputSchema'], typeof ${camelName}Agent['outputSchema'], typeof ${camelName}Agent['stream'] extends true ? true : false>;`;
 		})
 		.join('\n');
 
+	// Generate nested agent type definitions
+	const agentTypeLines: string[] = [];
+	for (const parentAgent of parentAgents) {
+		const parentCamelName = toCamelCase(parentAgent.name);
+		const children = subagentsByParent.get(parentAgent.name) || [];
+
+		if (children.length === 0) {
+			// No subagents
+			agentTypeLines.push(
+				`	   ${parentCamelName}: AgentRunner<AgentRegistry['${parentCamelName}']['inputSchema'], AgentRegistry['${parentCamelName}']['outputSchema'], AgentRegistry['${parentCamelName}']['stream'] extends true ? true : false>;`
+			);
+		} else {
+			// Has subagents - create intersection type
+			agentTypeLines.push(
+				`	   ${parentCamelName}: AgentRunner<AgentRegistry['${parentCamelName}']['inputSchema'], AgentRegistry['${parentCamelName}']['outputSchema'], AgentRegistry['${parentCamelName}']['stream'] extends true ? true : false> & {`
+			);
+			for (const child of children) {
+				const childCamelName = toCamelCase(child.name);
+				const fullChildName = toCamelCase(`${parentAgent.name}_${child.name}`);
+				agentTypeLines.push(
+					`	     ${childCamelName}: AgentRunner<typeof ${fullChildName}Agent['inputSchema'], typeof ${fullChildName}Agent['outputSchema'], typeof ${fullChildName}Agent['stream'] extends true ? true : false>;`
+				);
+			}
+			agentTypeLines.push(`	   };`);
+		}
+	}
+	const agentTypes = agentTypeLines.join('\n');
+
 	const generatedContent = `// Auto-generated by Agentuity - do not edit manually
-${imports}
+${imports}${evalsImportsStr}
 import type { AgentRunner, Logger } from '@agentuity/runtime';
 import type { KeyValueStorage, ObjectStorage, StreamStorage, VectorStorage } from '@agentuity/core';
 
@@ -60,7 +171,7 @@ declare module "hono" {
 	interface Context {
 	   agentName: AgentName;
 	   agent: {
-	     [K in AgentName]: AgentRunner<AgentRegistry[K]['inputSchema'], AgentRegistry[K]['outputSchema'], AgentRegistry[K]['stream'] extends true ? true : false>;
+${agentTypes}
 	   };
 	   waitUntil: (promise: Promise<void> | (() => void | Promise<void>)) => void;
 	   logger: Logger;
@@ -75,27 +186,55 @@ declare module "hono" {
 	const agentsDir = join(srcDir, 'agents');
 	const registryPath = join(agentsDir, 'registry.generated.ts');
 
+	// Ensure agents directory exists
+	if (!existsSync(agentsDir)) {
+		mkdirSync(agentsDir, { recursive: true });
+	}
+
 	writeFileSync(registryPath, generatedContent, 'utf-8');
 
+	// Generate React client types with nested structure
+	const clientImports = agentInfo
+		.map(({ name, path, parent }) => {
+			const fullName = parent ? `${parent}_${name}` : name;
+			const camelName = toCamelCase(fullName);
+			const relativePath = path.replace(/^\.\/agents\//, './');
+			return `import type ${camelName}Agent from '${relativePath}';`;
+		})
+		.join('\n');
+
+	const clientAgentTypeLines: string[] = [];
+	for (const parentAgent of parentAgents) {
+		const parentCamelName = toCamelCase(parentAgent.name);
+		const children = subagentsByParent.get(parentAgent.name) || [];
+
+		if (children.length === 0) {
+			// No subagents
+			clientAgentTypeLines.push(
+				`		'${parentAgent.name}': Agent<typeof ${parentCamelName}Agent['inputSchema'], typeof ${parentCamelName}Agent['outputSchema']>;`
+			);
+		} else {
+			// Has subagents - create nested type with subagent access via dot notation
+			clientAgentTypeLines.push(
+				`		'${parentAgent.name}': Agent<typeof ${parentCamelName}Agent['inputSchema'], typeof ${parentCamelName}Agent['outputSchema']>;`
+			);
+			for (const child of children) {
+				const fullChildName = toCamelCase(`${parentAgent.name}_${child.name}`);
+				clientAgentTypeLines.push(
+					`		'${parentAgent.name}.${child.name}': Agent<typeof ${fullChildName}Agent['inputSchema'], typeof ${fullChildName}Agent['outputSchema']>;`
+				);
+			}
+		}
+	}
+
 	const clientTypesContent = `// Auto-generated by Agentuity - do not edit manually
 // This file augments @agentuity/react with your project's agent types
-${agentInfo
-	.map(({ name, path }) => {
-		const camelName = toCamelCase(name);
-		const relativePath = path.replace(/^\.\/agents\//, './');
-		return `import type ${camelName}Agent from '${relativePath}';`;
-	})
-	.join('\n')}
+${clientImports}
 import type { Agent } from '@agentuity/react';
 
 declare module '@agentuity/react' {
 	interface AgentRegistry {
-${agentInfo
-	.map(({ name }) => {
-		const camelName = toCamelCase(name);
-		return `		'${name}': Agent<typeof ${camelName}Agent['inputSchema'], typeof ${camelName}Agent['outputSchema']>;`;
-	})
-	.join('\n')}
+${clientAgentTypeLines.join('\n')}
 	}
 }
 `;
@@ -104,11 +243,23 @@ ${agentInfo
 	writeFileSync(clientTypesPath, clientTypesContent, 'utf-8');
 }
 
+let metadata: Partial<BuildMetadata>;
+
+export function getBuildMetadata(): Partial<BuildMetadata> {
+	return metadata;
+}
+
 const AgentuityBundler: BunPlugin = {
 	name: 'Agentuity Bundler',
 	setup(build) {
-		const rootDir = build.config.root ?? '.';
+		const rootDir = resolve(build.config.root ?? '.');
 		const srcDir = join(rootDir, 'src');
+		const projectId = build.config.define?.['process.env.AGENTUITY_CLOUD_PROJECT_ID']
+			? JSON.parse(build.config.define['process.env.AGENTUITY_CLOUD_PROJECT_ID'])
+			: '';
+		const deploymentId = build.config.define?.['process.env.AGENTUITY_CLOUD_DEPLOYMENT_ID']
+			? JSON.parse(build.config.define['process.env.AGENTUITY_CLOUD_DEPLOYMENT_ID'])
+			: '';
 		const routes: Set<string> = new Set();
 		const agentInfo: Array<Record<string, string>> = [];
 		const agentMetadata: Map<string, Map<string, string>> = new Map<
@@ -129,12 +280,38 @@ const AgentuityBundler: BunPlugin = {
 			return args;
 		});
 
+		build.onLoad({ filter: /\/route\.ts$/, namespace: 'file' }, async (args) => {
+			if (args.path.startsWith(srcDir)) {
+				const importPath = args.path
+					.replace(rootDir, '')
+					.replace('.ts', '')
+					.replace('/src/', './');
+				routes.add(importPath);
+			}
+			// return undefined to let Bun handle loading normally
+			return;
+		});
+
 		build.onLoad({ filter: /\/agent\.ts$/, namespace: 'file' }, async (args) => {
 			let newsource = await Bun.file(args.path).text();
 			if (args.path.startsWith(srcDir)) {
 				const contents = transpiler.transformSync(newsource);
-				const [ns, md] = parseAgentMetadata(rootDir, args.path, contents);
+				const [ns, md] = await parseAgentMetadata(
+					rootDir,
+					args.path,
+					contents,
+					projectId,
+					deploymentId
+				);
 				newsource = ns;
+
+				// Detect if this is a subagent by checking path structure
+				// Note: Path structure assumption - 4 segments: agents/parent/child/agent.ts
+				const { isSubagent, parentName } = detectSubagent(args.path, srcDir);
+				if (isSubagent && parentName) {
+					md.set('parent', parentName);
+				}
+
 				agentMetadata.set(md.get('identifier')!, md);
 			}
 			return {
@@ -143,6 +320,19 @@ const AgentuityBundler: BunPlugin = {
 			};
 		});
 
+		build.onLoad({ filter: /\/eval\.ts$/, namespace: 'file' }, async (args) => {
+			let newsource = await Bun.file(args.path).text();
+			if (args.path.startsWith(srcDir)) {
+				const contents = transpiler.transformSync(newsource);
+				const [ns] = parseEvalMetadata(rootDir, args.path, contents, projectId, deploymentId);
+				newsource = ns;
+			}
+			return {
+				contents: newsource,
+				loader: 'ts',
+			};
+		});
+
 		const patches = generatePatches();
 		for (const [, patch] of patches) {
 			let modulePath = join('node_modules', patch.module, '.*');
@@ -173,17 +363,23 @@ const AgentuityBundler: BunPlugin = {
 				namespace: 'file',
 			},
 			async (args) => {
+				const logger = createLogger((process.env.AGENTUITY_LOG_LEVEL as LogLevel) || 'info');
 				if (build.config.target !== 'bun') {
 					return;
 				}
 				await args.defer();
 
 				const inserts: string[] = [];
+				const routeMapping: Record<string, string> = {};
 
 				for (const route of routes) {
 					const name = basename(dirname(route));
 					const agent = route.replace(/\/route$/, '/agent');
 					const hasAgent = existsSync(join(srcDir, agent + '.ts'));
+
+					// Detect if this is a subagent route using shared utility
+					const { isSubagent, parentName } = detectSubagent(route);
+
 					const agentPath = route
 						.replace(/\/route$/, '/*')
 						.replace('/agents', '/agent')
@@ -196,7 +392,12 @@ const AgentuityBundler: BunPlugin = {
 						.replace('/agents', '/agent')
 						.replace('./', '/');
 
-					const definitions = await parseRoute(rootDir, join(srcDir, route + '.ts'));
+					const definitions = await parseRoute(
+						rootDir,
+						join(srcDir, `${route}.ts`),
+						projectId,
+						deploymentId
+					);
 					routeDefinitions = [...routeDefinitions, ...definitions];
 
 					let agentDetail: Record<string, string> = {};
@@ -213,23 +414,38 @@ const AgentuityBundler: BunPlugin = {
 							identifier: md.get('identifier')!,
 							description: md.get('description') ?? '',
 						};
+						if (isSubagent && parentName) {
+							agentDetail.parent = parentName;
+						}
 						agentInfo.push(agentDetail);
 					}
 
 					let buffer = `await (async() => {
-    const { createAgentMiddleware, getApp, registerAgent } = await import('@agentuity/runtime');
-    const app = getApp()!;
+    const { createAgentMiddleware, getRouter, registerAgent } = await import('@agentuity/runtime');
+    const router = getRouter()!;
     const route = require('./src/${route}').default;`;
 					if (hasAgent) {
+						const agentRegistrationName =
+							isSubagent && parentName ? `${parentName}.${name}` : name;
+						// Build evals path from agent path (e.g., 'agents/eval/agent' -> 'agents/eval/eval.ts')
+						const agentDirPath = agent.replace(/\/agent$/, '');
+						const evalsPath = join(srcDir, agentDirPath, 'eval.ts');
+						const evalsImport = existsSync(evalsPath)
+							? `\n    require('./src/${agentDirPath}/eval');`
+							: '';
 						buffer += `
     const agent = require('./src/${agent}').default;
-    app.all("${agentPath}", createAgentMiddleware('${name}'));
-    registerAgent("${name}", agent);`;
+    router.all("${agentPath}", createAgentMiddleware('${agentRegistrationName}'));
+    registerAgent("${agentRegistrationName}", agent);${evalsImport}`;
 					}
 					buffer += `
-    app.route("${routePath}", route);
+    router.route("${routePath}", route);
 })();`;
 					inserts.push(buffer);
+
+					for (const def of definitions) {
+						routeMapping[`${def.method} ${def.path}`] = def.id;
+					}
 				}
 
 				const indexFile = join(srcDir, 'web', 'index.html');
@@ -237,18 +453,25 @@ const AgentuityBundler: BunPlugin = {
 				if (existsSync(indexFile)) {
 					inserts.unshift(`await (async () => {
     const { serveStatic } = require('hono/bun');
-    const { getApp } = await import('@agentuity/runtime');
-    const app = getApp()!;
-	const index = await Bun.file(import.meta.dir + '/web/index.js').text();
+    const { getRouter } = await import('@agentuity/runtime');
+    const router = getRouter()!;
+	const index = await Bun.file(import.meta.dir + '/web/index.html').text();
 	const webstatic = serveStatic({ root: import.meta.dir + '/web' });
-	app.get('/', (c) => c.html(index));
-    app.get('/chunk/*', webstatic);
-    app.get('/asset/*', webstatic);
-	app.get('/public/*', webstatic);
+	router.get('/', (c) => c.html(index));
+    router.get('/web/chunk/*', webstatic);
+    router.get('/web/asset/*', webstatic);
+	router.get('/public/*', webstatic);
 })();`);
 				}
 
-				generateAgentRegistry(srcDir, agentInfo);
+				// Only generate registry if there are agents
+				// Note: We don't import the registry here because:
+				// 1. Evals are already imported when agents are registered (see line 421-422)
+				// 2. The registry is for type definitions only, not runtime execution
+				// 3. Importing it causes bundler resolution issues since it's generated during build
+				if (agentInfo.length > 0) {
+					generateAgentRegistry(srcDir, agentInfo);
+				}
 
 				const file = Bun.file(args.path);
 				let contents = await file.text();
@@ -270,10 +493,15 @@ const AgentuityBundler: BunPlugin = {
 				}
 
 				// generate the build metadata
-				const metadata: BuildMetadata = {
+				metadata = {
 					routes: routeDefinitions,
 					agents: [],
 				};
+
+				// Group agents by parent/child relationship
+				const parentAgentMetadata = new Map<string, Map<string, string>>();
+				const subagentsByParent = new Map<string, Array<Map<string, string>>>();
+
 				for (const [, v] of agentMetadata) {
 					if (!v.has('filename')) {
 						throw new Error('agent metadata is missing expected filename property');
@@ -290,20 +518,112 @@ const AgentuityBundler: BunPlugin = {
 					if (!v.has('name')) {
 						throw new Error('agent metadata is missing expected name property');
 					}
-					metadata.agents.push({
+
+					const parentName = v.get('parent');
+					if (parentName) {
+						// This is a subagent
+						if (!subagentsByParent.has(parentName)) {
+							subagentsByParent.set(parentName, []);
+						}
+						subagentsByParent.get(parentName)!.push(v);
+					} else {
+						// This is a parent or standalone agent
+						parentAgentMetadata.set(v.get('identifier')!, v);
+					}
+				}
+
+				// Validate that all subagents reference existing parent agents
+				for (const [parentName, subagents] of subagentsByParent) {
+					const parentExists = Array.from(parentAgentMetadata.values()).some(
+						(meta) => meta.get('name') === parentName || meta.get('identifier') === parentName
+					);
+					if (!parentExists) {
+						const subagentPaths = subagents.map((s) => s.get('filename')).join(', ');
+						throw new Error(
+							`Subagent(s) [${subagentPaths}] reference parent "${parentName}" which does not exist. ` +
+								`Ensure the parent agent is defined.`
+						);
+					}
+				}
+
+				// Build metadata with nested subagents
+				for (const [_identifier, v] of parentAgentMetadata) {
+					const agentData: BuildMetadata['agents'][number] = {
 						filename: v.get('filename')!,
 						id: v.get('id')!,
 						identifier: v.get('identifier')!,
 						version: v.get('version')!,
 						name: v.get('name')!,
 						description: v.get('description') ?? '<no description provided>',
-					});
+					};
+
+					const evalsStr = v.get('evals');
+					if (evalsStr) {
+						logger.trace(
+							`[plugin] Found evals string for agent ${agentData.name}, parsing...`
+						);
+						try {
+							agentData.evals = JSON.parse(evalsStr);
+							logger.trace(
+								`[plugin] Successfully parsed ${agentData.evals?.length ?? 0} eval(s) for agent ${agentData.name}`
+							);
+						} catch (e) {
+							logger.trace(
+								`[plugin] Failed to parse evals for agent ${agentData.name}: ${e}`
+							);
+							console.warn(`Failed to parse evals for agent ${agentData.name}: ${e}`);
+						}
+					} else {
+						logger.trace(`[plugin] No evals found for agent ${agentData.name}`);
+					}
+
+					// Add subagents if any (check both name and identifier)
+					const subagents =
+						subagentsByParent.get(agentData.name) ||
+						subagentsByParent.get(agentData.identifier);
+					if (subagents && subagents.length > 0) {
+						agentData.subagents = subagents.map((sub) => {
+							const subagentData: BuildMetadata['agents'][number] = {
+								filename: sub.get('filename')!,
+								id: sub.get('id')!,
+								identifier: sub.get('identifier')!,
+								version: sub.get('version')!,
+								name: sub.get('name')!,
+								description: sub.get('description') ?? '<no description provided>',
+							};
+
+							// Add evals for subagents if any
+							const subEvalsStr = sub.get('evals');
+							if (subEvalsStr) {
+								logger.trace(
+									`[plugin] Found evals string for subagent ${subagentData.name}, parsing...`
+								);
+								try {
+									subagentData.evals = JSON.parse(subEvalsStr);
+									logger.trace(
+										`[plugin] Successfully parsed ${subagentData.evals?.length ?? 0} eval(s) for subagent ${subagentData.name}`
+									);
+								} catch (e) {
+									logger.trace(
+										`[plugin] Failed to parse evals for subagent ${subagentData.name}: ${e}`
+									);
+									console.warn(
+										`Failed to parse evals for subagent ${subagentData.name}: ${e}`
+									);
+								}
+							} else {
+								logger.trace(`[plugin] No evals found for subagent ${subagentData.name}`);
+							}
+
+							return subagentData;
+						});
+					}
+
+					metadata.agents!.push(agentData);
 				}
 
-				const metadataFilename = Bun.file(
-					join(build.config.outdir!, 'agentuity.metadata.json')
-				);
-				await metadataFilename.write(JSON.stringify(metadata));
+				const routeMappingJSFile = Bun.file(join(build.config.outdir!, '.routemapping.json'));
+				await routeMappingJSFile.write(JSON.stringify(routeMapping));
 
 				return {
 					contents,