@agentteams/runner 0.0.122 → 0.0.124

package/dist/handlers/trigger-handler.test.js

@@ -6,9 +6,40 @@ import { mkdir, mkdtemp, rm, stat, writeFile } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { logger } from '../logger.js';
-import { createTriggerHandler } from './trigger-handler.js';
+import { createTriggerHandler, selectIdleTimeoutMs } from './trigger-handler.js';
 import { startPolling } from '../poller.js';
 import { computeLocalKey } from '../utils/worktree-discovery.js';
+test('selectIdleTimeoutMs prefers the trigger value over every fallback', () => {
+    assert.deepEqual(selectIdleTimeoutMs({
+        triggerIdleTimeoutMs: 120_000,
+        configuredIdleTimeoutMs: 300_000,
+        isConfiguredIdleTimeoutExplicit: true,
+        runnerDefaultIdleTimeoutMs: 600_000,
+    }), { idleTimeoutMs: 120_000, source: 'trigger' });
+});
+test('selectIdleTimeoutMs prefers an explicitly configured env value over the runner default', () => {
+    assert.deepEqual(selectIdleTimeoutMs({
+        triggerIdleTimeoutMs: null,
+        configuredIdleTimeoutMs: 300_000,
+        isConfiguredIdleTimeoutExplicit: true,
+        runnerDefaultIdleTimeoutMs: 600_000,
+    }), { idleTimeoutMs: 300_000, source: 'env' });
+});
+test('selectIdleTimeoutMs uses the runner default when env is not explicitly configured', () => {
+    assert.deepEqual(selectIdleTimeoutMs({
+        triggerIdleTimeoutMs: null,
+        configuredIdleTimeoutMs: 1_800_000,
+        isConfiguredIdleTimeoutExplicit: false,
+        runnerDefaultIdleTimeoutMs: 2_700_000,
+    }), { idleTimeoutMs: 2_700_000, source: 'runnerDefault' });
+});
+test('selectIdleTimeoutMs falls back to the global default when no higher-priority value exists', () => {
+    assert.deepEqual(selectIdleTimeoutMs({
+        triggerIdleTimeoutMs: null,
+        configuredIdleTimeoutMs: 1_800_000,
+        isConfiguredIdleTimeoutExplicit: false,
+    }), { idleTimeoutMs: 1_800_000, source: 'globalDefault' });
+});
 const trigger = {
     id: 'trigger-1',
     prompt: 'Implement feature',
@@ -16,6 +47,7 @@ const trigger = {
     model: 'o4-mini',
     fastMode: false,
     effort: null,
+    idleTimeoutMs: null,
     status: 'PENDING',
     agentConfigId: 'agent-1',
     startedAt: null,
@@ -51,6 +83,63 @@ const runtime = {
 test.afterEach(() => {
     mock.restoreAll();
 });
+// 트리거 값이 없고 엔진별 기본값도 없는 기존 시나리오는 config 값을 그대로 쓰던 동작을 유지해야 한다.
+test('createTriggerHandler passes the resolved idle timeout to the runner and logs its source', async () => {
+    const runnerIdleTimeouts = [];
+    const idleTimeoutLogs = [];
+    mock.method(logger, 'info', (message, meta) => {
+        if (message === 'Resolved runner idle timeout' && meta) {
+            idleTimeoutLogs.push(meta);
+        }
+    });
+    const client = {
+        fetchTriggerRuntime: async () => runtime,
+        isTriggerCancelRequested: async () => false,
+        updateTriggerHistory: async () => { },
+        updateTriggerStatus: async () => { },
+    };
+    const runner = {
+        run: async (input) => {
+            runnerIdleTimeouts.push(input.idleTimeoutMs);
+            return { exitCode: 0 };
+        },
+    };
+    const handler = createTriggerHandler({
+        config: {
+            daemonToken: 'daemon-token',
+            apiUrl: 'https://api.example',
+            pollingIntervalMs: 5000,
+            maxPollingIntervalMs: 120_000,
+            timeoutMs: 1500,
+            idleTimeoutMs: 1_800_000,
+            isConfiguredIdleTimeoutExplicit: false,
+            runnerCmd: 'opencode',
+            preventSleepWhileBusy: false,
+        },
+        client: client,
+    }, {
+        pathExists: () => true,
+        createRunnerFactory: () => () => runner,
+        createLogReporter: () => ({ start: () => { }, append: () => { }, stop: async () => { } }),
+        readHistoryFile: async () => '### Summary\n- done\n',
+        resolveRunnerHistoryPaths: () => ({
+            currentHistoryPath: '/auth/path/.agentteams/runner/history/trigger-1.md',
+            parentHistoryPath: null,
+        }),
+    });
+    // CODEX는 엔진별 기본값이 없으므로 전역 기본값으로 떨어진다.
+    await handler({ ...trigger, idleTimeoutMs: null });
+    // CLAUDE_CODE는 엔진별 기본값을 가지므로 그 축에서 값이 온다.
+    await handler({ ...trigger, runnerType: 'CLAUDE_CODE', idleTimeoutMs: null });
+    // 태스크 라벨이 실린 실행은 다른 어떤 축보다 앞선다.
+    await handler({ ...trigger, runnerType: 'CLAUDE_CODE', idleTimeoutMs: 5_400_000 });
+    assert.deepEqual(runnerIdleTimeouts, [1_800_000, 1_800_000, 5_400_000]);
+    assert.deepEqual(idleTimeoutLogs.map((meta) => ({ source: meta.source, idleTimeoutMs: meta.idleTimeoutMs })), [
+        { source: 'globalDefault', idleTimeoutMs: 1_800_000 },
+        { source: 'runnerDefault', idleTimeoutMs: 1_800_000 },
+        { source: 'trigger', idleTimeoutMs: 5_400_000 },
+    ]);
+});
 test('createTriggerHandler runs the runner, reports history, and marks success', async () => {
     const clientCalls = [];
     const logEntries = [];
@@ -842,6 +931,166 @@ test('createTriggerHandler reports the explicit runner error before last output'
     await handler({ ...trigger, parentTriggerId: null });
     assert.deepEqual(clientCalls.at(-1)?.args, ['trigger-1', 'FAILED', 'specific runner error']);
 });
+test('createTriggerHandler: 파싱된 RESULT 실패 원문이 stderr 마지막 줄보다 우선한다', async () => {
+    const clientCalls = [];
+    const client = {
+        fetchTriggerRuntime: async () => runtime,
+        isTriggerCancelRequested: async () => false,
+        updateTriggerHistory: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerHistory', args });
+        },
+        updateTriggerStatus: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerStatus', args });
+        },
+    };
+    const handler = createTriggerHandler({
+        config: {
+            daemonToken: 'daemon-token',
+            apiUrl: 'https://api.example',
+            pollingIntervalMs: 5000,
+            maxPollingIntervalMs: 120_000,
+            timeoutMs: 1500,
+            idleTimeoutMs: 500,
+            runnerCmd: 'opencode',
+            preventSleepWhileBusy: false,
+        },
+        client: client,
+    }, {
+        pathExists: () => true,
+        createRunnerFactory: () => () => ({
+            run: async (opts) => {
+                // 구조화 로그 파서가 만든 RESULT 청크. 마지막 원인 있는 값이 사유로 승격돼야 한다.
+                opts.onStdoutChunk?.('[Result] Failed: first failure', 'RESULT');
+                opts.onStdoutChunk?.('[Result] Completed in 3s', 'RESULT');
+                opts.onStdoutChunk?.("[Result] Failed: The 'gpt-5' model is not supported", 'RESULT');
+                return {
+                    exitCode: 1,
+                    lastOutput: 'general output',
+                    errorMessage: 'Reading additional input from stdin...',
+                };
+            },
+        }),
+        createLogReporter: () => ({
+            start: () => undefined,
+            append: () => undefined,
+            stop: async () => undefined,
+        }),
+        readHistoryFile: async () => '',
+        resolveRunnerHistoryPaths: () => ({
+            currentHistoryPath: '/auth/path/.agentteams/runner/history/trigger-1.md',
+            parentHistoryPath: null,
+        }),
+    });
+    await handler({ ...trigger, parentTriggerId: null });
+    assert.deepEqual(clientCalls.at(-1)?.args, [
+        'trigger-1',
+        'FAILED',
+        "[Result] Failed: The 'gpt-5' model is not supported",
+    ]);
+});
+test('createTriggerHandler: 원인 없는 RESULT 마커면 stderr 마지막 줄을 유지한다', async () => {
+    const clientCalls = [];
+    const client = {
+        fetchTriggerRuntime: async () => runtime,
+        isTriggerCancelRequested: async () => false,
+        updateTriggerHistory: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerHistory', args });
+        },
+        updateTriggerStatus: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerStatus', args });
+        },
+    };
+    const handler = createTriggerHandler({
+        config: {
+            daemonToken: 'daemon-token',
+            apiUrl: 'https://api.example',
+            pollingIntervalMs: 5000,
+            maxPollingIntervalMs: 120_000,
+            timeoutMs: 1500,
+            idleTimeoutMs: 500,
+            runnerCmd: 'opencode',
+            preventSleepWhileBusy: false,
+        },
+        client: client,
+    }, {
+        pathExists: () => true,
+        createRunnerFactory: () => () => ({
+            run: async (opts) => {
+                opts.onStdoutChunk?.('[Result] Failed (12s, 3 files changed)', 'RESULT');
+                return {
+                    exitCode: 1,
+                    lastOutput: 'general output',
+                    errorMessage: 'Reading additional input from stdin...',
+                };
+            },
+        }),
+        createLogReporter: () => ({
+            start: () => undefined,
+            append: () => undefined,
+            stop: async () => undefined,
+        }),
+        readHistoryFile: async () => '',
+        resolveRunnerHistoryPaths: () => ({
+            currentHistoryPath: '/auth/path/.agentteams/runner/history/trigger-1.md',
+            parentHistoryPath: null,
+        }),
+    });
+    await handler({ ...trigger, parentTriggerId: null });
+    assert.deepEqual(clientCalls.at(-1)?.args, ['trigger-1', 'FAILED', 'Reading additional input from stdin...']);
+});
+test('createTriggerHandler: fail-safe 타임아웃 문구는 그 전에 나온 RESULT 원문으로 덮이지 않는다', async () => {
+    const clientCalls = [];
+    const client = {
+        fetchTriggerRuntime: async () => runtime,
+        isTriggerCancelRequested: async () => false,
+        updateTriggerHistory: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerHistory', args });
+        },
+        updateTriggerStatus: async (...args) => {
+            clientCalls.push({ method: 'updateTriggerStatus', args });
+        },
+    };
+    const handler = createTriggerHandler({
+        config: {
+            daemonToken: 'daemon-token',
+            apiUrl: 'https://api.example',
+            pollingIntervalMs: 5000,
+            maxPollingIntervalMs: 120_000,
+            timeoutMs: 1500,
+            idleTimeoutMs: 500,
+            runnerCmd: 'opencode',
+            preventSleepWhileBusy: false,
+        },
+        client: client,
+    }, {
+        pathExists: () => true,
+        createRunnerFactory: () => () => ({
+            run: async (opts) => {
+                // 원인 있는 RESULT를 한 번 낸 뒤 프로세스가 걸려 fail-safe 워치독에 죽은 경우.
+                // 러너는 `idleTimedOut`을 세우지 않고 `timedOut`만 true로 돌려준다.
+                opts.onStdoutChunk?.("[Result] Failed: The 'gpt-5' model is not supported", 'RESULT');
+                return {
+                    exitCode: 1,
+                    timedOut: true,
+                    lastOutput: 'general output',
+                    errorMessage: 'Runner fail-safe timed out after 6h',
+                };
+            },
+        }),
+        createLogReporter: () => ({
+            start: () => undefined,
+            append: () => undefined,
+            stop: async () => undefined,
+        }),
+        readHistoryFile: async () => '',
+        resolveRunnerHistoryPaths: () => ({
+            currentHistoryPath: '/auth/path/.agentteams/runner/history/trigger-1.md',
+            parentHistoryPath: null,
+        }),
+    });
+    await handler({ ...trigger, parentTriggerId: null });
+    assert.deepEqual(clientCalls.at(-1)?.args, ['trigger-1', 'FAILED', 'Runner fail-safe timed out after 6h']);
+});
 test('createTriggerHandler fails without running the runner when worktree creation fails', async () => {
     const clientCalls = [];
     const runnerInputs = [];