@agentskillkit/agent-skills 1.0.1 → 3.2.2

package/.agent/skills/code-review-checklist/SKILL.md

@@ -1,109 +0,0 @@
----
-name: code-review-checklist
-description: Code review guidelines covering code quality, security, and best practices.
-allowed-tools: Read, Glob, Grep
----
-
-# Code Review Checklist
-
-## Quick Review Checklist
-
-### Correctness
-- [ ] Code does what it's supposed to do
-- [ ] Edge cases handled
-- [ ] Error handling in place
-- [ ] No obvious bugs
-
-### Security
-- [ ] Input validated and sanitized
-- [ ] No SQL/NoSQL injection vulnerabilities
-- [ ] No XSS or CSRF vulnerabilities
-- [ ] No hardcoded secrets or sensitive credentials
-- [ ] **AI-Specific:** Protection against Prompt Injection (if applicable)
-- [ ] **AI-Specific:** Outputs are sanitized before being used in critical sinks
-
-### Performance
-- [ ] No N+1 queries
-- [ ] No unnecessary loops
-- [ ] Appropriate caching
-- [ ] Bundle size impact considered
-
-### Code Quality
-- [ ] Clear naming
-- [ ] DRY - no duplicate code
-- [ ] SOLID principles followed
-- [ ] Appropriate abstraction level
-
-### Testing
-- [ ] Unit tests for new code
-- [ ] Edge cases tested
-- [ ] Tests readable and maintainable
-
-### Documentation
-- [ ] Complex logic commented
-- [ ] Public APIs documented
-- [ ] README updated if needed
-
-## AI & LLM Review Patterns (2025)
-
-### Logic & Hallucinations
-- [ ] **Chain of Thought:** Does the logic follow a verifiable path?
-- [ ] **Edge Cases:** Did the AI account for empty states, timeouts, and partial failures?
-- [ ] **External State:** Is the code making safe assumptions about file systems or networks?
-
-### Prompt Engineering Review
-```markdown
-// ❌ Vague prompt in code
-const response = await ai.generate(userInput);
-
-// ✅ Structured & Safe prompt
-const response = await ai.generate({
-  system: "You are a specialized parser...",
-  input: sanitize(userInput),
-  schema: ResponseSchema
-});
-```
-
-## Anti-Patterns to Flag
-
-```typescript
-// ❌ Magic numbers
-if (status === 3) { ... }
-
-// ✅ Named constants
-if (status === Status.ACTIVE) { ... }
-
-// ❌ Deep nesting
-if (a) { if (b) { if (c) { ... } } }
-
-// ✅ Early returns
-if (!a) return;
-if (!b) return;
-if (!c) return;
-// do work
-
-// ❌ Long functions (100+ lines)
-// ✅ Small, focused functions
-
-// ❌ any type
-const data: any = ...
-
-// ✅ Proper types
-const data: UserData = ...
-```
-
-## Review Comments Guide
-
-```
-// Blocking issues use 🔴
-🔴 BLOCKING: SQL injection vulnerability here
-
-// Important suggestions use 🟡
-🟡 SUGGESTION: Consider using useMemo for performance
-
-// Minor nits use 🟢
-🟢 NIT: Prefer const over let for immutable variable
-
-// Questions use ❓
-❓ QUESTION: What happens if user is null here?
-```

package/.agent/skills/code-reviewer/.skill-source.json

@@ -1,8 +0,0 @@
-{
-  "repo": "dataguruin/agent-skills",
-  "skill": "coinpika-pr-reviewer",
-  "ref": null,
-  "checksum": "4d1f267a06d8a1a0309732714deff7e3afb2a62d7b350c981abad5a077b40c27",
-  "installedAt": "2026-01-24T11:02:40.755Z",
-  "method": "symlink"
-}

package/.agent/skills/code-reviewer/SKILL.md

@@ -1,32 +0,0 @@
----
-name: code-reviewer
-version: 1.0.0
-description: Automated Code Review and PR validation.
-allowed-tools: Read, Write, Edit, Glob, Grep, Bash
----
-
-# Code Reviewer
-
-> **Philosophy:** Code validation should be automated, objective, and empathetic.
-
-## 📚 Knowledge Base
-
-This skill uses the **My Agent Skills Doctrine Pack** to validate changes.
-
-| Component | Responsibility |
-|-----------|----------------|
-| **Constitution** | Supreme non-negotiable laws |
-| **Doctrines** | Architecture, Data, UI specific rules |
-
-## 🔧 Scripts (Execution)
-
-| Script | Purpose |
-|--------|---------|
-| `scripts/review.js` | Automated PR Reviewer |
-| `scripts/validate.js` | Single file validator |
-
-## ⚠️ Critical Checks
-
-- **Constitution Check**: Does this violate any Supreme Law?
-- **Architecture Check**: Does this violate layer boundaries?
-- **Security Check**: Are there secrets or injection risks?

package/.agent/skills/code-reviewer/enforcement/checklists/backend-api-review-checklist.md

@@ -1,5 +0,0 @@
-# Backend API Review Checklist
-
-- [ ] Rate limiting implemented?
-- [ ] Caching strategy defined?
-- [ ] No historical data mutation? (Law 2)

package/.agent/skills/code-reviewer/examples/approved-pr/review-output.md

@@ -1,76 +0,0 @@
-# Sample PR Review - Approved
-
-## PR Details
-- **PR**: #142 - Add Redis caching for coin price endpoints
-- **Author**: developer@coinpika.com
-- **Reviewer**: AI Agent (coinpika-pr-reviewer)
-- **Date**: 2026-01-24
-
-## Files Changed
-- `api/coins/[id]/price.ts` (modified)
-- `lib/cache/redis.ts` (new)
-- `lib/cache/types.ts` (new)
-
----
-
-## CoinPika Doctrine Review
-
-### Applicable Doctrines
-- [x] CoinPika Master Constitution
-- [x] Architecture Doctrine
-- [x] Performance Doctrine
-- [x] Backend Data Engine Doctrine
-
-### Constitutional Compliance
-
-#### ✅ Laws Upheld
-
-**Law 1 (Truth Ownership)**
-- Backend remains sole source of financial truth
-- Cache is read-through only, no client-side truth
-- All prices originate from authoritative sources
-
-**Law 2 (Historical Integrity)**
-- Cache TTL prevents stale data persistence
-- Historical data fetch bypasses cache appropriately
-
-**Architecture Doctrine**
-- Clean separation between cache layer and business logic
-- No direct external API calls from frontend
-
-**Performance Doctrine**
-- Redis caching implemented ✓
-- TTL set to 5 minutes (appropriate for price data)
-- P95 latency improvement expected: 800ms → 50ms
-
-#### ❌ Laws Violated
-None
-
-### Violations Found
-None
-
-### Suggestions (Non-blocking)
-
-1. **INFO** - Consider adding cache metrics
-   - File: `lib/cache/redis.ts`
-   - Suggestion: Add hit/miss ratio logging for monitoring
-
-2. **INFO** - Document cache invalidation strategy
-   - Suggestion: Add comments explaining when cache is invalidated
-
-### Approval Decision
-
-✅ **APPROVED** - All constitutional checks passed
-
-### Checklist
-- [x] Backend owns truth
-- [x] No historical data mutation
-- [x] Caching strategy implemented
-- [x] No external API calls from frontend
-- [x] Error handling present
-- [x] TypeScript types complete
-
----
-
-**Reviewer**: coinpika-pr-reviewer v1.1.0
-**Doctrines Checked**: Law-1, Law-2, Architecture, Performance

package/.agent/skills/code-reviewer/examples/rejected-pr/review-output.md

@@ -1,99 +0,0 @@
-# Sample PR Review - Rejected
-
-## PR Details
-- **PR**: #156 - Make charts more dynamic with realtime data
-- **Author**: developer@coinpika.com
-- **Reviewer**: AI Agent (coinpika-pr-reviewer)
-- **Date**: 2026-01-24
-
-## Files Changed
-- `components/charts/BitcoinChart.tsx` (modified)
-- `hooks/useRealtimePrice.ts` (modified)
-
----
-
-## CoinPika Doctrine Review
-
-### Applicable Doctrines
-- [x] CoinPika Master Constitution
-- [x] Chart Data Doctrine (Law-3, Law-4)
-- [x] Frontend Mobile Doctrine
-
-### Constitutional Compliance
-
-#### ✅ Laws Upheld
-(None applicable - violations found)
-
-#### ❌ Laws Violated
-
-**Law 3 (Realtime Ephemerality)** - CRITICAL
-- Realtime WebSocket data injected directly into chart
-- Ephemeral data being treated as historical
-
-**Law 4 (Chart Truthfulness)** - CRITICAL
-- Charts no longer represent backend-aggregated truth
-- Visual data contaminated with unvalidated ticks
-
-### Violations Found
-
-1. **🔴 ERROR** - Law-3 Violation: Realtime Injection
-   - File: `components/charts/BitcoinChart.tsx:45`
-   - Issue: WebSocket ticks pushed to historical chart data
-   - Code: `chartData.push(realtimePrice)`
-   - Fix: Remove realtime injection, display in separate ticker
-   - Doctrine: `doctrines/data/coinpika-chart-data-doctrine.md`
-
-2. **🔴 ERROR** - Law-4 Violation: Chart Truthfulness
-   - File: `components/charts/BitcoinChart.tsx:67`
-   - Issue: Chart displays mixed historical + realtime data
-   - Code: `const data = [...historicalData, ...realtimeTicks]`
-   - Fix: Chart must only consume pre-aggregated backend data
-   - Doctrine: `constitution/coinpika-master-constitution.md:68-73`
-
-3. **🟡 WARNING** - Historical Array Mutation
-   - File: `components/charts/BitcoinChart.tsx:45`
-   - Issue: Using `.push()` mutates historical array
-   - Fix: Create new array reference for React re-render
-
-### Approval Decision
-
-🚫 **REJECTED** - Constitutional violations found
-
-### Required Changes
-
-1. **Remove realtime injection from chart**
-   ```diff
-   - chartData.push(realtimePrice)
-   + // Chart only displays historical data
-   ```
-
-2. **Create separate LivePriceTicker component**
-   ```tsx
-   // New component for realtime display
-   <LivePriceTicker price={realtimePrice} />
-   ```
-
-3. **Load chart data from historical API only**
-   ```tsx
-   const { data } = useSWR('/api/bitcoin/historical');
-   // No mixing with realtime
-   ```
-
-### Systemic Risk
-
-If merged, this change would:
-- Corrupt historical chart integrity
-- Create visual inconsistency during high volatility
-- Violate user trust in chart accuracy
-- Potentially cause regulatory issues (displaying unverified data as historical)
-
-### References
-- Constitution: Law 3, Law 4
-- Doctrine: `doctrines/data/coinpika-chart-data-doctrine.md`
-- Example: `examples/violation-chart-injection/`
-
----
-
-**Reviewer**: coinpika-pr-reviewer v1.1.0
-**Decision**: REJECTED
-**Reason**: Constitutional violations (Law-3, Law-4)

package/.agent/skills/code-reviewer/examples/scenarios.md

@@ -1,3 +0,0 @@
-# PR Review Examples
-
-See SKILL.md for detailed scenarios.

package/.agent/skills/code-reviewer/metadata/doctrine-mapping.yaml

@@ -1,167 +0,0 @@
-# Doctrine Mapping
-# Maps file patterns to applicable doctrines for automatic loading
-# Extended to include Doctrine Definitions for Pattern Matching
-
-mappings:
-  # Backend API files
-  "api/**":
-    doctrines:
-      - Law-1  # Truth Ownership
-      - Law-2  # Historical Integrity
-      - Architecture
-      - Performance
-    severity: high
-    
-  "server/**":
-    doctrines:
-      - Law-1
-      - Law-2
-      - Architecture
-    severity: high
-    
-  "lib/**":
-    doctrines:
-      - Law-1
-      - Architecture
-    severity: medium
-
-  # Chart & Visualization
-  "**/chart*":
-    doctrines:
-      - Law-3  # Realtime Ephemerality
-      - Law-4  # Chart Truthfulness
-    severity: critical
-    
-  "**/graph*":
-    doctrines:
-      - Law-3
-      - Law-4
-    severity: critical
-    
-  "**/ohlc*":
-    doctrines:
-      - Law-2
-      - Law-3
-      - Law-4
-    severity: critical
-
-  # Mobile UI
-  "**/mobile/**":
-    doctrines:
-      - Frontend-Mobile
-    severity: high
-    
-  "**/gesture*":
-    doctrines:
-      - Frontend-Mobile
-    severity: high
-    
-  "**/swipe*":
-    doctrines:
-      - Frontend-Mobile
-    severity: high
-
-  # Data files
-  "**/price*":
-    doctrines:
-      - Law-1
-      - Law-2
-    severity: high
-    
-  "**/market*":
-    doctrines:
-      - Law-1
-    severity: medium
-    
-  "**/coin*":
-    doctrines:
-      - Law-1
-      - Performance
-    severity: medium
-
-  # Worker/Background
-  "**/worker*":
-    doctrines:
-      - Performance
-      - Architecture
-    severity: medium
-    
-  "**/cron*":
-    doctrines:
-      - Performance
-      - Architecture
-    severity: medium
-
-# Default for unmatched files
-default:
-  doctrines: []
-  severity: low
-
-# Doctrine Definitions (Regex Patterns)
-definitions:
-  Law-1:
-    name: 'Truth Ownership'
-    description: 'Backend owns truth, frontend only displays'
-    patterns:
-      - "localStorage\\.setItem\\s*\\(\\s*['\"`].*price"
-      - "sessionStorage\\.setItem\\s*\\(\\s*['\"`].*price"
-      - "setState\\s*\\(\\s*\\{[^}]*price[^}]*\\}"
-    severity: 'ERROR'
-    message: 'Frontend must not manage financial truth. Backend owns all price/market data.'
-
-  Law-2:
-    name: 'Historical Integrity'
-    description: 'Historical data is immutable'
-    patterns:
-      - "\\.push\\s*\\([^)]*historical"
-      - "\\.splice\\s*\\([^)]*historical"
-      - "history\\s*\\[\\s*\\d+\\s*\\]\\s*="
-      - "UPDATE\\s+.*history"
-      - "DELETE\\s+.*FROM.*history"
-    severity: 'ERROR'
-    message: 'Historical data must be immutable. Use append-only operations.'
-
-  Law-3:
-    name: 'Realtime Ephemerality'
-    description: 'Realtime data must not persist as historical'
-    patterns:
-      - "chart.*\\.push\\s*\\(\\s*realtimePrice"
-      - "historical.*push.*websocket"
-      - "ws.*message.*history.*push"
-    severity: 'ERROR'
-    message: 'Realtime ticks must not be injected into historical charts.'
-
-  Law-4:
-    name: 'Chart Truthfulness'
-    description: 'Charts show backend-aggregated data only'
-    patterns:
-      - "chart.*data.*=.*fetch\\s*\\(\\s*['\"`]wss?:"
-      - "candlestick.*websocket"
-      - "ohlcv.*realtime"
-    severity: 'ERROR'
-    message: 'Charts must display pre-aggregated backend data, not realtime feeds.'
-
-  Architecture:
-    name: 'Architecture Doctrine'
-    description: 'System boundaries must be respected'
-    patterns:
-      - "fetch\\s*\\(\\s*['\"`]https?:\\/\\/api\\.coingecko"
-      - "fetch\\s*\\(\\s*['\"`]https?:\\/\\/api\\.binance"
-      - "axios\\s*\\.\\s*get\\s*\\(\\s*['\"`]https?:\\/\\/.*external"
-    severity: 'WARNING'
-    message: 'Frontend should not call external APIs directly. Route through backend.'
-
-  Performance:
-    name: 'Performance Doctrine'
-    description: 'Caching and optimization required'
-    patterns:
-      - "fetch\\s*\\([^)]+\\)\\s*(?!.*cache)"
-    severity: 'INFO'
-    message: 'Consider implementing caching for API calls.'
-    
-  Frontend-Mobile:
-    name: 'Mobile UX Standards'
-    description: 'Strict gestures and layout for mobile'
-    patterns: []
-    severity: 'WARNING'
-    message: 'Mobile UI changes require audit'

package/.agent/skills/code-reviewer/metadata/intent-triggers.yaml

@@ -1,41 +0,0 @@
-# Intent Triggers
-# Defines when coinpika-pr-reviewer skill should activate
-
-triggers:
-  - pattern: "review.*pr"
-    confidence: high
-  - pattern: "check.*pull.*request"
-    confidence: high
-  - pattern: "validate.*changes"
-    confidence: medium
-  - pattern: "doctrine.*compliance"
-    confidence: high
-  - pattern: "constitutional.*check"
-    confidence: high
-  - pattern: "merge.*review"
-    confidence: medium
-  - pattern: "code.*review"
-    confidence: medium
-
-file_patterns:
-  # Files that require review against doctrines
-  high_priority:
-    - "api/**/*.ts"
-    - "api/**/*.js"
-    - "lib/**/*.ts"
-    - "server/**/*.ts"
-    - "**/chart*.tsx"
-    - "**/Chart*.tsx"
-    - "**/price*.ts"
-    - "**/mobile/**/*"
-
-  medium_priority:
-    - "components/**/*.tsx"
-    - "hooks/**/*.ts"
-    - "utils/**/*.ts"
-
-contexts:
-  - "pull_request"
-  - "code_review"
-  - "pre_merge"
-  - "ci_cd"

package/.agent/skills/code-reviewer/resources/links.md

@@ -1,59 +0,0 @@
-# Resources & Links
-
-## Official Documentation
-
-### GitHub
-- [GitHub Actions Documentation](https://docs.github.com/en/actions)
-- [GitHub Pull Request Reviews](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests)
-- [GitHub Code Review Best Practices](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews)
-
-### GitLab
-- [GitLab CI/CD Documentation](https://docs.gitlab.com/ee/ci/)
-- [GitLab Code Review Guidelines](https://docs.gitlab.com/ee/development/code_review.html)
-- [GitLab Merge Request Reviews](https://docs.gitlab.com/ee/user/project/merge_requests/reviews/)
-
-### Code Review Standards
-- [Conventional Comments](https://conventionalcomments.org/)
-- [Google Code Review Guidelines](https://google.github.io/eng-practices/review/)
-- [Microsoft Code Review Best Practices](https://docs.microsoft.com/en-us/azure/devops/repos/git/pullrequest)
-
-## CoinPika Internal
-
-### Constitution & Doctrines
-- [CoinPika Master Constitution](../coinpika-doctrine-pack/constitution/coinpika-master-constitution.md)
-- [Architecture Doctrine](../coinpika-doctrine-pack/doctrines/architecture/)
-- [Backend Data Engine Doctrine](../coinpika-doctrine-pack/doctrines/backend/)
-- [Chart Data Doctrine](../coinpika-doctrine-pack/doctrines/data/)
-- [Frontend Mobile Doctrine](../coinpika-doctrine-pack/doctrines/frontend/)
-
-### Enforcement
-- [Enforcement Guide](../coinpika-doctrine-pack/resources/ENFORCEMENT_GUIDE.md)
-- [Authority Model](../coinpika-doctrine-pack/resources/AUTHORITY_MODEL.md)
-- [Load Order](../coinpika-doctrine-pack/resources/LOAD_ORDER.md)
-
-## Tools & Automation
-
-### CI/CD Platforms
-- [GitHub Actions Marketplace](https://github.com/marketplace?type=actions)
-- [GitLab CI Templates](https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates)
-- [CircleCI Orbs](https://circleci.com/developer/orbs)
-
-### Static Analysis
-- [ESLint](https://eslint.org/)
-- [TypeScript ESLint](https://typescript-eslint.io/)
-- [Prettier](https://prettier.io/)
-
-### Security Scanning
-- [GitHub Security Advisories](https://github.com/advisories)
-- [Snyk](https://snyk.io/)
-- [npm audit](https://docs.npmjs.com/cli/v8/commands/npm-audit)
-
-## Learning Resources
-
-### Articles
-- [How to do a code review - Google Engineering](https://google.github.io/eng-practices/review/reviewer/)
-- [Code Review Best Practices - Atlassian](https://www.atlassian.com/agile/software-development/code-reviews)
-- [The Art of Code Review - Thoughtbot](https://thoughtbot.com/blog/five-tips-for-more-helpful-code-reviews)
-
-### Videos
-- [Code Review Best Practices - YouTube](https://www.youtube.com/results?search_query=code+review+best+practices)

package/.agent/skills/code-reviewer/scripts/audit_pr.js

@@ -1,8 +0,0 @@
-// scripts/audit_pr.js
-/**
- * Placeholder for CoinPika PR Audit Script
- * This script would normally run validation checks against the PR content.
- */
-console.log("Running CoinPika Doctrine Audit...");
-console.log("Checking for constitutional violations...");
-console.log("✅ No violations found (Mock Mode)");