@agentsfleet/orly 0.9.4 → 0.10.0

package/AGENTS.md

@@ -144,7 +144,7 @@ Guards fire pre-hoc regardless of lifecycle stage. Override: `<GATE>: SKIPPED pe
 | write auth-flow / token-minting files | `write_auth` | `dispatch/write_auth.md` — auth invariants; reads the product repo's `docs/AUTH.md` before · 🟣 delegated (product repo). |
 | write published docs / OpenAPI prose | `write_documentation` | `dispatch/write_documentation.md` → `docs/DOCUMENTATION_RULES.md` before narrower guides; page, fragment, API, changelog scopes differ · 🟣 delegated to repository pre-commit checks. |
 | write a changelog entry | `write_changelog` | `dispatch/write_changelog.md` — changelog voice (one headline, no marketing words, `**Bold lead-noun**` bullets, history append-only); reads `docs/CHANGELOG_VOICE.md` · 🤔 judgment-only. |
-| write/update a PR or MR body or its session notes | `write_pr_description` | `dispatch/write_pr_description.md` — append numbered `Session notes`, `Review`, and `Make`; measured fenced diagrams; review dispositions; commands with real output. |
+| write/update a PR or MR body or its session notes | `write_pr_description` | `dispatch/write_pr_description.md` — append numbered `Session notes`, `Review`, and `Make`; measured fenced diagrams; visual evidence from the lane's own artifacts; review dispositions; commands with real output. |
 | claim "tests pass / ready / shipping" | `verify` | `dispatch/verify.md` — verification tiers (`make` canonical; package-scoped runners are **not** verification), done-message glyph format · 🤔 judgment-only, `VERIFY GATE: <target> skipped per environment constraint (reason: ...)` only when genuinely unrunnable. |
 | name a stream/channel/Redis namespace/queue/RPC/Postgres schema, or describe a flow | `name_architecture` | `dispatch/name_architecture.md` — architecture-consult discipline; grep relevant `docs/architecture/` (chat brainstorming counts) · **no override** — doc wins until reconciled. |
 | run a lifecycle stage (open→close a stream, worktree setup, milestone bootstrap) | `lifecycle` | `dispatch/lifecycle.md` — stage runbooks: CHORE(open/close) checklists, PLAN expansions, spec discipline, deferral format, pre-PR gates, LAND · 🤔 judgment-only. |

package/core/operating-model.md

@@ -148,7 +148,7 @@ Guards fire pre-hoc regardless of lifecycle stage. Override: `<GATE>: SKIPPED pe
 | write auth-flow / token-minting files | `write_auth` | `dispatch/write_auth.md` — auth invariants; reads the product repo's `docs/AUTH.md` before · 🟣 delegated (product repo). | <!-- oracle-packs:domain.auth -->
 | write published docs / OpenAPI prose | `write_documentation` | `dispatch/write_documentation.md` → `docs/DOCUMENTATION_RULES.md` before narrower guides; page, fragment, API, changelog scopes differ · 🟣 delegated to repository pre-commit checks. | <!-- oracle-packs:domain.documentation -->
 | write a changelog entry | `write_changelog` | `dispatch/write_changelog.md` — changelog voice (one headline, no marketing words, `**Bold lead-noun**` bullets, history append-only); reads `docs/CHANGELOG_VOICE.md` · 🤔 judgment-only. | <!-- oracle-packs:domain.changelog -->
-| write/update a PR or MR body or its session notes | `write_pr_description` | `dispatch/write_pr_description.md` — append numbered `Session notes`, `Review`, and `Make`; measured fenced diagrams; review dispositions; commands with real output. | <!-- oracle-packs:universal.authoring -->
+| write/update a PR or MR body or its session notes | `write_pr_description` | `dispatch/write_pr_description.md` — append numbered `Session notes`, `Review`, and `Make`; measured fenced diagrams; visual evidence from the lane's own artifacts; review dispositions; commands with real output. | <!-- oracle-packs:universal.authoring -->
 | claim "tests pass / ready / shipping" | `verify` | `dispatch/verify.md` — verification tiers (`make` canonical; package-scoped runners are **not** verification), done-message glyph format · 🤔 judgment-only, `VERIFY GATE: <target> skipped per environment constraint (reason: ...)` only when genuinely unrunnable. | <!-- oracle-packs:product.agentsfleet -->
 | name a stream/channel/Redis namespace/queue/RPC/Postgres schema, or describe a flow | `name_architecture` | `dispatch/name_architecture.md` — architecture-consult discipline; grep relevant `docs/architecture/` (chat brainstorming counts) · **no override** — doc wins until reconciled. | <!-- oracle-packs:universal.authoring -->
 | run a lifecycle stage (open→close a stream, worktree setup, milestone bootstrap) | `lifecycle` | `dispatch/lifecycle.md` — stage runbooks: CHORE(open/close) checklists, PLAN expansions, spec discipline, deferral format, pre-PR gates, LAND · 🤔 judgment-only. |

package/dispatch/write_pr_description.md

@@ -84,6 +84,37 @@ their numbers:
    0.003-0.005ms        0.1ms        1.0ms      12-21ms
 ```
 
+## Visual evidence
+
+A change to a surface a person looks at, or a failure a picture explains faster
+than a paragraph, carries the picture. A reviewer who can see the wall, the
+dialog or the red run decides in seconds what a description makes them
+reconstruct.
+
+**Take it from what already ran, not from a staged pose.** A lane that failed
+has already produced the image: `gh run download <id> -n <artifact>` yields
+Playwright's `test-failed-*.png`, its `trace.zip` and its `error-context.md`.
+Those are measured evidence of the state under review. A browser driven by hand
+is the fallback, for a surface no lane photographs.
+
+**Screenshot the claim, not the neighbourhood.** One image per assertion, and
+the assertion named in the caption — "one tile, not two" beats "the fleets
+page". Never crop a failure out of a frame that contained it.
+
+**Attaching is the author's step, and say so rather than pretending.** No forge
+accepts an image upload to a pull-request body over its command-line interface;
+`gh` and `glab` both have no such call. So the agent hands the file to the
+person and the person drags it in. What the agent MUST do in the body is make
+the evidence retrievable without the image: name the run id, the artifact and
+the path inside it, and quote the decisive line. A body that says
+`error-context.md:27 records unexpected value "hidden"` survives a screenshot
+nobody attached; a body that says "see screenshot" does not.
+
+**A before/after belongs in a fence, not in two images**, when the difference is
+countable — the diagram rules above already cover it, and a diagram diffs
+better than a pair of pictures. Use images for what only rendering shows:
+alignment, spacing, contrast, what a person actually sees.
+
 ## Review
 
 Lead with the review result. Record every finding with P0, P1, or P2 severity,
@@ -142,6 +173,11 @@ a green pipeline.
 <Useful measured diagram, at most 78 columns.>
 ```
 
+<Visual evidence, when a surface changed or a picture explains a failure:
+each image named with the assertion it carries and with the run, artifact and
+path it came from, plus the decisive line quoted so the claim survives an
+image nobody attached.>
+
 ## Review
 
 <P0/P1/P2 entries with dispositions, No findings., or not-run reason.>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agentsfleet/orly",
-  "version": "0.9.4",
+  "version": "0.10.0",
   "description": "Repository-scoped engineering harness: renders agent rules, materialises the gates that enforce them, and proves the PR boundary \u2014 for any coding agent.",
   "license": "MIT",
   "type": "module",

package/registry.json

@@ -296,10 +296,6 @@
     "product.agentsfleet": {
       "extensions": [],
       "managed_files": [
-        {
-          "source": "audits/cross-tier-rates.sh",
-          "target": "audits/cross-tier-rates.sh"
-        },
         {
           "source": "audits/design-tokens.sh",
           "target": "audits/design-tokens.sh"

package/audits/cross-tier-rates.sh

@@ -1,105 +0,0 @@
-#!/usr/bin/env bash
-# cross-tier-rates.sh — pin numeric parity of the rate constants
-# across the daemon + three TypeScript surfaces.
-#
-# RULE UFS extension. The shipped billing surface depends on these constants
-# having identical numeric values everywhere they appear:
-#
-#   RUN_NANOS_PER_SEC         — per-second run rate (both postures) in nanos
-#
-# Two free-trial constants were pinned here and are both gone. FREE_TRIAL_END_MS
-# went when the boundary moved onto the tenant row; FREE_TRIAL_STAGE_NANOS went
-# when the trial mechanism was removed outright, because a rate that could
-# silently price a metered slice to zero was worth deleting rather than
-# guarding. The free allowance is wallet credit now — a balance, not a rate —
-# so there is no cross-tier number to pin for it.
-#
-# Files (one definition site per constant per file):
-#
-#   rustd/crates/afd_billing/src/nanos.rs   — server enforces the charge
-#   ui/packages/website/src/lib/rates.ts    — pricing page display
-#   ui/packages/app/lib/types.ts            — dashboard display
-#   cli/src/constants/billing.ts    — `agentsfleet doctor --json` billing block
-#
-# A drift between any two = a billing-display lie or a server-vs-CLI disagreement.
-# The daemon is the source of truth (server enforces); the three TS surfaces echo it.
-#
-# Fires in: make harness-verify, make harness-verify-all.
-# Exits 0 clean, 1 on any drift.
-
-set -euo pipefail
-
-ROOT="$(git rev-parse --show-toplevel)"
-cd "$ROOT"
-
-readonly NAMES=(
-  RUN_NANOS_PER_SEC
-)
-
-readonly FILES=(
-  rustd/crates/afd_billing/src/nanos.rs
-  ui/packages/website/src/lib/rates.ts
-  ui/packages/app/lib/types.ts
-  cli/src/constants/billing.ts
-)
-
-# Extract the numeric value bound to `name` in `file`. Matches definition
-# sites only — `^(pub |export )?const NAME` — not usages elsewhere in the
-# file. Normalises: strips underscores (Zig `1_000_000`, TS `1_000_000`),
-# strips the bigint `n` suffix (TS `1_000_000n`), trims whitespace.
-extract_value() {
-  local file="$1" name="$2"
-  grep -E "^[[:space:]]*(pub |export )?const ${name}\\b" "$file" 2>/dev/null \
-    | head -1 \
-    | sed -E "s|.*=[[:space:]]*||; s|[;,].*||; s|//.*||; s|[[:space:]_n]||g"
-}
-
-FAIL=0
-violations=()
-
-printf "audit-cross-tier-rates: pinning %d constants across %d files\n" \
-  "${#NAMES[@]}" "${#FILES[@]}"
-
-for name in "${NAMES[@]}"; do
-  expected=""
-  expected_file=""
-  for file in "${FILES[@]}"; do
-    if [[ ! -f "$file" ]]; then
-      violations+=("MISSING_FILE: $file")
-      FAIL=1
-      continue
-    fi
-    val="$(extract_value "$file" "$name")"
-    if [[ -z "$val" ]]; then
-      violations+=("MISSING_CONST: $name not defined in $file")
-      FAIL=1
-      continue
-    fi
-    if [[ -z "$expected" ]]; then
-      expected="$val"
-      expected_file="$file"
-      continue
-    fi
-    if [[ "$val" != "$expected" ]]; then
-      violations+=("DRIFT: $name = $val in $file vs $expected in $expected_file")
-      FAIL=1
-    fi
-  done
-  if [[ -n "$expected" ]]; then
-    printf "  OK   %-26s = %s\n" "$name" "$expected"
-  fi
-done
-
-if [[ $FAIL -ne 0 ]]; then
-  printf "\nFAIL: cross-tier rate drift detected:\n" >&2
-  for v in "${violations[@]}"; do
-    printf "  %s\n" "$v" >&2
-  done
-  printf "\nFix: align all four files on the canonical Zig value\n" >&2
-  printf "     (rustd/crates/afd_billing/src/nanos.rs is the server-side enforcer).\n" >&2
-  exit 1
-fi
-
-printf "OK:   all %d rate constants pin across %d files\n" \
-  "${#NAMES[@]}" "${#FILES[@]}"
-exit 0