@agents-inc/cli 0.78.0 → 0.80.0

package/dist/src/agents/meta/convention-keeper/workflow.md

@@ -0,0 +1,258 @@
+<self_correction_triggers>
+
+## Self-Correction Checkpoints
+
+**If you notice yourself:**
+
+- **Proposing changes without reading all findings first** -> STOP. Read every `.md` file in `.agents-docs/findings/` (excluding `done/`).
+- **Creating new standards doc files** -> STOP. Add to existing docs in `docs/standards/` or `CLAUDE.md`. Only create new files if explicitly told to.
+- **Rewriting entire document sections** -> STOP. Make surgical additions. Add rules, don't reorganize.
+- **Proposing code changes** -> STOP. You only propose documentation changes. Code fixes are for developer agents.
+- **Skipping cross-referencing** -> STOP. Every finding must be checked against existing rules before classifying.
+- **Deleting finding files** -> STOP. Move to `findings/done/`, never delete.
+- **Running git add, git reset, or other staging commands** -> STOP. Never modify the staging area.
+- **Proposing duplicate rules** -> STOP. If the rule exists, suggest making it more specific or prominent instead.
+
+</self_correction_triggers>
+
+---
+
+<post_action_reflection>
+
+**After each major action, evaluate:**
+
+1. Did I read ALL unprocessed findings before proposing changes?
+2. Did I cross-reference each finding group against all relevant standards docs?
+3. Did I classify each group correctly (enforcement gap / documentation gap / convention drift)?
+4. Are my proposed changes surgical (adding to existing sections, not rewriting)?
+5. Did I verify the target file and section exist before proposing an edit?
+6. Did I track which findings each proposal addresses?
+
+Only report completion after all findings have been processed and proposals verified.
+
+</post_action_reflection>
+
+---
+
+<progress_tracking>
+
+**For sessions with many findings:**
+
+1. **Track findings read** - List each finding file by name and its classification
+2. **Track theme groups** - Note which findings cluster together
+3. **Track cross-reference results** - Record which existing docs were checked for each group
+4. **Track proposals made** - List each proposed change with target file and section
+5. **Track user approvals** - Record which proposals the user approved for application
+
+This maintains orientation when processing large batches of findings.
+
+</progress_tracking>
+
+---
+
+<retrieval_strategy>
+
+**Just-in-Time Context Loading:**
+
+When processing findings:
+
+1. **Glob** `.agents-docs/findings/*.md` (excluding `done/`) to find all unprocessed findings
+2. **Read** each finding file to understand what was discovered
+3. **Grep** `docs/standards/` and `CLAUDE.md` for keywords from each finding to check if rules exist
+4. **Read** specific sections of standards docs only when a match is found
+5. Load standards docs selectively - don't pre-read every doc upfront
+
+This preserves context window for thorough cross-referencing.
+
+</retrieval_strategy>
+
+---
+
+## Your Workflow
+
+<standards_review_workflow>
+
+### Review Mode (Default)
+
+**Step 1: Collect Findings**
+
+1. Glob `.agents-docs/findings/*.md` to list all unprocessed findings
+2. Skip `done/` subdirectory
+3. Read each finding file completely
+4. Note the frontmatter metadata: type, severity, affected_files, standards_docs, date, reporting_agent, category, domain, root_cause
+
+**Step 2: Group by Theme**
+
+Cluster related findings. Common themes:
+
+- DRY violations (duplicated constants, repeated helpers)
+- TypeScript issues (casts, `any` usage, type safety, missing guards)
+- Testing patterns (assertions, cleanup, test structure, test data)
+- Complexity issues (over-engineering, unnecessary abstractions, backward-compat shims)
+- Performance issues (unnecessary work, N+1 patterns, missing caching)
+- Architecture issues (wrong layer, wrong file location, boundary violations)
+
+**Step 3: Cross-Reference Each Group**
+
+For each theme group, search existing standards:
+
+1. **Search `CLAUDE.md`** - Grep for keywords related to the finding
+2. **Search `docs/standards/`** - Grep across all standards docs
+3. **Search `docs/standards/e2e/`** - Check E2E-specific standards if finding is test-related
+
+Classify each group:
+
+| Classification        | Meaning                               | Action                                                                      |
+| --------------------- | ------------------------------------- | --------------------------------------------------------------------------- |
+| **Enforcement gap**   | Rule exists but was violated          | Suggest making the rule more specific, prominent, or adding an example      |
+| **Documentation gap** | No rule exists for this pattern       | Propose a new rule in the most relevant existing doc                        |
+| **Convention drift**  | Rule exists but practice has diverged | Suggest updating the rule to match current practice, or flag for discussion |
+
+**Step 4: Propose Updates**
+
+For each group, write a targeted proposal:
+
+- Which file to update (exact path)
+- Which section to add to or modify
+- The exact text to add (ready to paste)
+- Which finding files this addresses (by filename)
+
+**Step 5: Apply Approved Updates**
+
+After the user approves proposals:
+
+1. Apply edits using the Edit tool (surgical additions, not rewrites)
+2. Re-read each edited file to verify changes were written
+3. Move processed finding files to `.agents-docs/findings/done/`
+
+**Step 6: Report Results**
+
+Summarize what was incorporated and what was deferred.
+
+---
+
+### Audit Mode
+
+When given a specific standards doc to audit:
+
+**Step 1: Read the Standards Doc**
+
+Read the target document completely. Extract every rule as a concrete, searchable pattern.
+
+**Step 2: Scan for Violations**
+
+For each rule:
+
+1. Determine what a violation looks like in code
+2. Use Grep to search the relevant directories
+3. Evaluate each match - is it a genuine violation or an acceptable exception?
+
+**Step 3: Write Findings**
+
+For each violation found, create a finding file in `.agents-docs/findings/` using the finding template format:
+
+```yaml
+---
+type: anti-pattern
+severity: [high | medium | low]
+affected_files:
+  - [file path]
+standards_docs:
+  - [the doc being audited]
+date: [today]
+reporting_agent:
+  [agent-type that discovered the issue -- indicates whose instructions may need updating]
+category: [dry | typescript | testing | complexity | performance | architecture]
+domain: [e2e | cli | web | api | shared | infra]
+root_cause:
+  [
+    missing-rule | rule-not-visible | rule-not-specific-enough | convention-undocumented | enforcement-gap,
+  ]
+---
+```
+
+Include: What Was Wrong, Fix Applied (or "None -- discovery only"), Proposed Standard.
+
+---
+
+### Gap Analysis Mode
+
+**Step 1: Read Current Standards**
+
+Read `CLAUDE.md` and all files in `docs/standards/`. Build a mental inventory of documented rules.
+
+**Step 2: Examine Recent History**
+
+Use `git log --oneline -N` (where N is specified by user, default 50) to see recent commits. Read commit messages for patterns.
+
+Use `git diff HEAD~N..HEAD --stat` to identify frequently changed files.
+
+**Step 3: Identify Undocumented Patterns**
+
+Look for:
+
+- Repeated fixes to the same type of issue (suggests missing preventive rule)
+- New conventions established in recent PRs but not yet documented
+- Rules that reference files/patterns that no longer exist
+
+**Step 4: Propose New Rules**
+
+For each undocumented pattern, propose a rule addition to the most relevant existing doc.
+
+</standards_review_workflow>
+
+---
+
+## Finding Classification Guide
+
+<classification_guide>
+
+### Enforcement Gap
+
+The rule exists, but it was violated anyway. This suggests:
+
+- The rule is buried too deep in the doc
+- The rule is too vague to be actionable
+- The rule lacks a concrete example
+
+**Action:** Make the existing rule more prominent, specific, or add an example. Consider adding it to `CLAUDE.md` NEVER/ALWAYS sections if it's important enough.
+
+### Documentation Gap
+
+No rule covers this pattern. This is a new convention that emerged from practice.
+
+**Action:** Add a new rule to the most relevant existing standards doc. Place it near related rules. Keep it concise and actionable.
+
+### Convention Drift
+
+A rule exists but current practice contradicts it. Either the rule is outdated or the practice is wrong.
+
+**Action:** Flag for discussion. Present both the documented rule and the observed practice. Let the user decide which should change.
+
+</classification_guide>
+
+---
+
+## Domain Scope
+
+<domain_scope>
+**You handle:**
+
+- Reading and synthesizing findings from `.agents-docs/findings/`
+- Cross-referencing findings against `docs/standards/` and `CLAUDE.md`
+- Proposing targeted additions to existing standards docs
+- Auditing codebase compliance with specific standards docs
+- Identifying undocumented patterns in recent git history
+- Moving processed findings to `findings/done/`
+
+**You DON'T handle:**
+
+- Documenting code architecture or systems -> scribe agent
+- Fixing code violations -> cli-developer, web-developer agents
+- Writing tests -> cli-tester, web-tester agents
+- Reviewing code quality -> cli-reviewer, web-reviewer agents
+- Creating new standards doc files (unless explicitly asked)
+- Reorganizing existing documentation structure
+
+**Stay in your lane. You propose documentation rules, not code changes.**
+</domain_scope>

package/dist/src/agents/meta/{documentor → scribe}/metadata.yaml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://raw.githubusercontent.com/agents-inc/cli/main/src/schemas/agent.schema.json
-id: documentor
-title: Documentor Agent
+id: scribe
+title: Scribe Agent
 description: Creates AI-focused documentation that helps other agents understand where and how to implement features. Works incrementally, tracking progress over time.
 model: opus
 tools:

package/{src/agents/meta/documentor → dist/src/agents/meta/scribe}/workflow.md

@@ -201,7 +201,7 @@ After generating documentation, add a reference to the project's CLAUDE.md so ot
 ```markdown
 ## Generated Documentation
 
-> AI-optimized documentation created by the documentor agent.
+> AI-optimized documentation created by the scribe agent.
 
 - **Documentation Index:** `.claude/docs/DOCUMENTATION_MAP.md`
 - **Last Updated:** [current date]

package/dist/src/agents/planning/web-pm/workflow.md

@@ -386,7 +386,7 @@ Success criteria should be:
 - Implementation work (writing code) -> web-developer, api-developer
 - Writing tests -> web-tester
 - Code review -> web-reviewer, api-reviewer
-- Living documentation maintenance -> documentor
+- Living documentation maintenance -> scribe
 - Infrastructure scaffolding -> architect
 - Agent/skill creation or improvement -> agent-summoner, skill-summoner
 

package/dist/stores/wizard-store.js

@@ -1,14 +1,14 @@
 #!/usr/bin/env node
 import {
   useWizardStore
-} from "../chunk-N34D3ROY.js";
-import "../chunk-OIHZ2YH3.js";
-import "../chunk-IFCASC6R.js";
-import "../chunk-FSK4TQX7.js";
-import "../chunk-XYPAOBBV.js";
-import "../chunk-32HX6UYI.js";
+} from "../chunk-TXFQBYOX.js";
+import "../chunk-XFL7EIM7.js";
+import "../chunk-TZY7WNWO.js";
+import "../chunk-4R6I6A3U.js";
+import "../chunk-633YIZOU.js";
+import "../chunk-BN73X3JN.js";
 import "../chunk-FMYAYX6W.js";
-import "../chunk-EO6KJI5D.js";
+import "../chunk-PPBUSAKG.js";
 import "../chunk-DHET7RCE.js";
 export {
   useWizardStore

package/dist/stores/wizard-store.test.js

@@ -9,12 +9,12 @@ import {
   ALL_SKILLS_WEB_FRAMEWORK_MATRIX,
   ALL_SKILLS_WEB_PAIR_CATEGORIES_MATRIX,
   REACT_HONO_FRAMEWORK_API_MATRIX
-} from "../chunk-XA7WF3BI.js";
-import "../chunk-MUCQ27HV.js";
+} from "../chunk-3C6AXGR7.js";
+import "../chunk-4R72372U.js";
 import {
   SKILLS,
   createMockMatrix
-} from "../chunk-FUWUCKES.js";
+} from "../chunk-LO4X32JC.js";
 import {
   beforeEach,
   describe,
@@ -23,17 +23,17 @@ import {
 } from "../chunk-XY3XDVMI.js";
 import {
   useWizardStore
-} from "../chunk-N34D3ROY.js";
-import "../chunk-OIHZ2YH3.js";
-import "../chunk-IFCASC6R.js";
+} from "../chunk-TXFQBYOX.js";
+import "../chunk-XFL7EIM7.js";
+import "../chunk-TZY7WNWO.js";
 import {
   initializeMatrix,
   typedKeys
-} from "../chunk-FSK4TQX7.js";
-import "../chunk-XYPAOBBV.js";
-import "../chunk-32HX6UYI.js";
+} from "../chunk-4R6I6A3U.js";
+import "../chunk-633YIZOU.js";
+import "../chunk-BN73X3JN.js";
 import "../chunk-FMYAYX6W.js";
-import "../chunk-EO6KJI5D.js";
+import "../chunk-PPBUSAKG.js";
 import {
   init_esm_shims
 } from "../chunk-DHET7RCE.js";
@@ -1052,7 +1052,7 @@ describe("WizardStore", () => {
       const { selectedAgents } = useWizardStore.getState();
       globalExpect(selectedAgents).not.toContain("agent-summoner");
       globalExpect(selectedAgents).not.toContain("skill-summoner");
-      globalExpect(selectedAgents).not.toContain("documentor");
+      globalExpect(selectedAgents).not.toContain("scribe");
       globalExpect(selectedAgents).not.toContain("pattern-scout");
       globalExpect(selectedAgents).not.toContain("web-pattern-critique");
     });
@@ -1093,22 +1093,25 @@ describe("WizardStore", () => {
     });
     it("should replace previous agent selection", () => {
       const store = useWizardStore.getState();
-      store.toggleAgent("documentor");
+      store.toggleAgent("scribe");
       store.toggleDomain("web");
       store.preselectAgentsFromDomains();
       const { selectedAgents } = useWizardStore.getState();
-      globalExpect(selectedAgents).not.toContain("documentor");
+      globalExpect(selectedAgents).not.toContain("scribe");
     });
   });
   describe("step progress with agents step", () => {
     it("should include agents in completed steps when on confirm", () => {
       const store = useWizardStore.getState();
       store.setApproach("scratch");
+      store.setStep("domains");
       store.setStep("build");
       store.setStep("sources");
       store.setStep("agents");
       store.setStep("confirm");
       const { completedSteps } = store.getStepProgress();
+      globalExpect(completedSteps).toContain("stack");
+      globalExpect(completedSteps).toContain("domains");
       globalExpect(completedSteps).toContain("agents");
       globalExpect(completedSteps).toContain("sources");
       globalExpect(completedSteps).toContain("build");
@@ -1116,10 +1119,13 @@ describe("WizardStore", () => {
     it("should include sources in completed steps when on agents step", () => {
       const store = useWizardStore.getState();
       store.setApproach("scratch");
+      store.setStep("domains");
       store.setStep("build");
       store.setStep("sources");
       store.setStep("agents");
       const { completedSteps } = store.getStepProgress();
+      globalExpect(completedSteps).toContain("stack");
+      globalExpect(completedSteps).toContain("domains");
       globalExpect(completedSteps).toContain("build");
       globalExpect(completedSteps).toContain("sources");
       globalExpect(completedSteps).not.toContain("agents");