@agentproto/acp 0.3.0 → 0.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/LICENSE CHANGED
@@ -1,21 +1,202 @@
1
- MIT License
2
-
3
- Copyright (c) 2026 agentproto contributors
4
-
5
- Permission is hereby granted, free of charge, to any person obtaining a copy
6
- of this software and associated documentation files (the "Software"), to deal
7
- in the Software without restriction, including without limitation the rights
8
- to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9
- copies of the Software, and to permit persons to whom the Software is
10
- furnished to do so, subject to the following conditions:
11
-
12
- The above copyright notice and this permission notice shall be included in all
13
- copies or substantial portions of the Software.
14
-
15
- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16
- IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17
- FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18
- AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19
- LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20
- OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21
- SOFTWARE.
1
+
2
+ Apache License
3
+ Version 2.0, January 2004
4
+ http://www.apache.org/licenses/
5
+
6
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
7
+
8
+ 1. Definitions.
9
+
10
+ "License" shall mean the terms and conditions for use, reproduction,
11
+ and distribution as defined by Sections 1 through 9 of this document.
12
+
13
+ "Licensor" shall mean the copyright owner or entity authorized by
14
+ the copyright owner that is granting the License.
15
+
16
+ "Legal Entity" shall mean the union of the acting entity and all
17
+ other entities that control, are controlled by, or are under common
18
+ control with that entity. For the purposes of this definition,
19
+ "control" means (i) the power, direct or indirect, to cause the
20
+ direction or management of such entity, whether by contract or
21
+ otherwise, or (ii) ownership of fifty percent (50%) or more of the
22
+ outstanding shares, or (iii) beneficial ownership of such entity.
23
+
24
+ "You" (or "Your") shall mean an individual or Legal Entity
25
+ exercising permissions granted by this License.
26
+
27
+ "Source" form shall mean the preferred form for making modifications,
28
+ including but not limited to software source code, documentation
29
+ source, and configuration files.
30
+
31
+ "Object" form shall mean any form resulting from mechanical
32
+ transformation or translation of a Source form, including but
33
+ not limited to compiled object code, generated documentation,
34
+ and conversions to other media types.
35
+
36
+ "Work" shall mean the work of authorship, whether in Source or
37
+ Object form, made available under the License, as indicated by a
38
+ copyright notice that is included in or attached to the work
39
+ (an example is provided in the Appendix below).
40
+
41
+ "Derivative Works" shall mean any work, whether in Source or Object
42
+ form, that is based on (or derived from) the Work and for which the
43
+ editorial revisions, annotations, elaborations, or other modifications
44
+ represent, as a whole, an original work of authorship. For the purposes
45
+ of this License, Derivative Works shall not include works that remain
46
+ separable from, or merely link (or bind by name) to the interfaces of,
47
+ the Work and Derivative Works thereof.
48
+
49
+ "Contribution" shall mean any work of authorship, including
50
+ the original version of the Work and any modifications or additions
51
+ to that Work or Derivative Works thereof, that is intentionally
52
+ submitted to Licensor for inclusion in the Work by the copyright owner
53
+ or by an individual or Legal Entity authorized to submit on behalf of
54
+ the copyright owner. For the purposes of this definition, "submitted"
55
+ means any form of electronic, verbal, or written communication sent
56
+ to the Licensor or its representatives, including but not limited to
57
+ communication on electronic mailing lists, source code control systems,
58
+ and issue tracking systems that are managed by, or on behalf of, the
59
+ Licensor for the purpose of discussing and improving the Work, but
60
+ excluding communication that is conspicuously marked or otherwise
61
+ designated in writing by the copyright owner as "Not a Contribution."
62
+
63
+ "Contributor" shall mean Licensor and any individual or Legal Entity
64
+ on behalf of whom a Contribution has been received by Licensor and
65
+ subsequently incorporated within the Work.
66
+
67
+ 2. Grant of Copyright License. Subject to the terms and conditions of
68
+ this License, each Contributor hereby grants to You a perpetual,
69
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
70
+ copyright license to reproduce, prepare Derivative Works of,
71
+ publicly display, publicly perform, sublicense, and distribute the
72
+ Work and such Derivative Works in Source or Object form.
73
+
74
+ 3. Grant of Patent License. Subject to the terms and conditions of
75
+ this License, each Contributor hereby grants to You a perpetual,
76
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
77
+ (except as stated in this section) patent license to make, have made,
78
+ use, offer to sell, sell, import, and otherwise transfer the Work,
79
+ where such license applies only to those patent claims licensable
80
+ by such Contributor that are necessarily infringed by their
81
+ Contribution(s) alone or by combination of their Contribution(s)
82
+ with the Work to which such Contribution(s) was submitted. If You
83
+ institute patent litigation against any entity (including a
84
+ cross-claim or counterclaim in a lawsuit) alleging that the Work
85
+ or a Contribution incorporated within the Work constitutes direct
86
+ or contributory patent infringement, then any patent licenses
87
+ granted to You under this License for that Work shall terminate
88
+ as of the date such litigation is filed.
89
+
90
+ 4. Redistribution. You may reproduce and distribute copies of the
91
+ Work or Derivative Works thereof in any medium, with or without
92
+ modifications, and in Source or Object form, provided that You
93
+ meet the following conditions:
94
+
95
+ (a) You must give any other recipients of the Work or
96
+ Derivative Works a copy of this License; and
97
+
98
+ (b) You must cause any modified files to carry prominent notices
99
+ stating that You changed the files; and
100
+
101
+ (c) You must retain, in the Source form of any Derivative Works
102
+ that You distribute, all copyright, patent, trademark, and
103
+ attribution notices from the Source form of the Work,
104
+ excluding those notices that do not pertain to any part of
105
+ the Derivative Works; and
106
+
107
+ (d) If the Work includes a "NOTICE" text file as part of its
108
+ distribution, then any Derivative Works that You distribute must
109
+ include a readable copy of the attribution notices contained
110
+ within such NOTICE file, excluding those notices that do not
111
+ pertain to any part of the Derivative Works, in at least one
112
+ of the following places: within a NOTICE text file distributed
113
+ as part of the Derivative Works; within the Source form or
114
+ documentation, if provided along with the Derivative Works; or,
115
+ within a display generated by the Derivative Works, if and
116
+ wherever such third-party notices normally appear. The contents
117
+ of the NOTICE file are for informational purposes only and
118
+ do not modify the License. You may add Your own attribution
119
+ notices within Derivative Works that You distribute, alongside
120
+ or as an addendum to the NOTICE text from the Work, provided
121
+ that such additional attribution notices cannot be construed
122
+ as modifying the License.
123
+
124
+ You may add Your own copyright statement to Your modifications and
125
+ may provide additional or different license terms and conditions
126
+ for use, reproduction, or distribution of Your modifications, or
127
+ for any such Derivative Works as a whole, provided Your use,
128
+ reproduction, and distribution of the Work otherwise complies with
129
+ the conditions stated in this License.
130
+
131
+ 5. Submission of Contributions. Unless You explicitly state otherwise,
132
+ any Contribution intentionally submitted for inclusion in the Work
133
+ by You to the Licensor shall be under the terms and conditions of
134
+ this License, without any additional terms or conditions.
135
+ Notwithstanding the above, nothing herein shall supersede or modify
136
+ the terms of any separate license agreement you may have executed
137
+ with Licensor regarding such Contributions.
138
+
139
+ 6. Trademarks. This License does not grant permission to use the trade
140
+ names, trademarks, service marks, or product names of the Licensor,
141
+ except as required for reasonable and customary use in describing the
142
+ origin of the Work and reproducing the content of the NOTICE file.
143
+
144
+ 7. Disclaimer of Warranty. Unless required by applicable law or
145
+ agreed to in writing, Licensor provides the Work (and each
146
+ Contributor provides its Contributions) on an "AS IS" BASIS,
147
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
148
+ implied, including, without limitation, any warranties or conditions
149
+ of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
150
+ PARTICULAR PURPOSE. You are solely responsible for determining the
151
+ appropriateness of using or redistributing the Work and assume any
152
+ risks associated with Your exercise of permissions under this License.
153
+
154
+ 8. Limitation of Liability. In no event and under no legal theory,
155
+ whether in tort (including negligence), contract, or otherwise,
156
+ unless required by applicable law (such as deliberate and grossly
157
+ negligent acts) or agreed to in writing, shall any Contributor be
158
+ liable to You for damages, including any direct, indirect, special,
159
+ incidental, or consequential damages of any character arising as a
160
+ result of this License or out of the use or inability to use the
161
+ Work (including but not limited to damages for loss of goodwill,
162
+ work stoppage, computer failure or malfunction, or any and all
163
+ other commercial damages or losses), even if such Contributor
164
+ has been advised of the possibility of such damages.
165
+
166
+ 9. Accepting Warranty or Additional Liability. While redistributing
167
+ the Work or Derivative Works thereof, You may choose to offer,
168
+ and charge a fee for, acceptance of support, warranty, indemnity,
169
+ or other liability obligations and/or rights consistent with this
170
+ License. However, in accepting such obligations, You may act only
171
+ on Your own behalf and on Your sole responsibility, not on behalf
172
+ of any other Contributor, and only if You agree to indemnify,
173
+ defend, and hold each Contributor harmless for any liability
174
+ incurred by, or claims asserted against, such Contributor by reason
175
+ of your accepting any such warranty or additional liability.
176
+
177
+ END OF TERMS AND CONDITIONS
178
+
179
+ APPENDIX: How to apply the Apache License to your work.
180
+
181
+ To apply the Apache License to your work, attach the following
182
+ boilerplate notice, with the fields enclosed by brackets "[]"
183
+ replaced with your own identifying information. (Don't include
184
+ the brackets!) The text should be enclosed in the appropriate
185
+ comment syntax for the file format. We also recommend that a
186
+ file or class name and description of purpose be included on the
187
+ same "printed page" as the copyright notice for easier
188
+ identification within third-party archives.
189
+
190
+ Copyright [yyyy] [name of copyright owner]
191
+
192
+ Licensed under the Apache License, Version 2.0 (the "License");
193
+ you may not use this file except in compliance with the License.
194
+ You may obtain a copy of the License at
195
+
196
+ http://www.apache.org/licenses/LICENSE-2.0
197
+
198
+ Unless required by applicable law or agreed to in writing, software
199
+ distributed under the License is distributed on an "AS IS" BASIS,
200
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
201
+ See the License for the specific language governing permissions and
202
+ limitations under the License.
@@ -1,5 +1,5 @@
1
1
  import { ClientSideConnection, Client } from '@agentclientprotocol/sdk';
2
- import { S as StreamEvent } from '../types-DC2phPNG.js';
2
+ import { S as StreamEvent, e as AcpPermissionResolution } from '../types-DQCJO97x.js';
3
3
 
4
4
  /**
5
5
  * AIP-44 ACP client — drives a subprocess agent via stdio JSON-RPC.
@@ -12,14 +12,14 @@ import { S as StreamEvent } from '../types-DC2phPNG.js';
12
12
  */
13
13
 
14
14
  /**
15
- * Map our internal `AcpMcpServer` (`{ name, transport, ref }`) onto the
16
- * `@agentclientprotocol/sdk` wire shape expected by
15
+ * Map our internal `AcpMcpServer` (`{ name, transport, ref, headers, credentialRef }`)
16
+ * onto the `@agentclientprotocol/sdk` wire shape expected by
17
17
  * `session/new.mcpServers` (and `session/load.mcpServers`).
18
18
  *
19
19
  * The ACP `McpServer` union is transport-tagged and field-named
20
20
  * differently from our compact internal form:
21
- * - http → `{ type: "http", name, url, headers: [] }`
22
- * - sse → `{ type: "sse", name, url, headers: [] }`
21
+ * - http → `{ type: "http", name, url, headers: [{ name, value }, …] }`
22
+ * - sse → `{ type: "sse", name, url, headers: [{ name, value }, …] }`
23
23
  * - stdio → `{ name, command, args: [], env: [] }` (untagged variant)
24
24
  *
25
25
  * Without this mapping the raw `{ transport, ref }` entry reaches the
@@ -53,6 +53,16 @@ interface AcpClientOptions {
53
53
  };
54
54
  /** Optional handlers for agent-initiated requests beyond fs / terminal. */
55
55
  handlers?: Partial<Client>;
56
+ /**
57
+ * When true, every `session/request_permission` the agent raises is
58
+ * SURFACED (emitted as an `agent-prompt` StreamEvent on the session's
59
+ * stream) and HELD — the RPC does not resolve until the host calls
60
+ * `respondPermission(requestId, ...)`. `handlers.requestPermission` is
61
+ * bypassed while this is set. Undefined/false (the default) is unchanged:
62
+ * requests go straight to `handlers.requestPermission`. Used by the
63
+ * daemon's cross-session permission inbox.
64
+ */
65
+ permissionHold?: boolean;
56
66
  /** Protocol version to negotiate. Defaults to the SDK's current. */
57
67
  protocolVersion?: number;
58
68
  /**
@@ -97,6 +107,11 @@ interface AcpClient {
97
107
  * Model to select via `session/set_config_option` immediately after
98
108
  * `newSession`. The claude-agent-acp wrapper supports this as
99
109
  * `configId:"model"`. Omit to keep the agent's own default.
110
+ *
111
+ * Best-effort: a value the agent can't resolve (a stale/gated/typo'd id)
112
+ * is warned about and dropped — the session still starts on the agent's
113
+ * default model rather than crashing the spawn. See the reject handler
114
+ * in `newSession` for the reasoning (agentproto#186).
100
115
  */
101
116
  model?: string;
102
117
  /**
@@ -106,6 +121,15 @@ interface AcpClient {
106
121
  * Omit to keep the model's own default.
107
122
  */
108
123
  effort?: string;
124
+ /**
125
+ * Mode to select via `session/set_config_option` after `newSession`,
126
+ * for ACP servers that model mode selection as a session config
127
+ * option (`configId:"mode"`) instead of a CLI flag — e.g. opencode.
128
+ * Best-effort, same as `model`/`effort`: a rejection is warned about
129
+ * and dropped rather than failing the spawn. Omit to keep the
130
+ * agent's own default mode.
131
+ */
132
+ mode?: string;
109
133
  }): Promise<AcpClientSession>;
110
134
  /**
111
135
  * Reattach to an existing session by id. Available only when the
@@ -124,6 +148,15 @@ interface AcpClient {
124
148
  cwd: string;
125
149
  mcpServers?: unknown[];
126
150
  }): Promise<AcpClientSession>;
151
+ /**
152
+ * Resolve a permission request parked by permission-hold mode. `requestId`
153
+ * is the `toolCallId` carried on the `agent-prompt` StreamEvent that
154
+ * surfaced the request. Returns true when a matching parked request was
155
+ * found and resolved, false when the id is unknown or already resolved
156
+ * (idempotent — a duplicate response is a no-op). No-op returning false
157
+ * when `permissionHold` was never enabled.
158
+ */
159
+ respondPermission(requestId: string, resolution: AcpPermissionResolution): boolean;
127
160
  close(): Promise<void>;
128
161
  }
129
162
  interface AcpClientSession {
@@ -137,4 +170,4 @@ interface AcpClientSession {
137
170
  }
138
171
  declare function createAcpClient(options: AcpClientOptions): Promise<AcpClient>;
139
172
 
140
- export { type AcpClient, type AcpClientOptions, type AcpClientSession, createAcpClient, toAcpMcpServers };
173
+ export { type AcpClient, type AcpClientOptions, type AcpClientSession, AcpPermissionResolution, createAcpClient, toAcpMcpServers };
@@ -15,23 +15,59 @@ function toAcpMcpServer(server) {
15
15
  if ("type" in entry || "url" in entry || "command" in entry) return entry;
16
16
  const transport = entry.transport;
17
17
  if (typeof transport !== "string") return entry;
18
- const { name, ref } = entry;
18
+ const name = entry.name;
19
+ const ref = entry.ref;
20
+ const headers = entry.headers;
19
21
  switch (transport) {
20
22
  case "http":
21
- return { type: "http", name, url: ref ?? "", headers: [] };
23
+ return { type: "http", name, url: ref ?? "", headers: toAcpHeaders(headers) };
22
24
  case "sse":
23
- return { type: "sse", name, url: ref ?? "", headers: [] };
25
+ return { type: "sse", name, url: ref ?? "", headers: toAcpHeaders(headers) };
24
26
  case "stdio":
25
27
  return { name, command: ref ?? "", args: [], env: [] };
26
28
  default:
27
29
  return entry;
28
30
  }
29
31
  }
32
+ function toAcpHeaders(headers) {
33
+ if (!headers || typeof headers !== "object") return [];
34
+ return Object.entries(headers).map(([name, value]) => ({
35
+ name,
36
+ value: typeof value === "string" ? value : String(value)
37
+ }));
38
+ }
30
39
  async function createAcpClient(options) {
31
40
  const sessions = /* @__PURE__ */ new Map();
41
+ const pendingPermissions = /* @__PURE__ */ new Map();
42
+ let permissionSeq = 0;
43
+ const respondPermission = (requestId, resolution) => {
44
+ const held = pendingPermissions.get(requestId);
45
+ if (!held) return false;
46
+ pendingPermissions.delete(requestId);
47
+ held.resolve(
48
+ "cancelled" in resolution ? { outcome: { outcome: "cancelled" } } : { outcome: { outcome: "selected", optionId: resolution.optionId } }
49
+ );
50
+ return true;
51
+ };
52
+ const cancelPermissionsForSession = (sessionId) => {
53
+ const ids = [];
54
+ for (const [id, held] of pendingPermissions) {
55
+ if (held.sessionId === sessionId) ids.push(id);
56
+ }
57
+ for (const id of ids) {
58
+ const held = pendingPermissions.get(id);
59
+ if (!held) continue;
60
+ pendingPermissions.delete(id);
61
+ held.resolve({ outcome: { outcome: "cancelled" } });
62
+ }
63
+ };
32
64
  const stream = ndJsonStream(options.output, options.input);
33
65
  const connection = new ClientSideConnection(
34
- () => buildClientHandlers(options.handlers ?? {}, sessions, options.onActivity),
66
+ () => buildClientHandlers(options.handlers ?? {}, sessions, options.onActivity, {
67
+ permissionHold: options.permissionHold ?? false,
68
+ pendingPermissions,
69
+ nextRequestId: () => `perm_${++permissionSeq}`
70
+ }),
35
71
  stream
36
72
  );
37
73
  const initResponse = await connection.initialize({
@@ -61,12 +97,18 @@ async function createAcpClient(options) {
61
97
  };
62
98
  sessions.set(sessionId, state);
63
99
  if (params.model) {
64
- await connection.setSessionConfigOption({
65
- configId: "model",
66
- value: params.model,
67
- sessionId
68
- });
69
- options.onActivity?.();
100
+ try {
101
+ await connection.setSessionConfigOption({
102
+ configId: "model",
103
+ value: params.model,
104
+ sessionId
105
+ });
106
+ options.onActivity?.();
107
+ } catch (err) {
108
+ console.warn(
109
+ `[acp] set_config_option model="${params.model}" rejected by server \u2014 keeping the agent's default model. Reason: ${configOptionErrorDetail(err)}`
110
+ );
111
+ }
70
112
  }
71
113
  if (params.effort) {
72
114
  try {
@@ -78,8 +120,21 @@ async function createAcpClient(options) {
78
120
  options.onActivity?.();
79
121
  } catch (err) {
80
122
  console.warn(
81
- `[acp] set_config_option effort="${params.effort}" rejected by server (best-effort):`,
82
- err instanceof Error ? err.message : err
123
+ `[acp] set_config_option effort="${params.effort}" rejected by server (best-effort): ${configOptionErrorDetail(err)}`
124
+ );
125
+ }
126
+ }
127
+ if (params.mode) {
128
+ try {
129
+ await connection.setSessionConfigOption({
130
+ configId: "mode",
131
+ value: params.mode,
132
+ sessionId
133
+ });
134
+ options.onActivity?.();
135
+ } catch (err) {
136
+ console.warn(
137
+ `[acp] set_config_option mode="${params.mode}" rejected by server (best-effort): ${configOptionErrorDetail(err)}`
83
138
  );
84
139
  }
85
140
  }
@@ -89,7 +144,8 @@ async function createAcpClient(options) {
89
144
  state,
90
145
  sessions,
91
146
  options.onActivity,
92
- options.turnIdleTimeoutMs
147
+ options.turnIdleTimeoutMs,
148
+ cancelPermissionsForSession
93
149
  );
94
150
  },
95
151
  async loadSession(params) {
@@ -112,10 +168,16 @@ async function createAcpClient(options) {
112
168
  state,
113
169
  sessions,
114
170
  options.onActivity,
115
- options.turnIdleTimeoutMs
171
+ options.turnIdleTimeoutMs,
172
+ cancelPermissionsForSession
116
173
  );
117
174
  },
175
+ respondPermission,
118
176
  async close() {
177
+ for (const [, held] of pendingPermissions) {
178
+ held.resolve({ outcome: { outcome: "cancelled" } });
179
+ }
180
+ pendingPermissions.clear();
119
181
  sessions.clear();
120
182
  }
121
183
  };
@@ -130,7 +192,7 @@ function clientCapabilitiesFromOptions(options) {
130
192
  terminal: caps.terminal ?? false
131
193
  };
132
194
  }
133
- function buildSession(connection, sessionId, state, sessions, onActivity, turnIdleTimeoutMs) {
195
+ function buildSession(connection, sessionId, state, sessions, onActivity, turnIdleTimeoutMs, cancelPermissionsForSession) {
134
196
  return {
135
197
  sessionId,
136
198
  prompt(input) {
@@ -217,6 +279,7 @@ function buildSession(connection, sessionId, state, sessions, onActivity, turnId
217
279
  onActivity?.();
218
280
  },
219
281
  async close() {
282
+ cancelPermissionsForSession(sessionId);
220
283
  sessions.delete(sessionId);
221
284
  }
222
285
  };
@@ -259,8 +322,47 @@ function flush(state) {
259
322
  r(void 0);
260
323
  }
261
324
  }
262
- function buildClientHandlers(partial, sessions, onActivity) {
325
+ function holdPermissionRequest(rawParams, sessions, ctx) {
326
+ const params = rawParams ?? {};
327
+ const sessionId = params.sessionId ?? "";
328
+ const requestId = ctx.nextRequestId();
329
+ const options = Array.isArray(params.options) ? params.options.filter(
330
+ (o) => typeof o?.optionId === "string"
331
+ ).map((o) => ({
332
+ optionId: o.optionId,
333
+ ...typeof o.name === "string" ? { name: o.name } : {},
334
+ ...typeof o.kind === "string" ? { kind: o.kind } : {}
335
+ })) : [];
336
+ const toolName = params.toolCall?.title ?? params.toolCall?.kind;
337
+ const text = toolName ? `Allow "${toolName}"?` : "The agent is requesting permission to run a tool.";
338
+ const state = sessions.get(sessionId);
339
+ if (state) {
340
+ enqueue(state, {
341
+ kind: "agent-prompt",
342
+ sessionId,
343
+ toolCallId: requestId,
344
+ options,
345
+ text,
346
+ ...toolName ? { toolName } : {}
347
+ });
348
+ } else {
349
+ console.warn(
350
+ `[acp] permission-hold: no session state for sessionId="${sessionId}" (request ${requestId}) \u2014 parking the RPC but not surfacing an agent-prompt event.`
351
+ );
352
+ }
353
+ return new Promise((resolve) => {
354
+ ctx.pendingPermissions.set(requestId, { sessionId, resolve });
355
+ });
356
+ }
357
+ function buildClientHandlers(partial, sessions, onActivity, hold) {
263
358
  return {
359
+ // Spread the caller-supplied handlers FIRST so the named methods defined
360
+ // below always win. This matters for `requestPermission`: the arm always
361
+ // passes a `requestPermission` handler, and if that spread came last it
362
+ // would clobber the permission-hold guard below — silently bypassing hold
363
+ // mode. With the spread first, our guard stays in control and still falls
364
+ // through to `partial.requestPermission` when hold mode is OFF.
365
+ ...partial,
264
366
  async sessionUpdate(params) {
265
367
  onActivity?.();
266
368
  const sid = params.sessionId;
@@ -275,6 +377,10 @@ function buildClientHandlers(partial, sessions, onActivity) {
275
377
  if (partial.sessionUpdate) await partial.sessionUpdate(params);
276
378
  },
277
379
  async requestPermission(params) {
380
+ onActivity?.();
381
+ if (hold.permissionHold) {
382
+ return holdPermissionRequest(params, sessions, hold);
383
+ }
278
384
  if (partial.requestPermission) return partial.requestPermission(params);
279
385
  throw new Error("AcpClient.requestPermission: no handler configured");
280
386
  },
@@ -285,8 +391,41 @@ function buildClientHandlers(partial, sessions, onActivity) {
285
391
  async writeTextFile(params) {
286
392
  if (partial.writeTextFile) return partial.writeTextFile(params);
287
393
  throw new Error("AcpClient.writeTextFile: capability not advertised");
288
- },
289
- ...partial
394
+ }
395
+ };
396
+ }
397
+ function isEmptyish(value) {
398
+ if (value == null) return true;
399
+ if (Array.isArray(value)) return value.length === 0;
400
+ if (typeof value === "object") return Object.keys(value).length === 0;
401
+ return false;
402
+ }
403
+ function toolCallArguments(update) {
404
+ const rawInput = update.rawInput;
405
+ if (!isEmptyish(rawInput)) return rawInput;
406
+ const locations = update.locations;
407
+ if (locations && locations.length > 0) {
408
+ const first = locations[0];
409
+ return locations.length === 1 ? { path: first.path, ...first.line != null ? { line: first.line } : {} } : { paths: locations.map((location) => location.path) };
410
+ }
411
+ if (!isEmptyish(update.content)) return update.content;
412
+ return rawInput != null ? rawInput : void 0;
413
+ }
414
+ function toolCallEnrichment(sessionId, update) {
415
+ const toolCallId = update.toolCallId;
416
+ if (!toolCallId) return null;
417
+ const args = toolCallArguments(update);
418
+ const title = typeof update.title === "string" ? update.title : void 0;
419
+ if (args === void 0 && title === void 0) return null;
420
+ return {
421
+ kind: "tool-call",
422
+ sessionId,
423
+ toolCallId,
424
+ // "" when the update carried no title — consumers merge only non-empty
425
+ // names, so an untitled enrichment can't erase the announced one.
426
+ toolName: title ?? "",
427
+ arguments: args,
428
+ isUpdate: true
290
429
  };
291
430
  }
292
431
  function translateSessionUpdate(sessionId, update) {
@@ -306,20 +445,12 @@ function translateSessionUpdate(sessionId, update) {
306
445
  case "tool_call": {
307
446
  const toolCallId = update.toolCallId ?? "";
308
447
  const toolName = update.title ?? update.kind ?? "tool";
309
- const locations = update.locations;
310
- let args = update.rawInput ?? update.content ?? {};
311
- if (update.rawInput == null && locations && locations.length > 0) {
312
- args = locations.length === 1 ? {
313
- path: locations[0].path,
314
- ...locations[0].line != null ? { line: locations[0].line } : {}
315
- } : { paths: locations.map((location) => location.path) };
316
- }
317
448
  return {
318
449
  kind: "tool-call",
319
450
  sessionId,
320
451
  toolCallId,
321
452
  toolName,
322
- arguments: args
453
+ arguments: toolCallArguments(update) ?? {}
323
454
  };
324
455
  }
325
456
  case "tool_call_update": {
@@ -333,7 +464,7 @@ function translateSessionUpdate(sessionId, update) {
333
464
  isError: status === "failed"
334
465
  };
335
466
  }
336
- return null;
467
+ return toolCallEnrichment(sessionId, update);
337
468
  }
338
469
  case "plan": {
339
470
  const entries = update.entries ?? [];
@@ -349,12 +480,23 @@ function translateSessionUpdate(sessionId, update) {
349
480
  }
350
481
  case "usage_update": {
351
482
  const cost = update.cost;
483
+ const numeric = (...keys) => {
484
+ for (const key of keys) {
485
+ const v = update[key];
486
+ if (typeof v === "number") return v;
487
+ }
488
+ return void 0;
489
+ };
490
+ const tokensIn = numeric("tokensIn", "input_tokens", "inputTokens");
491
+ const tokensOut = numeric("tokensOut", "output_tokens", "outputTokens");
352
492
  return {
353
493
  kind: "usage_update",
354
494
  sessionId,
355
495
  size: update.size ?? 0,
356
496
  used: update.used ?? 0,
357
- ...cost ? { cost } : {}
497
+ ...cost ? { cost } : {},
498
+ ...tokensIn !== void 0 ? { tokensIn } : {},
499
+ ...tokensOut !== void 0 ? { tokensOut } : {}
358
500
  };
359
501
  }
360
502
  case "user_message_chunk":
@@ -363,6 +505,20 @@ function translateSessionUpdate(sessionId, update) {
363
505
  return null;
364
506
  }
365
507
  }
508
+ function configOptionErrorDetail(err) {
509
+ if (typeof err === "object" && err !== null) {
510
+ if ("data" in err && typeof err.data === "object" && err.data !== null) {
511
+ const data = err.data;
512
+ if ("details" in data && typeof data.details === "string" && data.details.length > 0) {
513
+ return data.details;
514
+ }
515
+ }
516
+ if ("message" in err && typeof err.message === "string" && err.message.length > 0) {
517
+ return err.message;
518
+ }
519
+ }
520
+ return String(err);
521
+ }
366
522
  function extractText(content) {
367
523
  if (!content) return "";
368
524
  if (typeof content === "string") return content;