@agentprojectcontext/apx 1.77.2 → 1.78.0

package/src/core/http-tools/registry.js

@@ -1,564 +1,15 @@
-// Tool Registry on-demand for APX.
+// Tool registry — lookup and HTTP surface.
 //
-// Endpoints registered by api.js:
-//   GET  /tools              → lightweight list [{name, description, category, schema_url}]
-//   GET  /tools/:name        → full schema + examples
-//   POST /tools/:name/call   → execute the tool (proxy to internal handler)
+// Endpoints registered by api.js (mounted under /api):
+//   GET  /api/tools              → lightweight list [{name, description, category, schema_url}]
+//   GET  /api/tools/:name        → full schema + examples
+//   POST /api/tools/:name/call   → execute the tool (proxy to internal handler)
 //
-// Tools that already exist as HTTP endpoints are listed here with their
-// endpoint targets — no code duplication.
+// The catalog itself lives in ./catalog.js and the in-process executors in
+// ./inline-handlers.js. This module only indexes and serves them.
+import { TOOL_DEFINITIONS } from "./catalog.js";
+import { makeInlineHandlers } from "./inline-handlers.js";
 
-// ---------------------------------------------------------------------------
-// Tool definitions
-// ---------------------------------------------------------------------------
-
-const TOOL_DEFINITIONS = [
-  // ── file ──────────────────────────────────────────────────────────────────
-  {
-    name: "read_file",
-    category: "file",
-    description: "Read the contents of a file inside the project.",
-    endpoint: { method: "GET", path: "/files", query: ["path", "project"] },
-    parameters: {
-      type: "object",
-      properties: {
-        path: { type: "string", description: "Relative path inside the project" },
-        project: { type: "string", description: "Project ID or path (optional)" },
-      },
-      required: ["path"],
-    },
-    examples: [{ path: "src/index.js" }],
-  },
-  {
-    name: "write_file",
-    category: "file",
-    description: "Write or overwrite a file inside the project.",
-    endpoint: { method: "POST", path: "/files" },
-    parameters: {
-      type: "object",
-      properties: {
-        path: { type: "string" },
-        content: { type: "string" },
-        project: { type: "string" },
-      },
-      required: ["path", "content"],
-    },
-    examples: [{ path: "notes.md", content: "# Hello" }],
-  },
-  {
-    name: "list_files",
-    category: "file",
-    description: "List files and directories inside a project path.",
-    endpoint: { method: "GET", path: "/files" },
-    parameters: {
-      type: "object",
-      properties: {
-        path: { type: "string", description: "Sub-path to list (optional)" },
-        project: { type: "string" },
-      },
-    },
-    examples: [{ path: "src" }],
-  },
-  {
-    name: "search_files",
-    category: "file",
-    description: "Search for files by name glob or content pattern in the project.",
-    endpoint: { method: "GET", path: "/files/search" },
-    parameters: {
-      type: "object",
-      properties: {
-        q: { type: "string", description: "Search query (filename or content)" },
-        project: { type: "string" },
-      },
-      required: ["q"],
-    },
-    examples: [{ q: "*.config.js" }],
-  },
-
-  // ── shell ─────────────────────────────────────────────────────────────────
-  {
-    name: "run_command",
-    category: "shell",
-    description: "Execute a shell command in the project directory. Returns stdout, stderr, exit_code.",
-    endpoint: { method: "POST", path: "/run" },
-    parameters: {
-      type: "object",
-      properties: {
-        cmd: { type: "string", description: "Shell command to run" },
-        cwd: { type: "string", description: "Working directory override" },
-        project: { type: "string" },
-        timeout_ms: { type: "integer", default: 30000 },
-      },
-      required: ["cmd"],
-    },
-    examples: [{ cmd: "ls -la" }, { cmd: "git log --oneline -5" }],
-  },
-
-  // ── memory ────────────────────────────────────────────────────────────────
-  {
-    name: "memory_get",
-    category: "memory",
-    description: "Read the memory.md of the default agent in a project.",
-    endpoint: { method: "GET", path: "/memory" },
-    parameters: {
-      type: "object",
-      properties: {
-        project: { type: "string" },
-      },
-    },
-    examples: [{}],
-  },
-  {
-    name: "memory_set",
-    category: "memory",
-    description: "Overwrite the memory.md of the default agent in a project.",
-    endpoint: { method: "POST", path: "/memory" },
-    parameters: {
-      type: "object",
-      properties: {
-        body: { type: "string", description: "Full content to write" },
-        project: { type: "string" },
-      },
-      required: ["body"],
-    },
-    examples: [{ body: "# Agent Memory\n\n- Remember to greet the user." }],
-  },
-  {
-    name: "memory_append",
-    category: "memory",
-    description: "Append text to the agent memory.md (read-modify-write).",
-    endpoint: null, // implemented inline in the call handler
-    parameters: {
-      type: "object",
-      properties: {
-        text: { type: "string" },
-        project: { type: "string" },
-      },
-      required: ["text"],
-    },
-    examples: [{ text: "\n- New fact to remember." }],
-  },
-  {
-    name: "memory_list",
-    category: "memory",
-    description: "List all agents that have memory files in a project.",
-    endpoint: null,
-    parameters: {
-      type: "object",
-      properties: { project: { type: "string" } },
-    },
-    examples: [{}],
-  },
-
-  // ── session ───────────────────────────────────────────────────────────────
-  {
-    name: "session_list",
-    category: "session",
-    description: "List sessions for an agent in a project.",
-    endpoint: { method: "GET", path: "/projects/:pid/agents/:slug/sessions" },
-    parameters: {
-      type: "object",
-      properties: {
-        project: { type: "string", description: "Project ID" },
-        agent: { type: "string", description: "Agent slug" },
-      },
-      required: ["project", "agent"],
-    },
-    examples: [{ project: "1", agent: "sofia" }],
-  },
-  {
-    name: "session_get",
-    category: "session",
-    description: "Get a session by filename.",
-    endpoint: { method: "GET", path: "/projects/:pid/sessions/:sid" },
-    parameters: {
-      type: "object",
-      properties: {
-        project: { type: "string" },
-        session_id: { type: "string" },
-      },
-      required: ["project", "session_id"],
-    },
-    examples: [{ project: "1", session_id: "2026-05-01-planning.md" }],
-  },
-  {
-    name: "session_search",
-    category: "session",
-    description: "Search session content by text query across all agents in a project.",
-    endpoint: { method: "GET", path: "/sessions/search" },
-    parameters: {
-      type: "object",
-      properties: {
-        q: { type: "string", description: "Search query" },
-        project: { type: "string" },
-        limit: { type: "integer", default: 20 },
-      },
-      required: ["q"],
-    },
-    examples: [{ q: "authentication bug" }],
-  },
-  {
-    name: "session_compact",
-    category: "session",
-    description: "Compact (summarise and compress) a session conversation.",
-    endpoint: { method: "POST", path: "/sessions/:id/compact" },
-    parameters: {
-      type: "object",
-      properties: {
-        session_id: { type: "string" },
-        project: { type: "string" },
-        agent: { type: "string" },
-        model: { type: "string" },
-      },
-      required: ["project", "agent", "session_id"],
-    },
-    examples: [{ project: "1", agent: "sofia", session_id: "2026-05-01-planning.md" }],
-  },
-
-  // ── mcp ───────────────────────────────────────────────────────────────────
-  {
-    name: "mcp_list",
-    category: "mcp",
-    description: "List all MCP servers registered in a project.",
-    endpoint: { method: "GET", path: "/mcp" },
-    parameters: {
-      type: "object",
-      properties: { project: { type: "string" } },
-    },
-    examples: [{}],
-  },
-  {
-    name: "mcp_run",
-    category: "mcp",
-    description: "Call a tool on an MCP server.",
-    endpoint: { method: "POST", path: "/mcp/run" },
-    parameters: {
-      type: "object",
-      properties: {
-        name: { type: "string", description: "MCP server name" },
-        tool: { type: "string", description: "Tool name on that server" },
-        params: { type: "object" },
-        project: { type: "string" },
-      },
-      required: ["name", "tool"],
-    },
-    examples: [{ name: "filesystem", tool: "list_directory", params: { path: "/tmp" } }],
-  },
-
-  // ── glob / grep ───────────────────────────────────────────────────────────
-  {
-    name: "glob",
-    category: "file",
-    description: "List files matching a glob pattern (e.g. **/*.js). Uses native Node.js glob.",
-    endpoint: { method: "POST", path: "/tools/glob" },
-    parameters: {
-      type: "object",
-      properties: {
-        pattern: { type: "string", description: "Glob pattern, e.g. src/**/*.ts" },
-        cwd: { type: "string", description: "Base directory (absolute path)" },
-        dot: { type: "boolean", default: false, description: "Include dotfiles" },
-        absolute: { type: "boolean", default: false },
-        limit: { type: "integer", default: 500 },
-      },
-      required: ["pattern"],
-    },
-    examples: [
-      { pattern: "**/*.js", cwd: "/my/project" },
-      { pattern: "src/**/*.ts", cwd: "/my/project", limit: 100 },
-    ],
-  },
-  {
-    name: "grep",
-    category: "file",
-    description: "Search file contents by regex pattern. Uses ripgrep when available, pure Node.js fallback.",
-    endpoint: { method: "POST", path: "/tools/grep" },
-    parameters: {
-      type: "object",
-      properties: {
-        pattern: { type: "string", description: "Regex to search for" },
-        path: { type: "string", description: "Directory or file to search in" },
-        glob: { type: "string", description: "Glob filter for files, e.g. *.ts" },
-        case_sensitive: { type: "boolean", default: false },
-        context: { type: "integer", default: 0, description: "Lines of context around matches" },
-        limit: { type: "integer", default: 100 },
-      },
-      required: ["pattern"],
-    },
-    examples: [
-      { pattern: "export default", path: "/my/project/src", glob: "*.js" },
-      { pattern: "TODO|FIXME", path: "/my/project", context: 2 },
-    ],
-  },
-
-  // ── fetch (native HTTP, no browser) ───────────────────────────────────────
-  {
-    name: "http_get",
-    category: "fetch",
-    description: "Native HTTP GET — fast, no headless browser. Use for REST APIs, raw HTML, JSON endpoints.",
-    endpoint: { method: "POST", path: "/tools/fetch/get" },
-    parameters: {
-      type: "object",
-      properties: {
-        url: { type: "string" },
-        headers: { type: "object" },
-        timeout_ms: { type: "number", default: 30000 },
-      },
-      required: ["url"],
-    },
-    examples: [{ url: "https://api.github.com/repos/anthropics/anthropic-sdk-typescript" }],
-  },
-  {
-    name: "http_post",
-    category: "fetch",
-    description: "Native HTTP POST — sends body as JSON when body is an object. Use for REST APIs.",
-    endpoint: { method: "POST", path: "/tools/fetch/post" },
-    parameters: {
-      type: "object",
-      properties: {
-        url: { type: "string" },
-        body: { description: "Object → JSON-stringified. String → sent as-is." },
-        headers: { type: "object" },
-        timeout_ms: { type: "number", default: 30000 },
-        json: { type: "boolean", description: "Force JSON parsing of response body." },
-      },
-      required: ["url"],
-    },
-    examples: [{ url: "https://api.example.com/items", body: { name: "foo" } }],
-  },
-  {
-    name: "http_request",
-    category: "fetch",
-    description: "Generic HTTP request with full control over method, headers, body, timeout.",
-    endpoint: { method: "POST", path: "/tools/fetch/request" },
-    parameters: {
-      type: "object",
-      properties: {
-        url: { type: "string" },
-        method: { type: "string", default: "GET" },
-        headers: { type: "object" },
-        body: {},
-        timeout_ms: { type: "number", default: 30000 },
-        json: { type: "boolean" },
-      },
-      required: ["url"],
-    },
-    examples: [{ url: "https://api.example.com/x", method: "DELETE" }],
-  },
-
-  // ── browser (Puppeteer-backed — heavier, launches Chromium lazily) ────────
-  {
-    name: "browser_navigate",
-    category: "browser",
-    description: "Navigate the headless browser to a URL. Launches Chromium lazily on first call. Auto-retries and falls back to a more permissive wait strategy on redirect-heavy sites.",
-    endpoint: { method: "POST", path: "/tools/browser/navigate" },
-    parameters: {
-      type: "object",
-      properties: {
-        url: { type: "string" },
-        wait_until: {
-          type: "string",
-          enum: ["load", "domcontentloaded", "networkidle0", "networkidle2"],
-          description: "Puppeteer wait strategy (default networkidle2). Use 'domcontentloaded' for slow/redirect-heavy sites; navigate auto-falls back to it on failure anyway.",
-        },
-        launch_options: { type: "object", description: "Puppeteer launch overrides (headless, args, defaultViewport, etc.)." },
-        allow_dangerous: { type: "boolean", description: "Allow dangerous launch args (--no-sandbox, --single-process, etc.)." },
-      },
-      required: ["url"],
-    },
-    examples: [{ url: "https://example.com" }],
-  },
-  {
-    name: "browser_screenshot",
-    category: "browser",
-    description: "Take a screenshot of the current browser page (or an element via selector). Returns { base64, path?, bytes, url }. To send via Telegram, prefer `save_to_tmp: true` and pass the returned `path` to send_telegram({photo_path}); otherwise pass `base64` straight to send_telegram({photo_base64}). NEVER include the base64 in any text field — Telegram does not render it.",
-    endpoint: { method: "POST", path: "/tools/browser/screenshot" },
-    parameters: {
-      type: "object",
-      properties: {
-        selector:    { type: "string",  description: "CSS selector of element to capture. Omit for full viewport/page." },
-        full_page:   { type: "boolean", default: false },
-        width:       { type: "number",  description: "Viewport width (capped at 1920)." },
-        height:      { type: "number",  description: "Viewport height (capped at 1080)." },
-        encoded:     { type: "boolean", description: "Also return a data:image/png;base64 URI in response." },
-        save_path:   { type: "string",  description: "Absolute path to write the PNG. Returns it in `path`." },
-        save_to_tmp: { type: "boolean", description: "Auto-write to <os.tmpdir>/apx-screenshots/screenshot-<ts>.png. Returns the path." },
-      },
-    },
-    examples: [{}, { selector: "#hero" }, { save_to_tmp: true }],
-  },
-  {
-    name: "browser_click",
-    category: "browser",
-    description: "Click a CSS selector on the current browser page.",
-    endpoint: { method: "POST", path: "/tools/browser/click" },
-    parameters: {
-      type: "object",
-      properties: { selector: { type: "string" } },
-      required: ["selector"],
-    },
-    examples: [{ selector: "button#submit" }],
-  },
-  {
-    name: "browser_type",
-    category: "browser",
-    description: "Type text into a CSS selector. Uses focus + Ctrl+A + Backspace to clear, then types with realistic delay.",
-    endpoint: { method: "POST", path: "/tools/browser/type" },
-    parameters: {
-      type: "object",
-      properties: {
-        selector: { type: "string" },
-        text: { type: "string" },
-        clear: { type: "boolean", default: true },
-      },
-      required: ["selector", "text"],
-    },
-    examples: [{ selector: "input#search", text: "hello world" }],
-  },
-  {
-    name: "browser_select",
-    category: "browser",
-    description: "Choose an option in a <select> element by its value.",
-    endpoint: { method: "POST", path: "/tools/browser/select" },
-    parameters: {
-      type: "object",
-      properties: {
-        selector: { type: "string" },
-        value: { type: "string" },
-      },
-      required: ["selector", "value"],
-    },
-    examples: [{ selector: "select#country", value: "AR" }],
-  },
-  {
-    name: "browser_hover",
-    category: "browser",
-    description: "Hover the cursor over an element (triggers tooltips, dropdowns, hover states).",
-    endpoint: { method: "POST", path: "/tools/browser/hover" },
-    parameters: {
-      type: "object",
-      properties: { selector: { type: "string" } },
-      required: ["selector"],
-    },
-    examples: [{ selector: "nav .menu-item" }],
-  },
-  {
-    name: "browser_evaluate",
-    category: "browser",
-    description: "Execute JavaScript in the page context. Captures the script's console.log/info/warn/error output and returns it alongside the result.",
-    endpoint: { method: "POST", path: "/tools/browser/evaluate" },
-    parameters: {
-      type: "object",
-      properties: { code: { type: "string", description: "JS code to eval (function body)." } },
-      required: ["code"],
-    },
-    examples: [{ code: "return document.title;" }],
-  },
-  {
-    name: "browser_get_text",
-    category: "browser",
-    description: "Extract readable text from the current page (or a single element). Strips script/style/nav/header/footer.",
-    endpoint: { method: "POST", path: "/tools/browser/get_text" },
-    parameters: {
-      type: "object",
-      properties: { selector: { type: "string", description: "Optional CSS selector." } },
-    },
-    examples: [{}, { selector: "article" }],
-  },
-  {
-    name: "browser_get_content",
-    category: "browser",
-    description: "Return raw innerHTML of the page or a single element (truncated at 1MB).",
-    endpoint: { method: "POST", path: "/tools/browser/get_content" },
-    parameters: {
-      type: "object",
-      properties: { selector: { type: "string" } },
-    },
-    examples: [{}, { selector: "main" }],
-  },
-  {
-    name: "browser_wait_for_selector",
-    category: "browser",
-    description: "Wait until a CSS selector appears on the page.",
-    endpoint: { method: "POST", path: "/tools/browser/wait_for_selector" },
-    parameters: {
-      type: "object",
-      properties: {
-        selector: { type: "string" },
-        timeout: { type: "number", default: 30000 },
-      },
-      required: ["selector"],
-    },
-    examples: [{ selector: ".results-loaded" }],
-  },
-  {
-    name: "browser_close",
-    category: "browser",
-    description: "Close the headless browser and free resources.",
-    endpoint: { method: "POST", path: "/tools/browser/close" },
-    parameters: { type: "object", properties: {} },
-    examples: [{}],
-  },
-
-  // ── search ────────────────────────────────────────────────────────────────
-  {
-    name: "web_search",
-    category: "search",
-    description: "Search the web. Modes: auto (tries DDG → Brave → Browser), ddg, brave, browser.",
-    endpoint: { method: "POST", path: "/tools/search" },
-    parameters: {
-      type: "object",
-      properties: {
-        query: { type: "string" },
-        mode: { type: "string", enum: ["auto", "ddg", "brave", "browser"], default: "auto" },
-        limit: { type: "integer", default: 5 },
-      },
-      required: ["query"],
-    },
-    examples: [
-      { query: "APC agent project context standard" },
-      { query: "site:github.com puppeteer examples", mode: "ddg" },
-    ],
-  },
-
-  // ── agents ────────────────────────────────────────────────────────────────
-  {
-    name: "agent_list",
-    category: "agents",
-    description: "List all agents in a project.",
-    endpoint: { method: "GET", path: "/projects/:pid/agents" },
-    parameters: {
-      type: "object",
-      properties: { project: { type: "string" } },
-      required: ["project"],
-    },
-    examples: [{ project: "1" }],
-  },
-  {
-    name: "agent_get",
-    category: "agents",
-    description: "Get details + memory for a specific agent.",
-    endpoint: { method: "GET", path: "/projects/:pid/agents/:slug" },
-    parameters: {
-      type: "object",
-      properties: {
-        project: { type: "string" },
-        agent: { type: "string" },
-      },
-      required: ["project", "agent"],
-    },
-    examples: [{ project: "1", agent: "sofia" }],
-  },
-
-  // ── project ───────────────────────────────────────────────────────────────
-  {
-    name: "project_info",
-    category: "project",
-    description: "List all registered projects and their metadata.",
-    endpoint: { method: "GET", path: "/projects" },
-    parameters: { type: "object", properties: {} },
-    examples: [{}],
-  },
-];
 
 // ---------------------------------------------------------------------------
 // Index for fast lookup
@@ -571,7 +22,7 @@ function listTools() {
     name,
     description,
     category,
-    schema_url: `/tools/${name}`,
+    schema_url: `/api/tools/${name}`,
     endpoint_method: endpoint?.method || "inline",
     endpoint_path: endpoint?.path || null,
   }));
@@ -587,60 +38,10 @@ function getTool(name) {
     parameters: t.parameters,
     examples: t.examples || [],
     endpoint: t.endpoint || null,
-    schema_url: `/tools/${name}`,
+    schema_url: `/api/tools/${name}`,
   };
 }
 
-// ---------------------------------------------------------------------------
-// Inline call handlers for tools without a dedicated HTTP endpoint
-// ---------------------------------------------------------------------------
-
-function makeInlineHandlers({ projects, registries }) {
-  return {
-    memory_append: async (body) => {
-      const { default: fetch } = await import("node-fetch");
-      const base = `http://localhost:${process.env.APX_PORT || 7430}`;
-      // GET current
-      const getRes = await fetch(`${base}/memory${body.project ? `?project=${body.project}` : ""}`);
-      if (!getRes.ok) throw new Error(`memory_get failed: ${getRes.status}`);
-      const { body: current } = await getRes.json();
-      // POST updated
-      const text = body.text || "";
-      const postRes = await fetch(`${base}/memory${body.project ? `?project=${body.project}` : ""}`, {
-        method: "POST",
-        headers: { "content-type": "application/json" },
-        body: JSON.stringify({ body: current + text }),
-      });
-      if (!postRes.ok) throw new Error(`memory_set failed: ${postRes.status}`);
-      return { ok: true, appended_chars: text.length };
-    },
-
-    memory_list: async (body) => {
-      const { default: fs } = await import("node:fs");
-      const { default: path } = await import("node:path");
-      const { readAgents } = await import("../parser.js");
-      const { agentMemoryPath } = await import("../agent-memory.js");
-      // Find the project
-      const all = projects.list();
-      let p = null;
-      if (body.project) {
-        const ref = String(body.project);
-        const found = all.find((x) => String(x.id) === ref || x.path === ref);
-        p = found ? projects.get(found.id) : null;
-      }
-      if (!p) p = projects.get(all.filter((x) => x.id !== 0)[0]?.id) || projects.get(0);
-      if (!p) throw new Error("no project registered");
-      const result = readAgents(p.path).map((agent) => {
-        const slug = agent.slug;
-        const memPath = agentMemoryPath(p, slug);
-        if (!fs.existsSync(memPath)) return null;
-        const stat = fs.statSync(memPath);
-        return { agent: slug, path: memPath, size: stat.size, mtime: stat.mtime };
-      }).filter(Boolean);
-      return { project: p.path, agents_with_memory: result };
-    },
-  };
-}
 
 // ---------------------------------------------------------------------------
 // Express router factory
@@ -651,19 +52,19 @@ export function buildRegistryRouter(express, ctx) {
   const router = express.Router();
   const inlineHandlers = makeInlineHandlers({ projects, registries });
 
-  // GET /tools — lightweight list
+  // GET /api/tools — lightweight list
   router.get("/", (_req, res) => {
     res.json(listTools());
   });
 
-  // GET /tools/:name — full schema
+  // GET /api/tools/:name — full schema
   router.get("/:name", (req, res) => {
     const tool = getTool(req.params.name);
     if (!tool) return res.status(404).json({ error: `tool "${req.params.name}" not found` });
     res.json(tool);
   });
 
-  // POST /tools/:name/call — execute tool
+  // POST /api/tools/:name/call — execute tool
   router.post("/:name/call", async (req, res) => {
     const { name } = req.params;
     const toolDef = TOOL_MAP.get(name);
@@ -703,7 +104,19 @@ export function buildRegistryRouter(express, ctx) {
       const method = toolDef.endpoint.method || "GET";
       let fetchUrl = `${base}${urlPath}`;
 
-      let fetchOpts = { method, headers: { "content-type": "application/json" } };
+      // Forward the caller's bearer. Every /api route is authenticated, and
+      // this proxy never sent one — so all 33 endpoint-backed tools answered
+      // 401 and only the 2 inline handlers worked. The tool call is made on
+      // behalf of an already-authenticated caller, so its credential carries.
+      const fetchOpts = {
+        method,
+        headers: {
+          "content-type": "application/json",
+          ...(req.get("authorization")
+            ? { authorization: req.get("authorization") }
+            : {}),
+        },
+      };
 
       if (method === "GET") {
         // Append body fields as query params
@@ -732,4 +145,7 @@ export function buildRegistryRouter(express, ctx) {
   return router;
 }
 
-export { listTools, getTool, TOOL_DEFINITIONS };
+// TOOL_DEFINITIONS is re-exported so the agent-side bridge
+// (core/agent/tools/registry-bridge.js) keeps its existing import path.
+export { listTools, getTool };
+export { TOOL_DEFINITIONS } from "./catalog.js";