@agentprojectcontext/apx 1.33.1 → 1.35.0

package/src/interfaces/web/src/screens/project/RoutinesTab.tsx

@@ -50,7 +50,7 @@ const SCHED_PRESETS = [
   { label: "días hábiles 9am", value: "cron 0 9 * * 1-5" },
 ];
 
-// Template/env vars the routine runner exposes (src/host/daemon/routines.js).
+// Template/env vars the routine runner exposes (src/core/routines/runner.js).
 const VARS = [
   { v: "{{pre_output}}", where: "prompt", desc: "Salida de los pre-commands, inyectada en el prompt." },
   { v: "$APX_LLM_OUTPUT", where: "post", desc: "Respuesta del agente / super-agente." },

package/src/interfaces/web/src/screens/project/VarsTab.tsx

@@ -0,0 +1,300 @@
+import { useEffect, useMemo, useState } from "react";
+import useSWR from "swr";
+import { Eye, EyeOff, Pencil, Plus, Trash2 } from "lucide-react";
+import { Vars, type VarScope, type VarsList } from "../../lib/api";
+import { Section } from "../../components/Section";
+import { Badge, Button, Dialog, Empty, Field, Input, Loading, Switch } from "../../components/ui";
+import { UiSelect } from "../../components/UiSelect";
+import { useToast } from "../../components/Toast";
+import { t } from "../../i18n";
+
+interface Row {
+  name: string;
+  scope: VarScope;
+  masked: string;
+  revealed?: string;
+}
+
+export function VarsTab({ pid }: { pid: string }) {
+  const toast = useToast();
+  const isBase = String(pid) === "0";
+  const [filter, setFilter] = useState<"all" | "project" | "global">(
+    isBase ? "global" : "all",
+  );
+  const [revealAll, setRevealAll] = useState(false);
+  const list = useSWR<VarsList>(
+    `/projects/${pid}/vars?reveal=${revealAll ? 1 : 0}`,
+    () => Vars.list(pid, { reveal: revealAll }),
+  );
+  const [openCreate, setOpenCreate] = useState<{ name?: string; value?: string; scope?: VarScope } | null>(null);
+
+  const rows: Row[] = useMemo(() => {
+    if (!list.data) return [];
+    const out: Row[] = [];
+    const proj = list.data.project || {};
+    const glob = list.data.global || {};
+    for (const [name, masked] of Object.entries(proj)) {
+      out.push({ name, scope: "project", masked });
+    }
+    for (const [name, masked] of Object.entries(glob)) {
+      if (proj[name] !== undefined) continue;
+      out.push({ name, scope: "global", masked });
+    }
+    return out
+      .filter((r) => (filter === "all" ? true : r.scope === filter))
+      .sort((a, b) => a.name.localeCompare(b.name));
+  }, [list.data, filter]);
+
+  const remove = async (name: string, scope: VarScope) => {
+    if (!confirm(t("project.vars.delete_confirm", { name, scope }))) return;
+    try {
+      await Vars.remove(pid, name, scope);
+      toast.success(t("project.vars.removed"));
+      list.mutate();
+    } catch (e: any) {
+      toast.error(e?.message || t("common.error_generic"));
+    }
+  };
+
+  return (
+    <Section
+      title={t("project.vars.title")}
+      description={
+        isBase ? t("project.vars.subtitle_base") : t("project.vars.subtitle_project")
+      }
+      action={
+        <div className="flex items-center gap-2">
+          <Switch checked={revealAll} onChange={setRevealAll} label={t("project.vars.reveal_all")} />
+          <Button size="sm" variant="primary" onClick={() => setOpenCreate({})}>
+            <Plus size={14} /> {t("project.vars.new")}
+          </Button>
+        </div>
+      }
+    >
+      {!isBase && (
+        <div className="mb-3 flex items-center gap-2 text-xs">
+          <span className="text-muted-fg">{t("project.vars.filter_label")}</span>
+          <FilterPill active={filter === "all"} onClick={() => setFilter("all")}>
+            {t("project.vars.filter_all")}
+          </FilterPill>
+          <FilterPill active={filter === "project"} onClick={() => setFilter("project")}>
+            {t("project.vars.filter_project")}
+          </FilterPill>
+          <FilterPill active={filter === "global"} onClick={() => setFilter("global")}>
+            {t("project.vars.filter_global")}
+          </FilterPill>
+        </div>
+      )}
+
+      {list.isLoading && <Loading />}
+      {!list.isLoading && rows.length === 0 && <Empty>{t("project.vars.empty")}</Empty>}
+
+      {rows.length > 0 && (
+        <ul className="space-y-2 text-sm">
+          {rows.map((r) => (
+            <li
+              key={`${r.scope}-${r.name}`}
+              className="flex items-center gap-3 rounded-md border border-border bg-muted/30 px-3 py-2"
+            >
+              <span className="font-mono text-xs font-medium">{r.name}</span>
+              <Badge tone={r.scope === "project" ? "info" : "muted"}>
+                {r.scope === "project" ? t("project.vars.scope_project") : t("project.vars.scope_global")}
+              </Badge>
+              <span className="ml-2 font-mono text-xs text-muted-fg">{r.masked}</span>
+              <div className="ml-auto flex items-center gap-1">
+                {/* Edit: only project-scope rows can be edited from a non-base project.
+                    Global rows can be edited from /p/0. We surface "edit globally" by
+                    pre-filling the dialog with scope=global; the user can switch. */}
+                <Button
+                  size="sm"
+                  variant="ghost"
+                  onClick={() => setOpenCreate({ name: r.name, scope: r.scope })}
+                  aria-label={t("project.vars.edit_btn")}
+                >
+                  <Pencil size={13} />
+                </Button>
+                {!(isBase && r.scope === "project") && (
+                  <Button
+                    size="sm"
+                    variant="destructive"
+                    onClick={() => remove(r.name, r.scope)}
+                    aria-label={t("project.vars.delete_btn")}
+                  >
+                    <Trash2 size={13} />
+                  </Button>
+                )}
+              </div>
+            </li>
+          ))}
+        </ul>
+      )}
+
+      <UpsertVarDialog
+        open={openCreate !== null}
+        initial={openCreate || undefined}
+        onClose={() => setOpenCreate(null)}
+        pid={pid}
+        isBase={isBase}
+        onSaved={() => {
+          setOpenCreate(null);
+          list.mutate();
+        }}
+      />
+    </Section>
+  );
+}
+
+function FilterPill({
+  active,
+  onClick,
+  children,
+}: {
+  active: boolean;
+  onClick: () => void;
+  children: React.ReactNode;
+}) {
+  return (
+    <button
+      type="button"
+      onClick={onClick}
+      className={
+        active
+          ? "rounded-full border border-primary/50 bg-primary/10 px-2 py-0.5 text-xs"
+          : "rounded-full border border-border bg-muted/30 px-2 py-0.5 text-xs hover:bg-muted/60"
+      }
+    >
+      {children}
+    </button>
+  );
+}
+
+function UpsertVarDialog({
+  open,
+  onClose,
+  pid,
+  isBase,
+  initial,
+  onSaved,
+}: {
+  open: boolean;
+  onClose: () => void;
+  pid: string;
+  isBase: boolean;
+  initial?: { name?: string; value?: string; scope?: VarScope };
+  onSaved: () => void;
+}) {
+  const toast = useToast();
+  const [busy, setBusy] = useState(false);
+  const [revealValue, setRevealValue] = useState(false);
+  const [name, setName] = useState(initial?.name || "");
+  const [value, setValue] = useState(initial?.value || "");
+  const [scope, setScope] = useState<VarScope>(
+    initial?.scope || (isBase ? "global" : "project"),
+  );
+  const isEdit = !!initial?.name;
+
+  // Reset state when the dialog opens with a different initial.
+  useEffect(() => {
+    if (open) {
+      setName(initial?.name || "");
+      setValue(initial?.value || "");
+      setScope(initial?.scope || (isBase ? "global" : "project"));
+      setRevealValue(false);
+    }
+  }, [open, initial?.name, initial?.scope, initial?.value, isBase]);
+
+  const submit = async () => {
+    if (!name.trim()) {
+      toast.error(t("project.vars.name_required"));
+      return;
+    }
+    if (!value) {
+      toast.error(t("project.vars.value_required"));
+      return;
+    }
+    setBusy(true);
+    try {
+      await Vars.upsert(pid, { name: name.trim(), value, scope });
+      toast.success(isEdit ? t("project.vars.updated") : t("project.vars.added"));
+      onSaved();
+    } catch (e: any) {
+      toast.error(e?.message || t("common.error_generic"));
+    } finally {
+      setBusy(false);
+    }
+  };
+
+  return (
+    <Dialog
+      open={open}
+      onClose={() => (busy ? null : onClose())}
+      title={isEdit ? t("project.vars.edit_title") : t("project.vars.new_title")}
+      description={t("project.vars.new_desc")}
+      size="sm"
+      footer={
+        <>
+          <Button variant="ghost" onClick={onClose} disabled={busy}>
+            {t("common.cancel")}
+          </Button>
+          <Button variant="primary" onClick={submit} loading={busy}>
+            {isEdit ? t("project.vars.save_btn") : t("project.vars.add_btn")}
+          </Button>
+        </>
+      }
+    >
+      <div className="space-y-3">
+        <Field label={t("project.vars.scope_label")}>
+          <UiSelect
+            value={scope}
+            onChange={(v) => setScope(v as VarScope)}
+            options={[
+              ...(isBase
+                ? []
+                : [
+                    {
+                      value: "project",
+                      label: t("project.vars.scope_project"),
+                      description: t("project.vars.scope_project_desc"),
+                    },
+                  ]),
+              {
+                value: "global",
+                label: t("project.vars.scope_global"),
+                description: t("project.vars.scope_global_desc"),
+              },
+            ]}
+          />
+        </Field>
+        <Field label={t("project.vars.name_label")} hint={t("project.vars.name_hint")}>
+          <Input
+            value={name}
+            onChange={(e) => setName(e.target.value.toUpperCase().replace(/[^A-Z0-9_]/g, "_"))}
+            placeholder="MY_API_KEY"
+            disabled={isEdit}
+            autoFocus={!isEdit}
+          />
+        </Field>
+        <Field label={t("project.vars.value_label")} hint={t("project.vars.value_hint")}>
+          <div className="relative">
+            <Input
+              type={revealValue ? "text" : "password"}
+              value={value}
+              onChange={(e) => setValue(e.target.value)}
+              placeholder={isEdit ? t("project.vars.value_edit_ph") : ""}
+              className="pr-9 font-mono text-xs"
+              autoFocus={isEdit}
+            />
+            <button
+              type="button"
+              onClick={() => setRevealValue((v) => !v)}
+              className="absolute right-2 top-1/2 -translate-y-1/2 text-muted-fg hover:text-fg"
+              aria-label={revealValue ? t("project.vars.hide") : t("project.vars.reveal")}
+            >
+              {revealValue ? <EyeOff size={14} /> : <Eye size={14} />}
+            </button>
+          </div>
+        </Field>
+      </div>
+    </Dialog>
+  );
+}

package/src/interfaces/web/src/types/daemon.ts

@@ -70,6 +70,11 @@ export interface McpEntry {
   source: "apc" | "runtime" | "global" | string;
   transport: string;
   enabled: boolean;
+  command?: string | null;
+  args?: string[];
+  env?: Record<string, string>;
+  url?: string | null;
+  headers?: Record<string, string>;
 }
 
 export interface MessageEntry {
@@ -279,6 +284,16 @@ export interface ChatStreamEvent {
   streak?: number;
   // tool_start / tool_result / tool_deduped
   trace?: ToolTrace;
+  // skill_inspector: which skills the per-turn RAG loaded/hinted this turn
+  inspector?: {
+    enabled?: boolean;
+    reason?: string;
+    embedder?: string;
+    scored?: { slug: string; sim: number }[];
+    loaded?: string[];
+    hinted?: string[];
+    jit?: boolean;
+  };
   // final
   result?: {
     text?: string;

package/skills/apx-agency-agents/SKILL.md

@@ -1,141 +0,0 @@
----
-name: apx-agency-agents
-description: "Manage the APX agent vault — reusable agent templates (Roby, Cody, Rocky, Tessa, Max, Arch, Sid, Vera, Finn + generic dev/marketing/ops/qa/support). Load to spawn a specialist, list templates, import one into a project, create a template, or hide/restore a bundled default. Triggers: 'spawn agent', 'use Cody/Rocky/Tessa', 'list agents', 'agent vault', 'import agent', 'new agent'."
----
-
-# apx-agency-agents — the APX agent vault
-
-The vault is the **global, project-agnostic library of agent templates** in APX. Two layers, deduped per-slug, with the user layer winning:
-
-| Layer | Where | Mutability |
-|---|---|---|
-| **Bundled** | `<repo>/assets/agent-vault-defaults/<slug>.md` | Read-only on disk. Always visible unless tombstoned. |
-| **User** | `~/.apx/agents/<slug>.md` | Read-write. Overrides the bundled with the same slug. |
-| **Tombstones** | `~/.apx/agents/.removed.json` | List of bundled slugs the user explicitly hid. |
-
-Listing returns `bundled ∪ user`, with `source: "bundled" | "user" | "user-override"` per entry. Editing a bundled entry is **copy-on-write** — it materializes into the user layer the moment you save. Deleting a bundled entry **tombstones** it (you can restore later); deleting a user-only entry physically removes the file.
-
-## Bundled starter pack
-
-APX ships 14 templates out of the box, two families:
-
-### Named team (from nicho-apps)
-A characterful crew already used in production by NichoApps:
-
-| Slug | Role | Strength |
-|---|---|---|
-| `roby-orchestrator` | Pipeline orchestrator | Autonomous task routing, multi-agent coordination |
-| `arch-architect` | Software architect | System design, tradeoffs, ADRs |
-| `cody-developer` | Senior Laravel dev | Code, refactors, technical leadership |
-| `tessa-qa` | QA / beta tester | Reality checks, test plans, real-user empathy |
-| `max-marketing` | Growth hacker | Content, campaigns, SEO, copy |
-| `sid-security` | Security specialist | Audits, threat models, hardening |
-| `rocky-pm` | Senior PM | Tasklists, roadmaps, stakeholder comms |
-| `vera-ui` | UI/UX reviewer | Visual audits, usability (uses browser-use) |
-| `finn-billing` | Billing / commercial ops | Stripe, invoicing, plan logic |
-
-### Generic specialists (from PandaProject)
-Plain functional roles — useful when you want capabilities without a persona:
-
-| Slug | Role |
-|---|---|
-| `development` | Engineering & code |
-| `marketing` | Marketing & growth |
-| `ops` | Ops, deploys & incidents |
-| `qa` | Quality assurance & testing |
-| `support` | Customer support & escalations |
-
-Bundled templates ship with `language: es` and **no `model:` set** — they inherit the project/global default model. Set a model on import or by editing the vault file directly.
-
-## Concrete commands
-
-```bash
-# List the vault (bundled + your overrides, with [bundled] / [user] / [override] tags)
-apx agent vault list
-
-# Include tombstoned bundled defaults (the ones you hid)
-apx agent vault list --all
-
-# Create a new template (writes ~/.apx/agents/<slug>.md)
-apx agent vault add reviewer \
-  --role "Code reviewer" \
-  --model ollama:llama3.2:3b \
-  --language es \
-  --skills code-review,git \
-  --description "Reviews PRs and pushes back on hand-wavy diffs."
-
-# Delete a template:
-#   - user-only slug → file is physically deleted
-#   - bundled slug   → tombstoned, hidden from listings
-apx agent vault rm tessa-qa
-
-# Bring back a tombstoned bundled default
-apx agent vault restore tessa-qa
-
-# Import a vault template into the current project
-apx agent import cody-developer
-apx agent import tessa-qa --copy     # copy into .apc/agents/ for local edits
-apx agent import roby-orchestrator --force   # overwrite an existing local def
-
-# Inside the daemon's tool API, the same flow:
-list_vault_agents()
-import_agent({ slug: "cody-developer", project: "<name-or-path>" })
-```
-
-## The web equivalents
-
-The Agent defaults tab (`/p/0/agent-defaults`) has the same CRUD: a "New" button (POST `/agents/vault`), "Edit" per card (PATCH `/agents/vault/:slug`, copy-on-write for bundled), "Delete"/"Hide" (DELETE), and a "Show removed" toggle that surfaces tombstoned bundled defaults with a "Restore" button.
-
-## When to use which agent
-
-- **User says "spawn/use Cody/Rocky/Tessa/Max/Arch/Sid/Vera/Roby/Finn"** → that exact slug exists in the named team. Import it.
-- **User wants a "developer" / "QA" / "marketing" agent without a persona** → use the generic specialists (`development`, `qa`, `marketing`, …).
-- **User wants something not in the vault** → either `apx agent vault add <slug>` to create a blank one, or `apx agent add <slug>` directly inside a project for a one-off.
-- **Fresh install** → bundled defaults are always present (no sync step); they appear in `apx agent vault list` immediately.
-
-## Where the files live
-
-```
-<APX repo>/assets/agent-vault-defaults/<slug>.md   ← canonical bundle (committed)
-~/.apx/agents/<slug>.md                            ← user vault (sync target)
-<project>/.apc/agents/<slug>.md                    ← project-local copy (after import --copy)
-```
-
-The vault file format is identical to a project agent file:
-
-```
----
-role: <human-readable role>
-model: <provider:model>
-description: <short description shown in UI grid>
-language: es
-skills: a, b, c
-tools: x, y
-is_master: false
----
-
-<markdown body — the agent's system prompt extension>
-```
-
-## Frontmatter fields the runtime reads
-
-| Field | Effect |
-|---|---|
-| `role` | Shown in CLI/web. Appears in the agent's prompt as "Role: …". |
-| `model` | Default model for engine routing. |
-| `description` | Shown in `/agents/vault` and the AgentDefaultsTab cards. |
-| `language` | Adds "Default language: <code>" to the system prompt. |
-| `skills` | Per-agent skill names; relevant skill bodies are loaded by skill resolution. |
-| `tools` | Declared tool hints; actual callable tools depend on the invocation surface. |
-| `is_master` | If true, marked as a master agent in the project (badge + ordering). |
-
-## Related skills
-
-- **[apx-agent](../apx-agent/SKILL.md)** — per-project agent CRUD (add / edit / memory / list). The vault is the *library*; this skill is the *workshop*.
-- **[apx-runtime](../apx-runtime/SKILL.md)** — delegating to external coding CLIs (claude-code, codex, etc) from inside an agent.
-
-## Gotchas
-
-- **Bundled defaults are always present** — there's no sync step. They appear in `apx agent vault list` and in the web UI the moment APX is installed. Removing one tombstones it; editing one copies it to your user layer.
-- The slug `roby-orchestrator` is intentionally **not** `roby` — the APX super-agent persona is already named "Roby" via `~/.apx/identity.json`. Importing a project agent called `roby` would shadow that and cause confusion. Use `roby-orchestrator` for a *project-level* orchestrator.
-- The `agency-agents` skill in `~/.claude/skills/` pulls from an external GitHub repo (`msitarzewski/agency-agents`). APX bundles a snapshot in `assets/agent-vault-defaults/` so installs are offline-first. To refresh from upstream, edit the bundle and re-commit; existing users' overrides are untouched.

package/skills/apx-agent/SKILL.md

@@ -1,100 +0,0 @@
----
-name: apx-agent
-description: How to create, configure, and use project agents in APX. Load when the user wants to "add an agent", import from the vault, set a per-agent model, or write agent memory.
----
-
-# apx-agent
-
-A project agent is a named persona inside an APC project. Canonical definition: `.apc/agents/<slug>.md` (flat file). `AGENTS.md` is auto-regenerated for discovery. Per-agent runtime data (memory, conversations, sessions) lives under `~/.apx/projects/<apx_id>/agents/<slug>/` and is never committed. APX still reads legacy `.apc/agents/<slug>/memory.md` as a migration fallback only.
-
-## Concrete CLI calls
-
-```bash
-# List agents in the current project (agent commands are cwd-scoped — run from the project root)
-apx agent list
-
-# Create a new agent (writes .apc/agents/<slug>.md, creates runtime dir, regenerates AGENTS.md)
-apx agent add reviewer \
-  --role "Code reviewer" \
-  --model ollama:llama3.2:3b \
-  --language es \
-  --description "Reviews PRs and pushes back on hand-wavy diffs." \
-  --tools read,write,run \
-  --skills code-review,git
-
-# Import an agent template from the global vault (~/.apx/agents/)
-apx agent vault list                 # see what's available
-apx agent import <slug>              # register vault slug in this project
-apx agent import <slug> --copy       # copy vault .md into .apc/agents/ for local edits
-apx agent import <slug> --force      # overwrite existing local definition
-
-# Show details (config + memory)
-apx agent get <slug>                 # alias: apx agent show <slug>
-
-# Per-agent memory (drives system prompt for that agent; cwd-scoped — run from the project root)
-apx memory <slug>                          # read
-apx memory <slug> --append "fact"          # append a line under "## Recent context"
-apx memory <slug> --replace < file.md      # full replace from stdin
-```
-
-## What the agent's system prompt looks like
-
-`buildAgentSystem()` (`src/core/agent-system.js`) composes:
-
-1. Identity block: `You are <slug>` + project name.
-2. Description (from AGENTS.md).
-3. Role + Language fields.
-4. Invocation context: `engine | telegram | routine | runtime` — the channel calling the agent.
-5. Memory: `~/.apx/projects/<apx_id>/agents/<slug>/memory.md` if it exists, with legacy `.apc/agents/<slug>/memory.md` as a migration fallback.
-6. Skills declared in the agent's `Skills:` field, each loaded from `.apc/skills/<slug>.md` or the bundled set.
-7. The `apx` meta-skill (so the agent knows how to operate APX).
-8. ACTION_DISCIPLINE_RULES (fixed footer — anti-ghost, anti-disclaimer, action-first).
-
-That's the prompt the engine sees on every `apx exec <agent>` or `apx chat <agent>`. The super-agent (default APX mode) uses a *different* prompt — see `apx-routine` for when the super-agent runs vs. when an exec_agent runs.
-
-## Models per agent
-
-Each agent can set `Model:` in its `.apc/agents/<slug>.md` definition to override the global super-agent model. Leave it empty when the agent should follow the project/global default.
-
-```markdown
-# .apc/agents/reviewer.md
----
-Role: Code reviewer
-Model: ollama:llama3.2:3b    ← this agent uses this model, independent of super_agent.model
-Language: es
----
-```
-
-When a routine `kind: exec_agent` runs with `spec.agent: reviewer`, it uses that model.
-
-## Anti-examples
-
-```bash
-# DON'T hand-write .apc/agents/<slug>.md without matching AGENTS.md regeneration.
-echo "..." > /path/.apc/agents/reviewer.md
-# ↑ Prefer `apx agent add` or `apx agent import` so AGENTS.md stays consistent.
-
-# DON'T set Model: to a provider you don't have keys for.
-# An agent with Model: openai:gpt-4o on a machine with no openai.api_key fails on first call.
-
-# DON'T put long-running context in `Description`. Put it in memory.md.
-# Description is one line, Role is a noun phrase, memory is unlimited.
-```
-
-## How agents differ from the super-agent
-
-| Aspect | Super-agent (default APX) | Project agent |
-|---|---|---|
-| Has tools? | Yes (the full registry) | No (text-in/text-out via callEngine) |
-| Loop? | Multi-iteration tool loop | Single call |
-| System prompt | `super-agent-base.md` + channel template + identity | `buildAgentSystem()` per-agent |
-| Conversation persisted in | super-agent surfaces | `<storagePath>/agents/<slug>/conversations/*.md` |
-| Configured via | `super_agent.*` in config | `AGENTS.md` + per-agent files |
-
-When in doubt: the super-agent is APX itself; agents are personas inside a project.
-
-## Don't
-
-- Don't expect a project agent to call tools. It can't. If you want tools, use the super-agent or call MCPs from a routine `kind: shell`.
-- Don't overwrite `AGENTS.md` manually — `apx agent add/remove` regenerates it. Hand edits get clobbered.
-- Don't use the same slug across projects expecting shared memory. Memory is per-project.