@agentikos/omega-os 0.2.0 → 0.19.6

package/omega/Agentik_Engine/tests/test_installer_wiring.py

@@ -0,0 +1,496 @@
+"""Tests that the installer actually wires v0.19.x features that the engine
+already exposes. Without this guard the engine ships modules nobody calls,
+which is exactly the v0.19.2 bug:
+
+  * `omega_engine.tmux.install_into_home_tmux_conf(profile="pro")` existed
+    but `step_engine` only wrote the "minimal" bundled config and never
+    touched ~/.tmux.conf.
+  * `omega_engine.hermes_bootstrap.write_brief()` existed but no install
+    step called it, so Hermès booted blind.
+  * `tmux.spawn_aisb_chat()` existed but install never created the always-on
+    session, so a user without Telegram had no entry point.
+
+This test reads `bootstrap/lib/steps.sh` and `install.sh` directly — the
+shell files are the source of truth, and `unittest` is cheap enough to keep
+in the suite that already runs on every commit.
+"""
+from __future__ import annotations
+
+import os
+import re
+import sys
+import tempfile
+import textwrap
+import unittest
+from pathlib import Path
+
+
+HERE = Path(__file__).resolve().parent
+sys.path.insert(0, str(HERE.parent))
+
+REPO_ROOT = Path(__file__).resolve().parents[3]
+INSTALL_SH = REPO_ROOT / "install.sh"
+STEPS_SH = REPO_ROOT / "bootstrap" / "lib" / "steps.sh"
+COMMON_SH = REPO_ROOT / "bootstrap" / "lib" / "common.sh"
+
+
+# ---------------------------------------------------------------------------
+# Plan-mode wiring (the STEPS array drives the entire UX)
+# ---------------------------------------------------------------------------
+
+
+class TestInstallerStepList(unittest.TestCase):
+    """The STEPS array in install.sh MUST mention each new step name.
+    If the engine ships a new step function but install.sh never registers
+    it, the plan-mode display + the run loop both miss it."""
+
+    REQUIRED_ENTRIES = [
+        # name (the human label) → step function name
+        ("36-tmux-config",   "step_tmux_config"),
+        ("37-hermes-brief",  "step_hermes_brief"),
+        ("59-hermes-session", "step_hermes_session"),
+    ]
+
+    def setUp(self):
+        if not INSTALL_SH.is_file():
+            self.skipTest("install.sh not in repo")
+        if not STEPS_SH.is_file():
+            self.skipTest("bootstrap/lib/steps.sh not in repo")
+        self.install_text = INSTALL_SH.read_text()
+        self.steps_text = STEPS_SH.read_text()
+
+    def test_install_sh_registers_each_new_step(self):
+        for label, fn in self.REQUIRED_ENTRIES:
+            entry = f'"{label}:{fn}"'
+            self.assertIn(entry, self.install_text,
+                f"install.sh STEPS array missing {entry!r} — "
+                f"plan-mode will not show it and run loop will skip it")
+
+    def test_steps_sh_defines_each_step_function(self):
+        for _, fn in self.REQUIRED_ENTRIES:
+            pattern = re.compile(rf"^{fn}\(\) \{{", re.MULTILINE)
+            self.assertRegex(self.steps_text, pattern,
+                f"{fn} is referenced by install.sh but not defined in steps.sh")
+
+    def test_step_engine_no_longer_inlines_tmux_block(self):
+        """We moved tmux config out of step_engine into step_tmux_config so
+        plan-mode shows it as its own line. Guard against accidental
+        re-inlining."""
+        # Find the body of step_engine
+        m = re.search(r"^step_engine\(\) \{(.+?)^\}", self.steps_text,
+                      re.DOTALL | re.MULTILINE)
+        self.assertIsNotNone(m, "step_engine function not found")
+        body = m.group(1)
+        self.assertNotIn("write_default_config", body,
+            "step_engine must NOT call write_default_config directly anymore "
+            "— that's step_tmux_config's job")
+
+
+# ---------------------------------------------------------------------------
+# Step semantics — exercise the same Python the heredocs run, against a
+# temp HOME, so we don't touch the live ~/Omega or ~/.tmux.conf.
+# ---------------------------------------------------------------------------
+
+
+class TestStepTmuxConfigBehavior(unittest.TestCase):
+    """step_tmux_config writes the pro bundled config AND wires ~/.tmux.conf
+    with backup-on-difference. Re-runs with identical content must be silent
+    no-ops (no extra backups)."""
+
+    def test_pro_profile_lands_and_is_idempotent(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp = Path(tmp)
+            fake_home = tmp / "fake-home"
+            fake_home.mkdir()
+            omega_home = tmp / "Omega"
+            omega_home.mkdir()
+
+            os.environ["OMEGA_HOME"] = str(omega_home)
+            os.environ["HOME"] = str(fake_home)
+            try:
+                from omega_engine.tmux import (
+                    write_default_config,
+                    install_into_home_tmux_conf,
+                )
+
+                # First pass — writes both files.
+                bundled = write_default_config(profile="pro")
+                bundled_content = Path(bundled).read_text()
+                self.assertGreater(len(bundled_content), 1000,
+                    "pro profile should be substantially larger than minimal")
+                # Pro-only sentinels (paste fix + kill log).
+                self.assertIn("assume-paste-time", bundled_content,
+                    "pro profile missing Termius paste-fix sentinel")
+                self.assertIn("buffer-limit", bundled_content,
+                    "pro profile missing tmux buffer-limit sentinel")
+
+                res1 = install_into_home_tmux_conf(profile="pro", backup=True)
+                self.assertEqual(res1["profile"], "pro")
+                home_conf = fake_home / ".tmux.conf"
+                self.assertEqual(home_conf.read_text(), bundled_content)
+
+                # Second pass — content matches, the step's heredoc skips the
+                # rewrite. We simulate that gate here (the heredoc compares
+                # existing vs bundled_content before calling install_into_*).
+                existing = home_conf.read_text()
+                self.assertEqual(existing, bundled_content,
+                    "second-pass content drifted — idempotency broken")
+            finally:
+                os.environ.pop("OMEGA_HOME", None)
+
+
+class TestStepHermesBriefBehavior(unittest.TestCase):
+    """step_hermes_brief writes ~/.hermes/skills/omega/SKILL.md so Hermès
+    knows about OmegaOS at install time. Atomic + idempotent."""
+
+    def test_brief_lands_and_is_atomic(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp = Path(tmp)
+            fake_home = tmp / "fake-home"
+            fake_home.mkdir()
+            omega_home = tmp / "Omega"
+            omega_home.mkdir()
+            os.environ["OMEGA_HOME"] = str(omega_home)
+            os.environ["HOME"] = str(fake_home)
+            try:
+                from omega_engine import hermes_bootstrap as HB
+                res = HB.write_brief()
+                self.assertTrue(res.written)
+                brief = Path(res.path)
+                self.assertTrue(brief.is_file())
+                content = brief.read_text()
+                # The brief must teach Hermès the L1-L5 architecture + the
+                # no-API-key principle — those are the two non-negotiable
+                # seed facts.
+                self.assertIn("OmegaOS", content)
+                self.assertIn("Hermès", content)
+                memlog = HB.memory_log_path()
+                # Memory log path is computed (file may not exist yet —
+                # observe_outcome creates it lazily).
+                self.assertTrue(str(memlog).endswith(
+                    ".hermes/memory/omega_observations.jsonl"))
+            finally:
+                os.environ.pop("OMEGA_HOME", None)
+
+
+# ---------------------------------------------------------------------------
+# UX wiring — the post-install card must announce the always-on session.
+# ---------------------------------------------------------------------------
+
+
+# ---------------------------------------------------------------------------
+# State drift — installer must NOT skip new steps after an upgrade.
+# This was the v0.19.x Mac regression: a stale state file from v0.2.0
+# silently skipped every step on a v0.19.x re-run, so the user got "se
+# passe rien" and no new card.
+# ---------------------------------------------------------------------------
+
+
+class TestInstallerStateDrift(unittest.TestCase):
+    """state_version_drift / record_state_version must:
+      1. Detect a missing version marker as drift (legacy state files).
+      2. Detect a recorded version different from $OMEGA_BUNDLED_VERSION.
+      3. Treat a matching marker as "no drift" (idempotent re-run is silent)."""
+
+    def _run(self, *, recorded: str | None, current: str,
+             have_state: bool = True) -> int:
+        """Source common.sh, set env, call state_version_drift,
+        return its exit code (0 = drift, 1 = no drift).
+
+        common.sh derives STATE_DIR from OMEGA_HOME at source time, so we
+        export OMEGA_HOME (not STATE_DIR) and let common.sh build the
+        right path. Sourcing later override of STATE_DIR is then safe.
+        """
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp = Path(tmp)
+            omega_home = tmp / "Omega"
+            state_dir = omega_home / "Agentik_Extra" / "var"
+            state_dir.mkdir(parents=True)
+            if have_state:
+                (state_dir / ".install-state").write_text("00-preflight\n")
+            if recorded is not None:
+                (state_dir / ".install-version").write_text(recorded + "\n")
+            script = (
+                f"set -e\n"
+                f"export OMEGA_HOME={omega_home!s}\n"
+                f"export OMEGA_BUNDLED_VERSION={current!r}\n"
+                f". {COMMON_SH!s}\n"
+                f"if state_version_drift; then exit 0; else exit 1; fi\n"
+            )
+            import subprocess
+            rc = subprocess.run(["bash", "-c", script],
+                                capture_output=True).returncode
+            return rc
+
+    def test_missing_marker_is_drift(self):
+        rc = self._run(recorded=None, current="0.19.4")
+        self.assertEqual(rc, 0,
+            "stale state with no version marker MUST be treated as drift")
+
+    def test_version_mismatch_is_drift(self):
+        rc = self._run(recorded="0.2.0", current="0.19.4")
+        self.assertEqual(rc, 0,
+            "0.2.0 state under 0.19.4 installer MUST be treated as drift")
+
+    def test_matching_version_is_no_drift(self):
+        rc = self._run(recorded="0.19.4", current="0.19.4")
+        self.assertEqual(rc, 1,
+            "matching versions MUST be treated as a clean idempotent re-run")
+
+    def test_record_state_version_writes_marker(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp = Path(tmp)
+            omega_home = tmp / "Omega"
+            state_dir = omega_home / "Agentik_Extra" / "var"
+            script = (
+                f"set -e\n"
+                f"export OMEGA_HOME={omega_home!s}\n"
+                f"export OMEGA_BUNDLED_VERSION='0.19.4'\n"
+                f". {COMMON_SH!s}\n"
+                f"record_state_version\n"
+            )
+            import subprocess
+            subprocess.run(["bash", "-c", script], check=True,
+                           capture_output=True)
+            marker = state_dir / ".install-version"
+            self.assertTrue(marker.exists(),
+                ".install-version marker must be created")
+            self.assertEqual(marker.read_text().strip(), "0.19.4")
+
+
+class TestInstallShWiresDriftCheck(unittest.TestCase):
+    """The install.sh entry point MUST source OMEGA_BUNDLED_VERSION and call
+    state_version_drift / record_state_version. Without those, the engine-side
+    drift detection is dead code."""
+
+    def test_install_sh_exports_bundled_version(self):
+        text = INSTALL_SH.read_text()
+        self.assertIn("OMEGA_BUNDLED_VERSION", text,
+            "install.sh must read the bundled version for drift detection")
+        self.assertIn("state_version_drift", text,
+            "install.sh must call state_version_drift before run_step loop")
+        self.assertIn("record_state_version", text,
+            "install.sh must call record_state_version after path setup")
+
+
+# ---------------------------------------------------------------------------
+# whiptail / newt — the bare `omega` command MUST work on macOS too.
+# ---------------------------------------------------------------------------
+
+
+class TestSystemDepsCoversMenuDep(unittest.TestCase):
+    """`omega` (no args) shows the menu. On Linux apt/dnf, on macOS brew —
+    all three branches MUST install the package that provides `whiptail`."""
+
+    def test_apt_branch_installs_whiptail(self):
+        text = STEPS_SH.read_text()
+        # apt installs the 'whiptail' package
+        self.assertRegex(text, r"apt\)[^;]*whiptail",
+            "apt branch must install whiptail")
+
+    def test_dnf_branch_installs_newt(self):
+        text = STEPS_SH.read_text()
+        # dnf installs 'newt' which provides /usr/bin/whiptail
+        self.assertRegex(text, r"dnf\)[^;]*newt",
+            "dnf branch must install newt (provides whiptail)")
+
+    def test_brew_branch_installs_newt(self):
+        text = STEPS_SH.read_text()
+        # macOS brew package is 'newt'
+        self.assertRegex(text, r"brew\)[^;]*newt",
+            "brew branch must install newt (provides whiptail on macOS)")
+
+
+# ---------------------------------------------------------------------------
+# Text-mode menu — `omega` must NEVER silently exit when whiptail is missing.
+# ---------------------------------------------------------------------------
+
+
+class TestTextMenuFallback(unittest.TestCase):
+    """When whiptail is unavailable, `omega` must print a visible numbered
+    list and accept stdin input. Silent exit was the v0.19.x Mac symptom
+    ("se passe rien")."""
+
+    def test_text_menu_prints_items_and_quits_cleanly(self):
+        import io, contextlib
+        from omega_engine import menu as M
+        # Force the no-whiptail path by monkeypatching _have.
+        orig = M._have
+        M._have = lambda b: False if b == "whiptail" else orig(b)
+        try:
+            # Feed "0\n" so it quits on the first prompt.
+            stdin_buf = io.StringIO("0\n")
+            stdout_buf = io.StringIO()
+            with contextlib.redirect_stdout(stdout_buf):
+                from unittest.mock import patch
+                with patch("builtins.input", side_effect=["0"]):
+                    rc = M.run_menu()
+        finally:
+            M._have = orig
+        self.assertEqual(rc, 0)
+        out = stdout_buf.getvalue()
+        self.assertIn("Omega OS v", out, "header must include version")
+        # Each main item label must appear at least once.
+        for tag, label in M._MAIN_ITEMS:
+            if tag == "quit":
+                continue
+            self.assertIn(label, out,
+                f"text menu missing item: {label!r}")
+
+    def test_text_menu_unknown_input_does_not_exit(self):
+        """Garbage input loops back, doesn't crash the menu."""
+        import io, contextlib
+        from omega_engine import menu as M
+        orig = M._have
+        M._have = lambda b: False if b == "whiptail" else orig(b)
+        try:
+            from unittest.mock import patch
+            with patch("builtins.input", side_effect=["abc", "99", "0"]):
+                with contextlib.redirect_stdout(io.StringIO()):
+                    rc = M.run_menu()
+        finally:
+            M._have = orig
+        self.assertEqual(rc, 0)
+
+
+# ---------------------------------------------------------------------------
+# Helper functions defined in common.sh — used by install.sh in plan-mode.
+# `prompt_yes_no` was missing in v0.19.1..0.19.4 and aborted the first install
+# on macOS ("command not found"). This guards the regression.
+# ---------------------------------------------------------------------------
+
+
+class TestPromptYesNoDefined(unittest.TestCase):
+    """install.sh's plan-mode gate calls `prompt_yes_no` to confirm the run.
+    The helper MUST be defined in common.sh, or the install aborts before
+    a single step executes."""
+
+    def test_prompt_yes_no_is_a_shell_function(self):
+        import subprocess
+        rc = subprocess.run(
+            ["bash", "-c", f". {COMMON_SH!s} && type prompt_yes_no"],
+            capture_output=True, text=True,
+        )
+        self.assertEqual(rc.returncode, 0,
+            "prompt_yes_no must be defined in common.sh — without it the "
+            "plan-mode prompt aborts every interactive install")
+        self.assertIn("function", rc.stdout,
+            "prompt_yes_no must be a bash function, not an alias")
+
+    def test_prompt_yes_no_default_yes_accepts_empty_stdin(self):
+        """Just hitting Enter must accept the default."""
+        import subprocess
+        script = (
+            f". {COMMON_SH!s}\n"
+            f"prompt_yes_no 'install?' yes && echo YES || echo NO\n"
+        )
+        rc = subprocess.run(
+            ["bash", "-c", script],
+            input="\n", capture_output=True, text=True,
+        )
+        self.assertIn("YES", rc.stdout)
+
+    def test_prompt_yes_no_n_rejects(self):
+        """Typing 'n' returns non-zero so install aborts cleanly."""
+        import subprocess
+        script = (
+            f". {COMMON_SH!s}\n"
+            f"prompt_yes_no 'install?' yes && echo YES || echo NO\n"
+        )
+        rc = subprocess.run(
+            ["bash", "-c", script],
+            input="n\n", capture_output=True, text=True,
+        )
+        self.assertIn("NO", rc.stdout)
+
+
+# ---------------------------------------------------------------------------
+# Banner — the OMEGA ascii art must read OMEGA, not OMEBA.
+# Position 4 (the G) was rendering as a B in some terminals because row 3
+# closed the upper-right with `█▀` (looked like the top loop of B) and the
+# bottom used a flat `████████▀` instead of the canonical arc.
+# ---------------------------------------------------------------------------
+
+
+class TestBannerReadsOmega(unittest.TestCase):
+    """The hand-tuned colossal-font OMEGA banner has specific row signatures
+    that distinguish G from B. We assert both signatures directly."""
+
+    def test_g_row3_does_not_close_upper_right(self):
+        text = COMMON_SH.read_text()
+        # The fixed G row 3 has just `███` for left side then spaces.
+        # The old broken-G row 3 had `███    █▀` closing the upper right.
+        # We check the actual line in the banner:
+        # 'row 3' in the printf list is the third printf after install_banner.
+        # Easiest: assert the broken-G row sentinel does NOT appear in the
+        # banner block.
+        broken_row3 = '███    █▀    ███    ███'
+        # That's the OLD row3 with E+G+A — find the install_banner block.
+        import re
+        m = re.search(r"install_banner\(\) \{.*?^\}", text, re.S | re.M)
+        self.assertIsNotNone(m, "install_banner not found in common.sh")
+        block = m.group(0)
+        # OLD signature (E and G both close upper-right): three repetitions
+        # of `█▀` separated by spaces on the SAME row.
+        old_sig = "███    █▀    ███    █▀    ███    ███"
+        self.assertNotIn(old_sig, block,
+            "banner row 3 still has the old G-as-B signature "
+            "(closes upper-right with █▀)")
+
+    def test_g_has_clean_arc_bottom(self):
+        text = COMMON_SH.read_text()
+        # Fixed bottom row has ` ▀██████▀ ` for G (arc), not `████████▀`.
+        # Search for the BOTTOM row in install_banner.
+        import re
+        m = re.search(r"install_banner\(\) \{.*?^\}", text, re.S | re.M)
+        block = m.group(0)
+        # OLD signature on bottom row: `██████████   ████████▀`
+        old_bottom = "██████████   ████████▀"
+        self.assertNotIn(old_bottom, block,
+            "banner bottom row still uses the flat G base — should be arc")
+
+
+# ---------------------------------------------------------------------------
+# Brand colour — Claude-Code orange. The truecolor escape must be exported.
+# ---------------------------------------------------------------------------
+
+
+class TestBrandColourIsOrange(unittest.TestCase):
+    def test_c_orange_is_truecolor_d97757(self):
+        text = COMMON_SH.read_text()
+        self.assertIn("38;2;217;119;87", text,
+            "C_ORANGE must be the Claude-Code brand truecolor "
+            "(\\033[38;2;217;119;87m)")
+        self.assertIn("C_ORANGE=", text)
+
+    def test_banner_uses_c_orange(self):
+        text = COMMON_SH.read_text()
+        # Count how many times the banner printf uses C_ORANGE.
+        # Banner has 8 rows — each row must use C_ORANGE.
+        import re
+        m = re.search(r"install_banner\(\) \{.*?^\}", text, re.S | re.M)
+        block = m.group(0)
+        n = block.count("$C_ORANGE")
+        self.assertGreaterEqual(n, 8,
+            f"banner should use C_ORANGE on each of 8 rows (got {n})")
+
+
+class TestPostInstallCardMentionsAISBChat(unittest.TestCase):
+    """The 'AISB-chat' tmux session is the conversational entry point when
+    Telegram isn't wired. The post-install card MUST tell the operator how
+    to attach to it; otherwise they finish the install with no UI."""
+
+    def test_card_shows_attach_command(self):
+        if not COMMON_SH.is_file():
+            self.skipTest("common.sh not in repo")
+        text = COMMON_SH.read_text()
+        self.assertIn("tmux attach -t AISB-chat", text,
+            "post_install_card must include the AISB-chat attach line — "
+            "otherwise the operator has no way to discover their always-on "
+            "Hermès session")
+        # Also surface the "every session in tmux" expectation.
+        self.assertIn("tmux", text)
+
+
+if __name__ == "__main__":
+    unittest.main()