@agentforge/patterns 0.15.10 → 0.15.12

package/dist/index.cjs

@@ -273,10 +273,12 @@ function formatScratchpad(scratchpad) {
   }).join("\n\n");
 }
 
-// src/react/nodes.ts
-var import_messages = require("@langchain/core/messages");
+// src/react/nodes/reasoning.ts
 var import_core3 = require("@agentforge/core");
 
+// src/react/nodes/shared.ts
+var import_messages = require("@langchain/core/messages");
+
 // src/shared/deduplication.ts
 var import_core2 = require("@agentforge/core");
 function normalizeObject(obj) {
@@ -321,25 +323,7 @@ function buildDeduplicationMetrics(toolsExecuted, duplicatesSkipped, totalObserv
   };
 }
 
-// src/shared/error-handling.ts
-function isGraphInterrupt(error) {
-  return error !== null && typeof error === "object" && "constructor" in error && error.constructor.name === "GraphInterrupt";
-}
-function handleNodeError(error, context, verbose = false) {
-  if (isGraphInterrupt(error)) {
-    throw error;
-  }
-  const errorMessage = error instanceof Error ? error.message : String(error);
-  if (verbose) {
-    console.error(`[${context}] Error:`, errorMessage);
-    if (error instanceof Error && error.stack) {
-      console.error(`[${context}] Stack:`, error.stack);
-    }
-  }
-  return errorMessage;
-}
-
-// src/react/nodes.ts
+// src/react/nodes/shared.ts
 var reasoningLogger = createPatternLogger("agentforge:patterns:react:reasoning");
 var actionLogger = createPatternLogger("agentforge:patterns:react:action");
 var observationLogger = createPatternLogger("agentforge:patterns:react:observation");
@@ -397,7 +381,7 @@ function formatObservationContent(observation) {
   return stringifyObservationResult(observation.result, 2);
 }
 function formatActionSummary(actions) {
-  return actions.map((action) => `${action.name}(${JSON.stringify(action.arguments)})`).join(", ");
+  return actions.map((action) => `${action.name}(${stringifyActionArguments(action.arguments)})`).join(", ");
 }
 function formatObservationSummary(observations) {
   return observations.map((observation) => {
@@ -411,8 +395,15 @@ function stringifyObservationResult(result, space) {
   if (typeof result === "string") {
     return result;
   }
-  const stringified = JSON.stringify(result, null, space);
-  return stringified ?? String(result);
+  try {
+    const stringified = JSON.stringify(result, null, space);
+    return stringified ?? String(result);
+  } catch {
+    return String(result);
+  }
+}
+function stringifyActionArguments(arguments_) {
+  return stringifyObservationResult(arguments_);
 }
 function getLatestThought(thoughts) {
   return thoughts[thoughts.length - 1]?.content ?? "";
@@ -422,6 +413,8 @@ function debugIfVerbose(logger4, verbose, message, data) {
     logger4.debug(message, data);
   }
 }
+
+// src/react/nodes/reasoning.ts
 function createReasoningNode(llm, tools, systemPrompt, maxIterations, verbose = false) {
   const langchainTools = (0, import_core3.toLangChainTools)(tools);
   const llmWithTools = llm.bindTools ? llm.bindTools(langchainTools) : llm;
@@ -452,15 +445,43 @@ function createReasoningNode(llm, tools, systemPrompt, maxIterations, verbose =
       thoughts: thought ? [{ content: thought, timestamp: Date.now() }] : [],
       actions: toolCalls,
       iteration: 1,
-      // Add 1 to iteration counter (uses additive reducer)
       shouldContinue,
       response: toolCalls.length === 0 ? thought : void 0
-      // Final response if no tool calls
     };
   };
 }
+
+// src/shared/error-handling.ts
+function isGraphInterrupt(error) {
+  return error !== null && typeof error === "object" && "constructor" in error && error.constructor.name === "GraphInterrupt";
+}
+function handleNodeError(error, context, verbose = false) {
+  if (isGraphInterrupt(error)) {
+    throw error;
+  }
+  const errorMessage = error instanceof Error ? error.message : String(error);
+  if (verbose) {
+    console.error(`[${context}] Error:`, errorMessage);
+    if (error instanceof Error && error.stack) {
+      console.error(`[${context}] Stack:`, error.stack);
+    }
+  }
+  return errorMessage;
+}
+
+// src/react/nodes/action.ts
 function createActionNode(tools, verbose = false, enableDeduplication = true) {
   const toolMap = new Map(tools.map((tool) => [tool.metadata.name, tool]));
+  function buildCacheKey(toolName, args) {
+    try {
+      return generateToolCallCacheKey(toolName, args);
+    } catch {
+      debugIfVerbose(actionLogger, verbose, "Skipping deduplication for unserializable tool call", {
+        toolName
+      });
+      return void 0;
+    }
+  }
   return async (state) => {
     const actions = state.actions;
     const allObservations = state.observations;
@@ -474,14 +495,23 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     const recentActions = actions.slice(-10);
     const observations = [];
     const executionCache = /* @__PURE__ */ new Map();
+    const actionsById = new Map(actions.map((action) => [action.id, action]));
+    const observedToolCallIds = new Set(
+      allObservations.map((observation) => observation.toolCallId)
+    );
     let cacheSize = 0;
     if (enableDeduplication) {
       for (const observation of allObservations) {
-        const correspondingAction = actions.find((a) => a.id === observation.toolCallId);
+        const correspondingAction = actionsById.get(observation.toolCallId);
         if (correspondingAction) {
-          const cacheKey = generateToolCallCacheKey(correspondingAction.name, correspondingAction.arguments);
-          executionCache.set(cacheKey, observation);
-          cacheSize++;
+          const cacheKey = buildCacheKey(
+            correspondingAction.name,
+            correspondingAction.arguments
+          );
+          if (cacheKey) {
+            executionCache.set(cacheKey, observation);
+            cacheSize++;
+          }
         }
       }
       if (cacheSize > 0) {
@@ -494,8 +524,7 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     let duplicatesSkipped = 0;
     let toolsExecuted = 0;
     for (const action of recentActions) {
-      const existingObservation = allObservations.find((obs) => obs.toolCallId === action.id);
-      if (existingObservation) {
+      if (observedToolCallIds.has(action.id)) {
         debugIfVerbose(actionLogger, verbose, "Skipping already-processed action", {
           toolName: action.name,
           toolCallId: action.id,
@@ -504,13 +533,13 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         continue;
       }
       if (enableDeduplication) {
-        const cacheKey = generateToolCallCacheKey(action.name, action.arguments);
-        const cachedResult = executionCache.get(cacheKey);
+        const cacheKey = buildCacheKey(action.name, action.arguments);
+        const cachedResult = cacheKey ? executionCache.get(cacheKey) : void 0;
         if (cachedResult) {
           duplicatesSkipped++;
           actionLogger.info("Duplicate tool call prevented", {
             toolName: action.name,
-            arguments: action.arguments,
+            argumentKeys: Object.keys(action.arguments),
             iteration,
             cacheHit: true
           });
@@ -535,9 +564,9 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         continue;
       }
       try {
-        const startTime2 = Date.now();
+        const toolStartTime = Date.now();
         const result = await tool.invoke(action.arguments);
-        const executionTime = Date.now() - startTime2;
+        const executionTime = Date.now() - toolStartTime;
         toolsExecuted++;
         debugIfVerbose(actionLogger, verbose, "Tool executed successfully", {
           toolName: action.name,
@@ -551,8 +580,10 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         };
         observations.push(observation);
         if (enableDeduplication) {
-          const cacheKey = generateToolCallCacheKey(action.name, action.arguments);
-          executionCache.set(cacheKey, observation);
+          const cacheKey = buildCacheKey(action.name, action.arguments);
+          if (cacheKey) {
+            executionCache.set(cacheKey, observation);
+          }
         }
       } catch (error) {
         const errorMessage = handleNodeError(error, `action:${action.name}`, verbose);
@@ -570,7 +601,11 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
       }
     }
     if (duplicatesSkipped > 0 || toolsExecuted > 0) {
-      const metrics = buildDeduplicationMetrics(toolsExecuted, duplicatesSkipped, observations.length);
+      const metrics = buildDeduplicationMetrics(
+        toolsExecuted,
+        duplicatesSkipped,
+        observations.length
+      );
       actionLogger.info("Action node complete", {
         iteration,
         ...metrics,
@@ -582,6 +617,8 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     };
   };
 }
+
+// src/react/nodes/observation.ts
 function createObservationNode(verbose = false, returnIntermediateSteps = false) {
   return async (state) => {
     const observations = state.observations;
@@ -601,13 +638,15 @@ function createObservationNode(verbose = false, returnIntermediateSteps = false)
       name: actionNamesById.get(observation.toolCallId),
       tool_call_id: observation.toolCallId
     }));
-    const scratchpadEntries = returnIntermediateSteps ? [{
-      step: state.iteration,
-      thought: getLatestThought(thoughts),
-      action: formatActionSummary(latestActions),
-      observation: formatObservationSummary(recentObservations),
-      timestamp: Date.now()
-    }] : [];
+    const scratchpadEntries = returnIntermediateSteps ? [
+      {
+        step: iteration,
+        thought: getLatestThought(thoughts),
+        action: formatActionSummary(latestActions),
+        observation: formatObservationSummary(recentObservations),
+        timestamp: Date.now()
+      }
+    ] : [];
     debugIfVerbose(observationLogger, verbose, "Observation node complete", {
       iteration,
       scratchpadUpdated: returnIntermediateSteps,

package/dist/index.js

@@ -170,14 +170,16 @@ function formatScratchpad(scratchpad) {
   }).join("\n\n");
 }
 
-// src/react/nodes.ts
+// src/react/nodes/reasoning.ts
+import { toLangChainTools } from "@agentforge/core";
+
+// src/react/nodes/shared.ts
 import {
   HumanMessage,
   AIMessage,
   SystemMessage,
   ToolMessage
 } from "@langchain/core/messages";
-import { toLangChainTools } from "@agentforge/core";
 
 // src/shared/deduplication.ts
 import { createLogger } from "@agentforge/core";
@@ -223,25 +225,7 @@ function buildDeduplicationMetrics(toolsExecuted, duplicatesSkipped, totalObserv
   };
 }
 
-// src/shared/error-handling.ts
-function isGraphInterrupt(error) {
-  return error !== null && typeof error === "object" && "constructor" in error && error.constructor.name === "GraphInterrupt";
-}
-function handleNodeError(error, context, verbose = false) {
-  if (isGraphInterrupt(error)) {
-    throw error;
-  }
-  const errorMessage = error instanceof Error ? error.message : String(error);
-  if (verbose) {
-    console.error(`[${context}] Error:`, errorMessage);
-    if (error instanceof Error && error.stack) {
-      console.error(`[${context}] Stack:`, error.stack);
-    }
-  }
-  return errorMessage;
-}
-
-// src/react/nodes.ts
+// src/react/nodes/shared.ts
 var reasoningLogger = createPatternLogger("agentforge:patterns:react:reasoning");
 var actionLogger = createPatternLogger("agentforge:patterns:react:action");
 var observationLogger = createPatternLogger("agentforge:patterns:react:observation");
@@ -299,7 +283,7 @@ function formatObservationContent(observation) {
   return stringifyObservationResult(observation.result, 2);
 }
 function formatActionSummary(actions) {
-  return actions.map((action) => `${action.name}(${JSON.stringify(action.arguments)})`).join(", ");
+  return actions.map((action) => `${action.name}(${stringifyActionArguments(action.arguments)})`).join(", ");
 }
 function formatObservationSummary(observations) {
   return observations.map((observation) => {
@@ -313,8 +297,15 @@ function stringifyObservationResult(result, space) {
   if (typeof result === "string") {
     return result;
   }
-  const stringified = JSON.stringify(result, null, space);
-  return stringified ?? String(result);
+  try {
+    const stringified = JSON.stringify(result, null, space);
+    return stringified ?? String(result);
+  } catch {
+    return String(result);
+  }
+}
+function stringifyActionArguments(arguments_) {
+  return stringifyObservationResult(arguments_);
 }
 function getLatestThought(thoughts) {
   return thoughts[thoughts.length - 1]?.content ?? "";
@@ -324,6 +315,8 @@ function debugIfVerbose(logger4, verbose, message, data) {
     logger4.debug(message, data);
   }
 }
+
+// src/react/nodes/reasoning.ts
 function createReasoningNode(llm, tools, systemPrompt, maxIterations, verbose = false) {
   const langchainTools = toLangChainTools(tools);
   const llmWithTools = llm.bindTools ? llm.bindTools(langchainTools) : llm;
@@ -354,15 +347,43 @@ function createReasoningNode(llm, tools, systemPrompt, maxIterations, verbose =
       thoughts: thought ? [{ content: thought, timestamp: Date.now() }] : [],
       actions: toolCalls,
       iteration: 1,
-      // Add 1 to iteration counter (uses additive reducer)
       shouldContinue,
       response: toolCalls.length === 0 ? thought : void 0
-      // Final response if no tool calls
     };
   };
 }
+
+// src/shared/error-handling.ts
+function isGraphInterrupt(error) {
+  return error !== null && typeof error === "object" && "constructor" in error && error.constructor.name === "GraphInterrupt";
+}
+function handleNodeError(error, context, verbose = false) {
+  if (isGraphInterrupt(error)) {
+    throw error;
+  }
+  const errorMessage = error instanceof Error ? error.message : String(error);
+  if (verbose) {
+    console.error(`[${context}] Error:`, errorMessage);
+    if (error instanceof Error && error.stack) {
+      console.error(`[${context}] Stack:`, error.stack);
+    }
+  }
+  return errorMessage;
+}
+
+// src/react/nodes/action.ts
 function createActionNode(tools, verbose = false, enableDeduplication = true) {
   const toolMap = new Map(tools.map((tool) => [tool.metadata.name, tool]));
+  function buildCacheKey(toolName, args) {
+    try {
+      return generateToolCallCacheKey(toolName, args);
+    } catch {
+      debugIfVerbose(actionLogger, verbose, "Skipping deduplication for unserializable tool call", {
+        toolName
+      });
+      return void 0;
+    }
+  }
   return async (state) => {
     const actions = state.actions;
     const allObservations = state.observations;
@@ -376,14 +397,23 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     const recentActions = actions.slice(-10);
     const observations = [];
     const executionCache = /* @__PURE__ */ new Map();
+    const actionsById = new Map(actions.map((action) => [action.id, action]));
+    const observedToolCallIds = new Set(
+      allObservations.map((observation) => observation.toolCallId)
+    );
     let cacheSize = 0;
     if (enableDeduplication) {
       for (const observation of allObservations) {
-        const correspondingAction = actions.find((a) => a.id === observation.toolCallId);
+        const correspondingAction = actionsById.get(observation.toolCallId);
         if (correspondingAction) {
-          const cacheKey = generateToolCallCacheKey(correspondingAction.name, correspondingAction.arguments);
-          executionCache.set(cacheKey, observation);
-          cacheSize++;
+          const cacheKey = buildCacheKey(
+            correspondingAction.name,
+            correspondingAction.arguments
+          );
+          if (cacheKey) {
+            executionCache.set(cacheKey, observation);
+            cacheSize++;
+          }
         }
       }
       if (cacheSize > 0) {
@@ -396,8 +426,7 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     let duplicatesSkipped = 0;
     let toolsExecuted = 0;
     for (const action of recentActions) {
-      const existingObservation = allObservations.find((obs) => obs.toolCallId === action.id);
-      if (existingObservation) {
+      if (observedToolCallIds.has(action.id)) {
         debugIfVerbose(actionLogger, verbose, "Skipping already-processed action", {
           toolName: action.name,
           toolCallId: action.id,
@@ -406,13 +435,13 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         continue;
       }
       if (enableDeduplication) {
-        const cacheKey = generateToolCallCacheKey(action.name, action.arguments);
-        const cachedResult = executionCache.get(cacheKey);
+        const cacheKey = buildCacheKey(action.name, action.arguments);
+        const cachedResult = cacheKey ? executionCache.get(cacheKey) : void 0;
         if (cachedResult) {
           duplicatesSkipped++;
           actionLogger.info("Duplicate tool call prevented", {
             toolName: action.name,
-            arguments: action.arguments,
+            argumentKeys: Object.keys(action.arguments),
             iteration,
             cacheHit: true
           });
@@ -437,9 +466,9 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         continue;
       }
       try {
-        const startTime2 = Date.now();
+        const toolStartTime = Date.now();
         const result = await tool.invoke(action.arguments);
-        const executionTime = Date.now() - startTime2;
+        const executionTime = Date.now() - toolStartTime;
         toolsExecuted++;
         debugIfVerbose(actionLogger, verbose, "Tool executed successfully", {
           toolName: action.name,
@@ -453,8 +482,10 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
         };
         observations.push(observation);
         if (enableDeduplication) {
-          const cacheKey = generateToolCallCacheKey(action.name, action.arguments);
-          executionCache.set(cacheKey, observation);
+          const cacheKey = buildCacheKey(action.name, action.arguments);
+          if (cacheKey) {
+            executionCache.set(cacheKey, observation);
+          }
         }
       } catch (error) {
         const errorMessage = handleNodeError(error, `action:${action.name}`, verbose);
@@ -472,7 +503,11 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
       }
     }
     if (duplicatesSkipped > 0 || toolsExecuted > 0) {
-      const metrics = buildDeduplicationMetrics(toolsExecuted, duplicatesSkipped, observations.length);
+      const metrics = buildDeduplicationMetrics(
+        toolsExecuted,
+        duplicatesSkipped,
+        observations.length
+      );
       actionLogger.info("Action node complete", {
         iteration,
         ...metrics,
@@ -484,6 +519,8 @@ function createActionNode(tools, verbose = false, enableDeduplication = true) {
     };
   };
 }
+
+// src/react/nodes/observation.ts
 function createObservationNode(verbose = false, returnIntermediateSteps = false) {
   return async (state) => {
     const observations = state.observations;
@@ -503,13 +540,15 @@ function createObservationNode(verbose = false, returnIntermediateSteps = false)
       name: actionNamesById.get(observation.toolCallId),
       tool_call_id: observation.toolCallId
     }));
-    const scratchpadEntries = returnIntermediateSteps ? [{
-      step: state.iteration,
-      thought: getLatestThought(thoughts),
-      action: formatActionSummary(latestActions),
-      observation: formatObservationSummary(recentObservations),
-      timestamp: Date.now()
-    }] : [];
+    const scratchpadEntries = returnIntermediateSteps ? [
+      {
+        step: iteration,
+        thought: getLatestThought(thoughts),
+        action: formatActionSummary(latestActions),
+        observation: formatObservationSummary(recentObservations),
+        timestamp: Date.now()
+      }
+    ] : [];
     debugIfVerbose(observationLogger, verbose, "Observation node complete", {
       iteration,
       scratchpadUpdated: returnIntermediateSteps,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agentforge/patterns",
-  "version": "0.15.10",
+  "version": "0.15.12",
   "description": "Production-ready agent workflow patterns for TypeScript including ReAct and Planner-Executor, built on LangGraph.",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -41,13 +41,13 @@
     "url": "https://github.com/TVScoundrel/agentforge/issues"
   },
   "dependencies": {
-    "@agentforge/core": "0.15.10",
+    "@agentforge/core": "0.15.12",
     "@langchain/core": "^1.1.17",
     "@langchain/langgraph": "^1.1.2",
     "zod": "^3.23.8"
   },
   "devDependencies": {
-    "@agentforge/testing": "0.15.10",
+    "@agentforge/testing": "0.15.12",
     "@eslint/js": "^9.17.0",
     "@types/node": "^22.10.2",
     "eslint": "^9.17.0",