@agentchatham/cli 1.3.1 → 1.4.1

package/CLAUDE.md

@@ -48,20 +48,31 @@ Retry logic, turn management, watermark tracking stay in `src/dispatcher.ts`.
 They do not move to SDK. If you find turn-coordination logic in `provider.ts`
 or an adapter, it belongs in the dispatcher instead.
 
-## MCP client binding across reconnects
+## Shared client context across reconnects
 
-`startMcpServer` captures its `ctx` argument by reference. Pass a mutable holder
-and update `ctx.client` on every `monitorProvider.onConnect` — this keeps MCP tool
-calls live across reconnects without recreating the server:
+There is ONE client context — the SDK's `ToolContext` shape
+`{ client, store, attachmentCache }` — created once at boot and captured by
+reference by both `startMcpServer` AND the `Dispatcher`. `store` and
+`attachmentCache` are stable singletons; only `client` changes, and it is
+updated in exactly one place (`monitorProvider.onConnect`). That single
+assignment keeps MCP tool calls and dispatcher fetches live across reconnects
+without recreating the server or a separate `setClient` call:
 
 ```typescript
-const toolCtx: { client: ChathamClient | null; store: ChannelKeyStore } = { client: null, store }
-const mcp = await startMcpServer(toolCtx as { client: ChathamClient; store: ChannelKeyStore })
+const ctx: { client: ChathamClient | null; store: ChannelKeyStore; attachmentCache: AttachmentCache } =
+  { client: null, store, attachmentCache }
+const mcp = await startMcpServer(ctx as ToolContext)
+const dispatcher = new Dispatcher({ agent, ctx: ctx as ToolContext, signal, onFatal })
 
-// In onConnect:
-toolCtx.client = client   // MCP tool calls now use the live client
+// In onConnect — ONE update, seen by both the MCP server and the dispatcher:
+ctx.client = client
 ```
 
+Do NOT add a second mutable holder or a `Dispatcher.setClient` — thread the one
+`ctx` so the live client has a single source of truth. SDK data functions
+(`listMessages`, `monitorProvider`, `sendCommandResult`, `parseInboundNotification`)
+take their args positionally; destructure `ctx` at those call sites.
+
 ## Tooling
 
 - Build: `esbuild` via `build.ts` — bundles to `dist/server.js`, obfuscated, node-native