@agent-scope/cli 1.20.2 → 1.20.4

package/dist/index.cjs

@@ -11,6 +11,7 @@ var module$1 = require('module');
 var promises = require('fs/promises');
 var readline = require('readline');
 var playwright = require('@agent-scope/playwright');
+var core = require('@agent-scope/core');
 var playwright$1 = require('playwright');
 var os = require('os');
 var http = require('http');
@@ -2302,26 +2303,7 @@ function buildHookInstrumentationScript() {
   // Walk fiber tree and collect hook data per component
   var components = [];
 
-  function serializeValue(v) {
-    if (v === null) return null;
-    if (v === undefined) return undefined;
-    var t = typeof v;
-    if (t === "string" || t === "number" || t === "boolean") return v;
-    if (t === "function") return "[function " + (v.name || "anonymous") + "]";
-    if (Array.isArray(v)) {
-      try { return v.map(serializeValue); } catch(e) { return "[Array]"; }
-    }
-    if (t === "object") {
-      try {
-        var keys = Object.keys(v).slice(0, 5);
-        var out = {};
-        for (var k of keys) { out[k] = serializeValue(v[k]); }
-        if (Object.keys(v).length > 5) out["..."] = "(truncated)";
-        return out;
-      } catch(e) { return "[Object]"; }
-    }
-    return String(v);
-  }
+  var serializeValue = __SCOPE_SERIALIZE_VALUE__;
 
   // Hook node classifiers (mirrors hooks-extractor.ts logic)
   var HookLayout = 0b00100;
@@ -2542,7 +2524,10 @@ async function runHooksProfiling(componentName, filePath, props) {
     if (renderError !== null) {
       throw new Error(`Component render error: ${renderError}`);
     }
-    const instrumentScript = buildHookInstrumentationScript();
+    const instrumentScript = buildHookInstrumentationScript().replace(
+      "__SCOPE_SERIALIZE_VALUE__",
+      core.serialize.toString()
+    );
     const raw = await page.evaluate(instrumentScript);
     const result = raw;
     if (result.error) {
@@ -2738,44 +2723,79 @@ function buildProfilingCollectScript() {
 `;
 }
 async function replayInteraction(page, steps) {
-  for (const step of steps) {
+  let executed = 0;
+  const skippedInteractions = [];
+  const skip = (index, step, reason) => {
+    skippedInteractions.push({ index, action: step.action, target: step.target, reason });
+  };
+  for (const [index, step] of steps.entries()) {
     switch (step.action) {
       case "click":
-        if (step.target) {
-          await page.click(step.target, { timeout: 5e3 }).catch(() => {
-            process.stderr.write(`  \u26A0 click target "${step.target}" not found, skipping
+        if (!step.target) {
+          skip(index, step, "missing_target");
+          break;
+        }
+        try {
+          await page.click(step.target, { timeout: 5e3 });
+          executed++;
+        } catch {
+          process.stderr.write(`  \u26A0 click target "${step.target}" not found, skipping
 `);
-          });
+          skip(index, step, "not_found");
         }
         break;
       case "fill":
-        if (step.target && step.value !== void 0) {
-          await page.fill(step.target, step.value, { timeout: 5e3 }).catch(() => {
-            process.stderr.write(`  \u26A0 fill target "${step.target}" not found, skipping
+        if (!step.target) {
+          skip(index, step, "missing_target");
+          break;
+        }
+        if (step.value === void 0) {
+          skip(index, step, "missing_value");
+          break;
+        }
+        try {
+          await page.fill(step.target, step.value, { timeout: 5e3 });
+          executed++;
+        } catch {
+          process.stderr.write(`  \u26A0 fill target "${step.target}" not found, skipping
 `);
-          });
+          skip(index, step, "not_found");
         }
         break;
       case "hover":
-        if (step.target) {
-          await page.hover(step.target, { timeout: 5e3 }).catch(() => {
-            process.stderr.write(`  \u26A0 hover target "${step.target}" not found, skipping
+        if (!step.target) {
+          skip(index, step, "missing_target");
+          break;
+        }
+        try {
+          await page.hover(step.target, { timeout: 5e3 });
+          executed++;
+        } catch {
+          process.stderr.write(`  \u26A0 hover target "${step.target}" not found, skipping
 `);
-          });
+          skip(index, step, "not_found");
         }
         break;
       case "press":
-        if (step.value) {
-          await page.keyboard.press(step.value);
+        if (!step.value) {
+          skip(index, step, "missing_value");
+          break;
         }
+        await page.keyboard.press(step.value);
+        executed++;
         break;
       case "wait":
         await page.waitForTimeout(step.delay ?? 500);
+        executed++;
+        break;
+      default:
+        skip(index, step, "unsupported");
         break;
     }
   }
+  return { executed, skippedInteractions };
 }
-function analyzeProfileFlags(totalRenders, wastedRenders, timing, layoutShifts) {
+function analyzeProfileFlags(totalRenders, wastedRenders, timing, layoutShifts, profileValidity) {
   const flags = /* @__PURE__ */ new Set();
   if (wastedRenders !== null && wastedRenders > 0 && wastedRenders / Math.max(1, totalRenders) > 0.3) {
     flags.add("WASTED_RENDER");
@@ -2786,7 +2806,7 @@ function analyzeProfileFlags(totalRenders, wastedRenders, timing, layoutShifts)
   if (layoutShifts.cumulativeScore > 0.1) {
     flags.add("LAYOUT_SHIFT_DETECTED");
   }
-  if (timing.js > 100) {
+  if (profileValidity === "interaction" && timing.js > 100) {
     flags.add("SLOW_INTERACTION");
   }
   return [...flags];
@@ -2825,13 +2845,18 @@ async function runInteractionProfile(componentName, filePath, props, interaction
       throw new Error(`Profiling setup failed: ${setupData.error}`);
     }
     const jsStart = Date.now();
+    let executedInteractions = 0;
+    let skippedInteractions = [];
     if (interaction.length > 0) {
       process.stderr.write(`  Replaying ${interaction.length} interaction step(s)\u2026
 `);
-      await replayInteraction(page, interaction);
+      const replayResult = await replayInteraction(page, interaction);
+      executedInteractions = replayResult.executed;
+      skippedInteractions = replayResult.skippedInteractions;
       await page.waitForTimeout(300);
     }
     const jsDuration = Date.now() - jsStart;
+    const profileValidity = interaction.length === 0 ? "no_interaction_requested" : executedInteractions === 0 ? "setup_only" : "interaction";
     const collected = await page.evaluate(buildProfilingCollectScript());
     const profileData = collected;
     if (profileData.error) {
@@ -2849,7 +2874,13 @@ async function runInteractionProfile(componentName, filePath, props, interaction
     const totalRenders = profileData.commitCount ?? 0;
     const uniqueComponents = profileData.uniqueComponents ?? 0;
     const wastedRenders = profileData.wastedRenders ?? null;
-    const flags = analyzeProfileFlags(totalRenders, wastedRenders, timing, layoutShifts);
+    const flags = analyzeProfileFlags(
+      totalRenders,
+      wastedRenders,
+      timing,
+      layoutShifts,
+      profileValidity
+    );
     return {
       component: componentName,
       totalRenders,
@@ -2863,7 +2894,17 @@ async function runInteractionProfile(componentName, filePath, props, interaction
       timing,
       layoutShifts,
       flags,
-      interaction
+      interaction,
+      interactionSteps: {
+        attempted: interaction.length,
+        executed: executedInteractions,
+        skipped: skippedInteractions.length
+      },
+      interactionStepsAttempted: interaction.length,
+      interactionStepsExecuted: executedInteractions,
+      interactionStepsSkipped: skippedInteractions.length,
+      skippedInteractions,
+      profileValidity
     };
   } finally {
     await browser.close();
@@ -2963,6 +3004,7 @@ function flattenSerializedValue(sv) {
     case "string":
     case "number":
     case "boolean":
+    case "date":
       return v.value;
     case "object": {
       if (!Array.isArray(v.entries)) return {};
@@ -4083,6 +4125,39 @@ function formatAggregateRenderFailureJson(componentName, failures, scenarioCount
 }
 var MANIFEST_PATH6 = ".reactscope/manifest.json";
 var DEFAULT_OUTPUT_DIR = ".reactscope/renders";
+function renderArtifactBaseName(componentName, scenarioName) {
+  return scenarioName === void 0 ? componentName : `${componentName}-${scenarioName}`;
+}
+function removeStaleRenderError(outputDir, componentName, scenarioName) {
+  const errorPath = path.resolve(
+    outputDir,
+    `${renderArtifactBaseName(componentName, scenarioName)}.error.json`
+  );
+  if (fs.existsSync(errorPath)) {
+    fs.rmSync(errorPath, { force: true });
+  }
+}
+function writeRenderErrorArtifact(outputDir, failure) {
+  const errPath = path.resolve(
+    outputDir,
+    `${renderArtifactBaseName(failure.component, failure.scenario)}.error.json`
+  );
+  fs.writeFileSync(
+    errPath,
+    JSON.stringify(
+      {
+        component: failure.component,
+        scenario: failure.scenario,
+        errorMessage: failure.errorMessage,
+        heuristicFlags: failure.heuristicFlags,
+        propsAtCrash: failure.propsAtCrash
+      },
+      null,
+      2
+    )
+  );
+  return errPath;
+}
 var _pool3 = null;
 async function getPool3(viewportWidth, viewportHeight) {
   if (_pool3 === null) {
@@ -4767,20 +4842,12 @@ function registerRenderAll(renderCmd) {
               success: false,
               errorMessage: outcome.error.message
             });
-            const errPath = path.resolve(outputDir, `${name}.error.json`);
-            fs.writeFileSync(
-              errPath,
-              JSON.stringify(
-                {
-                  component: name,
-                  errorMessage: outcome.error.message,
-                  heuristicFlags: outcome.error.heuristicFlags,
-                  propsAtCrash: outcome.error.propsAtCrash
-                },
-                null,
-                2
-              )
-            );
+            const errPath = writeRenderErrorArtifact(outputDir, {
+              component: name,
+              errorMessage: outcome.error.message,
+              heuristicFlags: outcome.error.heuristicFlags,
+              propsAtCrash: outcome.error.propsAtCrash
+            });
             failures.push({
               component: name,
               stage: "render",
@@ -4793,13 +4860,14 @@ function registerRenderAll(renderCmd) {
           }
           const result = outcome.result;
           results.push({ name, renderTimeMs: result.renderTimeMs, success: true });
+          removeStaleRenderError(outputDir, name);
           if (!isIcon) {
             const pngPath = path.resolve(outputDir, `${name}.png`);
             fs.writeFileSync(pngPath, result.screenshot);
             outputPaths.push(pngPath);
           }
           const jsonPath = path.resolve(outputDir, `${name}.json`);
-          const renderJson = formatRenderJson(name, {}, result);
+          const renderJson = formatRenderJson(name, renderProps, result);
           const extResult = result;
           if (isIcon && extResult.svgContent) {
             renderJson.svgContent = extResult.svgContent;
@@ -4860,13 +4928,34 @@ function registerRenderAll(renderCmd) {
                 concurrency: 2
               });
               const matrixResult = await matrix.render();
-              const matrixCells = matrixResult.cells.map((cell) => ({
-                axisValues: [scenarioEntries2[cell.axisIndices[0] ?? 0]?.[0] ?? ""],
-                screenshot: cell.result.screenshot.toString("base64"),
-                width: cell.result.width,
-                height: cell.result.height,
-                renderTimeMs: cell.result.renderTimeMs
-              }));
+              const matrixCells = matrixResult.cells.map((cell) => {
+                const scenarioName = scenarioEntries2[cell.axisIndices[0] ?? 0]?.[0] ?? "";
+                const artifactBaseName = renderArtifactBaseName(name, scenarioName);
+                const scenarioPngPath = path.resolve(outputDir, `${artifactBaseName}.png`);
+                const scenarioJsonPath = path.resolve(outputDir, `${artifactBaseName}.json`);
+                if (!isIcon) {
+                  fs.writeFileSync(scenarioPngPath, cell.result.screenshot);
+                  outputPaths.push(scenarioPngPath);
+                }
+                const scenarioJson = formatRenderJson(
+                  `${name}:${scenarioName}`,
+                  scenarioPropsMap[scenarioName] ?? {},
+                  cell.result
+                );
+                fs.writeFileSync(scenarioJsonPath, JSON.stringify(scenarioJson, null, 2));
+                outputPaths.push(scenarioJsonPath);
+                removeStaleRenderError(outputDir, name, scenarioName);
+                return {
+                  axisValues: [scenarioName],
+                  scenario: scenarioName,
+                  outputPath: scenarioJsonPath,
+                  screenshotPath: isIcon ? void 0 : scenarioPngPath,
+                  screenshot: cell.result.screenshot.toString("base64"),
+                  width: cell.result.width,
+                  height: cell.result.height,
+                  renderTimeMs: cell.result.renderTimeMs
+                };
+              });
               const existingJson = JSON.parse(fs.readFileSync(jsonPath, "utf-8"));
               existingJson.cells = matrixCells;
               existingJson.axisLabels = [scenarioAxis.values];