@agent-relay/dashboard-server 2.0.69 → 2.0.71

package/dist/server.js

@@ -989,6 +989,8 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
             };
             // Set up direct message handler to forward messages to presence WebSocket
             // This enables agents to send replies that appear in the dashboard UI
+            // Note: the relay daemon already persists messages authoritatively, so we
+            // only need to broadcast the real-time event here (no storage.saveMessage).
             client.onMessage = (from, payload, messageId) => {
                 const body = typeof payload === 'object' && payload !== null && 'body' in payload
                     ? payload.body
@@ -1000,28 +1002,9 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                 // Determine entity type: user if they have presence state, agent otherwise
                 const fromEntityType = senderPresence ? 'user' : 'agent';
                 const timestamp = new Date().toISOString();
-                // Persist the message to storage so it survives page refresh
-                if (storage) {
-                    storage.saveMessage({
-                        id: messageId || `dm-${crypto.randomUUID()}`,
-                        ts: Date.now(),
-                        from,
-                        to: senderName,
-                        topic: undefined,
-                        kind: 'message',
-                        body,
-                        data: {
-                            fromAvatarUrl,
-                            fromEntityType,
-                        },
-                        status: 'unread',
-                        is_urgent: false,
-                        is_broadcast: false,
-                    }).catch((err) => {
-                        console.error('[dashboard] Failed to persist direct message', err);
-                    });
-                }
-                // Broadcast to presence WebSocket clients so cloud/dashboard can display the message
+                // Broadcast real-time event so the dashboard UI updates immediately.
+                // Pass id (= messageId) so the client has a stable identifier and
+                // doesn't need to fabricate one from Date.now().
                 broadcastDirectMessage({
                     type: 'direct_message',
                     targetUser: senderName,
@@ -1029,6 +1012,7 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                     fromAvatarUrl,
                     fromEntityType,
                     body,
+                    id: messageId,
                     messageId,
                     timestamp,
                 });
@@ -1756,15 +1740,17 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                                 existing.avatarUrl = user.avatarUrl;
                         }
                         else {
-                            const now = new Date().toISOString();
+                            // Use stable timestamps from the user/file data, not new Date(),
+                            // so getAllData() produces deterministic output for dedup comparison
+                            const stableTimestamp = user.lastSeen || user.connectedAt || new Date(remoteData.updatedAt).toISOString();
                             agentsMap.set(user.name, {
                                 name: user.name,
                                 role: 'User',
                                 cli: 'dashboard',
                                 messageCount: 0,
                                 status: 'online',
-                                lastSeen: now,
-                                lastActive: now,
+                                lastSeen: stableTimestamp,
+                                lastActive: stableTimestamp,
                                 needsAttention: false,
                                 avatarUrl: user.avatarUrl,
                             });
@@ -1954,18 +1940,21 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
             return true;
         });
         // Separate AI agents from human users
+        // Sort by name for deterministic JSON serialization (enables dedup comparison)
         const filteredAgents = validEntries
             .filter(agent => agent.cli !== 'dashboard')
             .map(agent => ({
             ...agent,
             isHuman: false,
-        }));
+        }))
+            .sort((a, b) => a.name.localeCompare(b.name));
         const humanUsers = validEntries
             .filter(agent => agent.cli === 'dashboard')
             .map(agent => ({
             ...agent,
             isHuman: true,
-        }));
+        }))
+            .sort((a, b) => a.name.localeCompare(b.name));
         return {
             agents: filteredAgents,
             users: humanUsers,
@@ -1978,6 +1967,7 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
     // Track clients that are still initializing (haven't received first data yet)
     // This prevents race conditions where broadcastData sends before initial data is sent
     const initializingClients = new WeakSet();
+    let lastBroadcastPayload = '';
     const broadcastData = async () => {
         try {
             const data = await getAllData();
@@ -1987,6 +1977,11 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                 console.warn('[dashboard] Skipping broadcast - empty payload');
                 return;
             }
+            // Skip broadcast if data hasn't changed since last send
+            if (rawPayload === lastBroadcastPayload) {
+                return;
+            }
+            lastBroadcastPayload = rawPayload;
             // Push into buffer and wrap with sequence ID for replay support
             const seq = mainMessageBuffer.push('data', rawPayload);
             const payload = JSON.stringify({ seq, ...data });
@@ -2066,6 +2061,7 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
         }
         return { projects: [], messages: [], connected: false };
     };
+    let lastBridgeBroadcastPayload = '';
     const broadcastBridgeData = async () => {
         try {
             const data = await getBridgeData();
@@ -2075,6 +2071,11 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                 console.warn('[dashboard] Skipping bridge broadcast - empty payload');
                 return;
             }
+            // Skip broadcast if data hasn't changed since last send
+            if (payload === lastBridgeBroadcastPayload) {
+                return;
+            }
+            lastBridgeBroadcastPayload = payload;
             wssBridge.clients.forEach(client => {
                 if (client.readyState === WebSocket.OPEN) {
                     try {
@@ -2633,7 +2634,6 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
     };
     // Helper to broadcast direct messages to all connected clients
     // This enables agent replies to appear in the dashboard UI
-    // Broadcasts to both main wss (local mode) and wssPresence (cloud mode)
     const broadcastDirectMessage = (message) => {
         // Push into buffer and wrap with sequence ID for replay support
         const rawPayload = JSON.stringify(message);
@@ -2647,15 +2647,20 @@ export async function startDashboard(portOrOptions, dataDirArg, teamDirArg, dbPa
                 client.send(payload);
             }
         });
-        // Also broadcast to presence WebSocket clients (cloud mode)
-        const presenceClients = Array.from(wssPresence.clients).filter(c => c.readyState === WebSocket.OPEN);
-        if (presenceClients.length > 0) {
-            debug(`[dashboard] Broadcasting direct_message to ${presenceClients.length} presence clients`);
-            wssPresence.clients.forEach((client) => {
-                if (client.readyState === WebSocket.OPEN) {
-                    client.send(payload);
-                }
-            });
+        // Only broadcast to presence WS if UserBridge does NOT have a session for
+        // the target user. When UserBridge is active it already delivers the DM
+        // directly to the user's WebSocket(s), so broadcasting here would duplicate.
+        const targetHandledByBridge = userBridge?.isUserRegistered(message.targetUser) ?? false;
+        if (!targetHandledByBridge) {
+            const presenceClients = Array.from(wssPresence.clients).filter(c => c.readyState === WebSocket.OPEN);
+            if (presenceClients.length > 0) {
+                debug(`[dashboard] Broadcasting direct_message to ${presenceClients.length} presence clients (no bridge session)`);
+                wssPresence.clients.forEach((client) => {
+                    if (client.readyState === WebSocket.OPEN) {
+                        client.send(payload);
+                    }
+                });
+            }
         }
     };
     // Helper to get online users list (without ws references)
@@ -5816,12 +5821,15 @@ Start by greeting the project leads and asking for status updates.`;
         }
         return {};
     }
-    // Watch for changes
+    // Watch for changes - poll as a safety net for DB-backed storage mode.
+    // Real-time updates are already handled by explicit broadcastData() calls
+    // at every data mutation point (message send, spawn, release, cwd update, etc.).
+    // This interval only catches external/indirect changes (presence, DB edits).
     if (storage) {
         setInterval(() => {
             broadcastData().catch((err) => console.error('Broadcast failed', err));
             broadcastBridgeData().catch((err) => console.error('Bridge broadcast failed', err));
-        }, 1000);
+        }, 5000);
     }
     else {
         let fsWait = null;