@agent-plan/server 0.2.29 → 0.3.1

package/dist/serve.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"serve.d.ts","sourceRoot":"","sources":["../src/serve.ts"],"names":[],"mappings":"AAYA,OAAO,EAAE,KAAK,EAAE,MAAM,aAAa,CAAC;AAuMpC,MAAM,WAAW,kBAAkB;IACjC,GAAG,EAAE,MAAM,CAAC;IACZ,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,GAAG,CAAC,EAAE,OAAO,CAAC;CACf;AAED,MAAM,WAAW,cAAc;IAC7B,IAAI,EAAE,OAAO,GAAG,KAAK,CAAC;IACtB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;CAC7B;AAED,MAAM,WAAW,QAAQ;IACvB,SAAS,CAAC,EAAE,OAAO,CAAC,MAAM,CAAC,QAAQ,GAAG,MAAM,GAAG,QAAQ,GAAG,QAAQ,EAAE,kBAAkB,CAAC,CAAC,CAAC;IACzF,MAAM,CAAC,EAAE,cAAc,GAAG,SAAS,CAAC;CACrC;AAw5CD,MAAM,WAAW,YAAY;IAC3B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC1B,SAAS,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC/B,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,QAAQ,CAAC,EAAE,QAAQ,GAAG,SAAS,CAAC;IAChC,MAAM,CAAC,EAAE,CAAC,MAAM,OAAO,CAAC,GAAG,SAAS,CAAC;CACtC;AAED,MAAM,WAAW,WAAW;IAC1B,GAAG,EAAE,MAAM,CAAC;IACZ,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC5B,IAAI,EAAE,OAAO,GAAG,KAAK,CAAC;IACtB,QAAQ,EAAE,MAAM,CAAC;IACjB,GAAG,EAAE,KAAK,CAAC;IACX,KAAK,EAAE,MAAM,OAAO,CAAC,IAAI,CAAC,CAAC;CAC5B;AAED,wBAAsB,KAAK,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CA6EvE"}
+{"version":3,"file":"serve.d.ts","sourceRoot":"","sources":["../src/serve.ts"],"names":[],"mappings":"AAYA,OAAO,EAAE,KAAK,EAAE,MAAM,aAAa,CAAC;AAyJpC,MAAM,WAAW,kBAAkB;IACjC,GAAG,EAAE,MAAM,CAAC;IACZ,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,GAAG,CAAC,EAAE,OAAO,CAAC;CACf;AAED,MAAM,WAAW,cAAc;IAC7B,IAAI,EAAE,OAAO,GAAG,KAAK,CAAC;IACtB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;CAC7B;AAED,MAAM,WAAW,QAAQ;IACvB,SAAS,CAAC,EAAE,OAAO,CAAC,MAAM,CAAC,QAAQ,GAAG,MAAM,GAAG,QAAQ,GAAG,QAAQ,EAAE,kBAAkB,CAAC,CAAC,CAAC;IACzF,MAAM,CAAC,EAAE,cAAc,GAAG,SAAS,CAAC;CACrC;AA+6CD,MAAM,WAAW,YAAY;IAC3B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC1B,SAAS,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC/B,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,QAAQ,CAAC,EAAE,QAAQ,GAAG,SAAS,CAAC;IAChC,MAAM,CAAC,EAAE,CAAC,MAAM,OAAO,CAAC,GAAG,SAAS,CAAC;CACtC;AAED,MAAM,WAAW,WAAW;IAC1B,GAAG,EAAE,MAAM,CAAC;IACZ,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC5B,IAAI,EAAE,OAAO,GAAG,KAAK,CAAC;IACtB,QAAQ,EAAE,MAAM,CAAC;IACjB,GAAG,EAAE,KAAK,CAAC;IACX,KAAK,EAAE,MAAM,OAAO,CAAC,IAAI,CAAC,CAAC;CAC5B;AAED,wBAAsB,KAAK,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CA6EvE"}

package/dist/serve.js

@@ -7,15 +7,11 @@ import { fileURLToPath } from "node:url";
 import { createAdaptorServer } from "@hono/node-server";
 import { Hono } from "hono";
 import { cors } from "hono/cors";
-import { ExportService, PlanStore, PlanStoreError, PlanStaleWriteError, PlanWriterBusyError, createFeatureId, createPhaseId, createChecklistItemId, createRequirementId, createTaskId, findPhaseByRef, normalizeSlug, withFeatureLock, needsMotivation, checkExplicitTaskStart, recommendNextTask, recommendNextWork, reconcileRequirementMacroTasks, RequirementMacroTaskError, packageVersionFromModule } from "@agent-plan/core";
+import { ExportService, PlanStore, PlanStoreError, PlanStaleWriteError, PlanWriterBusyError, createFeatureId, createPhaseId, createChecklistItemId, createRequirementId, createTaskId, findPhaseByRef, normalizeSlug, withFeatureLock, needsMotivation, checkExplicitTaskStart, recommendNextTask, recommendNextWork, reconcileRequirementMacroTasks, RequirementMacroTaskError, packageVersionFromModule, ACCEPTED_DECISION_RAW_REPLACEMENT_DISABLED_MESSAGE, ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED_ERROR_CODE, deleteFeatureCascade, nowISO, applyTaskLifecycleDates, resolveAcceptedDecisionTarget } from "@agent-plan/core";
 import { WsHub } from "./ws-hub.js";
 // ─── Watcher ────────────────────────────────────────────────────────────
 let watcherAbort = null;
-let watcherHubRef = { current: null };
 const SERVER_PACKAGE = packageVersionFromModule(import.meta.url, "@agent-plan/server");
-function nowISO() {
-    return new Date().toISOString();
-}
 /** Resolve requirement phase refs before persistence so requirements never dangle. */
 async function resolveRequirementPhaseIds(store, linkedPhaseIds) {
     if (!Array.isArray(linkedPhaseIds) || linkedPhaseIds.length === 0) {
@@ -46,40 +42,27 @@ function noMutableFieldsResponse(fields) {
         mutableFields: [...fields],
     };
 }
-async function resolveAcceptedDecisionTarget(store, targetType, rawTargetRef) {
-    if (targetType === "project")
-        return { ok: true, owner: { kind: "project" }, targetRef: "project", event: { type: "project" } };
-    const targetRef = rawTargetRef?.trim();
-    if (!targetRef)
-        return { ok: false, error: `targetRef is required for ${targetType} accepted decisions` };
-    const [featuresDocument, phases] = await Promise.all([store.loadFeatures(), store.loadAllPhases()]);
-    const features = featuresDocument.features;
-    if (targetType === "feature") {
-        const feature = features.find((entry) => entry.id === targetRef || `F${String(entry.number).padStart(3, "0")}`.toLowerCase() === targetRef.toLowerCase() || entry.shortId?.toLowerCase() === targetRef.toLowerCase());
-        if (!feature)
-            return { ok: false, error: `feature not found: ${targetRef}` };
-        return { ok: true, owner: { kind: "feature", featureId: feature.id }, targetRef: `F${String(feature.number).padStart(3, "0")}`, event: { type: "feature", featureId: feature.id } };
-    }
-    if (targetType === "phase") {
-        const phase = findPhaseByRef(phases, features, targetRef);
-        if (!phase)
-            return { ok: false, error: `phase not found: ${targetRef}` };
-        return { ok: true, owner: { kind: "phase", phaseId: phase.id }, targetRef: `P${String(phase.number).padStart(3, "0")}`, event: { type: "phase", phaseId: phase.id, featureId: phase.featureId ?? "" } };
-    }
-    const found = phases.flatMap((phase) => phase.tasks.map((task) => ({ phase, task }))).find(({ task }) => task.id === targetRef)
-        ?? (() => {
-            const taskNumberMatch = targetRef.match(/^T(\d+)$/i);
-            return taskNumberMatch
-                ? phases.flatMap((phase) => phase.tasks.map((task) => ({ phase, task }))).find(({ task }) => task.number === Number(taskNumberMatch[1]))
-                : undefined;
-        })();
-    if (!found)
-        return { ok: false, error: `task not found: ${targetRef}` };
-    return { ok: true, owner: { kind: "task", phaseId: found.phase.id, taskId: found.task.id }, targetRef: `P${String(found.phase.number).padStart(3, "0")}/T${String(found.task.number).padStart(3, "0")}`, event: { type: "task", phaseId: found.phase.id, taskId: found.task.id, featureId: found.phase.featureId ?? "" } };
-}
-function nextTaskNumber(phase) {
-    const numbers = phase.tasks.map((task) => task.number || 0).filter((n) => Number.isFinite(n));
-    return (numbers.length > 0 ? Math.max(...numbers) : 0) + 1;
+/**
+ * Resolve an accepted-decision target with the same ref grammar the adapters
+ * use (plan-core's resolveAcceptedDecisionTarget: composite/shortId/title for
+ * tasks, exact/partial name with ambiguity detection for features), then add
+ * the WebSocket broadcast envelope this HTTP layer alone needs. Resolution
+ * itself is never re-derived here — only the event shape is server-local.
+ */
+async function resolveAcceptedDecisionEventTarget(store, targetType, rawTargetRef) {
+    const target = await resolveAcceptedDecisionTarget(store, targetType, rawTargetRef);
+    if (!target.ok)
+        return target;
+    const { owner, ref: targetRef } = target;
+    if (owner.kind === "project")
+        return { ok: true, owner, targetRef, event: { type: "project" } };
+    if (owner.kind === "feature")
+        return { ok: true, owner, targetRef, event: { type: "feature", featureId: owner.featureId } };
+    const phase = await store.loadPhase(owner.phaseId).catch(() => null);
+    const featureId = phase?.featureId ?? "";
+    if (owner.kind === "phase")
+        return { ok: true, owner, targetRef, event: { type: "phase", phaseId: owner.phaseId, featureId } };
+    return { ok: true, owner, targetRef, event: { type: "task", phaseId: owner.phaseId, taskId: owner.taskId, featureId } };
 }
 function isPrivateIpv4(address) {
     return /^10\./.test(address) || /^192\.168\./.test(address) || /^172\.(1[6-9]|2\d|3[01])\./.test(address);
@@ -129,29 +112,12 @@ function phaseGovernanceReady(phase) {
 function fromWebUi(c) {
     return c.req.header("X-Planner-Source") === "web-ui";
 }
-function applyTaskLifecycleDates(task, nextStatus, now) {
-    const previousStatus = task.status;
-    if (nextStatus === "in-progress" && !task.startedAt) {
-        task.startedAt = now;
-    }
-    if (nextStatus === "done") {
-        if (!task.startedAt)
-            task.startedAt = now;
-        task.completedAt = now;
-    }
-    else if (previousStatus === "done") {
-        task.completedAt = "";
-    }
-    task.status = nextStatus;
-    return task;
-}
 function startWatcher(planRoot, hubRef) {
     stopWatcher();
     if (!existsSync(planRoot))
         return;
     const ac = new AbortController();
     watcherAbort = ac;
-    watcherHubRef = hubRef;
     try {
         const watcher = watch(planRoot, { recursive: true, signal: ac.signal }, (_event, filename) => {
             if (filename && !filename.includes(".tmp.")) {
@@ -171,13 +137,6 @@ function stopWatcher() {
     watcherAbort?.abort();
     watcherAbort = null;
 }
-// ── Helpers ─────────────────────────────────────────────────────────
-async function propagateTaskStatus(phaseId) {
-    // This is now handled by PlanStore.syncStatuses()
-}
-async function propagatePhaseStatus(featureId) {
-    // This is now handled by PlanStore.syncStatuses()
-}
 function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
     const hub = () => hubRef.current;
     const route = (path) => `${apiPrefix}${path}`;
@@ -248,7 +207,12 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         const body = await c.req.json();
         const existingProject = await store.loadProject();
         if (body.acceptedDecisions !== undefined && JSON.stringify(body.acceptedDecisions) !== JSON.stringify(existingProject.acceptedDecisions))
-            return c.json({ updated: false, errorCode: "ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED", message: "Raw acceptedDecisions replacement is disabled. Use the accepted-decisions semantic create, update, or delete endpoints so IDs and acceptedAt are preserved." }, 400);
+            return c.json({ updated: false, errorCode: ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED_ERROR_CODE, message: ACCEPTED_DECISION_RAW_REPLACEMENT_DISABLED_MESSAGE }, 400);
+        // The legacy free-form `decisions` array stays writable over HTTP. It is an
+        // agent-governance rule, and .planner/SKILL.md makes the Web UI a human-
+        // supervisor surface that may bypass agent-only gates. Blocking it here also
+        // blocked the only way to seed the legacy state the planner-load migration
+        // exists to consume. The Pi and MCP tools still refuse it.
         const mutableFields = ["name", "goal", "description", "descriptionRef", "webPort", "scope", "outOfScope", "decisions", "globalRules", "technologies", "tools", "contentLanguage", "chatLanguage", "workflowRules", "projectGuidelines"];
         if (!hasDefinedField(body, mutableFields))
             return c.json(noMutableFieldsResponse(mutableFields), 400);
@@ -311,7 +275,7 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         const body = await c.req.json();
         if (!body.targetType)
             return c.json({ error: "targetType required" }, 400);
-        const target = await resolveAcceptedDecisionTarget(store, body.targetType, body.targetRef);
+        const target = await resolveAcceptedDecisionEventTarget(store, body.targetType, body.targetRef);
         if (!target.ok)
             return c.json({ error: target.error, created: false }, 404);
         const createInput = {
@@ -333,7 +297,7 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         const mutableFields = ["title", "decision", "rationale", "implementationNotes"];
         if (!hasDefinedField(body, mutableFields))
             return c.json(noMutableFieldsResponse(mutableFields), 400);
-        const target = await resolveAcceptedDecisionTarget(store, body.targetType, body.targetRef);
+        const target = await resolveAcceptedDecisionEventTarget(store, body.targetType, body.targetRef);
         if (!target.ok)
             return c.json({ error: target.error, updated: false }, 404);
         const updateInput = {
@@ -352,7 +316,7 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         const body = await c.req.json().catch(() => ({}));
         if (!body.targetType)
             return c.json({ error: "targetType required", deleted: false }, 400);
-        const target = await resolveAcceptedDecisionTarget(store, body.targetType, body.targetRef);
+        const target = await resolveAcceptedDecisionEventTarget(store, body.targetType, body.targetRef);
         if (!target.ok)
             return c.json({ error: target.error, deleted: false }, 404);
         if (body.confirmed !== true)
@@ -639,7 +603,7 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         if (body.status !== undefined && body.status !== existing.status)
             return c.json({ updated: false, errorCode: "DERIVED_STATUS_READ_ONLY", message: "Feature status is derived from child phases and tasks and cannot be updated directly." }, 400);
         if (body.acceptedDecisions !== undefined && JSON.stringify(body.acceptedDecisions) !== JSON.stringify(existing.acceptedDecisions))
-            return c.json({ updated: false, errorCode: "ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED", message: "Raw acceptedDecisions replacement is disabled. Use the accepted-decisions semantic create, update, or delete endpoints so IDs and acceptedAt are preserved." }, 400);
+            return c.json({ updated: false, errorCode: ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED_ERROR_CODE, message: ACCEPTED_DECISION_RAW_REPLACEMENT_DISABLED_MESSAGE }, 400);
         const mutableFields = ["name", "description", "descriptionRef", "discussedAt", "contextReady", "contextReadyReason", "startDate", "endDate", "workDone", "workRemaining", "priority", "dependsOn"];
         if (!hasDefinedField(body, mutableFields))
             return c.json(noMutableFieldsResponse(mutableFields), 400);
@@ -668,11 +632,21 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
     }));
     app.delete(route("/features/:id"), async (c) => {
         const id = c.req.param("id");
-        await store.updateFeatures((doc) => {
-            doc.features = doc.features.filter((f) => f.id !== id);
-            return doc;
-        });
-        await store.writeGenerated();
+        if (!id)
+            return c.json({ error: "id required" }, 400);
+        const cascade = c.req.query("cascade") === "true";
+        const outcome = await deleteFeatureCascade(store, id, { cascade });
+        if (!outcome.ok) {
+            // FEATURE_NOT_FOUND: no such feature, or it vanished between resolve
+            // and write (race). Either way, this is a 404 — never a reported
+            // success for a delete that did not happen (same defect class as
+            // T413).
+            return c.json({ error: outcome.error }, 404);
+        }
+        const { result } = outcome;
+        for (const phase of result.phases) {
+            hub()?.broadcast({ type: "phases-updated", data: { action: phase.action === "deleted" ? "deleted" : "updated", id: phase.id, phaseId: phase.id, featureId: phase.action === "deleted" ? id : "" } });
+        }
         hub()?.broadcast({ type: "features-updated", data: { action: "deleted", id, featureId: id } });
         hub()?.broadcast({ type: "plan-rendered", data: {} });
         await store.syncStatuses();
@@ -725,7 +699,6 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
             return c.json({ error: "featureId required: a phase must belong to a feature" }, 400);
         let phase;
         await store.runBatch(() => withFeatureLock(featureId, async () => {
-            const allPhases = await store.loadAllPhases();
             const slug = normalizeSlug(title);
             const id = createPhaseId();
             const identity = await store.allocateEntityIdentity("phase", id);
@@ -816,7 +789,12 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         if (body.status !== undefined && body.status !== existingPhase.status)
             return c.json({ updated: false, errorCode: "DERIVED_STATUS_READ_ONLY", message: "Phase status is derived from child tasks and cannot be updated directly." }, 400);
         if (body.acceptedDecisions !== undefined && JSON.stringify(body.acceptedDecisions) !== JSON.stringify(existingPhase.acceptedDecisions))
-            return c.json({ updated: false, errorCode: "ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED", message: "Raw acceptedDecisions replacement is disabled. Use the accepted-decisions semantic create, update, or delete endpoints so IDs and acceptedAt are preserved." }, 400);
+            return c.json({ updated: false, errorCode: ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED_ERROR_CODE, message: ACCEPTED_DECISION_RAW_REPLACEMENT_DISABLED_MESSAGE }, 400);
+        // The legacy free-form `decisions` array stays writable over HTTP. It is an
+        // agent-governance rule, and .planner/SKILL.md makes the Web UI a human-
+        // supervisor surface that may bypass agent-only gates. Blocking it here also
+        // blocked the only way to seed the legacy state the planner-load migration
+        // exists to consume. The Pi and MCP tools still refuse it.
         let nextFeatureId = existingPhase.featureId;
         if (body.featureId !== undefined) {
             nextFeatureId = body.featureId.trim() || undefined;
@@ -1280,7 +1258,12 @@ function createApiApp(store, hubRef, apiPrefix = "", uiConfig, isBusy) {
         if (!existing)
             return c.json({ error: "task not found" }, 404);
         if (body.acceptedDecisions !== undefined && JSON.stringify(body.acceptedDecisions) !== JSON.stringify(existing.acceptedDecisions))
-            return c.json({ updated: false, errorCode: "ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED", message: "Raw acceptedDecisions replacement is disabled. Use the accepted-decisions semantic create, update, or delete endpoints so IDs and acceptedAt are preserved." }, 400);
+            return c.json({ updated: false, errorCode: ACCEPTED_DECISION_SEMANTIC_MUTATION_REQUIRED_ERROR_CODE, message: ACCEPTED_DECISION_RAW_REPLACEMENT_DISABLED_MESSAGE }, 400);
+        // The legacy free-form `decisions` array stays writable over HTTP. It is an
+        // agent-governance rule, and .planner/SKILL.md makes the Web UI a human-
+        // supervisor surface that may bypass agent-only gates. Blocking it here also
+        // blocked the only way to seed the legacy state the planner-load migration
+        // exists to consume. The Pi and MCP tools still refuse it.
         const mutableFields = ["title", "description", "descriptionRef", "status", "notes", "decisions", "priority", "checklist", "subtasks"];
         if (!hasDefinedField(body, mutableFields))
             return c.json(noMutableFieldsResponse(mutableFields), 400);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agent-plan/server",
-  "version": "0.2.29",
+  "version": "0.3.1",
   "private": false,
   "description": "Local HTTP/WebSocket server for Agent Plan dashboards and planner APIs.",
   "license": "MIT",
@@ -41,7 +41,7 @@
     "@hono/node-server": "^1.14.0",
     "hono": "^4.7.0",
     "ws": "^8.18.0",
-    "@agent-plan/core": "0.2.29"
+    "@agent-plan/core": "0.3.1"
   },
   "devDependencies": {
     "@types/ws": "^8.18.0"