@agent-os-sdk/client 0.2.2 → 0.3.0

package/src/modules/approvals.ts

@@ -1,8 +1,8 @@
 /**
  * Approvals Module - Human-in-the-Loop Native
- *
- * NOT IMPLEMENTED - Backend endpoint not available.
- * All methods return 501 NotImplemented.
+ * 
+ * Wave 2.x: Real implementation for HITL workflow.
+ * Endpoints: /v1/api/workspaces/{workspaceId}/approvals
  */
 
 import type { RawClient, APIResponse } from "../client/raw.js";
@@ -11,58 +11,37 @@ import type { RawClient, APIResponse } from "../client/raw.js";
 // Types
 // ============================================================================
 
-export type ApprovalStatus = "pending" | "approved" | "rejected" | "expired" | "auto_approved";
+export type ApprovalStatus = "pending" | "approved" | "denied" | "expired";
 
 export interface Approval {
     id: string;
     run_id: string;
-    thread_id?: string;
-    action: string;
-    payload: Record<string, unknown>;
+    attempt_id: string;
+    policy_name: string;
+    reason: string;
     status: ApprovalStatus;
-    reason?: string;
-    requested_at: string;
-    responded_at?: string;
-    responded_by?: string;
-    expires_at?: string;
-    auto_approve_after?: number;
+    created_at: string;
+    decided_at?: string;
+    decided_by_actor?: string;
+    payload?: Record<string, unknown>;
 }
 
-export interface ApprovalRequest {
-    run_id: string;
-    action: string;
-    payload: Record<string, unknown>;
-    expires_in_seconds?: number;
-    auto_approve_after_seconds?: number;
-    notify_channels?: string[];
+export interface ApprovalDecision {
+    decision: "approve" | "deny";
+    comment?: string;
 }
 
 export interface ApprovalListResponse {
     items: Approval[];
     total: number;
-    pending_count: number;
-}
-
-export interface ApprovalDecision {
-    approval_id: string;
-    decision: "approve" | "reject";
-    reason?: string;
-    modified_payload?: Record<string, unknown>;
 }
 
-// ============================================================================
-// Helper for 501 responses
-// ============================================================================
-
-function notImplemented<T>(method: string): APIResponse<T> {
-    return {
-        data: undefined,
-        error: {
-            code: "NOT_IMPLEMENTED",
-            message: `ApprovalsModule.${method}() is not implemented. Backend endpoint not available.`,
-        },
-        response: new Response(null, { status: 501, statusText: "Not Implemented" }),
-    };
+export interface ApprovalStatusResponse {
+    id: string;
+    status: ApprovalStatus;
+    decided_at?: string;
+    decided_by_actor?: string;
+    decision_comment?: string;
 }
 
 // ============================================================================
@@ -70,40 +49,103 @@ function notImplemented<T>(method: string): APIResponse<T> {
 // ============================================================================
 
 export class ApprovalsModule {
-    constructor(private client: RawClient, private headers: () => Record<string, string>) { }
-
-    /** @returns 501 Not Implemented */
-    async list(params?: {
+    constructor(
+        private client: RawClient,
+        private headers: () => Record<string, string>
+    ) { }
+
+    /**
+     * List approvals for a workspace.
+     * @param workspaceId - Workspace ID
+     * @param params - Filter options
+     */
+    async list(workspaceId: string, params?: {
         status?: ApprovalStatus;
-        run_id?: string;
         limit?: number;
-        offset?: number;
     }): Promise<APIResponse<ApprovalListResponse>> {
-        return notImplemented<ApprovalListResponse>("list");
+        return this.client.GET<ApprovalListResponse>(
+            "/v1/api/workspaces/{workspaceId}/approvals",
+            {
+                params: {
+                    path: { workspaceId },
+                    query: {
+                        status: params?.status,
+                        limit: params?.limit ?? 50
+                    }
+                },
+                headers: this.headers(),
+            }
+        );
     }
 
-    /** @returns 501 Not Implemented */
-    async get(approvalId: string): Promise<APIResponse<Approval>> {
-        return notImplemented<Approval>("get");
+    /**
+     * Get a specific approval by ID.
+     * @param workspaceId - Workspace ID
+     * @param approvalId - Approval ID
+     */
+    async get(workspaceId: string, approvalId: string): Promise<APIResponse<Approval>> {
+        return this.client.GET<Approval>(
+            "/v1/api/workspaces/{workspaceId}/approvals/{approvalId}",
+            {
+                params: {
+                    path: { workspaceId, approvalId }
+                },
+                headers: this.headers(),
+            }
+        );
     }
 
-    /** @returns 501 Not Implemented */
-    async create(request: ApprovalRequest): Promise<APIResponse<Approval>> {
-        return notImplemented<Approval>("create");
+    /**
+     * Approve an approval request.
+     * @param workspaceId - Workspace ID
+     * @param approvalId - Approval ID
+     * @param comment - Optional reason for approval
+     */
+    async approve(workspaceId: string, approvalId: string, comment?: string): Promise<APIResponse<ApprovalStatusResponse>> {
+        return this.client.POST<ApprovalStatusResponse>(
+            "/v1/api/workspaces/{workspaceId}/approvals/{approvalId}/decision",
+            {
+                params: {
+                    path: { workspaceId, approvalId }
+                },
+                body: {
+                    decision: "approve",
+                    comment
+                },
+                headers: this.headers(),
+            }
+        );
     }
 
-    /** @returns 501 Not Implemented */
-    async approve(approvalId: string, reason?: string): Promise<APIResponse<Approval>> {
-        return notImplemented<Approval>("approve");
+    /**
+     * Deny an approval request.
+     * @param workspaceId - Workspace ID
+     * @param approvalId - Approval ID
+     * @param comment - Optional reason for denial
+     */
+    async deny(workspaceId: string, approvalId: string, comment?: string): Promise<APIResponse<ApprovalStatusResponse>> {
+        return this.client.POST<ApprovalStatusResponse>(
+            "/v1/api/workspaces/{workspaceId}/approvals/{approvalId}/decision",
+            {
+                params: {
+                    path: { workspaceId, approvalId }
+                },
+                body: {
+                    decision: "deny",
+                    comment
+                },
+                headers: this.headers(),
+            }
+        );
     }
 
-    /** @returns 501 Not Implemented */
-    async reject(approvalId: string, reason?: string): Promise<APIResponse<Approval>> {
-        return notImplemented<Approval>("reject");
+    /**
+     * Shorthand: List pending approvals for a workspace.
+     */
+    async listPending(workspaceId: string, limit = 50): Promise<APIResponse<ApprovalListResponse>> {
+        return this.list(workspaceId, { status: "pending", limit });
     }
 
-    /** @returns 501 Not Implemented */
-    async awaitApproval(runId: string, timeoutSeconds?: number): Promise<APIResponse<Approval>> {
-        return notImplemented<Approval>("awaitApproval");
-    }
+    // Convenience aliases
+    reject = this.deny;
 }