@agent-native/recap-cli 0.5.67 → 0.5.68-nightly-20261009011246

package/dist/recap.js

@@ -1008,9 +1008,9 @@ function compactWhitespace(text) {
 }
 export function sanitizeAgentFailureSummary(value, maxChars = AGENT_FAILURE_MAX_CHARS) {
     const redactSecretValues = (line) => line
-        .replace(/Authorization:\s*Bearer\s+[A-Za-z0-9._-]{8,}/gi, "Authorization: Bearer [redacted]")
-        .replace(/Bearer\s+[A-Za-z0-9._-]{8,}/gi, "Bearer [redacted]")
-        .replace(/Authorization:\s*(?!Bearer\s+\[redacted\])[^\s]+/gi, "Authorization: [redacted]")
+        .replace(/Authorization\s*[:=]\s*Bearer\s+\S+/gi, "Authorization: Bearer [redacted]")
+        .replace(/Bearer\s+\S+/gi, "Bearer [redacted]")
+        .replace(/Authorization\s*[:=]\s*(?!Bearer\s+\[redacted\])(?:\S+\s+)?\S+/gi, "Authorization: [redacted]")
         .replace(/PLAN_RECAP_TOKEN=([^\s]+)/g, "PLAN_RECAP_TOKEN=[redacted]")
         .replace(/ANTHROPIC_API_KEY=([^\s]+)/g, "ANTHROPIC_API_KEY=[redacted]")
         .replace(/OPENAI_API_KEY=([^\s]+)/g, "OPENAI_API_KEY=[redacted]");
@@ -1751,6 +1751,32 @@ export function buildCommentBody(env = process.env) {
     const lightImageUrl = trustedRecapImageUrl(env.RECAP_LIGHT_IMAGE_URL || env.RECAP_IMAGE_URL, base);
     const darkImageUrl = trustedRecapImageUrl(env.RECAP_DARK_IMAGE_URL, base);
     const fallbackImageUrl = env.RECAP_SHOT_OK === "false" ? undefined : lightImageUrl || darkImageUrl;
+    const readbackFailed = Object.hasOwn(env, "RECAP_READBACK_OK") && env.RECAP_READBACK_OK !== "true";
+    if (readbackFailed) {
+        const readbackDiagnostic = (env.RECAP_READBACK_REASON || "").trim() ||
+            (env.RECAP_SHOT_REASON || "")
+                .trim()
+                .match(/^Published recap readback failed:\s*(.+)$/i)?.[1] ||
+            "";
+        const diagnostic = buildRecapFailureDiagnostic({
+            readbackReason: readbackDiagnostic,
+        });
+        lines.push("### Visual recap — readback failed");
+        lines.push("");
+        lines.push("The recap was published, but the workflow could not verify it. Screenshot capture was skipped. Open the interactive recap directly:");
+        lines.push("");
+        lines.push(`**Open the [full interactive recap](${safeUrl})**`);
+        if (diagnostic)
+            lines.push("", "Diagnostic:", "", diagnostic);
+        if (env.DIFF_HUGE === "true") {
+            lines.push("", "_This PR has a large diff; the recap summarizes its main changes._");
+        }
+        if (markerPlanId)
+            lines.push("", `<!-- plan-id: ${markerPlanId} -->`);
+        if (headMarker)
+            lines.push("", headMarker);
+        return lines.join("\n");
+    }
     if (!fallbackImageUrl) {
         const diagnostic = sanitizeAgentFailureSummary((env.RECAP_SHOT_REASON || "").trim(), 500) ||
             (env.RECAP_SHOT_OK === "true"
@@ -2624,6 +2650,52 @@ importPlaywright = defaultImportPlaywright) {
             });
         }
         const page = await context.newPage();
+        const trustedAppOrigin = new URL(appUrl ?? url).origin;
+        const planActionResponses = [];
+        let pageErrorCount = 0;
+        page.on("pageerror", () => {
+            pageErrorCount += 1;
+        });
+        page.on("response", (response) => {
+            const responseUrl = new URL(response.url());
+            if (responseUrl.origin !== trustedAppOrigin)
+                return;
+            const action = responseUrl.pathname.match(/\/_agent-native\/actions\/(get-visual-plan|get-plan-access-status)$/)?.[1];
+            if (action) {
+                planActionResponses.push({ action, status: response.status() });
+            }
+        });
+        const describeDocumentTimeout = async (error) => {
+            let state;
+            try {
+                const browserState = await page.evaluate(() => {
+                    const bodyText = document.body?.innerText ?? "";
+                    return {
+                        readyState: document.readyState,
+                        hasPlanDocument: Boolean(document.querySelector("[data-plan-document]")),
+                        hasSignInPrompt: /sign in|log in/i.test(bodyText),
+                        hasAccessError: /belongs to|no access|forbidden/i.test(bodyText),
+                    };
+                });
+                state = { kind: "available", ...browserState };
+            }
+            catch {
+                state = { kind: "unavailable" };
+            }
+            const actions = ["get-visual-plan", "get-plan-access-status"].map((action) => {
+                const latest = [...planActionResponses]
+                    .reverse()
+                    .find((response) => response.action === action);
+                return `${action}=${latest ? `HTTP ${latest.status}` : "not requested"}`;
+            });
+            const pageState = state.kind === "available"
+                ? `document=${state.readyState}, plan-document=${state.hasPlanDocument}, sign-in=${state.hasSignInPrompt}, access-error=${state.hasAccessError}`
+                : "document state unavailable";
+            const clientErrors = pageErrorCount
+                ? `, client runtime errors=${pageErrorCount}`
+                : "";
+            return new Error(`${errorMessage(error)}; recap readiness: ${actions.join(", ")}; ${pageState}${clientErrors}`);
+        };
         for (let attempt = 1; attempt <= RECAP_DOCUMENT_LOAD_ATTEMPTS; attempt += 1) {
             try {
                 const navigationResponse = await page.goto(captureUrl, {
@@ -2651,10 +2723,12 @@ importPlaywright = defaultImportPlaywright) {
                 break;
             }
             catch (err) {
-                if (attempt === RECAP_DOCUMENT_LOAD_ATTEMPTS ||
-                    !shouldRetryRecapDocumentLoad(err)) {
+                if (!shouldRetryRecapDocumentLoad(err)) {
                     throw err;
                 }
+                if (attempt === RECAP_DOCUMENT_LOAD_ATTEMPTS) {
+                    throw await describeDocumentTimeout(err);
+                }
                 process.stderr.write(`[recap shot] recap document did not become ready; retrying once\n`);
             }
         }
@@ -3105,9 +3179,15 @@ export function inferLocalRecapUrlFailureReason(input = {}) {
 export function buildRecapFailureDiagnostic(input) {
     const parts = [];
     const urlReason = sanitizeAgentFailureSummary(input.urlReason ?? "", 400);
+    const readbackReason = sanitizeAgentFailureSummary(input.readbackReason ?? "", 400);
+    const shotReason = sanitizeAgentFailureSummary(input.shotReason ?? "", 400);
     const failureSummary = sanitizeAgentFailureSummary(input.failureSummary ?? "", 900);
     if (urlReason)
         parts.push(`No plan URL: ${urlReason}`);
+    if (readbackReason)
+        parts.push(`Published recap readback failed: ${readbackReason}`);
+    if (shotReason)
+        parts.push(`Screenshot failed: ${shotReason}`);
     if (failureSummary)
         parts.push(`Agent output: ${failureSummary}`);
     return parts.join("\n\n");
@@ -3119,18 +3199,40 @@ export function recapCheckOutcome(input) {
     const diagnostic = buildRecapFailureDiagnostic({
         failureSummary: input.failureSummary,
         urlReason: input.urlReason,
+        shotReason: input.readbackOk === false ? undefined : input.shotReason,
+        readbackReason: input.readbackReason,
     });
     let text = diagnostic ? `### Diagnostic\n\n${diagnostic}` : "";
     let detailsUrl = input.workflowUrl;
-    if (input.planOk) {
-        const recapUrl = canonicalRecapUrl(input.planUrl, input.appUrl);
+    const recapUrl = canonicalRecapUrl(input.planUrl, input.appUrl);
+    if (recapUrl && input.readbackOk === false) {
+        detailsUrl = recapUrl;
+        conclusion = "failure";
+        title = "Visual recap readback failed";
+        summary =
+            "The recap was published, but the workflow could not verify it. Screenshot capture was skipped. This informational check does not block the PR.";
+        text = diagnostic
+            ? `**[Open visual recap](${recapUrl})**\n\n### Diagnostic\n\n${diagnostic}\n\nScreenshot capture was skipped.`
+            : `**[Open visual recap](${recapUrl})**\n\nScreenshot capture was skipped because published recap readback failed.`;
+    }
+    else if (recapUrl && input.screenshotOk === false) {
+        detailsUrl = recapUrl;
+        conclusion = "failure";
+        title = "Visual recap screenshot failed";
+        summary =
+            "The recap was published, but its screenshot could not be captured. This informational check does not block the PR.";
+        text = diagnostic
+            ? `**[Open visual recap](${recapUrl})**\n\n### Diagnostic\n\n${diagnostic}`
+            : `**[Open visual recap](${recapUrl})**\n\nScreenshot capture did not return both theme images.`;
+    }
+    else if (input.planOk) {
         if (recapUrl) {
+            detailsUrl = recapUrl;
             conclusion = "success";
             title = "Visual recap ready";
             summary = input.huge
                 ? "A summarized visual recap was generated for this large PR."
                 : "A visual code-review recap was generated for this PR.";
-            detailsUrl = recapUrl;
             text = `**[Open visual recap](${recapUrl})**`;
         }
         else {
@@ -3215,13 +3317,26 @@ async function runCheckComplete(args) {
         "";
     const checkRunId = optionalArg(args, "check-run-id") ?? "";
     const planOk = boolFlag(args, "plan-ok");
+    const screenshotOk = Object.hasOwn(args, "shot-ok")
+        ? boolFlag(args, "shot-ok")
+        : undefined;
+    const readbackOk = Object.hasOwn(args, "readback-ok")
+        ? boolFlag(args, "readback-ok")
+        : undefined;
     const huge = boolFlag(args, "huge");
     const tiny = boolFlag(args, "tiny");
     const suppressed = boolFlag(args, "suppressed");
     const appUrl = optionalArg(args, "app-url") ?? process.env.PLAN_RECAP_APP_URL ?? "";
     let failureSummary = optionalArg(args, "failure-summary") ?? "";
     let urlReason = optionalArg(args, "url-reason") ?? "";
-    if (!planOk && !tiny && !suppressed) {
+    const shotReason = optionalArg(args, "shot-reason") ?? "";
+    const readbackReason = optionalArg(args, "readback-reason") ?? "";
+    const planUrl = optionalArg(args, "plan-url") ?? "";
+    const publishedRecap = canonicalRecapUrl(planUrl, appUrl);
+    if (!planOk &&
+        !tiny &&
+        !suppressed &&
+        !(publishedRecap && (readbackOk === false || screenshotOk === false))) {
         if (!failureSummary) {
             failureSummary = summarizeLocalAgentFailure({
                 agent: optionalArg(args, "agent") ??
@@ -3239,12 +3354,16 @@ async function runCheckComplete(args) {
     }
     const outcome = recapCheckOutcome({
         planOk,
-        planUrl: optionalArg(args, "plan-url") ?? "",
+        planUrl,
         appUrl,
         huge,
         tiny,
         suppressed,
         suppressedJson: optionalArg(args, "suppressed-json") ?? "",
+        readbackOk,
+        readbackReason,
+        screenshotOk,
+        shotReason,
         failureSummary,
         urlReason,
         workflowUrl: optionalArg(args, "workflow-url") ?? "",
@@ -3537,7 +3656,7 @@ Usage:
     $GITHUB_OUTPUT (check_run_id). repo/sha/token default to GITHUB_REPOSITORY /
     HEAD_SHA / GH_TOKEN (or GITHUB_TOKEN). Best-effort: warns and exits 0 on any
     API error without emitting an id.
-  npx @agent-native/recap-cli@latest recap check complete --check-run-id <id> [--repo owner/name] [--token <github-token>] [--plan-ok <bool>] [--plan-url <url>] [--app-url <url>] [--suppressed <bool>] [--suppressed-json <json>] [--huge <bool>] [--tiny <bool>] [--failure-summary <text>] [--url-reason <text>] [--workflow-url <url>]
+  npx @agent-native/recap-cli@latest recap check complete --check-run-id <id> [--repo owner/name] [--token <github-token>] [--plan-ok <bool>] [--plan-url <url>] [--app-url <url>] [--readback-ok <bool>] [--readback-reason <text>] [--shot-ok <bool>] [--shot-reason <text>] [--suppressed <bool>] [--suppressed-json <json>] [--huge <bool>] [--tiny <bool>] [--failure-summary <text>] [--url-reason <text>] [--workflow-url <url>]
     Mark the "Visual Recap" check run completed with a computed
     conclusion/title/summary/text/details_url (success when the agent published a
     plan whose URL validates against --app-url; neutral/skipped otherwise).