@agent-native/dispatch 0.33.1-nightly-20260902192636 → 0.33.1

package/src/components/workspace-app-card.spec.tsx

@@ -2,7 +2,7 @@
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import React, { act } from "react";
 import { createRoot, type Root } from "react-dom/client";
-import { MemoryRouter } from "react-router";
+import { MemoryRouter, useLocation } from "react-router";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { TooltipProvider } from "./ui/tooltip";
@@ -54,7 +54,13 @@ vi.mock("@agent-native/core/client/i18n", () => ({
 
 const frameState = vi.hoisted(() => ({ inBuilderFrame: false }));
 
+function LocationProbe() {
+  const location = useLocation();
+  return <output data-location-path>{location.pathname}</output>;
+}
+
 vi.mock("@agent-native/core/client/host", () => ({
+  getClientSurface: () => "web",
   isInBuilderFrame: () => frameState.inBuilderFrame,
 }));
 
@@ -259,6 +265,68 @@ describe("WorkspaceAppCard", () => {
     }
   });
 
+  it("falls back to the Dispatch route when top-window navigation is blocked", async () => {
+    frameState.inBuilderFrame = true;
+    const originalParent = window.parent;
+    const originalTop = window.top;
+    const location = {} as Location;
+    Object.defineProperty(location, "href", {
+      configurable: true,
+      set: () => {
+        throw new Error("Top navigation is blocked");
+      },
+    });
+    const topWindow = { location } as unknown as Window;
+    Object.defineProperty(window, "parent", {
+      configurable: true,
+      value: {},
+    });
+    Object.defineProperty(window, "top", {
+      configurable: true,
+      value: topWindow,
+    });
+
+    try {
+      await act(async () => {
+        root.render(
+          <MemoryRouter>
+            <LocationProbe />
+            <TooltipProvider>
+              <WorkspaceAppCard
+                app={{
+                  id: "feedback-leaderboard",
+                  name: "Feedback leaderboard",
+                  path: "/feedback-leaderboard",
+                  url: "https://agent-workspace.builder.io/feedback-leaderboard/leaderboard",
+                  status: "ready",
+                }}
+              />
+            </TooltipProvider>
+          </MemoryRouter>,
+        );
+      });
+
+      await act(async () =>
+        container
+          .querySelector<HTMLButtonElement>(".app-open-actions__primary")
+          ?.click(),
+      );
+
+      expect(container.querySelector("[data-location-path]")?.textContent).toBe(
+        "/apps/feedback-leaderboard",
+      );
+    } finally {
+      Object.defineProperty(window, "parent", {
+        configurable: true,
+        value: originalParent,
+      });
+      Object.defineProperty(window, "top", {
+        configurable: true,
+        value: originalTop,
+      });
+    }
+  });
+
   it("opens Share from the app settings menu instead of the card actions", async () => {
     const animationFrameCallbacks: FrameRequestCallback[] = [];
     vi.stubGlobal("requestAnimationFrame", (callback: FrameRequestCallback) => {

package/src/components/workspace-app-card.tsx

@@ -380,9 +380,10 @@ function WorkspaceAppOpenActions({
       name={app.name}
       href={href}
       showNewTabOption
-      onOpen={() =>
-        openDirectly ? navigateToWorkspaceApp(href) : navigate(appRoute)
-      }
+      onOpen={() => {
+        if (!openDirectly || navigateToWorkspaceApp(href)) return;
+        void navigate(appRoute);
+      }}
       menuItems={
         onTogglePinned
           ? [

package/src/components/workspace-app-host.spec.tsx

@@ -38,6 +38,7 @@ const clientState = vi.hoisted(() => {
     legacyMutateError: null as Error | null,
     legacyErrorMutateAsync,
     inBuilderFrame: false,
+    clientSurface: "web" as "web" | "electron" | "tauri",
     frameLoadHandler: null as (() => void) | null,
     suppressFrameLoad: false,
     theme: "dark" as "dark" | "light",
@@ -95,6 +96,7 @@ vi.mock("@agent-native/core/client/feature-flags", () => ({
 }));
 
 vi.mock("@agent-native/core/client/host", () => ({
+  getClientSurface: () => clientState.clientSurface,
   isInBuilderFrame: () => clientState.inBuilderFrame,
 }));
 
@@ -190,6 +192,7 @@ describe("WorkspaceAppKeepAlive", () => {
     clientState.legacyMutateError = null;
     clientState.legacyErrorMutateAsync.mockReset();
     clientState.inBuilderFrame = false;
+    clientState.clientSurface = "web";
     clientState.frameLoadHandler = null;
     clientState.suppressFrameLoad = false;
     clientState.workspaceSsoMutateAsync.mockClear();
@@ -663,6 +666,27 @@ describe("WorkspaceAppKeepAlive", () => {
     expect(container.querySelector("iframe")).not.toBeNull();
   });
 
+  it("opens the app in the top window for a native desktop host", async () => {
+    const topWindow = { location: { href: "" } } as unknown as Window;
+    const expectedUrl = new URL("/mail", window.location.href).href;
+    clientState.clientSurface = "electron";
+    Object.defineProperty(window, "top", {
+      configurable: true,
+      value: topWindow,
+    });
+
+    await act(async () => {
+      root.render(
+        <WorkspaceAppFrame app={{ id: "mail", name: "Mail", path: "/mail" }} />,
+      );
+      await Promise.resolve();
+    });
+
+    expect(topWindow.location.href).toBe(expectedUrl);
+    expect(clientState.legacyMutateAsync).not.toHaveBeenCalled();
+    expect(container.querySelector("iframe")).toBeNull();
+  });
+
   it("falls back to the embedded app when top-window navigation is blocked", async () => {
     const navigateToTopWindow = vi.fn(() => false);
     clientState.inBuilderFrame = true;

package/src/lib/workspace-apps.test.ts

@@ -8,6 +8,15 @@ import {
   workspaceAppEmbedTarget,
 } from "./workspace-apps";
 
+const defaultUserAgent = navigator.userAgent;
+
+function setUserAgent(userAgent: string) {
+  Object.defineProperty(navigator, "userAgent", {
+    configurable: true,
+    value: userAgent,
+  });
+}
+
 function setAncestorOrigin(origin: string | null) {
   Object.defineProperty(window.location, "ancestorOrigins", {
     configurable: true,
@@ -88,6 +97,7 @@ describe("navigateToWorkspaceApp", () => {
   afterEach(() => {
     window.history.replaceState({}, "", "/");
     setAncestorOrigin(null);
+    setUserAgent(defaultUserAgent);
     Object.defineProperty(window, "parent", {
       configurable: true,
       value: window,
@@ -107,6 +117,32 @@ describe("navigateToWorkspaceApp", () => {
     expect(shouldOpenWorkspaceAppInTopWindow()).toBe(false);
   });
 
+  it("keeps unrelated Electron webviews inline", () => {
+    setUserAgent("Mozilla/5.0 Electron/38.0");
+
+    expect(shouldOpenWorkspaceAppInTopWindow()).toBe(false);
+  });
+
+  it("ignores a generic Electron preload global", () => {
+    setUserAgent("Mozilla/5.0 Electron/38.0");
+    Object.defineProperty(window, "electronAPI", {
+      configurable: true,
+      value: {},
+    });
+
+    try {
+      expect(shouldOpenWorkspaceAppInTopWindow()).toBe(false);
+    } finally {
+      delete (window as unknown as { electronAPI?: unknown }).electronAPI;
+    }
+  });
+
+  it("uses the top window in known native desktop hosts", () => {
+    setUserAgent("Mozilla/5.0 Electron/38.0 ChatGPT/1.0");
+
+    expect(shouldOpenWorkspaceAppInTopWindow()).toBe(true);
+  });
+
   it("keeps the hosted Dispatch shell inline", () => {
     Object.defineProperty(window, "parent", {
       configurable: true,

package/src/lib/workspace-apps.ts

@@ -1,5 +1,8 @@
 import { CHAT_FIRST_DEFAULT_APP_IDS } from "@agent-native/core/client/chat-first";
-import { isInBuilderFrame } from "@agent-native/core/client/host";
+import {
+  getClientSurface,
+  isInBuilderFrame,
+} from "@agent-native/core/client/host";
 import {
   resolveEnvironmentTargets,
   withBuilderUtmTrackingParams,
@@ -376,9 +379,9 @@ export function isPendingBuilderHref(app: WorkspaceAppSummary): boolean {
 
 export function shouldOpenWorkspaceAppInTopWindow(): boolean {
   if (typeof window === "undefined") return false;
-  // A generic iframe is an inline host by design. Only Builder owns the
-  // parent navigation contract for workspace apps.
-  return isInBuilderFrame();
+  // Standard browser iframes stay inline; Builder and native shells need the
+  // app as the top-level document so browser APIs such as WebMCP bind to it.
+  return isInBuilderFrame() || getClientSurface() !== "web";
 }
 
 export function navigateToWorkspaceApp(href: string): boolean {