@agent-native/core 0.90.3 → 0.90.5

package/corpus/core/src/client/agent-chat-adapter.ts

@@ -133,16 +133,15 @@ const MAX_HISTORY_LARGE_TOOL_ARGS_CHARS = 200_000;
 const STARTUP_RESPONSE_TIMEOUT_MS = 45_000;
 
 // ── Background follow mode ──────────────────────────────────────────────────
-// For background-dispatched runs (dispatchMode starts with "background") the
-// SERVER is the sole recovery brain: it chains continuation chunks itself
-// (fresh runId, same turnId), pre-inserts the successor run row BEFORE the old
-// chunk completes (so /runs/active shows an active run continuously across
-// chunk boundaries), and a server sweep reaps lost handoffs into loud terminal
-// errors. The client therefore never POSTs synthetic continuations for these
-// runs — it demotes itself to a READER of server state: poll /runs/active,
-// (re)attach to whichever run of this turn is live, and fold its events into
-// the same assistant message. Read-only, so multiple tabs following the same
-// run are safe (no localStorage/Web-Locks claim needed).
+// For server-continued runs (dispatchMode starts with "background" or equals
+// "foreground-self-chain") the SERVER normally chains continuation chunks
+// itself (fresh runId, same turnId), pre-inserts the successor run row BEFORE
+// the old chunk completes (so /runs/active shows an active run continuously
+// across chunk boundaries), and a server sweep reaps lost handoffs into loud
+// terminal errors. The client demotes itself to a READER of server state for
+// healthy handoffs. Foreground self-chain keeps one escape hatch: if the server
+// reports that the self-dispatch itself failed before a successor claimed the
+// run, the existing client auto-continue POST remains the fallback.
 const BACKGROUND_FOLLOW_POLL_INTERVAL_MS = 1_000;
 // How long the follow loop tolerates seeing NO active run for this turn before
 // treating the turn as ended. The server pre-inserts the successor row before
@@ -1687,12 +1686,24 @@ export function createAgentChatAdapter(
         if (mode) currentRunDispatchMode = mode;
       };
 
-      // Mode switch for recovery ownership: background-dispatched runs are
-      // recovered by the SERVER (chained continuations, sweeps); the client
-      // only follows. Foreground (null/"foreground"/unknown) keeps the full
-      // client-side continuation machinery unchanged.
-      const isBackgroundDispatch = () =>
+      // Mode switch for recovery ownership: durable/background-dispatched runs
+      // are always recovered by the server. Foreground self-chain follows the
+      // server on healthy handoffs, but a loud self-dispatch failure falls back
+      // to the client POST path because no successor run owns recovery yet.
+      const isDurableBackgroundDispatch = () =>
         currentRunDispatchMode?.startsWith("background") === true;
+      const isForegroundSelfChainDispatch = () =>
+        currentRunDispatchMode === "foreground-self-chain";
+      const shouldFollowServerContinuation = (
+        signal?: AgentAutoContinueSignal,
+      ) => {
+        if (isDurableBackgroundDispatch()) return true;
+        if (!isForegroundSelfChainDispatch()) return false;
+        return (
+          signal?.errorInfo?.errorCode !==
+          "background_continuation_dispatch_failed"
+        );
+      };
 
       const rememberRunSeq = (seq: number) => {
         lastSeq = seq;
@@ -2966,7 +2977,7 @@ export function createAgentChatAdapter(
               // following of server state instead. This is the fix for the
               // client/server recovery race: client watchdog signals here are
               // just "reattach", not "recover".
-              if (isBackgroundDispatch() && threadId) {
+              if (shouldFollowServerContinuation(err) && threadId) {
                 yield* followBackgroundTurn(err);
                 return;
               }
@@ -3145,7 +3156,7 @@ export function createAgentChatAdapter(
             // synthetic-continuation POST below. (An initial POST that failed
             // before any response headers arrived has no dispatch mode yet
             // and keeps the foreground startup-retry path.)
-            if (isBackgroundDispatch() && threadId) {
+            if (shouldFollowServerContinuation() && threadId) {
               yield* followBackgroundTurn(
                 new AgentAutoContinueSignal({ reason: "stream_ended" }),
               );

package/corpus/core/src/client/history/VersionHistoryPanel.tsx

@@ -1,5 +1,5 @@
 import { IconClock, IconRestore, IconTimeline } from "@tabler/icons-react";
-import type { ReactNode } from "react";
+import { useState, type ReactNode } from "react";
 
 import type { ResourceVersion } from "../../history/types.js";
 import { cn } from "../utils.js";
@@ -31,6 +31,7 @@ export function VersionHistoryPanel({
 }: VersionHistoryPanelProps) {
   const versions = useResourceVersions({ resourceType, resourceId, limit });
   const restore = useRestoreResourceVersion();
+  const [confirmRestoreId, setConfirmRestoreId] = useState<string | null>(null);
 
   return (
     <section
@@ -49,52 +50,81 @@ export function VersionHistoryPanel({
             Loading versions...
           </div>
         ) : versions.data?.versions.length ? (
-          versions.data.versions.map((version) => (
-            <article key={version.id} className="flex gap-3 px-4 py-3">
-              <div className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-full bg-muted">
-                <IconClock className="h-4 w-4 text-muted-foreground" />
-              </div>
-              <div className="min-w-0 flex-1">
-                {renderVersion ? (
-                  renderVersion(version)
-                ) : (
-                  <>
-                    <div className="flex flex-wrap items-center gap-x-2 gap-y-1">
-                      <h3 className="truncate text-sm font-medium">
-                        {version.title ?? `Version ${version.versionNumber}`}
-                      </h3>
-                      <span className="text-xs text-muted-foreground">
-                        {formatVersionDate(version.createdAt)}
-                      </span>
-                    </div>
-                    {version.summary ? (
-                      <p className="mt-1 text-sm text-muted-foreground">
-                        {version.summary}
-                      </p>
-                    ) : null}
-                  </>
-                )}
-              </div>
-              <button
-                type="button"
-                className="inline-flex h-8 items-center gap-1.5 rounded-md border border-input px-2.5 text-xs font-medium hover:bg-accent disabled:cursor-not-allowed disabled:opacity-50"
-                disabled={restore.isPending}
-                onClick={() =>
-                  restore.mutate(
-                    { id: version.id },
-                    {
-                      onSuccess: (result) => {
-                        onRestored?.(result.version, result.result);
-                      },
-                    },
-                  )
-                }
-              >
-                <IconRestore className="h-3.5 w-3.5" />
-                Restore
-              </button>
-            </article>
-          ))
+          versions.data.versions.map((version) => {
+            const confirming = confirmRestoreId === version.id;
+            return (
+              <article key={version.id} className="flex gap-3 px-4 py-3">
+                <div className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-full bg-muted">
+                  <IconClock className="h-4 w-4 text-muted-foreground" />
+                </div>
+                <div className="min-w-0 flex-1">
+                  {renderVersion ? (
+                    renderVersion(version)
+                  ) : (
+                    <>
+                      <div className="flex flex-wrap items-center gap-x-2 gap-y-1">
+                        <h3 className="truncate text-sm font-medium">
+                          {version.title ?? `Version ${version.versionNumber}`}
+                        </h3>
+                        <span className="text-xs text-muted-foreground">
+                          {formatVersionDate(version.createdAt)}
+                        </span>
+                      </div>
+                      {version.summary ? (
+                        <p className="mt-1 text-sm text-muted-foreground">
+                          {version.summary}
+                        </p>
+                      ) : null}
+                    </>
+                  )}
+                </div>
+                <div className="flex shrink-0 items-center gap-2">
+                  {confirming ? (
+                    <>
+                      <button
+                        type="button"
+                        className="inline-flex h-8 items-center rounded-md border border-input px-2.5 text-xs font-medium hover:bg-accent disabled:cursor-not-allowed disabled:opacity-50"
+                        disabled={restore.isPending}
+                        onClick={() => setConfirmRestoreId(null)}
+                      >
+                        Cancel
+                      </button>
+                      <button
+                        type="button"
+                        className="inline-flex h-8 items-center gap-1.5 rounded-md border border-destructive bg-destructive px-2.5 text-xs font-medium text-destructive-foreground hover:bg-destructive/90 disabled:cursor-not-allowed disabled:opacity-50"
+                        disabled={restore.isPending}
+                        onClick={() =>
+                          restore.mutate(
+                            { id: version.id },
+                            {
+                              onSuccess: (result) => {
+                                setConfirmRestoreId(null);
+                                onRestored?.(result.version, result.result);
+                              },
+                              onError: () => setConfirmRestoreId(null),
+                            },
+                          )
+                        }
+                      >
+                        <IconRestore className="h-3.5 w-3.5" />
+                        Confirm restore
+                      </button>
+                    </>
+                  ) : (
+                    <button
+                      type="button"
+                      className="inline-flex h-8 items-center gap-1.5 rounded-md border border-input px-2.5 text-xs font-medium hover:bg-accent disabled:cursor-not-allowed disabled:opacity-50"
+                      disabled={restore.isPending}
+                      onClick={() => setConfirmRestoreId(version.id)}
+                    >
+                      <IconRestore className="h-3.5 w-3.5" />
+                      Restore
+                    </button>
+                  )}
+                </div>
+              </article>
+            );
+          })
         ) : (
           <div className="px-4 py-6 text-sm text-muted-foreground">
             {emptyState}

package/corpus/core/src/client/history/index.ts

@@ -6,9 +6,12 @@ export {
 export {
   useCreateResourceVersion,
   useResourceHistory,
+  useResourceVersion,
   useResourceVersions,
   useRestoreResourceVersion,
   type CreateResourceVersionInput,
+  type GetResourceVersionInput,
+  type GetResourceVersionResult,
   type ListResourceHistoryResult,
   type ListResourceVersionsResult,
   type ResourceHistoryParams,

package/corpus/core/src/client/history/use-history.ts

@@ -30,6 +30,13 @@ export interface RestoreResourceVersionInput {
   versionNumber?: number;
 }
 
+export interface GetResourceVersionInput {
+  id?: string;
+  resourceType?: string;
+  resourceId?: string;
+  versionNumber?: number;
+}
+
 export interface ListResourceVersionsResult {
   versions: ResourceVersion[];
 }
@@ -39,6 +46,10 @@ export interface ListResourceHistoryResult {
   auditEvents: unknown[];
 }
 
+export interface GetResourceVersionResult {
+  version: ResourceVersion;
+}
+
 export interface RestoreResourceVersionResult {
   version: ResourceVersion;
   result: unknown;
@@ -72,6 +83,23 @@ export function useResourceHistory(
   );
 }
 
+export function useResourceVersion(
+  params: GetResourceVersionInput,
+  options?: { enabled?: boolean },
+) {
+  const enabled =
+    options?.enabled ??
+    Boolean(
+      params.id ||
+      (params.resourceType && params.resourceId && params.versionNumber),
+    );
+  return useActionQuery<GetResourceVersionResult>(
+    "get-resource-version",
+    params,
+    { enabled },
+  );
+}
+
 export function useCreateResourceVersion() {
   return useActionMutation<ResourceVersion, CreateResourceVersionInput>(
     "create-resource-version",

package/corpus/core/src/client/index.ts

@@ -791,9 +791,12 @@ export {
   VersionHistoryPanel,
   useCreateResourceVersion,
   useResourceHistory,
+  useResourceVersion,
   useResourceVersions,
   useRestoreResourceVersion,
   type CreateResourceVersionInput,
+  type GetResourceVersionInput,
+  type GetResourceVersionResult,
   type ListResourceHistoryResult,
   type ListResourceVersionsResult,
   type ResourceHistoryParams,
@@ -806,14 +809,19 @@ export {
   ReviewStatusBadge,
   ReviewThreadPanel,
   buildReviewThreads,
+  useConsumeReviewFeedback,
   useCreateReviewComment,
   useDeleteReviewComment,
   useReplyReviewComment,
   useResolveReviewThread,
   useReviewComments,
+  useReviewFeedback,
   useSetReviewStatus,
+  type ConsumeReviewFeedbackInput,
   type CreateReviewCommentInput,
   type DeleteReviewCommentInput,
+  type GetReviewFeedbackParams,
+  type GetReviewFeedbackResult,
   type ListReviewCommentsParams,
   type ListReviewCommentsResult,
   type ReplyReviewCommentInput,

package/corpus/core/src/client/review/index.ts

@@ -9,14 +9,19 @@ export {
   type ReviewThreadPanelProps,
 } from "./ReviewThreadPanel.js";
 export {
+  useConsumeReviewFeedback,
   useCreateReviewComment,
   useDeleteReviewComment,
   useReplyReviewComment,
   useResolveReviewThread,
   useReviewComments,
+  useReviewFeedback,
   useSetReviewStatus,
+  type ConsumeReviewFeedbackInput,
   type CreateReviewCommentInput,
   type DeleteReviewCommentInput,
+  type GetReviewFeedbackParams,
+  type GetReviewFeedbackResult,
   type ListReviewCommentsParams,
   type ListReviewCommentsResult,
   type ReplyReviewCommentInput,

package/corpus/core/src/client/review/use-review.ts

@@ -22,6 +22,17 @@ export interface ListReviewCommentsResult {
   reviewStatus: ReviewStatusEntry | null;
 }
 
+export interface GetReviewFeedbackParams {
+  resourceType: string;
+  resourceId: string;
+  includeHumanTargeted?: boolean;
+  limit?: number;
+}
+
+export interface GetReviewFeedbackResult {
+  comments: ReviewComment[];
+}
+
 export interface CreateReviewCommentInput {
   resourceType: string;
   resourceId: string;
@@ -59,6 +70,12 @@ export interface DeleteReviewCommentInput {
   commentId: string;
 }
 
+export interface ConsumeReviewFeedbackInput {
+  resourceType: string;
+  resourceId: string;
+  commentIds: string[];
+}
+
 export interface SetReviewStatusInput {
   resourceType: string;
   resourceId: string;
@@ -81,6 +98,20 @@ export function useReviewComments(
   );
 }
 
+export function useReviewFeedback(
+  params: GetReviewFeedbackParams,
+  options?: { enabled?: boolean },
+) {
+  return useActionQuery<GetReviewFeedbackResult>(
+    "get-review-feedback",
+    params,
+    {
+      enabled:
+        options?.enabled ?? Boolean(params.resourceType && params.resourceId),
+    },
+  );
+}
+
 export function useCreateReviewComment() {
   return useActionMutation<ReviewComment, CreateReviewCommentInput>(
     "create-review-comment",
@@ -95,18 +126,25 @@ export function useReplyReviewComment() {
 
 export function useResolveReviewThread() {
   return useActionMutation<
-    { threadId: string; resolved: true },
+    { threadId: string; resolved: true; updatedCount: number },
     ResolveReviewThreadInput
   >("resolve-review-thread");
 }
 
 export function useDeleteReviewComment() {
   return useActionMutation<
-    { commentId: string; deleted: true },
+    { commentId: string; deleted: true; updatedCount: number },
     DeleteReviewCommentInput
   >("delete-review-comment");
 }
 
+export function useConsumeReviewFeedback() {
+  return useActionMutation<
+    { consumedCommentIds: string[]; updatedCount: number },
+    ConsumeReviewFeedbackInput
+  >("consume-review-feedback");
+}
+
 export function useSetReviewStatus() {
   return useActionMutation<ReviewStatusEntry, SetReviewStatusInput>(
     "set-review-status",

package/corpus/core/src/client/use-run-stuck-detection.ts

@@ -26,7 +26,7 @@ export interface RunStuckState {
   heartbeatAt: number | null;
   /** Milliseconds since `heartbeatAt`, computed against the server clock. */
   heartbeatSinceMs: number | null;
-  /** How the run was dispatched, e.g. foreground or background-processing. */
+  /** How the run was dispatched/continued, e.g. foreground-self-chain or background-processing. */
   dispatchMode: string | null;
 }
 
@@ -133,10 +133,13 @@ export function useRunStuckDetection({
             heartbeatAt != null ? nowMs - heartbeatAt : null;
           const dispatchMode =
             typeof data.dispatchMode === "string" ? data.dispatchMode : null;
-          // Background-dispatched runs get the wider threshold: the server's
-          // own recovery (150s no-progress backstop + chained continuations)
-          // must get its chance before the user sees a "stuck" affordance.
-          const effectiveThresholdMs = dispatchMode?.startsWith("background")
+          // Server-continued runs get the wider threshold: the server's own
+          // recovery (150s no-progress backstop + chained continuations) must
+          // get its chance before the user sees a "stuck" affordance.
+          const serverContinued =
+            dispatchMode === "foreground-self-chain" ||
+            dispatchMode?.startsWith("background") === true;
+          const effectiveThresholdMs = serverContinued
             ? backgroundStuckThresholdMs
             : stuckThresholdMs;
           const isStuck = Boolean(

package/corpus/core/src/history/actions/create-resource-version.ts

@@ -30,15 +30,18 @@ export default defineAction({
       "editor",
     );
     const registration = getVersionedResource(args.resourceType);
+    // Prefer the registered server snapshot when available so editors/agents
+    // cannot plant arbitrary restore payloads for managed resource types.
+    const serverSnapshot = registration?.getSnapshot
+      ? await registration.getSnapshot({
+          resourceType: args.resourceType,
+          resourceId: args.resourceId,
+          ctx: actionCtx,
+          access,
+        })
+      : undefined;
     const snapshot =
-      args.snapshot !== undefined
-        ? args.snapshot
-        : await registration?.getSnapshot?.({
-            resourceType: args.resourceType,
-            resourceId: args.resourceId,
-            ctx: actionCtx,
-            access,
-          });
+      serverSnapshot !== undefined ? serverSnapshot : args.snapshot;
 
     if (snapshot === undefined) {
       throw new Error(

package/corpus/core/src/history/index.ts

@@ -22,6 +22,5 @@ export {
   ensureResourceVersionsTable,
   getResourceVersionById,
   getResourceVersionByNumber,
-  insertResourceVersion,
   queryResourceVersions,
 } from "./store.js";

package/corpus/core/src/history/registry.ts

@@ -1,4 +1,8 @@
-import { ForbiddenError, resolveAccess } from "../sharing/access.js";
+import {
+  ForbiddenError,
+  resolveAccess,
+  type AccessContext,
+} from "../sharing/access.js";
 import { getShareableResource } from "../sharing/registry.js";
 import { roleSatisfies, type Visibility } from "../sharing/schema.js";
 import type {
@@ -31,6 +35,16 @@ export function listVersionedResources(): VersionedResourceRegistration[] {
   return Array.from(registrations.values());
 }
 
+function accessContextFrom(
+  ctx?: VersionedResourceContext,
+): AccessContext | undefined {
+  if (!ctx) return undefined;
+  return {
+    userEmail: ctx.userEmail ?? undefined,
+    orgId: ctx.orgId ?? undefined,
+  };
+}
+
 export async function resolveVersionedResourceAccess(
   resourceType: string,
   resourceId: string,
@@ -42,7 +56,11 @@ export async function resolveVersionedResourceAccess(
   }
 
   if (getShareableResource(resourceType)) {
-    const access = await resolveAccess(resourceType, resourceId);
+    const access = await resolveAccess(
+      resourceType,
+      resourceId,
+      accessContextFrom(ctx),
+    );
     if (!access) {
       return null;
     }
@@ -55,16 +73,10 @@ export async function resolveVersionedResourceAccess(
     };
   }
 
-  const userEmail = ctx?.userEmail ?? null;
-  if (!userEmail) {
-    return null;
-  }
-  return {
-    role: "owner",
-    ownerEmail: userEmail,
-    orgId: ctx?.orgId ?? null,
-    visibility: "private",
-  };
+  // Fail closed: unregistered types, and registered types without an access
+  // resolver that aren't shareable, never invent ownership. bypassScope on
+  // history queries is only safe after a real resource ACL.
+  return null;
 }
 
 export async function assertVersionedResourceAccess(