@agent-native/core 0.90.11 → 0.91.0

package/dist/server/agent-chat-plugin.js

@@ -11,12 +11,12 @@ import { AGENT_CHAT_BACKGROUND_RUN_FIELD, AGENT_CHAT_PROCESS_RUN_PATH, backgroun
 import { resolveEngine, createAnthropicEngine, getStoredModelForEngine, normalizeModelForEngine, getAgentEngineEntry, isAgentEnginePackageInstalled, isStoredEngineUsableForRequest, listAgentEngines, registerBuiltinEngines, } from "../agent/engine/index.js";
 import { createProductionAgentHandler, actionsToEngineTools, getActiveRunForThreadAsync, abortRun, subscribeToRun, } from "../agent/production-agent.js";
 import { runAgentLoopDirectWithSoftTimeout } from "../agent/run-loop-with-resume.js";
-import { callerOwnsRun, callerOwnsThread } from "../agent/run-ownership.js";
+import { callerHasRunAccess, callerHasThreadAccess, } from "../agent/run-ownership.js";
 import { CLAIMED_BACKGROUND_WORKER_FAILED_ERROR_EVENT, ensureTerminalRunEvent, readBackgroundRunClaim, recordRunDiagnostic, RUN_DIAG_STAGE, setRunError, setRunTerminalReason, updateRunStatusIfRunning, } from "../agent/run-store.js";
 import { buildCurrentTimeUserContext, buildRuntimeContextPrompt, } from "../agent/runtime-context.js";
 import { buildAssistantMessage, buildUserMessage, extractThreadMeta, foldAssistantTurn, mergeThreadDataForClientSave, normalizeThreadRepository, upsertUserMessage, } from "../agent/thread-data-builder.js";
 import { attachToolSearch } from "../agent/tool-search.js";
-import { createThread, forkThread, getThread, listThreads, searchThreads, renameThread, createThreadShareLink, getThreadByShareToken, getThreadShareState, revokeThreadShareLink, setThreadArchived, setThreadPinned, setThreadScope, updateThreadData, withThreadDataLock, deleteThread, setThreadQueuedMessages, } from "../chat-threads/store.js";
+import { createThread, forkThread, getThread, registerChatThreadsShareable, resolveThreadAccess, listThreads, searchThreads, renameThread, createThreadShareLink, getThreadByShareToken, getThreadShareState, revokeThreadShareLink, setThreadArchived, setThreadPinned, setThreadScope, updateThreadData, withThreadDataLock, deleteThread, setThreadQueuedMessages, } from "../chat-threads/store.js";
 import { dataWidgetResultSchema } from "../data-widgets/index.js";
 import { createDbAdminAgentTools } from "../db-admin/agent-tools.js";
 import { verifyInternalToken, extractBearerToken, } from "../integrations/internal-token.js";
@@ -1471,8 +1471,10 @@ async function createChatScriptEntries() {
                         const owner = getRequestRunContext()?.owner ?? getRequestUserEmail() ?? "";
                         if (!owner)
                             return "No authenticated user is available.";
-                        const thread = await getThread(id);
-                        if (!thread || thread.ownerEmail !== owner) {
+                        const thread = await resolveThreadAccess(owner, id, "editor", {
+                            orgId: getRequestOrgId(),
+                        });
+                        if (!thread) {
                             return `Chat thread "${id}" not found.`;
                         }
                         const title = thread.title || thread.preview || "(untitled)";
@@ -1482,24 +1484,18 @@ async function createChatScriptEntries() {
                                 : "";
                             if (!nextTitle)
                                 return "Missing required title.";
-                            const renamed = await renameThread(id, nextTitle, {
-                                ownerEmail: owner,
-                            });
+                            const renamed = await renameThread(id, nextTitle);
                             if (!renamed)
                                 return `Chat thread "${id}" could not be renamed.`;
                             return `Renamed chat "${title}" to "${nextTitle}".`;
                         }
                         if (args.action === "archive") {
-                            const archived = await setThreadArchived(id, true, {
-                                ownerEmail: owner,
-                            });
+                            const archived = await setThreadArchived(id, true);
                             if (!archived)
                                 return `Chat thread "${id}" could not be archived.`;
                             return `Archived chat: ${title}`;
                         }
-                        const pinned = await setThreadPinned(id, args.action === "pin", {
-                            ownerEmail: owner,
-                        });
+                        const pinned = await setThreadPinned(id, args.action === "pin");
                         if (!pinned)
                             return `Chat thread "${id}" could not be updated.`;
                         return `${args.action === "pin" ? "Pinned" : "Unpinned"} chat: ${title}`;
@@ -3994,6 +3990,14 @@ export function createAgentChatPlugin(options) {
             const getUserNameFromEvent = async (event) => {
                 return (await resolveOwnerContext(event)).name;
             };
+            const getOrgIdFromEvent = async (event) => {
+                if (options?.resolveOrgId) {
+                    return (await options.resolveOrgId(event)) ?? undefined;
+                }
+                const session = await getSession(event).catch(() => null);
+                return session?.orgId ?? undefined;
+            };
+            registerChatThreadsShareable();
             // Auto-mount template actions as HTTP endpoints under /_agent-native/actions/
             // Include engine management script so the UI can call manage-agent-engine.
             // HTTP/frontend surface keeps the full `*All` sets so actions with
@@ -4058,13 +4062,6 @@ export function createAgentChatPlugin(options) {
                         if (!thread) {
                             throw new Error(`Agent chat thread ${threadId} was not found while saving run ${run.runId}.`);
                         }
-                        const runOwner = getRequestRunContext()?.owner ?? getRequestUserEmail();
-                        if (runOwner && thread.ownerEmail !== runOwner) {
-                            throw createError({
-                                statusCode: 404,
-                                statusMessage: "Thread not found",
-                            });
-                        }
                         const assistantMsg = buildAssistantMessage(run.events ?? [], run.runId, {
                             suppressInternalContinuation: true,
                             turnId: typeof run.turnId === "string" && run.turnId
@@ -4232,7 +4229,14 @@ export function createAgentChatPlugin(options) {
                             thread = await getThread(threadId);
                         }
                     }
-                    if (!thread || thread.ownerEmail !== ownerEmail) {
+                    if (!thread) {
+                        throw createError({
+                            statusCode: 404,
+                            statusMessage: "Thread not found",
+                        });
+                    }
+                    const access = await resolveThreadAccess(ownerEmail, threadId, "editor", { orgId: getRequestOrgId() });
+                    if (!access) {
                         throw createError({
                             statusCode: 404,
                             statusMessage: "Thread not found",
@@ -4555,6 +4559,18 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     if (runCtxForPrepare && details.threadId) {
                         runCtxForPrepare._requestThreadId = details.threadId;
                     }
+                    if (details.threadId && details.ownerEmail) {
+                        const existingThread = await getThread(details.threadId);
+                        if (existingThread) {
+                            const access = await resolveThreadAccess(details.ownerEmail, details.threadId, "editor", { orgId: await getOrgIdFromEvent(details.event) });
+                            if (!access) {
+                                throw createError({
+                                    statusCode: 404,
+                                    statusMessage: "Thread not found",
+                                });
+                            }
+                        }
+                    }
                     // Drain any parent-completion injections queued by finished sub-agents
                     // and prepend them to the user message so the orchestrator sees results
                     // at the start of this turn rather than only after a manual poll.
@@ -4750,7 +4766,25 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     runNoProgressTimeoutMs: options?.runNoProgressTimeoutMs,
                     durableBackgroundRuns: options?.durableBackgroundRuns,
                     finalResponseGuard: options?.finalResponseGuard,
-                    prepareRequest: options?.prepareRequest,
+                    prepareRequest: async (details) => {
+                        const runCtxForPrepare = ensureRequestRunContext();
+                        if (runCtxForPrepare && details.threadId) {
+                            runCtxForPrepare._requestThreadId = details.threadId;
+                        }
+                        if (details.threadId && details.ownerEmail) {
+                            const existingThread = await getThread(details.threadId);
+                            if (existingThread) {
+                                const access = await resolveThreadAccess(details.ownerEmail, details.threadId, "editor", { orgId: await getOrgIdFromEvent(details.event) });
+                                if (!access) {
+                                    throw createError({
+                                        statusCode: 404,
+                                        statusMessage: "Thread not found",
+                                    });
+                                }
+                            }
+                        }
+                        return options?.prepareRequest?.(details);
+                    },
                     skipFilesContext,
                     initialToolNames: options?.initialToolNames,
                     ...(options?.toolLimits ? { toolLimits: options.toolLimits } : {}),
@@ -5627,17 +5661,15 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                 const owner = await getOwnerFromEvent(event);
                 const method = getMethod(event);
                 const url = event.node?.req?.url || event.path || "";
-                // Authorization: a run's events/abort and a thread's active-run
-                // status must only be exposed to the user who OWNS the thread.
+                const orgId = await getOrgIdFromEvent(event);
+                // Authorization: a run's events and a thread's active-run status are
+                // visible to anyone with viewer+ access to the thread. Mutating run
+                // controls require editor+ access.
                 // agent_runs carries no owner column — ownership lives on the
-                // chat_threads row via thread_id. callerOwnsRun/callerOwnsThread
-                // (agent/run-ownership.ts) resolve the run's thread (in-memory first,
-                // SQL fallback) and compare its ownerEmail. Without this, any
-                // authenticated tenant who learns another tenant's runId/threadId
-                // could stream their live agent turn (assistant text + tool-result
-                // payloads) or abort their run.
-                const ownsThread = (threadId) => callerOwnsThread(owner, threadId);
-                const ownsRun = (runId) => callerOwnsRun(owner, runId);
+                // chat_threads row via thread_id.
+                const canViewThread = (threadId) => callerHasThreadAccess(owner, threadId, "viewer", { orgId });
+                const canViewRun = (runId) => callerHasRunAccess(owner, runId, "viewer", { orgId });
+                const canEditRun = (runId) => callerHasRunAccess(owner, runId, "editor", { orgId });
                 // Route: GET /runs/list?goalId=agent-team|agent-harness
                 // Returns background agents in the Code hub-compatible run shape.
                 const listMatch = url.match(/\/runs\/list(?:[/?]|$)/) ||
@@ -5690,8 +5722,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     url.match(/^\/([^/?]+)\/abort/);
                 if (abortMatch && method === "POST") {
                     const runId = decodeURIComponent(abortMatch[1]);
-                    if (!(await ownsRun(runId))) {
-                        // 404 (not 403) so run existence isn't leaked to non-owners.
+                    if (!(await canEditRun(runId))) {
+                        // 404 (not 403) so run existence isn't leaked to unauthorized users.
                         setResponseStatus(event, 404);
                         return { error: "Run not found" };
                     }
@@ -5738,8 +5770,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     url.match(/^\/([^/?]+)\/events/);
                 if (eventsMatch && method === "GET") {
                     const runId = decodeURIComponent(eventsMatch[1]);
-                    if (!(await ownsRun(runId))) {
-                        // 404 (not 403) so run existence isn't leaked to non-owners.
+                    if (!(await canViewRun(runId))) {
+                        // 404 (not 403) so run existence isn't leaked to unauthorized users.
                         setResponseStatus(event, 404);
                         return { error: "Run not found" };
                     }
@@ -5765,11 +5797,11 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         setResponseStatus(event, 400);
                         return { error: "threadId query parameter is required" };
                     }
-                    // Only reveal a thread's active run to the thread's owner.
-                    // Present non-owners (or unknown threads) as idle rather than
-                    // 404 so thread existence isn't leaked and the client polls
-                    // benignly.
-                    if (!(await ownsThread(threadId))) {
+                    // Only reveal a thread's active run to viewers/editors of the
+                    // thread. Present unauthorized users (or unknown threads) as idle
+                    // rather than 404 so thread existence isn't leaked and the client
+                    // polls benignly.
+                    if (!(await canViewThread(threadId))) {
                         return {
                             active: false,
                             threadId,
@@ -6001,14 +6033,15 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
             const buildShareUrl = (event, token) => `${getOrigin(event)}${routePath}/shared/${encodeURIComponent(token)}`;
             getH3App(nitroApp).use(`${routePath}/threads`, defineEventHandler(async (event) => {
                 const owner = await getOwnerFromEvent(event);
+                const orgId = await getOrgIdFromEvent(event);
                 const method = getMethod(event);
                 const { threadId, tail: threadTail } = parseThreadRoute(event);
                 const isThreadSubroute = (subroute) => threadTail[0] === subroute;
                 // ── Specific thread: GET/PUT/DELETE /threads/:id ──
                 if (threadId) {
                     if (method === "GET") {
-                        const thread = await getThread(threadId);
-                        if (!thread || thread.ownerEmail !== owner) {
+                        const thread = await resolveThreadAccess(owner, threadId, "viewer", { orgId });
+                        if (!thread) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
                         }
@@ -6022,8 +6055,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         // run could clobber the assistant message the server just
                         // appended (and vice versa).
                         return await withThreadDataLock(threadId, async () => {
-                            const thread = await getThread(threadId);
-                            if (!thread || thread.ownerEmail !== owner) {
+                            const thread = await resolveThreadAccess(owner, threadId, "editor", { orgId });
+                            if (!thread) {
                                 setResponseStatus(event, 404);
                                 return { error: "Thread not found" };
                             }
@@ -6089,16 +6122,16 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     // queued messages durable across reloads without piggybacking
                     // on full-thread saves.
                     if (method === "POST" && isThreadSubroute("queued")) {
+                        const thread = await resolveThreadAccess(owner, threadId, "editor", { orgId });
+                        if (!thread) {
+                            setResponseStatus(event, 404);
+                            return { error: "Thread not found" };
+                        }
                         const body = await readBody(event);
                         const queued = Array.isArray(body?.queuedMessages)
                             ? body.queuedMessages
                             : [];
-                        // Ownership is checked inside setThreadQueuedMessages (under
-                        // the thread-data lock) — no separate getThread pre-read on
-                        // this debounced hot path.
-                        const saved = await setThreadQueuedMessages(threadId, queued, {
-                            ownerEmail: owner,
-                        });
+                        const saved = await setThreadQueuedMessages(threadId, queued);
                         if (!saved) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
@@ -6106,8 +6139,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         return { ok: true };
                     }
                     if (method === "POST" && isThreadSubroute("rename")) {
-                        const thread = await getThread(threadId);
-                        if (!thread || thread.ownerEmail !== owner) {
+                        const thread = await resolveThreadAccess(owner, threadId, "editor", { orgId });
+                        if (!thread) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
                         }
@@ -6119,9 +6152,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                             setResponseStatus(event, 400);
                             return { error: "Title is required" };
                         }
-                        const renamed = await renameThread(threadId, title, {
-                            ownerEmail: owner,
-                        });
+                        const renamed = await renameThread(threadId, title);
                         if (!renamed) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
@@ -6129,8 +6160,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         return { ok: true };
                     }
                     if (method === "POST" && isThreadSubroute("pin")) {
-                        const thread = await getThread(threadId);
-                        if (!thread || thread.ownerEmail !== owner) {
+                        const thread = await resolveThreadAccess(owner, threadId, "editor", { orgId });
+                        if (!thread) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
                         }
@@ -6139,9 +6170,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                             setResponseStatus(event, 400);
                             return { error: "pinned boolean is required" };
                         }
-                        const pinned = await setThreadPinned(threadId, body.pinned, {
-                            ownerEmail: owner,
-                        });
+                        const pinned = await setThreadPinned(threadId, body.pinned);
                         if (!pinned) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
@@ -6149,8 +6178,8 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         return { ok: true };
                     }
                     if (method === "POST" && isThreadSubroute("archive")) {
-                        const thread = await getThread(threadId);
-                        if (!thread || thread.ownerEmail !== owner) {
+                        const thread = await resolveThreadAccess(owner, threadId, "editor", { orgId });
+                        if (!thread) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
                         }
@@ -6159,7 +6188,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                             setResponseStatus(event, 400);
                             return { error: "archived boolean is required" };
                         }
-                        const archived = await setThreadArchived(threadId, body.archived, { ownerEmail: owner });
+                        const archived = await setThreadArchived(threadId, body.archived);
                         if (!archived) {
                             setResponseStatus(event, 404);
                             return { error: "Thread not found" };
@@ -6168,10 +6197,16 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     }
                     // POST /threads/:id/fork — duplicate a thread with all its messages
                     if (method === "POST" && isThreadSubroute("fork")) {
+                        const thread = await resolveThreadAccess(owner, threadId, "viewer", { orgId });
+                        if (!thread) {
+                            setResponseStatus(event, 404);
+                            return { error: "Thread not found" };
+                        }
                         const body = await readBody(event);
                         const forked = await forkThread(threadId, owner, {
                             id: body?.id,
                             source: parseForkSourceFromBody(body?.source),
+                            sourceAccessGranted: true,
                         });
                         if (!forked) {
                             setResponseStatus(event, 404);
@@ -6180,10 +6215,13 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         return forked;
                     }
                     if (isThreadSubroute("share")) {
+                        const thread = await resolveThreadAccess(owner, threadId, "admin", { orgId });
+                        if (!thread) {
+                            setResponseStatus(event, 404);
+                            return { error: "Thread not found" };
+                        }
                         if (method === "GET") {
-                            const state = await getThreadShareState(threadId, {
-                                ownerEmail: owner,
-                            });
+                            const state = await getThreadShareState(threadId);
                             if (!state) {
                                 setResponseStatus(event, 404);
                                 return { error: "Thread not found" };
@@ -6191,9 +6229,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                             return { share: state };
                         }
                         if (method === "POST") {
-                            const link = await createThreadShareLink(threadId, {
-                                ownerEmail: owner,
-                            });
+                            const link = await createThreadShareLink(threadId);
                             if (!link) {
                                 setResponseStatus(event, 404);
                                 return { error: "Thread not found" };
@@ -6204,9 +6240,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                             };
                         }
                         if (method === "DELETE") {
-                            const state = await revokeThreadShareLink(threadId, {
-                                ownerEmail: owner,
-                            });
+                            const state = await revokeThreadShareLink(threadId);
                             if (!state) {
                                 setResponseStatus(event, 404);
                                 return { error: "Thread not found" };
@@ -6236,6 +6270,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                     if (q) {
                         const threads = await searchThreads(owner, q, limit, {
                             scope: scope ?? undefined,
+                            orgId,
                         });
                         return { threads };
                     }
@@ -6245,6 +6280,7 @@ Non-code requests are still fine on this surface: read data, navigate the UI, su
                         offset,
                         scope: scope ?? undefined,
                         unscopedOnly,
+                        orgId,
                     });
                     return { threads };
                 }