@agent-native/core 0.222.0-nightly-20261029004912 → 0.222.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/agent/production-agent.js +22 -9
- package/dist/agent/run-store.d.ts +9 -1
- package/dist/agent/run-store.js +26 -3
- package/dist/cli/code-agent-mcp-config.js +6 -1
- package/dist/client/chat/agentkit-agent-native.js +1 -2
- package/dist/client/chat/agentkit-protocol.js +14 -0
- package/dist/client/chat/runtime.d.ts +5 -1
- package/dist/client/chat/runtime.js +23 -1
- package/dist/client/sse-event-processor.d.ts +10 -0
- package/dist/client/sse-event-processor.js +1 -1
- package/dist/collab/routes.d.ts +1 -1
- package/dist/collab/struct-routes.d.ts +1 -1
- package/dist/connections/catalog.d.ts +1 -1
- package/dist/connections/catalog.js +4 -11
- package/dist/mcp-client/config.d.ts +6 -0
- package/dist/mcp-client/manager.js +25 -2
- package/dist/mcp-client/routes.js +2 -0
- package/dist/mcp-client/workspace-connection-servers.d.ts +30 -0
- package/dist/mcp-client/workspace-connection-servers.js +119 -0
- package/dist/notifications/routes.d.ts +3 -3
- package/dist/provider-api/actions/custom-provider-registration.d.ts +8 -8
- package/dist/provider-api/actions/provider-api.d.ts +4 -4
- package/dist/provider-api/actions/provider-api.js +2 -0
- package/dist/provider-api/agent-request-policy.d.ts +13 -0
- package/dist/provider-api/agent-request-policy.js +31 -0
- package/dist/provider-api/corpus-jobs.d.ts +2 -2
- package/dist/provider-api/corpus-jobs.js +7 -1
- package/dist/provider-api/index.d.ts +4 -1
- package/dist/provider-api/index.js +4 -1
- package/dist/provider-api/read-only-requests.js +11 -2
- package/dist/resources/handlers.d.ts +1 -1
- package/dist/secrets/routes.d.ts +4 -4
- package/dist/server/action-discovery.js +6 -0
- package/dist/server/agent-chat/process-run-failure.js +58 -2
- package/dist/server/agent-engine-api-key-route.d.ts +3 -3
- package/dist/server/workspace-provider-oauth.d.ts +1 -0
- package/dist/server/workspace-provider-oauth.js +10 -2
- package/dist/templates/chat/.agents/skills/actions/references/provider-apis.md +13 -0
- package/dist/templates/default/.agents/skills/actions/references/provider-apis.md +13 -0
- package/dist/templates/factory/.agents/skills/review-latest-feedback/SKILL.md +10 -4
- package/dist/templates/factory/.agents/skills/review-latest-feedback/references/slack-reaction-replies.md +287 -0
- package/dist/templates/factory/.agents/skills/review-prs/SKILL.md +266 -92
- package/dist/templates/headless/.agents/skills/actions/references/provider-apis.md +13 -0
- package/dist/templates/workspace-core/.agents/skills/actions/references/provider-apis.md +13 -0
- package/dist/vite/action-types-plugin.js +4 -0
- package/dist/workspace-connections/actions/list-workspace-connection-scopes.d.ts +16 -0
- package/dist/workspace-connections/actions/list-workspace-connection-scopes.js +62 -0
- package/package.json +5 -4
- package/src/templates/chat/.agents/skills/actions/references/provider-apis.md +13 -0
- package/src/templates/default/.agents/skills/actions/references/provider-apis.md +13 -0
- package/src/templates/factory/.agents/skills/review-latest-feedback/SKILL.md +10 -4
- package/src/templates/factory/.agents/skills/review-latest-feedback/references/slack-reaction-replies.md +287 -0
- package/src/templates/factory/.agents/skills/review-prs/SKILL.md +266 -92
- package/src/templates/headless/.agents/skills/actions/references/provider-apis.md +13 -0
- package/src/templates/workspace-core/.agents/skills/actions/references/provider-apis.md +13 -0
|
@@ -2,10 +2,11 @@
|
|
|
2
2
|
name: review-prs
|
|
3
3
|
description: >-
|
|
4
4
|
Review recent BuilderIO/agent-native human pull requests, approve eligible
|
|
5
|
-
internal PRs, and
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
5
|
+
internal PRs, and identify PRs ready for Steve's final maintainer decision.
|
|
6
|
+
Outside Factory governance, merge only when Steve explicitly requests it for
|
|
7
|
+
that PR. Factory governance is approval-only. Use for scheduled or manual PR
|
|
8
|
+
sweeps; flag external work needing a major product call or new framework API,
|
|
9
|
+
and unresolved major product or UX decisions, to Steve.
|
|
9
10
|
user-invocable: true
|
|
10
11
|
scope: dev
|
|
11
12
|
metadata:
|
|
@@ -15,18 +16,28 @@ metadata:
|
|
|
15
16
|
# Review Pull Requests
|
|
16
17
|
|
|
17
18
|
Review the newest relevant human pull requests in `BuilderIO/agent-native`.
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
19
|
+
Under the default internal-author policy below, approve eligible fixes from
|
|
20
|
+
verified BuilderIO organization members. Never submit an approval review for an
|
|
21
|
+
external or unverified author; `community-prs` assigns that code-review
|
|
22
|
+
decision to a human Builder dev. When Steve explicitly gives the manual blanket
|
|
23
|
+
instruction for a non-Factory review sweep defined below, follow it over
|
|
24
|
+
ordinary approval gates; the non-waivable safeguards still apply.
|
|
25
|
+
|
|
26
|
+
Approval and merge readiness are separate. **Ready for your final approval**
|
|
27
|
+
means implementation is complete, required checks have passed, and any required
|
|
28
|
+
product or UX decision is complete. It identifies a candidate for Steve's
|
|
29
|
+
final decision; readiness alone does not authorize a merge. Factory governance
|
|
30
|
+
never performs or invokes a merge: only the
|
|
31
|
+
designated Factory workflow may merge a Builder PR after its merge gate. Outside
|
|
32
|
+
Factory governance, merge only when Steve explicitly requests the merge for that
|
|
33
|
+
PR, using the applicable merge path below. Factory governance records a manual
|
|
34
|
+
disposition for confirmed external authors through its action and never
|
|
35
|
+
approves them. Every invocation stands down on a fork PR assigned to a
|
|
36
|
+
verified BuilderIO member, as required by `community-prs`. Other invocations
|
|
37
|
+
apply the external-contribution gate below; external authors are never eligible
|
|
38
|
+
for an approval review. Surface external work that needs a major product call
|
|
39
|
+
or a new framework API for Steve's explicit approval before a full review or
|
|
40
|
+
merge; a scheduled or manual sweep is not that approval.
|
|
30
41
|
|
|
31
42
|
## Selection and evidence
|
|
32
43
|
|
|
@@ -50,16 +61,21 @@ author and draft state:
|
|
|
50
61
|
them to the end-of-run recap.
|
|
51
62
|
|
|
52
63
|
- Verify each remaining human author's current BuilderIO membership using the
|
|
53
|
-
organization membership API below
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
the
|
|
62
|
-
|
|
64
|
+
organization membership API below before applying any existing-approval
|
|
65
|
+
filter. For a PR from a fork, check assignees before any other gate: if any
|
|
66
|
+
assignee is a verified current BuilderIO member, ignore the PR completely,
|
|
67
|
+
like a draft. That member owns it under `community-prs`. Take no review,
|
|
68
|
+
reply, action, or merge action, and leave it out of the recap. This exclusion
|
|
69
|
+
applies in Factory governance too.
|
|
70
|
+
|
|
71
|
+
- For every other confirmed external PR in Factory governance, call
|
|
72
|
+
`govern-factory-pull-request` so the action records a manual disposition,
|
|
73
|
+
even when the PR already has a current-head approval. Do not use the manual
|
|
74
|
+
external-scope or reply path for that PR, and never approve it. In other
|
|
75
|
+
invocations, apply the external-contribution scope gate before reading
|
|
76
|
+
review summaries or entering the evidence sweep. For PRs that continue,
|
|
77
|
+
determine whether any existing current-head approval is eligible to suppress
|
|
78
|
+
duplicate code review under the reviewer and newer-event rules below.
|
|
63
79
|
|
|
64
80
|
- Reuse that review as the code assessment only after verifying the reviewer
|
|
65
81
|
is a different, current BuilderIO member and is eligible under the PR's
|
|
@@ -71,9 +87,13 @@ author and draft state:
|
|
|
71
87
|
|
|
72
88
|
All non-draft human PRs that pass the author and external-scope gates enter the
|
|
73
89
|
evidence sweep below. For PRs with a verified eligible current-head approval and
|
|
74
|
-
no newer event, skip duplicate code review but check merge readiness
|
|
75
|
-
|
|
76
|
-
|
|
90
|
+
no newer event, skip duplicate code review but check merge readiness. Only a
|
|
91
|
+
manual, non-Factory invocation may merge, and only after Steve explicitly
|
|
92
|
+
requests it for that PR. Eligible Liam PRs with only older-head approvals enter
|
|
93
|
+
the sweep so the current head can be reviewed. The blanket approval instruction
|
|
94
|
+
may waive ordinary approval gates, but it does not
|
|
95
|
+
bypass the complete diff and safety review. It need not produce a readiness
|
|
96
|
+
disposition or a full-sweep recap.
|
|
77
97
|
|
|
78
98
|
For every PR you inspect, read:
|
|
79
99
|
|
|
@@ -105,6 +125,72 @@ infer membership from a display name, email, company claim, branch name,
|
|
|
105
125
|
verified, do not approve. External authors are never auto-approved, even when
|
|
106
126
|
the patch looks safe or the issue is obviously valid.
|
|
107
127
|
|
|
128
|
+
## Explicit blanket approval instruction
|
|
129
|
+
|
|
130
|
+
Identify the invocation before applying this override. A Factory governance run
|
|
131
|
+
is launched by the `factory-pr-governance` automation and includes the
|
|
132
|
+
server-injected `<!-- factory-skill-alignment:start -->` and
|
|
133
|
+
`<!-- factory-skill-alignment:end -->` markers in its active prompt. The
|
|
134
|
+
automation composes this block independently of its editable prompt text; do
|
|
135
|
+
not rely on a user-editable heading. A manual invocation is a direct Steve
|
|
136
|
+
request outside that automation. If the source or injected markers cannot be
|
|
137
|
+
verified, do not apply the override or submit an approval; report the invocation
|
|
138
|
+
context as unknown.
|
|
139
|
+
|
|
140
|
+
This override applies only to manual, non-Factory review invocations. Factory
|
|
141
|
+
governance follows its code-defined action gates; this skill's blanket
|
|
142
|
+
instruction cannot waive them.
|
|
143
|
+
|
|
144
|
+
In Factory governance, the manual blanket-approval override is unavailable,
|
|
145
|
+
even if equivalent wording appears in the run prompt. Never submit an approval
|
|
146
|
+
through `gh api`, `gh pr review`, GraphQL, or another direct GitHub review
|
|
147
|
+
mutation. Route every Factory approval decision through
|
|
148
|
+
`govern-factory-pull-request` and follow its result; only that action may submit
|
|
149
|
+
an approval, under its code-enforced gates.
|
|
150
|
+
|
|
151
|
+
Only an explicit instruction from Steve, given directly in the current request
|
|
152
|
+
or in the user-authorized prompt for this invocation, triggers this override.
|
|
153
|
+
It must expressly request approval of every currently open, non-draft PR by
|
|
154
|
+
verified current BuilderIO human members in `BuilderIO/agent-native`; “Approve
|
|
155
|
+
all BuilderIO member PRs” is one such instruction. Requests to review, inspect,
|
|
156
|
+
list, or identify ready PRs do not trigger it. If the requested repository,
|
|
157
|
+
approval action, or author/status scope differs or is ambiguous, apply the
|
|
158
|
+
normal gates rather than expanding the instruction. Exclude all bot-authored
|
|
159
|
+
PRs and the exact login `steve8708`. This direct instruction overrides ordinary
|
|
160
|
+
approval gates, including check, review-feedback, UX-owner, and narrower
|
|
161
|
+
author-specific gates.
|
|
162
|
+
It does not waive membership verification, the external-author prohibition,
|
|
163
|
+
the ultra-scary safety gate, or the independent-review requirement for PRs
|
|
164
|
+
changing review or approval policy, agent-safety instructions, membership
|
|
165
|
+
verification, or CI/deployment security controls. Active credible safety
|
|
166
|
+
findings remain approval-blocking. If a non-waivable gate applies, do not
|
|
167
|
+
approve that PR; report the exact gate.
|
|
168
|
+
|
|
169
|
+
Before approving, inspect the complete changed-file list and diff, current
|
|
170
|
+
review findings, and current check results needed to identify non-waivable
|
|
171
|
+
safety concerns. The approval can serve as code-review evidence in a later
|
|
172
|
+
readiness pass only because this path requires that full diff review; it remains
|
|
173
|
+
reusable only under the reviewer eligibility, current-head, and no-newer-event
|
|
174
|
+
rules above. It cannot satisfy a required independent-review gate: when that
|
|
175
|
+
gate applies, require a separate, non-dismissed, current-head `APPROVED` review
|
|
176
|
+
from a verified current BuilderIO member other than the blanket approver. Do
|
|
177
|
+
not count or reuse the blanket approval as independent-review evidence. Do not
|
|
178
|
+
infer a code assessment from the blanket instruction alone.
|
|
179
|
+
|
|
180
|
+
For each eligible PR, record the head whose complete diff was reviewed. Re-read
|
|
181
|
+
the live head immediately before acting. If it changed during or after review,
|
|
182
|
+
restart the complete diff and safety review against the new head; do not approve
|
|
183
|
+
until that review is complete. Submit at most one approval for the reviewed
|
|
184
|
+
head, and do not duplicate an existing current-head approval. If membership or
|
|
185
|
+
the exact reviewed head cannot be verified, do not approve that PR and report
|
|
186
|
+
the specific verification failure. This instruction authorizes approvals only.
|
|
187
|
+
Do not merge from this path. Do not comment or reply unless Steve separately
|
|
188
|
+
asks; Factory governance still never merges or invokes a merge workflow. Keep
|
|
189
|
+
the recap concise, but report the exact check and actionable-feedback states
|
|
190
|
+
for each approval even when ordinary gates are overridden. Distinguish approval
|
|
191
|
+
from readiness and include any verification or non-waivable safety exceptions;
|
|
192
|
+
omit unrelated risk inventory unless Steve asks for it.
|
|
193
|
+
|
|
108
194
|
## External-contribution scope gate
|
|
109
195
|
|
|
110
196
|
Builder devs decide bounded outside contributions; Steve keeps major product
|
|
@@ -255,6 +341,9 @@ needs an explicit ultra-scary assessment before approval.
|
|
|
255
341
|
|
|
256
342
|
## Standard approval gate
|
|
257
343
|
|
|
344
|
+
This is the default gate; the explicit blanket approval instruction above takes
|
|
345
|
+
precedence when invoked.
|
|
346
|
+
|
|
258
347
|
For verified internal authors who do not qualify for a verified owner or docs
|
|
259
348
|
exception, approve only when all of the following are true after applying the
|
|
260
349
|
internal-author policy:
|
|
@@ -270,7 +359,8 @@ internal-author policy:
|
|
|
270
359
|
change.
|
|
271
360
|
4. The scope and affected behavior are understood. Escalate unresolved major
|
|
272
361
|
product or UX decisions as described below. Owner exceptions govern whether
|
|
273
|
-
to submit an approval review; they do not
|
|
362
|
+
to submit an approval review; they do not create an additional owner-approval
|
|
363
|
+
requirement for code readiness.
|
|
274
364
|
|
|
275
365
|
Do not approve external authors, unverified authors, or internal PRs whose
|
|
276
366
|
remaining concern is ultra-scary. A clean-looking diff is not enough when the
|
|
@@ -283,18 +373,19 @@ includes visible copy, layout, navigation, controls, settings, interaction,
|
|
|
283
373
|
loading states, accessibility behavior, and user-facing defaults. A major
|
|
284
374
|
decision changes a core workflow, navigation or information architecture,
|
|
285
375
|
product defaults or permissions, or behavior across apps. If that decision is
|
|
286
|
-
not already settled by Steve's written direction,
|
|
287
|
-
|
|
288
|
-
established workflow is not
|
|
376
|
+
not already settled by Steve's written direction, classify it as **Needs Steve's
|
|
377
|
+
product/UX decision** and do not enter the manual merge path until he decides.
|
|
378
|
+
A routine bug fix or bounded improvement within an established workflow is not
|
|
379
|
+
a major decision.
|
|
289
380
|
|
|
290
|
-
Keep the PR thread silent while a product
|
|
381
|
+
Keep the PR thread silent while a required product or UX decision is
|
|
291
382
|
unresolved. Do not comment or reply to request, announce, or explain that the
|
|
292
383
|
decision is needed; record the gate only in the recap. This remains true after
|
|
293
384
|
an author update, so do not send a thanks-only or status-only reply while the
|
|
294
385
|
decision is pending.
|
|
295
386
|
|
|
296
387
|
The app-owner map is for approval exceptions only; an owner approval is not a
|
|
297
|
-
|
|
388
|
+
separate code-readiness requirement:
|
|
298
389
|
|
|
299
390
|
- Alice (`3mdistal`) - Content
|
|
300
391
|
- Shomix (`shomix`) - Clips
|
|
@@ -309,27 +400,68 @@ the major product/UX decision above.
|
|
|
309
400
|
|
|
310
401
|
## Review actions
|
|
311
402
|
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
318
|
-
|
|
403
|
+
Factory governance submits approvals only through
|
|
404
|
+
`govern-factory-pull-request`, which claims and reconciles the decision and
|
|
405
|
+
revalidates evidence. Never call GitHub write endpoints directly from Factory
|
|
406
|
+
governance. If the invocation context is unknown, do not submit an approval.
|
|
407
|
+
|
|
408
|
+
The following approval procedure is for manual, non-Factory invocations only;
|
|
409
|
+
Factory governance must not use or adapt it. If a PR passes the applicable gate
|
|
410
|
+
and lacks a current-head approval, submit one GitHub approval review pinned to
|
|
411
|
+
the exact SHA whose complete diff you reviewed, and record the approval URL in
|
|
412
|
+
the recap. The review creation request must set `event=APPROVE` and
|
|
413
|
+
`commit_id=$reviewed_head_sha`; do not omit the reviewed SHA or use a flow that
|
|
414
|
+
defaults to the latest head.
|
|
415
|
+
|
|
416
|
+
Read the response and require its `commit_id` to equal
|
|
417
|
+
`$reviewed_head_sha`. If the request fails, the returned SHA differs, or the
|
|
418
|
+
live head moved after review, do not count that review as current-head evidence;
|
|
419
|
+
review the new head completely before retrying with its SHA. Do not duplicate
|
|
420
|
+
an existing current-head approval. This skill reviews other people's PRs: do
|
|
421
|
+
not add a tag, assignment, mention, or explanatory comment unless the current
|
|
422
|
+
invocation explicitly authorizes that communication on the exact PR. This does
|
|
423
|
+
not add a separate authorization step for replies required on the active
|
|
424
|
+
user's own PR under `/ship`, `/ship-now`, or `/babysit-pr`.
|
|
425
|
+
|
|
426
|
+
When a PR needs product, UX, or app-owner review, record that gate only in the
|
|
427
|
+
recap and leave the PR thread alone. Do not comment or reply to ask for, announce,
|
|
428
|
+
or explain that owner review is needed. This silence rule applies even after an
|
|
429
|
+
author update; do not send a thanks-only or status reply while that review gate is
|
|
430
|
+
outstanding.
|
|
431
|
+
This silence rule does not suppress replies required on the active user's own PR
|
|
432
|
+
under `/ship`, `/ship-now`, or `/babysit-pr`; those follow the own-PR reply rules.
|
|
433
|
+
|
|
434
|
+
When a reply is needed to resolve a review thread on the exact PR the current
|
|
435
|
+
invocation authorizes, only a verified external author gets one. Confirm the author
|
|
436
|
+
is a nonmember first. An unknown-membership author gets no reply, and the membership
|
|
437
|
+
check goes in the recap. Verified BuilderIO members get no reply here. The active
|
|
438
|
+
user's own PR is the one exception: it gets the disposition only, with no thank-you.
|
|
439
|
+
For a verified external author, an explicit reply request sends the reply even
|
|
440
|
+
without an author update. Otherwise reply only if the author has updated since the
|
|
441
|
+
last message, and begin by thanking them for the PR or for their update. An explicit
|
|
442
|
+
request does not override the owner-review silence rule above, except on the active
|
|
443
|
+
user's own PR. Never write “I have no further feedback” or another vague closing;
|
|
444
|
+
state the disposition and the next actor and action, such as the exact change
|
|
445
|
+
requested, that no changes are requested and the PR is ready for maintainer
|
|
446
|
+
merge, or which named check is still pending. If the next step is a product,
|
|
447
|
+
UX, or app-owner decision, use the silence rule above.
|
|
319
448
|
|
|
320
449
|
Bot-authored PRs, including Dependabot, are outside this skill's review and
|
|
321
450
|
merge scope and must remain completely untouched.
|
|
322
451
|
|
|
323
|
-
For a PR that fails an approval gate
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
452
|
+
For a PR that fails an ordinary approval gate overridden by the explicit
|
|
453
|
+
blanket instruction, the approval may proceed only after the full diff and
|
|
454
|
+
safety review above. A non-waivable gate always blocks approval, even under the
|
|
455
|
+
blanket instruction; if one applies, do not submit an approval and flag the
|
|
456
|
+
exact concern and evidence needed to resolve it. External or unverified authors
|
|
457
|
+
never receive an approval review. Outside Factory governance, their PRs may
|
|
458
|
+
still be assessed for code readiness, but merging requires Steve's explicit
|
|
459
|
+
request for that PR and all readiness gates below. Confirmed external PRs must
|
|
460
|
+
also pass the external-contribution scope gate; external work that needs a
|
|
461
|
+
major product call or a new framework API remains stopped at Steve's approval
|
|
462
|
+
gate. For unknown membership, do not apply the external scope gate solely
|
|
463
|
+
because verification failed; preserve the no-approval outcome, assess readiness
|
|
464
|
+
under the existing unknown-membership policy, and name the missing check.
|
|
333
465
|
|
|
334
466
|
## Merge-ready disposition and handoff
|
|
335
467
|
|
|
@@ -341,28 +473,42 @@ external. Never draft a reply for a verified BuilderIO member, including a
|
|
|
341
473
|
thank-you; report requested updates in the recap instead. If membership is
|
|
342
474
|
unknown, do not treat the author as external or draft a reply.
|
|
343
475
|
|
|
344
|
-
Classify the PR as **Ready
|
|
345
|
-
**Needs Steve's product/UX decision**, or **Cannot assess**.
|
|
346
|
-
current head is sound,
|
|
347
|
-
|
|
348
|
-
|
|
476
|
+
Classify the PR as **Ready for your final approval**,
|
|
477
|
+
**Needs updates**, **Needs Steve's product/UX decision**, or **Cannot assess**.
|
|
478
|
+
Ready means the current head is sound, implementation is complete, every
|
|
479
|
+
required check and status context has passed, any required independent review
|
|
480
|
+
above is present on the current head, any required product or UX decision is
|
|
481
|
+
complete, and actionable human or automated findings have a verified fix or
|
|
482
|
+
evidence-backed terminal disposition. Steve retains the final decision. PRs
|
|
483
|
+
still waiting on a required check, independent review, or product/UX decision
|
|
484
|
+
are not ready.
|
|
349
485
|
An active human `CHANGES_REQUESTED` review or unresolved actionable request
|
|
350
486
|
blocks readiness; resolved, superseded, or non-actionable threads do not.
|
|
351
|
-
Missing approval or `reviewDecision: REVIEW_REQUIRED` alone
|
|
352
|
-
|
|
353
|
-
|
|
354
|
-
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
|
|
364
|
-
|
|
365
|
-
|
|
487
|
+
Missing approval or `reviewDecision: REVIEW_REQUIRED` alone does not make the
|
|
488
|
+
code **Needs updates**; it remains a pending human merge requirement and must be
|
|
489
|
+
reported separately from code readiness. Conflicts, pending or failed required
|
|
490
|
+
checks, active actionable bot findings, credible safety concerns, or a material
|
|
491
|
+
code issue mean **Needs updates** or **Cannot assess**. Report skipped, unknown,
|
|
492
|
+
and non-required checks accurately; never describe them as passing.
|
|
493
|
+
|
|
494
|
+
Independent-review requirements above govern approval actions, reuse of
|
|
495
|
+
existing approvals, code readiness, and merge. When they apply, the required
|
|
496
|
+
separate approval from a verified current BuilderIO member must be present on
|
|
497
|
+
the current head before the PR is ready or can merge. Steve's direct merge
|
|
498
|
+
request and a GitHub admin bypass do not replace that evidence. Factory
|
|
499
|
+
governance must follow its own merge gate and never use this skill's admin or
|
|
500
|
+
queue commands. If no eligible current-head approval supplies the existing
|
|
501
|
+
code assessment, inspect the complete diff and decide readiness from that
|
|
502
|
+
evidence.
|
|
503
|
+
|
|
504
|
+
A ready disposition is a private handoff for Steve's final decision, not an
|
|
505
|
+
instruction to merge. Do not merge based on readiness alone. The merge gate
|
|
506
|
+
and commands below apply only to manual, non-Factory execution after Steve
|
|
507
|
+
explicitly requests a merge for that PR. In Factory governance, stop before
|
|
508
|
+
this section's merge actions, report the current disposition, and leave merging
|
|
509
|
+
to the Factory workflow.
|
|
510
|
+
Once all the conditions hold, record the live `headRefOid`; they must remain
|
|
511
|
+
true for 10 consecutive minutes on that same head:
|
|
366
512
|
|
|
367
513
|
- every status context required by branch protection or an applicable
|
|
368
514
|
repository ruleset is satisfied on the recorded head according to GitHub's
|
|
@@ -376,10 +522,17 @@ for 10 consecutive minutes on that same head:
|
|
|
376
522
|
interval, and all checks and review dispositions apply to that head.
|
|
377
523
|
|
|
378
524
|
Reset the 10-minute gate after a push, failed check, new actionable feedback,
|
|
379
|
-
new commit, or merge conflict.
|
|
380
|
-
|
|
381
|
-
|
|
382
|
-
|
|
525
|
+
new commit, or merge conflict. Do not treat this skill or a ready disposition
|
|
526
|
+
as standing merge authorization. For an external or membership-unknown author,
|
|
527
|
+
never submit an approval review through this skill. The “Ready for maintainer
|
|
528
|
+
review” path in `community-prs` describes a human Builder dev's approval; it does not
|
|
529
|
+
authorize the agent to submit that approval. Follow its ordinary merge
|
|
530
|
+
requirements and leave the PR unmerged until a human has approved the reviewed
|
|
531
|
+
head and all required checks pass. Never use `--admin` for those PRs. For
|
|
532
|
+
verified internal-member PRs only, GitHub's `--admin` merge is a
|
|
533
|
+
broad protection bypass, not one scoped to human approval. Use it only after
|
|
534
|
+
verifying that any required independent review above is already satisfied and
|
|
535
|
+
that missing human approval or
|
|
383
536
|
`REVIEW_REQUIRED` is the sole unsatisfied requirement, all other applicable
|
|
384
537
|
protections are satisfied, and no merge queue is required. Revalidate the
|
|
385
538
|
exact live head and all requirements immediately before invoking it. If any
|
|
@@ -436,13 +589,16 @@ queue cannot proceed solely because a human approval is required, report that
|
|
|
436
589
|
queue/approval policy conflict to Steve; do not send the PR to another reviewer
|
|
437
590
|
or bypass the queue.
|
|
438
591
|
|
|
439
|
-
|
|
440
|
-
|
|
441
|
-
|
|
592
|
+
For a verified BuilderIO-member PR outside Factory governance, when Steve
|
|
593
|
+
explicitly asks to merge,
|
|
594
|
+
`REVIEW_REQUIRED` alone is not a reason to wait for another reviewer; use the
|
|
595
|
+
guarded admin merge only if all conditions above hold. After the command,
|
|
596
|
+
re-query the PR for its merged state and merge commit, fetch
|
|
442
597
|
`origin/main`, and verify that commit is an ancestor of `origin/main`. Report a
|
|
443
598
|
merge only after that verification; otherwise report the actual pending or
|
|
444
|
-
not-merged state. If the head or another gate changes, restart the gate.
|
|
445
|
-
|
|
599
|
+
not-merged state. If the head or another gate changes, restart the gate. Merge
|
|
600
|
+
only if Steve explicitly requested it for this PR and no code or author action
|
|
601
|
+
is needed; otherwise report its private readiness disposition.
|
|
446
602
|
|
|
447
603
|
For every verified external PR needing a code update or evidence necessary to
|
|
448
604
|
assess a material behavior change, draft a concise reply that names the concrete
|
|
@@ -466,8 +622,8 @@ a substantive update since Steve's last message. Begin a first reply by
|
|
|
466
622
|
thanking the author for the PR; if replying after an author update, begin by
|
|
467
623
|
thanking them for that update. Never write “I have no further feedback” or
|
|
468
624
|
another vague closing. State the disposition, the exact next action, and who
|
|
469
|
-
owns it. If a product
|
|
470
|
-
|
|
625
|
+
owns it. If a product or UX decision is still needed, do not post an
|
|
626
|
+
author-facing status comment or ask the author to get that review; keep the
|
|
471
627
|
thread silent and report the decision gate in the recap. Never comment that a
|
|
472
628
|
product owner needs to review the PR. For a contributor thread paused by an
|
|
473
629
|
unresolved gate, an internal decision does not count as an author update, and
|
|
@@ -478,6 +634,12 @@ and state the resolved disposition, exact next action, and owner. This
|
|
|
478
634
|
contributor-update gate does not govern review feedback on the active user's
|
|
479
635
|
own PR; follow the own-PR review-update rule in `ship`.
|
|
480
636
|
|
|
637
|
+
Readiness is an internal disposition for Steve's final decision. Never post a
|
|
638
|
+
public PR comment saying a change is “ready for maintainer approval and merge,”
|
|
639
|
+
“ready for maintainer review,” or equivalent; Steve is the maintainer. Keep
|
|
640
|
+
the thread silent while a required product or UX decision is pending, and
|
|
641
|
+
report that gate only in the private recap.
|
|
642
|
+
|
|
481
643
|
If no prior Steve request is awaiting an update and this would be Steve's first
|
|
482
644
|
comment on that PR, begin the draft with a warm thank-you that tags the author
|
|
483
645
|
using the exact GitHub `author.login` from the live PR metadata, for example:
|
|
@@ -544,18 +706,25 @@ count or restart checks.
|
|
|
544
706
|
|
|
545
707
|
## End-of-run recap
|
|
546
708
|
|
|
547
|
-
|
|
548
|
-
sweep, including approved, flagged, external, duplicate, already
|
|
549
|
-
unavailable cases. Include the PR link, author and membership
|
|
550
|
-
disposition, merge result, UX/screenshot status, relevant issue
|
|
551
|
-
checks or review links, and the reason.
|
|
709
|
+
For a full review sweep, end with a succinct row for every human PR that entered
|
|
710
|
+
the evidence sweep, including approved, flagged, external, duplicate, already
|
|
711
|
+
handled, and unavailable cases. Include the PR link, author and membership
|
|
712
|
+
result, review disposition, merge result, UX/screenshot status, relevant issue
|
|
713
|
+
or source link, checks or review links, and the reason. In private recaps,
|
|
714
|
+
describe a ready PR as **Ready for your final approval** or equivalent. For each
|
|
552
715
|
non-auto-approved external PR that needs an update or screenshot, include its
|
|
553
716
|
draft reply in a separate section, or mark it waiting on the contributor with
|
|
554
717
|
a link to Steve's outstanding request. For internal PRs, report the needed
|
|
555
718
|
update or screenshot without drafting an author-facing reply. Do not add rows
|
|
556
|
-
for bots, `steve8708`, drafts, or
|
|
719
|
+
for bots, `steve8708`, drafts, or fork PRs assigned to a BuilderIO member;
|
|
557
720
|
those are ignored completely.
|
|
558
721
|
|
|
722
|
+
If Steve asks only which PRs are ready to merge, return only the candidate list
|
|
723
|
+
with short reasons. Do not include PRs waiting on required checks or product,
|
|
724
|
+
UX decision, or a full status report for other PRs. If Steve asks for a
|
|
725
|
+
blanket internal-member approval, give a concise list of approvals and any
|
|
726
|
+
verification exceptions; do not add a risk inventory unless he asks for one.
|
|
727
|
+
|
|
559
728
|
Use this shape:
|
|
560
729
|
|
|
561
730
|
```md
|
|
@@ -563,15 +732,20 @@ Use this shape:
|
|
|
563
732
|
|
|
564
733
|
| PR | Author / org status | Review disposition | Merge readiness | Merge result | UX / screenshot | Author-facing reply | Why and evidence |
|
|
565
734
|
| --- | --- | --- | --- | --- | --- | --- | --- |
|
|
566
|
-
| [#123](...) | `@name` - BuilderIO member / external / unverified | Approved / Not approved / Skipped | Ready
|
|
735
|
+
| [#123](...) | `@name` - BuilderIO member / external / unverified | Approved / Not approved / Skipped | Ready for your final approval / Needs updates / Needs Steve's decision / Cannot assess | Merged (SHA) / Waiting on 10-minute gate / Held (reason) / Not merged | Unknown / unable to inspect; No UI; UI - screenshot present or needed | Draft / Waiting on contributor / Internal - no draft / Not needed | ... |
|
|
567
736
|
|
|
568
737
|
Unavailable or unverified: ...
|
|
569
738
|
```
|
|
570
739
|
|
|
571
740
|
Keep the recap short, link every claim, and distinguish “not approved because
|
|
572
741
|
external” from “not reviewed because GitHub was unavailable.” Record the actual
|
|
573
|
-
merge result.
|
|
574
|
-
|
|
742
|
+
merge result. A PR can be code-ready while human approval remains pending. If
|
|
743
|
+
Steve has not requested a merge, report **Ready for your final approval** and
|
|
744
|
+
**Not merged - awaiting Steve's explicit merge request** separately. If a
|
|
745
|
+
protected-branch human approval remains required, name that requirement. Do not
|
|
746
|
+
imply that a ready disposition or available admin merge authorizes a bypass.
|
|
747
|
+
Factory governance reports its merge-gate state and leaves the merge to its
|
|
748
|
+
workflow.
|
|
575
749
|
|
|
576
750
|
## Related skills
|
|
577
751
|
|
|
@@ -93,3 +93,16 @@ cross-source joins, multi-page provider sweeps, and heavy analysis scripts;
|
|
|
93
93
|
keep quick scripts in the default foreground mode. Agents should continue
|
|
94
94
|
other work between polls, and on `failed`/`timed_out` split the computation or
|
|
95
95
|
persist intermediate progress with `workspaceWrite` and re-run.
|
|
96
|
+
|
|
97
|
+
## HubSpot API versions
|
|
98
|
+
|
|
99
|
+
Write new HubSpot code against a date-based API version (2026-09 or later),
|
|
100
|
+
for example `POST /crm/objects/2026-09/contacts`, not `/crm/v3/...`. Only the
|
|
101
|
+
date-based versions apply the portal's required-property rules to API writes:
|
|
102
|
+
a create that leaves out a property the portal's create form requires, or a
|
|
103
|
+
stage change missing a conditionally required property, is rejected with a
|
|
104
|
+
400, while the same request on `/crm/v3/` succeeds. HubSpot also stops
|
|
105
|
+
supporting v1-v3 after September 2027. Moving existing write code to a dated
|
|
106
|
+
version changes its behavior, because writes that pass today can start failing
|
|
107
|
+
validation, so migrate one app at a time and surface those 400s to the user.
|
|
108
|
+
Reads behave the same on either version.
|
|
@@ -93,3 +93,16 @@ cross-source joins, multi-page provider sweeps, and heavy analysis scripts;
|
|
|
93
93
|
keep quick scripts in the default foreground mode. Agents should continue
|
|
94
94
|
other work between polls, and on `failed`/`timed_out` split the computation or
|
|
95
95
|
persist intermediate progress with `workspaceWrite` and re-run.
|
|
96
|
+
|
|
97
|
+
## HubSpot API versions
|
|
98
|
+
|
|
99
|
+
Write new HubSpot code against a date-based API version (2026-09 or later),
|
|
100
|
+
for example `POST /crm/objects/2026-09/contacts`, not `/crm/v3/...`. Only the
|
|
101
|
+
date-based versions apply the portal's required-property rules to API writes:
|
|
102
|
+
a create that leaves out a property the portal's create form requires, or a
|
|
103
|
+
stage change missing a conditionally required property, is rejected with a
|
|
104
|
+
400, while the same request on `/crm/v3/` succeeds. HubSpot also stops
|
|
105
|
+
supporting v1-v3 after September 2027. Moving existing write code to a dated
|
|
106
|
+
version changes its behavior, because writes that pass today can start failing
|
|
107
|
+
validation, so migrate one app at a time and surface those 400s to the user.
|
|
108
|
+
Reads behave the same on either version.
|
|
@@ -177,6 +177,10 @@ const CORE_SHARING_ACTIONS = [
|
|
|
177
177
|
name: "list-workspace-user-groups",
|
|
178
178
|
specifier: "@agent-native/core/workspace-connections/actions/list-workspace-user-groups",
|
|
179
179
|
},
|
|
180
|
+
{
|
|
181
|
+
name: "list-workspace-connection-scopes",
|
|
182
|
+
specifier: "@agent-native/core/workspace-connections/actions/list-workspace-connection-scopes",
|
|
183
|
+
},
|
|
180
184
|
{
|
|
181
185
|
name: "upsert-workspace-user-group",
|
|
182
186
|
specifier: "@agent-native/core/workspace-connections/actions/upsert-workspace-user-group",
|
|
@@ -0,0 +1,16 @@
|
|
|
1
|
+
declare const _default: import("../../action.js").ActionDefinition<{
|
|
2
|
+
provider: string;
|
|
3
|
+
}, {
|
|
4
|
+
connections: {
|
|
5
|
+
id: string;
|
|
6
|
+
provider: string;
|
|
7
|
+
label: string;
|
|
8
|
+
accountLabel: string | null;
|
|
9
|
+
status: string;
|
|
10
|
+
connectionScope: "app" | "organization" | "user" | null;
|
|
11
|
+
ownedByCaller: boolean;
|
|
12
|
+
grantedScopes: string[];
|
|
13
|
+
}[];
|
|
14
|
+
hint: string;
|
|
15
|
+
}>;
|
|
16
|
+
export default _default;
|